Re: [PHP] Correct Coding
That can generate an error if $Task was never assigned a value.
Cheers,
Rob.
On Thu, 2003-08-07 at 13:17, Juan Nin wrote:
Is this the best way to do this?
if(isset($Task) $Task == Add) { Do something }
I want to check if the variable is set and if so, if it is Add.
why don't just do:
if($Task == Add) { Do something }
regards,
Juan
--
PHP General Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
--
.-.
| Worlds of Carnage - http://www.wocmud.org |
:-:
| Come visit a world of myth and legend where |
| fantastical creatures come to life and the |
| stuff of nightmares grasp for your soul.|
`-'
--
PHP General Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
RE: [PHP] Correct Coding
Could you explain a little better why this would make things better? I don't understand how this would improve things. Concerning the $Task == Add, I'd like to make a comment. It can be a wise decision to compare your variables with strings like: if (Add == $Task) This can help preventing typo's like: if ($Task = Add) $Task = Add (typo'd for $Task == Add) would assign the value, clearly not your intent. Add = $Task would be an illegal assignment to a constant, so your error would be detected. -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP] Correct Coding
You can -- but correct me if I'm wrong -- won't that possibly cause an
exception to fire which could be extremely heavy if a custom exception
handler is implemented?
Cheers,
Rob.
On Thu, 2003-08-07 at 13:35, skate wrote:
That can generate an error if $Task was never assigned a value.
could you not do
if(@$Task == Add ){do something }
to suppress the error of the variable not being set?
--
PHP General Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
--
.-.
| Worlds of Carnage - http://www.wocmud.org |
:-:
| Come visit a world of myth and legend where |
| fantastical creatures come to life and the |
| stuff of nightmares grasp for your soul.|
`-'
--
PHP General Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP] Correct Coding
Good point. Would not have seen it that way. Thanks for the tip. Jim Lucas - Original Message - From: Roger B.A. Klorese [EMAIL PROTECTED] To: 'Jim Lucas' [EMAIL PROTECTED]; 'Curt Zirzow' [EMAIL PROTECTED]; [EMAIL PROTECTED] Sent: Thursday, August 07, 2003 11:03 AM Subject: RE: [PHP] Correct Coding Could you explain a little better why this would make things better? I don't understand how this would improve things. Concerning the $Task == Add, I'd like to make a comment. It can be a wise decision to compare your variables with strings like: if (Add == $Task) This can help preventing typo's like: if ($Task = Add) $Task = Add (typo'd for $Task == Add) would assign the value, clearly not your intent. Add = $Task would be an illegal assignment to a constant, so your error would be detected. -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
RE: [PHP] Correct Coding
Roger B.A. Klorese wrote: if (Add == $Task) I call that 'defensive programming', defending yourself from yourself! -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
RE: [PHP] Correct Coding
Well this page will load and not always with that variable set. Is that ok,
or will this code you put output an error.
Christopher J. Crane
Network Manager - Infrastructure Services
IKON Document Efficiency at Work
755 Winding Brook Drive
Glastonbury, CT 06078
Phone - (860) 659-6464
Fax - (860) 682-6847
-Original Message-
From: Juan Nin [mailto:[EMAIL PROTECTED]
Sent: Thursday, August 07, 2003 1:17 PM
To: Christopher J. Crane
Cc: [EMAIL PROTECTED]
Subject: Re: [PHP] Correct Coding
Is this the best way to do this?
if(isset($Task) $Task == Add) { Do something }
I want to check if the variable is set and if so, if it is Add.
why don't just do:
if($Task == Add) { Do something }
regards,
Juan
[PHP] Correct Coding
Is this the best way to do this?
if(isset($Task) $Task == Add) { Do something }
I want to check if the variable is set and if so, if it is Add.
--
PHP General Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP] Correct Coding
* Thus wrote Martin Peck ([EMAIL PROTECTED]):
That can generate an error if $Task was never assigned a value.
could you not do
if(@$Task == Add ){do something }
to suppress the error of the variable not being set?
I have never seen php give an error if $Task is not set to anything. I
would have said that
your error_reporting level doesnt have E_NOTICE set.
Curt
--
I used to think I was indecisive, but now I'm not so sure.
--
PHP General Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP] Correct Coding
That can generate an error if $Task was never assigned a value.
could you not do
if(@$Task == Add ){do something }
to suppress the error of the variable not being set?
I have never seen php give an error if $Task is not set to anything. I
would have said that
if (Add == $Task) { Do something }
would always be fine - what am I missing?
Martin
--
PHP General Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP] Correct Coding
That can generate an error if $Task was never assigned a value.
could you not do
if(@$Task == Add ){do something }
to suppress the error of the variable not being set?
--
PHP General Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP] Correct Coding
* Thus wrote Christopher J. Crane ([EMAIL PROTECTED]):
Is this the best way to do this?
if(isset($Task) $Task == Add) { Do something }
I want to check if the variable is set and if so, if it is Add.
Yes, that is good. Remember, though, it is case sensitive so ADD
wont match.
Concerning the $Task == Add, I'd like to make a comment. It can
be a wise decision to compare your variables with strings like:
if (Add == $Task)
This can help preventing typo's like:
if ($Task = Add)
I've seen people tear their hair out wondering why the if statement
is always true even if $Task is not Add. I don't see this method
used very often but it can prevent serious logic typos.
HTH,
Curt
--
I used to think I was indecisive, but now I'm not so sure.
--
PHP General Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP] Correct Coding
Could you explain a little better why this would make things better?
I don't understand how this would improve things.
Jim Lucas
- Original Message -
From: Curt Zirzow [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Sent: Thursday, August 07, 2003 10:28 AM
Subject: Re: [PHP] Correct Coding
* Thus wrote Christopher J. Crane ([EMAIL PROTECTED]):
Is this the best way to do this?
if(isset($Task) $Task == Add) { Do something }
I want to check if the variable is set and if so, if it is Add.
Yes, that is good. Remember, though, it is case sensitive so ADD
wont match.
Concerning the $Task == Add, I'd like to make a comment. It can
be a wise decision to compare your variables with strings like:
if (Add == $Task)
This can help preventing typo's like:
if ($Task = Add)
I've seen people tear their hair out wondering why the if statement
is always true even if $Task is not Add. I don't see this method
used very often but it can prevent serious logic typos.
HTH,
Curt
--
I used to think I was indecisive, but now I'm not so sure.
--
PHP General Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
--
PHP General Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP] Correct Coding
From: Martin Peck [EMAIL PROTECTED]
That can generate an error if $Task was never assigned a value.
could you not do
if(@$Task == Add ){do something }
to suppress the error of the variable not being set?
I have never seen php give an error if $Task is not set to anything. I
would have said that
It would give an error if you have your error reporting set accordingly.
Search the archives for the difference between works and right (or the
next issue of PHP|Architect) :)
---John Holmes...
--
PHP General Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP] Correct Coding
Looks good.
Cheers,
Rob.
On Thu, 2003-08-07 at 13:09, Christopher J. Crane wrote:
Is this the best way to do this?
if(isset($Task) $Task == Add) { Do something }
I want to check if the variable is set and if so, if it is Add.
--
PHP General Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
--
.-.
| Worlds of Carnage - http://www.wocmud.org |
:-:
| Come visit a world of myth and legend where |
| fantastical creatures come to life and the |
| stuff of nightmares grasp for your soul.|
`-'
--
PHP General Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP] Correct Coding
Is this the best way to do this?
if(isset($Task) $Task == Add) { Do something }
I want to check if the variable is set and if so, if it is Add.
why don't just do:
if($Task == Add) { Do something }
regards,
Juan
--
PHP General Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
