[PHP-QA] [PHP-BUG] Bug #74918 [NEW]: Wrong ICU version comparison in some tests

[graefrath at femu dot rwth-aachen dot de]

From: graefrath at femu dot rwth-aachen dot de
Operating system: Oracle Linux 6
PHP version:  5.6.31
Package:  Testing related
Bug Type: Bug
Bug description:Wrong ICU version comparison in some tests

Description:

While running make test the tests

- dateformat_create_cal_arg.phpt
- dateformat_formatObject_calendar.phpt
- dateformat_formatObject_datetime.phpt
- dateformat_get_set_calendar.phpt
- dateformat_get_set_timezone.phpt
- msgfmt_format_intlcalendar.phpt

execute and fail, even though they should have been skipped. My ICU
version is 4.2.1, the tests are supposed to be skipped if the ICU
version is < 51.2.


-- 
Edit bug report at https://bugs.php.net/bug.php?id=74918&edit=1
-- 
Try a snapshot (PHP 5.4):   
https://bugs.php.net/fix.php?id=74918&r=trysnapshot54
Try a snapshot (PHP 5.5):   
https://bugs.php.net/fix.php?id=74918&r=trysnapshot55
Try a snapshot (trunk): 
https://bugs.php.net/fix.php?id=74918&r=trysnapshottrunk
Fixed in SVN:   https://bugs.php.net/fix.php?id=74918&r=fixed
Fixed in release:   https://bugs.php.net/fix.php?id=74918&r=alreadyfixed
Need backtrace: https://bugs.php.net/fix.php?id=74918&r=needtrace
Need Reproduce Script:  https://bugs.php.net/fix.php?id=74918&r=needscript
Try newer version:  https://bugs.php.net/fix.php?id=74918&r=oldversion
Not developer issue:https://bugs.php.net/fix.php?id=74918&r=support
Expected behavior:  https://bugs.php.net/fix.php?id=74918&r=notwrong
Not enough info:
https://bugs.php.net/fix.php?id=74918&r=notenoughinfo
Submitted twice:
https://bugs.php.net/fix.php?id=74918&r=submittedtwice
register_globals:   https://bugs.php.net/fix.php?id=74918&r=globals
PHP 4 support discontinued: https://bugs.php.net/fix.php?id=74918&r=php4
Daylight Savings:   https://bugs.php.net/fix.php?id=74918&r=dst
IIS Stability:  https://bugs.php.net/fix.php?id=74918&r=isapi
Install GNU Sed:https://bugs.php.net/fix.php?id=74918&r=gnused
Floating point limitations: https://bugs.php.net/fix.php?id=74918&r=float
No Zend Extensions: https://bugs.php.net/fix.php?id=74918&r=nozend
MySQL Configuration Error:  https://bugs.php.net/fix.php?id=74918&r=mysqlcfg


-- 
PHP Quality Assurance Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-QA] Bug #74918 [Opn->Fbk]: Wrong ICU version comparison in some tests

[requinix]

Edit report at https://bugs.php.net/bug.php?id=74918&edit=1

 ID: 74918
 Updated by: requi...@php.net
 Reported by:graefrath at femu dot rwth-aachen dot de
 Summary:Wrong ICU version comparison in some tests
-Status: Open
+Status: Feedback
 Type:   Bug
 Package:Testing related
 Operating System:   Oracle Linux 6
 PHP Version:5.6.31
 Block user comment: N
 Private report: N

 New Comment:

(If anyone is wondering about the versioning, apparently libicu changed schemes 
and went from 4.6 to 49. So 4.2.1 ≈ 42.1 and 50.1.2 ≈ 5.0.1.2.)


if (version_compare(INTL_ICU_VERSION, '50.1.2') >=  0) die('skip for ICU < 
50.1.2');

Note that the leading "skip" in the die() message is a technical requirement 
and not necessarily meant to be read as part of the reason (though it often is).
https://qa.php.net/write-test.php#skipif

Either
a) The code is right (skip >= 50.1.2) and the message means the test only 
applies to < 50.1.2, or
b) The comment is right (skip < 50.1.2) and the code is backwards
I think the former is more likely.

How are the tests failing?


Previous Comments:

[2017-07-13 11:44:14] graefrath at femu dot rwth-aachen dot de

Description:

While running make test the tests

- dateformat_create_cal_arg.phpt
- dateformat_formatObject_calendar.phpt
- dateformat_formatObject_datetime.phpt
- dateformat_get_set_calendar.phpt
- dateformat_get_set_timezone.phpt
- msgfmt_format_intlcalendar.phpt

execute and fail, even though they should have been skipped. My ICU version is 
4.2.1, the tests are supposed to be skipped if the ICU version is < 51.2.







--
Edit this bug report at https://bugs.php.net/bug.php?id=74918&edit=1

-- 
PHP Quality Assurance Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-QA] Announcing PHP TestFest 2017

[Ben Ramsey]

(Cross-posting to php-qa and ug-admins mailing lists.)

TL;DR: PHP TestFest is back! Join the Google Group (link below) for
discussion.

Hi, all,

For those who’ve been around the PHP community for a while, you’ll
recall the successful PHP TestFest events that began after a discussion
at PHP Quebec in 2008 [1]. Many user groups and mentors signed on to
host and help with events, and a lot of folks became first-time
contributors to the PHP project, helping improve our code coverage. It
ran strong in a _global_ sense from 2008 to 2010. After that, various
groups (particularly the Brazilian groups) have continued the tradition.

A few months ago, at php[tek] in Atlanta, I mentioned to Michelangelo
that I’d love to bring back PHP TestFest. Sammy had given an excellent
talk on writing PHPT tests [2], and Gemma tweeted a link to the old PHP
TestFest wiki page [3,4]. From there, things snowballed.

We’re bringing back PHP TestFest!

The PHP TestFest will run for 4 months this year: September through
December. This should give groups plenty of time to plan and prepare one
or more local events. In early January, we will award prizes; if your
organization/company is interested in offering products or services as
prizes, let us know (send email to ).

This time around, I’ve set up a dedicated website at
 and Google Group for discussion [5]. We also
have the #phptestfest channel on Freenode IRC [6]. All are encouraged to
contribute to the website and tools repository [7]. We need technical
tutorials, as well as tutorials from veteran TestFest organizers on how
to lead successful PHP TestFest events. Additionally, I’ve provided a
stub for a console application in the repository, and I’d love to see
that evolve into a robust tool for helping people write and contribute
PHPT tests.

I’ll be updating the “Getting Started” page on the PHP TestFest website
soon with this information and more, so keep posted [8].

Let’s get to work on improving code coverage of the PHP language!

Cheers,
Ben

P.S. Special thanks to Sammy for letting us use “Wooble” as a testing
mascot.


[1]: http://news.php.net/php.qa/64083
[2]: https://speakerdeck.com/sammyk/writing-tests-for-php-source-php-tek-2017
[3]: https://twitter.com/ellotheth/status/868583446498734084
[4]: https://wiki.php.net/qa/testfest
[5]: https://groups.google.com/a/phpcommunity.org/group/testfest/
[6]: https://kiwiirc.com/client/irc.freenode.net#phptestfest
[7]: https://github.com/phpcommunity/phptestfest.org
[8]: https://phptestfest.org/start/



signature.asc
Description: Message signed with OpenPGP using GPGMail