date:20190628

com pftt2: Close #1: Wipe PHP version support < 5.6: src/com/mostc/pftt/main/CmpReport.java src/com/mostc/pftt/main/CmpReport2.java src/com/mostc/pftt/main/PfttAuto.java src/com/mostc/pftt/model/core/

2019-06-28 Thread Christoph Michael Becker

Commit:c8bf1cfbb470d022bce67a697266c758278e9df9
Author:Christoph M. Becker  Fri, 28 Jun 2019 
13:17:52 +0200
Parents:   d92ea3219b7ef9057610a86498c76ff368da5cef
Branches:  master

Link:   
http://git.php.net/?p=pftt2.git;a=commitdiff;h=c8bf1cfbb470d022bce67a697266c758278e9df9

Log:
Close #1: Wipe PHP version support < 5.6

Bugs:
https://bugs.php.net/1

Changed paths:
  M  src/com/mostc/pftt/main/CmpReport.java
  M  src/com/mostc/pftt/main/CmpReport2.java
  M  src/com/mostc/pftt/main/PfttAuto.java
  M  src/com/mostc/pftt/model/core/EBuildBranch.java
  M  src/com/mostc/pftt/model/core/PhpBuild.java
  M  src/com/mostc/pftt/model/core/PhptSourceTestPack.java
  M  src/com/mostc/pftt/model/sapi/EApacheVersion.java
  M  src/com/mostc/pftt/model/smoke/RequiredExtensionsSmokeTest.java
  M  src/com/mostc/pftt/scenario/AzureWebsitesScenario.java
  M  src/com/mostc/pftt/scenario/BuiltinWebServerScenario.java
  M  src/com/mostc/pftt/scenario/MSSQLScenario.java
  M  src/com/mostc/pftt/scenario/OpcacheScenario.java
  M  src/com/mostc/pftt/scenario/SAPIScenario.java
  M  src/com/mostc/pftt/scenario/WinCacheUScenario.java
  M  src/com/mostc/pftt/util/HostEnvUtil.java
  M  src/com/mostc/pftt/util/WindowsSnapshotDownloadUtil.groovy

diff --git a/src/com/mostc/pftt/main/CmpReport.java 
b/src/com/mostc/pftt/main/CmpReport.java
index 072a847..54dd351 100644
--- a/src/com/mostc/pftt/main/CmpReport.java
+++ b/src/com/mostc/pftt/main/CmpReport.java
@@ -497,6 +497,8 @@ public class CmpReport {
}
}
}
+
+   // TODO: check whether this method makes any sense, and remove or 
convert to regular PFTT2 option
public static void main(String[] args) throws Exception {
IRecvr recvr = new Verify();
//
@@ -528,54 +530,10 @@ public class CmpReport {
LocalConsoleManager cm = new LocalConsoleManager();

// TODO check if a smoke test failed!
-   //File base_dir = (new 
File("C:\\php-sdk\\PFTT-Auto\\PHP_5_3-Result-Pack-5.3.27-TS-X86-VC9"));
-   //File test_dir = (new 
File("C:\\php-sdk\\PFTT-Auto\\PHP_5_3-Result-Pack-5.3.28-TS-X86-VC9"));
-   //File base_dir = (new 
File("C:\\php-sdk\\PFTT-Auto\\PHP_5_3-Result-Pack-re2e002d-nTS-X86-VC9"));
-   //File test_dir = (new 
File("C:\\php-sdk\\PFTT-Auto\\PHP_5_3-Result-Pack-r7c9bb87-nTS-X86-VC9"));
-   //File base_dir = (new 
File("C:\\php-sdk\\PFTT-Auto\\PHP_5_3-Result-Pack-re2e002d-TS-X86-VC9"));
-   //File test_dir = (new 
File("C:\\php-sdk\\PFTT-Auto\\PHP_5_3-Result-Pack-r7c9bb87-TS-X86-VC9"));
-   //File base_dir = (new 
File("C:\\php-sdk\\PFTT-Auto\\PHP_5_4-Result-Pack-5.4.23-NTS-X86-VC9"));
-   //File test_dir = (new 
File("C:\\php-sdk\\PFTT-Auto\\PHP_5_4-Result-Pack-5.4.24rc1-NTS-X86-VC9"));
-   
-   //File base_dir = new 
File("C:\\php-sdk\\PFTT-Auto\\PHP_5_4-Result-Pack-rd487f5e-TS-X86-VC9");
-   //File test_dir = new 
File("C:\\php-sdk\\PFTT-Auto\\PHP_5_4-Result-Pack-r6c48c6b-TS-X86-VC9");
-   //File base_dir = new 
File("C:\\php-sdk\\PFTT-Auto\\PHP_5_4-Result-Pack-ra03f094-nTS-X86-VC9");
-   //File test_dir = new 
File("C:\\php-sdk\\PFTT-Auto\\PHP_5_4-Result-Pack-r72aacbf-nTS-X86-VC9");
 
-   //File base_dir = (new 
File("C:\\php-sdk\\PFTT-Auto\\PHP_5_5-Result-Pack-rc8b0da6-TS-X64-VC11"));
-   //File test_dir = (new 
File("C:\\php-sdk\\PFTT-Auto\\PHP_5_5-Result-Pack-rc8b0da6-TS-x64-VC11"));
-   //File base_dir = (new 
File("C:\\php-sdk\\PFTT-Auto\\PHP_5_5-Result-Pack-r82dd6b9-NTS-X64-VC11"));
-   //File test_dir = (new 
File("C:\\php-sdk\\PFTT-Auto\\PHP_5_5-Result-Pack-rc8b0da6-NTS-X64-VC11"));
-   //File base_dir = (new 
File("C:\\php-sdk\\PFTT-Auto\\PHP_5_5-Result-Pack-rb2ee1b6-NTS-X86-VC11"));
-   //File test_dir = (new 
File("C:\\php-sdk\\PFTT-Auto\\PHP_5_5-Result-Pack-rfc9d886-NTS-X86-VC11"));
-   //File base_dir = (new 
File("C:\\php-sdk\\PFTT-Auto\\PHP_5_5-Result-Pack-rc8b0da6-TS-X86-VC11"));
-   //File test_dir = (new 
File("C:\\php-sdk\\PFTT-Auto\\PHP_5_5-Result-Pack-rfc9d886-TS-X86-VC11"));
-   
-   //File base_dir = new 
File("C:\\php-sdk\\PFTT-Auto\\PHP_Master-Result-Pack--TS-X86-VC11");
-   //File base_dir = new 
File("C:\\php-sdk\\PFTT-Auto\\PHP_Master-Result-Pack-r43289d6-TS-X86-VC11");
-   //File test_dir = new 
File("C:\\php-sdk\\PFTT-Auto\\PHP_5_6-Result-Pack-5.6.0-dev-TS-X86-VC11-keyword916");
-   //File base_dir = new 
File("C:\\php-sdk\\PFTT-Auto\\PHP_Master-Result-Pack-r89c4aba-NTS-X64-VC11");
-   //File base_dir = new 
File("C:\\php-sdk\\PFTT-Auto\\PHP_Master-Result-Pack-r82bb2a2-NTS-X86-VC11");
-   //File test_dir = new 
File("C:\\php-sdk\\PFTT-Auto\\PHP_5_6-Result-Pack-5.6.0-dev-NTS-

com pftt2: Close #8: Cleanup unused files in the /bin folder: bin/NanoServerApiScan.exe bin/PFTT bin/cmp.exe bin/diff.exe bin/diff3.exe bin/handle.exe bin/patch.exe bin/pftt_workspace.WEW bin/sdiff.ex

2019-06-28 Thread Christoph Michael Becker

Commit:f6ddff3a4b96e4a36f2534ad4177900485538238
Author:Christoph M. Becker  Fri, 28 Jun 2019 
15:07:47 +0200
Parents:   c8bf1cfbb470d022bce67a697266c758278e9df9
Branches:  master

Link:   
http://git.php.net/?p=pftt2.git;a=commitdiff;h=f6ddff3a4b96e4a36f2534ad4177900485538238

Log:
Close #8: Cleanup unused files in the /bin folder

`cmp`, `diff`, `diff3`, `patch` and `sdiff` are Windows ports of the
respective Gnu utilities.  `NanoServerApiScan` is a Microsoft tool.
`handle` is from sysinternals.

Since none of these executables are used by PFTT, we can safely remove
them.

We also remove the useless "PFTT Shell.lnk" and pftt_workspace.WEW
files.

Bugs:
https://bugs.php.net/8

Changed paths:
  D  bin/NanoServerApiScan.exe
  D  bin/PFTT
  D  bin/cmp.exe
  D  bin/diff.exe
  D  bin/diff3.exe
  D  bin/handle.exe
  D  bin/patch.exe
  D  bin/pftt_workspace.WEW
  D  bin/sdiff.exe


Diff:
diff --git a/bin/NanoServerApiScan.exe b/bin/NanoServerApiScan.exe
deleted file mode 100644
index 4fbbea9..000
Binary files a/bin/NanoServerApiScan.exe and /dev/null differ
diff --git a/bin/PFTT Shell.lnk b/bin/PFTT Shell.lnk
deleted file mode 100644
index 5a792a9..000
Binary files a/bin/PFTT Shell.lnk and /dev/null differ
diff --git a/bin/cmp.exe b/bin/cmp.exe
deleted file mode 100644
index 0bb5bf0..000
Binary files a/bin/cmp.exe and /dev/null differ
diff --git a/bin/diff.exe b/bin/diff.exe
deleted file mode 100644
index 85f370d..000
Binary files a/bin/diff.exe and /dev/null differ
diff --git a/bin/diff3.exe b/bin/diff3.exe
deleted file mode 100644
index 05a7296..000
Binary files a/bin/diff3.exe and /dev/null differ
diff --git a/bin/handle.exe b/bin/handle.exe
deleted file mode 100644
index 6743e05..000
Binary files a/bin/handle.exe and /dev/null differ
diff --git a/bin/patch.exe b/bin/patch.exe
deleted file mode 100644
index 1b22a07..000
Binary files a/bin/patch.exe and /dev/null differ
diff --git a/bin/pftt_workspace.WEW b/bin/pftt_workspace.WEW
deleted file mode 100644
index 1f3e04d..000
Binary files a/bin/pftt_workspace.WEW and /dev/null differ
diff --git a/bin/sdiff.exe b/bin/sdiff.exe
deleted file mode 100644
index b9d14e5..000
Binary files a/bin/sdiff.exe and /dev/null differ

Bug #78119 [Opn->Ver]: server not running error

2019-06-28 Thread cmb

Edit report at https://bugs.php.net/bug.php?id=78119&edit=1

 ID: 78119
 Updated by: c...@php.net
 Reported by:v-altruo at microsoft dot com
 Summary:server not running error
-Status: Open
+Status: Verified
 Type:   Bug
 Package:Testing related
 Operating System:   Windows
 PHP Version:7.3.6
-Assigned To:
+Assigned To:cmb
 Block user comment: N
 Private report: N

 New Comment:

Thanks!  I can confirm the test failure.  The exit code of the
server process hints at an access violation, which has to be
investigated.

By the way, the code in php_cli_server.inc, which checks that the
server is actually running, makes not much sense.  The for loop is
supposed to be executed multiple times, but if the server process
is not running during the first pass, the code breaks out of the
loop.  Also it makes not much sense to call fsockopen() before
checking the $status.  It likely makes sense to overhaul this code
similar to commit d6480fa[1].

[1] 



Previous Comments:

[2019-06-25 18:48:21] v-altruo at microsoft dot com

Similar error occurs for ext\opcache\tests\bug78106.phpt with php-7.3.7RC3. 

Error occurs only for TS builds regardless opcache enabled/disabled.


[2019-06-05 21:10:02] v-altruo at microsoft dot com

A similar error occurs for 'ext\opcache\tests\issue0149.phpt' with the same 
settings mentioned.


[2019-06-05 21:04:40] v-altruo at microsoft dot com

Description:

Test fails only for TS builds with opcache enabled. 

Test file location: ext\opcache\tests\issue0115.phpt

Expected result:

Hello from Index 1.
Hello World 1!
Hello from Index 2.
Hello World 2!

Actual result:
--
Server is not running






--
Edit this bug report at https://bugs.php.net/bug.php?id=78119&edit=1

com pftt2: Close #1: Wipe PHP version support < 5.6: src/com/mostc/pftt/main/CmpReport.java src/com/mostc/pftt/main/CmpReport2.java src/com/mostc/pftt/main/PfttAuto.java src/com/mostc/pftt/model/core/

com pftt2: Close #8: Cleanup unused files in the /bin folder: bin/NanoServerApiScan.exe bin/PFTT bin/cmp.exe bin/diff.exe bin/diff3.exe bin/handle.exe bin/patch.exe bin/pftt_workspace.WEW bin/sdiff.ex

Bug #78119 [Opn->Ver]: server not running error

3 matches

Site Navigation

Mail list logo

Footer information