[PHP-QA] Bug #70580 [Com]: Test Zend/tests/bug42143.phpt is broken

2018-08-05 Thread carusogabr...@php.net 
Edit report at https://bugs.php.net/bug.php?id=70580&edit=1

 ID: 70580
 Comment by: carusogabr...@php.net
 Reported by:rainer dot jung at kippdata dot de
 Summary:Test Zend/tests/bug42143.phpt is broken
 Status: Re-Opened
 Type:   Bug
 Package:Testing related
 Operating System:   Solaris
 PHP Version:7.0.0RC3
 Assigned To:carusogabriel
 Block user comment: N
 Private report: N

 New Comment:

@cmb My apologies, I didn't pay attention to that detail. I'll try to emulate 
Solaris locally and see if we can fix, or drop those lines as suggested.

Btw, thanks for the Wiki Systems link (https://wiki.php.net/systems), I didn't 
know about it.


Previous Comments:

[2018-08-05 14:20:19] c...@php.net

gcov.php.net runs on CentOS 6[1], so the test is likely to
succeed. The report is about the test failing on Solaris, which
still might be the case.

I agree with Rainer, that the two lines should be dropped.
Kalle's argument to keep the lines for better code coverage is
somewhat moot, since our log() and log10() implementations are
thin wrappers over C's log() and log10(), respectively, so
basically we're testing implementation defined behavior here.

[1] <https://wiki.php.net/systems/nex2>

--------
[2018-08-05 05:00:40] carusogabr...@php.net

Closing as this tests isn't failing anymore: 
http://gcov.php.net/viewer.php?version=PHP_HEAD&func=tests


[2015-10-24 04:48:25] ka...@php.net

Now its been a while with proper testing writing, but I think its possible that 
we change the EXPECT section to EXPECTF and then have something like: %NaN|INF% 
or similar, I should probably consult run-tests.php for this, but it seems most 
reasonable we keep the test for most code path coverage.


[2015-09-25 12:05:16] rainer dot jung at kippdata dot de

This applies also to PHP 5.4-5.6 (latest releases).


[2015-09-25 11:59:46] rainer dot jung at kippdata dot de

Description:

The test Zend/tests/bug42143.phpt contains:

 13 var_dump(log10(-1) == log(-1));
 14 var_dump(log10(-1) != log10(-1));

On Linux, that test works, because the logarithm of -1 returns NAN as expected. 
On Solaris the log returns -INF and that part of the test fails. This behavior 
is allowed by the specifications: See in 
http://pubs.opengroup.org/onlinepubs/9699919799/functions/log.html

"For finite values of x that are less than 0 ..., a domain error shall occur, 
and either a NaN (if supported), or an implementation-defined value shall be 
returned."

Since there are a lot of other but similar tests in Zend/tests/bug42143.phpt, I 
suggest to drop these two lines.

See attached patch.







--
Edit this bug report at https://bugs.php.net/bug.php?id=70580&edit=1

-- 
PHP Quality Assurance Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-QA] Bug #75205 [Com]: Bugs reports from automatic testing

2018-08-05 Thread carusogabr...@php.net 
Edit report at https://bugs.php.net/bug.php?id=75205&edit=1

 ID: 75205
 Comment by: carusogabr...@php.net
 Reported by:ecamy at 163 dot com
 Summary:Bugs reports from automatic testing
 Status: Open
 Type:   Bug
 Package:Testing related
 Operating System:   CentOS6.6
 PHP Version:5.6.31
 Block user comment: N
 Private report: N

 New Comment:

All reported tests have a SKIPIF section for online tests:

if (getenv("SKIP_ONLINE_TESTS")) die("skip online test");

But, this is only set if we pass `--offline` to `run-tests.php`.

What can be done, is set this `SKIP_ONLINE_TESTS` env var dynamically, checking 
for real internet connection.


Previous Comments:

[2017-09-15 05:23:16] ecamy at 163 dot com

Yes, I installed all package by the way of offline. Even it can't pass during 
making test, but it still work well after making install. I don't know how 
about it can be in the future. Thanks so much for your reply.


[2017-09-14 15:02:17] c...@php.net

On a cursory glance it looks like you have not been online while
running the tests, in which case they have not been supposed to be
run at all.


[2017-09-14 02:24:45] ecamy at 163 dot com

Description:

When I installed the php5.6 on CentOS by compiling, it reports some bugs as 
attached. I can't deal with it because the hit of its is not enough. Would you 
help me? 







--
Edit this bug report at https://bugs.php.net/bug.php?id=75205&edit=1

-- 
PHP Quality Assurance Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-QA] [PHP-BUG] Bug #76723 [NEW]: Zip extension tests aren't being running in GCOV

2018-08-08 Thread carusogabr...@php.net 
From: carusogabr...@php.net
Operating system: 
PHP version:  Irrelevant
Package:  Testing related
Bug Type: Bug
Bug description:Zip extension tests aren't being running in GCOV

Description:

Recently, during some tests clean up, I've fixed some SKIPIF sections in
our tests, and due to this work
(http://gcov.php.net/viewer.php?version=PHP_HEAD&func=skip&file=ext%2Ffileinfo%2Ftests%2Ffinfo_file_stream_001.phpt),
I noticed that we aren't running our Zip extension tests in GCOV. 

The `--enable-zip` flag is missing during our configuration:
http://gcov.php.net/viewer.php?version=PHP_HEAD&func=system.

Is there a specific reason why we don't run them there? In contrast, we
do run them in our CIs, Travis
(http://git.php.net/?p=php-src.git;a=blob;f=travis/compile.sh;hb=HEAD#l47)
for example.

I've already reported to internals@
(http://news.php.net/php.internals/103053), but I believe here at
bugs.php.net is a better place to discuss and track this issue.

Thanks


-- 
Edit bug report at https://bugs.php.net/bug.php?id=76723&edit=1
-- 
Try a snapshot (PHP 5.4):   
https://bugs.php.net/fix.php?id=76723&r=trysnapshot54
Try a snapshot (PHP 5.5):   
https://bugs.php.net/fix.php?id=76723&r=trysnapshot55
Try a snapshot (trunk): 
https://bugs.php.net/fix.php?id=76723&r=trysnapshottrunk
Fixed in SVN:   https://bugs.php.net/fix.php?id=76723&r=fixed
Fixed in release:   https://bugs.php.net/fix.php?id=76723&r=alreadyfixed
Need backtrace: https://bugs.php.net/fix.php?id=76723&r=needtrace
Need Reproduce Script:  https://bugs.php.net/fix.php?id=76723&r=needscript
Try newer version:  https://bugs.php.net/fix.php?id=76723&r=oldversion
Not developer issue:https://bugs.php.net/fix.php?id=76723&r=support
Expected behavior:  https://bugs.php.net/fix.php?id=76723&r=notwrong
Not enough info:
https://bugs.php.net/fix.php?id=76723&r=notenoughinfo
Submitted twice:
https://bugs.php.net/fix.php?id=76723&r=submittedtwice
register_globals:   https://bugs.php.net/fix.php?id=76723&r=globals
PHP 4 support discontinued: https://bugs.php.net/fix.php?id=76723&r=php4
Daylight Savings:   https://bugs.php.net/fix.php?id=76723&r=dst
IIS Stability:  https://bugs.php.net/fix.php?id=76723&r=isapi
Install GNU Sed:https://bugs.php.net/fix.php?id=76723&r=gnused
Floating point limitations: https://bugs.php.net/fix.php?id=76723&r=float
No Zend Extensions: https://bugs.php.net/fix.php?id=76723&r=nozend
MySQL Configuration Error:  https://bugs.php.net/fix.php?id=76723&r=mysqlcfg


-- 
PHP Quality Assurance Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-QA] Req #60360 [Com]: Add a phpinfo() somewhere on GCOV

2018-08-12 Thread carusogabr...@php.net 
Edit report at https://bugs.php.net/bug.php?id=60360&edit=1

 ID: 60360
 Comment by: carusogabr...@php.net
 Reported by:pierr...@php.net
 Summary:Add a phpinfo() somewhere on GCOV
 Status: Open
 Type:   Feature/Change Request
 Package:Testing related
 PHP Version:Irrelevant
 Block user comment: N
 Private report: N

 New Comment:

+nlop...@php.net Can we do this one? As described, would help us know which 
version our libs are.


Previous Comments:

[2011-11-22 20:22:05] tyr...@php.net

It should be generated per build basis, so we can check it for each execution.
If Nuno doesn't mind, I can do this, as it seems trivial to implement.


[2011-11-22 20:09:17] pierr...@php.net

Description:

It would be nice to have a phpinfo() somewhere on the gcov server to know which 
version of a specific lib is used.







--
Edit this bug report at https://bugs.php.net/bug.php?id=60360&edit=1

-- 
PHP Quality Assurance Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-QA] [PHP-BUG] Bug #76733 [NEW]: Trivial tests aren't covered by GCOV

2018-08-12 Thread carusogabr...@php.net 
From: carusogabriel
Operating system: 
PHP version:  Irrelevant
Package:  Testing related
Bug Type: Bug
Bug description:Trivial tests aren't covered by GCOV

Description:

Trivial tests for functions like gettype, floatval, boolval, is_bool,
etc, aren't being covered in GCOV:
http://gcov.php.net/PHP_HEAD/lcov_html/ext/standard/type.c.gcov.php

I've tested locally the new LCOV version, 1.13
(http://ltp.sourceforge.net/coverage/lcov.php), but it didn't help us.


Something to start with: in PHP 7.1 we weren't using macros for gettype
(http://gcov.php.net/PHP_7_1/lcov_html/ext/standard/type.c.gcov.php),
for example, and after we started on 7.2
(http://gcov.php.net/PHP_7_2/lcov_html/ext/standard/type.c.gcov.php),
we've lost those lines.


-- 
Edit bug report at https://bugs.php.net/bug.php?id=76733&edit=1
-- 
Try a snapshot (PHP 5.4):   
https://bugs.php.net/fix.php?id=76733&r=trysnapshot54
Try a snapshot (PHP 5.5):   
https://bugs.php.net/fix.php?id=76733&r=trysnapshot55
Try a snapshot (trunk): 
https://bugs.php.net/fix.php?id=76733&r=trysnapshottrunk
Fixed in SVN:   https://bugs.php.net/fix.php?id=76733&r=fixed
Fixed in release:   https://bugs.php.net/fix.php?id=76733&r=alreadyfixed
Need backtrace: https://bugs.php.net/fix.php?id=76733&r=needtrace
Need Reproduce Script:  https://bugs.php.net/fix.php?id=76733&r=needscript
Try newer version:  https://bugs.php.net/fix.php?id=76733&r=oldversion
Not developer issue:https://bugs.php.net/fix.php?id=76733&r=support
Expected behavior:  https://bugs.php.net/fix.php?id=76733&r=notwrong
Not enough info:
https://bugs.php.net/fix.php?id=76733&r=notenoughinfo
Submitted twice:
https://bugs.php.net/fix.php?id=76733&r=submittedtwice
register_globals:   https://bugs.php.net/fix.php?id=76733&r=globals
PHP 4 support discontinued: https://bugs.php.net/fix.php?id=76733&r=php4
Daylight Savings:   https://bugs.php.net/fix.php?id=76733&r=dst
IIS Stability:  https://bugs.php.net/fix.php?id=76733&r=isapi
Install GNU Sed:https://bugs.php.net/fix.php?id=76733&r=gnused
Floating point limitations: https://bugs.php.net/fix.php?id=76733&r=float
No Zend Extensions: https://bugs.php.net/fix.php?id=76733&r=nozend
MySQL Configuration Error:  https://bugs.php.net/fix.php?id=76733&r=mysqlcfg


-- 
PHP Quality Assurance Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

Req #60360 [Com]: Add a phpinfo() somewhere on GCOV

2018-09-09 Thread carusogabr...@php.net 
Edit report at https://bugs.php.net/bug.php?id=60360&edit=1

 ID: 60360
 Comment by: carusogabr...@php.net
 Reported by:pierr...@php.net
 Summary:Add a phpinfo() somewhere on GCOV
 Status: Open
 Type:   Feature/Change Request
 Package:Testing related
 PHP Version:Irrelevant
 Block user comment: N
 Private report: N

 New Comment:

> I think anyone with php-web karma can commit to gcov.


@nlopess Unfortunately, no. I have an open PR in GitHub 
https://github.com/php/web-gcov/pull/1, and after try to commit, I got a 
message that I have insufficient karma. 

I'll attach the patch to this PR and let you know.


Previous Comments:

[2018-08-12 22:08:17] nlop...@php.net

Ferenc: sure, feel free to implement this. Let me know if you need to me to 
commit the patch. I think anyone with php-web karma can commit to gcov.


[2018-08-12 18:04:29] carusogabr...@php.net

+nlop...@php.net Can we do this one? As described, would help us know which 
version our libs are.


[2011-11-22 20:22:05] tyr...@php.net

It should be generated per build basis, so we can check it for each execution.
If Nuno doesn't mind, I can do this, as it seems trivial to implement.


[2011-11-22 20:09:17] pierr...@php.net

Description:

It would be nice to have a phpinfo() somewhere on the gcov server to know which 
version of a specific lib is used.







--
Edit this bug report at https://bugs.php.net/bug.php?id=60360&edit=1