[piccolo2d-dev] Issue 231 in piccolo2d: Mistake in java doc comment

2011-12-10 Thread piccolo2d 

Status: New
Owner: 

New issue 231 by 3...@gmx.de: Mistake in java doc comment
http://code.google.com/p/piccolo2d/issues/detail?id=231

See  
http://piccolo2d.org/doc/piccolo2d.java/release-1.3/core/apidocs/edu/umd/cs/piccolo/nodes/PText.html#setConstrainHeightToTextHeight(boolean):


Parameters:
constrainHeightToTextHeight - true if this text node should constrain its  
height to the width of its text


should read

Parameters:
constrainHeightToTextHeight - true if this text node should constrain its  
height to the *height* of its text


--
Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en

[piccolo2d-dev] Re: Issue 231 in piccolo2d: Mistake in java doc comment

2011-12-10 Thread piccolo2d 

Updates:
Status: Accepted
Owner: heue...@gmail.com
	Labels: Type-Defect Priority-Medium Effort-Low OpSys-All  
Toolkit-Piccolo2D.Java Component-Core Milestone-1.3.2


Comment #1 on issue 231 by heue...@gmail.com: Mistake in java doc comment
http://code.google.com/p/piccolo2d/issues/detail?id=231

Good catch, thanks for the note.

--
Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en

[piccolo2d-dev] [piccolo2d] r1158 committed - Issue 231 ; doc fix, width --> height

2011-12-10 Thread piccolo2d 

Revision: 1158
Author:   heuermh
Date: Sat Dec 10 12:57:01 2011
Log:  Issue 231 ; doc fix, width --> height
http://code.google.com/p/piccolo2d/source/detail?r=1158

Modified:
 /piccolo2d.java/trunk/core/src/main/java/org/piccolo2d/nodes/PText.java

===
--- /piccolo2d.java/trunk/core/src/main/java/org/piccolo2d/nodes/PText.java	 
Tue Mar 15 15:23:53 2011
+++ /piccolo2d.java/trunk/core/src/main/java/org/piccolo2d/nodes/PText.java	 
Sat Dec 10 12:57:01 2011

@@ -310,7 +310,7 @@
  * the height of its text.
  *
  * @param constrainHeightToTextHeight true if this text node should
- *constrain its height to the width of its text
+ *constrain its height to the height of its text
  */
 public void setConstrainHeightToTextHeight(final boolean  
constrainHeightToTextHeight) {

 this.constrainHeightToTextHeight = constrainHeightToTextHeight;

--
Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en

[piccolo2d-dev] [piccolo2d] r1159 committed - Issue 231 ; doc fix, width --> height

2011-12-10 Thread piccolo2d 

Revision: 1159
Author:   heuermh
Date: Sat Dec 10 12:59:59 2011
Log:  Issue 231 ; doc fix, width --> height
http://code.google.com/p/piccolo2d/source/detail?r=1159

Modified:
  
/piccolo2d.java/branches/release-1.3/core/src/main/java/edu/umd/cs/piccolo/nodes/PText.java


===
---  
/piccolo2d.java/branches/release-1.3/core/src/main/java/edu/umd/cs/piccolo/nodes/PText.java	 
Tue Mar 15 15:28:41 2011
+++  
/piccolo2d.java/branches/release-1.3/core/src/main/java/edu/umd/cs/piccolo/nodes/PText.java	 
Sat Dec 10 12:59:59 2011

@@ -327,7 +327,7 @@
  * the height of its text.
  *
  * @param constrainHeightToTextHeight true if this text node should
- *constrain its height to the width of its text
+ *constrain its height to the height of its text
  */
 public void setConstrainHeightToTextHeight(final boolean  
constrainHeightToTextHeight) {

 this.constrainHeightToTextHeight = constrainHeightToTextHeight;

--
Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en

[piccolo2d-dev] Re: Issue 231 in piccolo2d: Mistake in java doc comment

2011-12-10 Thread piccolo2d 

Updates:
Status: Fixed

Comment #2 on issue 231 by heue...@gmail.com: Mistake in java doc comment
http://code.google.com/p/piccolo2d/issues/detail?id=231

Fixed on trunk

$ svn commit -m "Issue 231 ; doc fix, width --> height"  
src/main/java/org/piccolo2d/nodes/PText.java

...
Committed revision 1158.

and on release-1.3-branch

$ svn commit -m "Issue 231 ; doc fix, width --> height"  
core/src/main/java/edu/umd/cs/piccolo/nodes/PText.java

...
Committed revision 1159.

--
Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en