[jira] Commented: (PIG-1034) Pig does not support ORDER ... BY group alias

2010-07-27 Thread Thejas M Nair (JIRA)

[ 
https://issues.apache.org/jira/browse/PIG-1034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12892821#action_12892821
 ] 

Thejas M Nair commented on PIG-1034:


+1 please commit.
I also ran the test-patch and unit tests on my machine, they pass.


 Pig does not support ORDER ... BY group alias
 -

 Key: PIG-1034
 URL: https://issues.apache.org/jira/browse/PIG-1034
 Project: Pig
  Issue Type: Bug
Affects Versions: 0.8.0
Reporter: David Ciemiewicz
Assignee: Jeff Zhang
 Fix For: 0.8.0

 Attachments: PIG_1034.patch


 GROUP ... ALL and GROUP ... BY produce an alias group.
 Pig produces a syntax error if you attempt to ORDER ... BY group.
 This does seem like a perfectly reasonable thing to do.
 The workaround is to create an alias for group using an AS clause.  But I 
 think this workaround should be unnecessary.
 Here's sample code which elicits the syntax error:
 {code}
 A = load 'one.txt' using PigStorage as (one: int);
 B = group A all;
 C = foreach B generate
   group,
   COUNT(A) as count;
 D = order C by group parallel 1; -- group is one of the aliases in C, why 
 does this throw a syntax error?
 dump D;
 {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (PIG-1034) Pig does not support ORDER ... BY group alias

2010-06-23 Thread Jeff Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/PIG-1034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12881598#action_12881598
 ] 

Jeff Zhang commented on PIG-1034:
-

Check the testReport, the failed testcase does not relate to this patch



 Pig does not support ORDER ... BY group alias
 -

 Key: PIG-1034
 URL: https://issues.apache.org/jira/browse/PIG-1034
 Project: Pig
  Issue Type: Bug
Affects Versions: 0.8.0
Reporter: David Ciemiewicz
Assignee: Jeff Zhang
 Fix For: 0.8.0

 Attachments: PIG_1034.patch


 GROUP ... ALL and GROUP ... BY produce an alias group.
 Pig produces a syntax error if you attempt to ORDER ... BY group.
 This does seem like a perfectly reasonable thing to do.
 The workaround is to create an alias for group using an AS clause.  But I 
 think this workaround should be unnecessary.
 Here's sample code which elicits the syntax error:
 {code}
 A = load 'one.txt' using PigStorage as (one: int);
 B = group A all;
 C = foreach B generate
   group,
   COUNT(A) as count;
 D = order C by group parallel 1; -- group is one of the aliases in C, why 
 does this throw a syntax error?
 dump D;
 {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (PIG-1034) Pig does not support ORDER ... BY group alias

2010-06-21 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/PIG-1034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12880808#action_12880808
 ] 

Hadoop QA commented on PIG-1034:


-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12447586/PIG_1034.patch
  against trunk revision 956440.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

-1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

-1 contrib tests.  The patch failed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/344/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/344/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/344/console

This message is automatically generated.

 Pig does not support ORDER ... BY group alias
 -

 Key: PIG-1034
 URL: https://issues.apache.org/jira/browse/PIG-1034
 Project: Pig
  Issue Type: Bug
Affects Versions: 0.8.0
Reporter: David Ciemiewicz
Assignee: Jeff Zhang
 Fix For: 0.8.0

 Attachments: PIG_1034.patch


 GROUP ... ALL and GROUP ... BY produce an alias group.
 Pig produces a syntax error if you attempt to ORDER ... BY group.
 This does seem like a perfectly reasonable thing to do.
 The workaround is to create an alias for group using an AS clause.  But I 
 think this workaround should be unnecessary.
 Here's sample code which elicits the syntax error:
 {code}
 A = load 'one.txt' using PigStorage as (one: int);
 B = group A all;
 C = foreach B generate
   group,
   COUNT(A) as count;
 D = order C by group parallel 1; -- group is one of the aliases in C, why 
 does this throw a syntax error?
 dump D;
 {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.