[jira] Commented: (PIG-1118) expression with aggregate functions returning null, with accumulate interface

2009-12-03 Thread Olga Natkovich (JIRA)

[ 
https://issues.apache.org/jira/browse/PIG-1118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12785400#action_12785400
 ] 

Olga Natkovich commented on PIG-1118:
-

looks like the failures due to problems with framework no the patch itself. 
Will resubmit the patch.

 expression with aggregate functions returning null, with accumulate interface
 -

 Key: PIG-1118
 URL: https://issues.apache.org/jira/browse/PIG-1118
 Project: Pig
  Issue Type: Bug
Reporter: Thejas M Nair
Assignee: Ying He
 Fix For: 0.7.0

 Attachments: PIG_1118.patch


 The problem is in trunk . It works fine in 0.6 branch.
 l = load '/tmp/students.txt' as (a : chararray,b : chararray,c : int);
 grunt g = group l by 1;
 grunt dump g;
 (1,{(asdfxc,M,23),(qwer,F,21),(uhsdf,M,34),(zxldf,M,21),(qwer,F,23),(oiue,M,54)})
 grunt f = foreach g generate SUM(l.c), 1 + SUM(l.c) + SUM(l.c);
 grunt dump f;
 (176L,)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (PIG-1118) expression with aggregate functions returning null, with accumulate interface

2009-12-02 Thread Olga Natkovich (JIRA)

[ 
https://issues.apache.org/jira/browse/PIG-1118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12785025#action_12785025
 ] 

Olga Natkovich commented on PIG-1118:
-

Ying, the change looks good. Please, add a unit test for this bug.

 expression with aggregate functions returning null, with accumulate interface
 -

 Key: PIG-1118
 URL: https://issues.apache.org/jira/browse/PIG-1118
 Project: Pig
  Issue Type: Bug
Reporter: Thejas M Nair
Assignee: Ying He
 Fix For: 0.7.0

 Attachments: PIG_1118.patch


 The problem is in trunk . It works fine in 0.6 branch.
 l = load '/tmp/students.txt' as (a : chararray,b : chararray,c : int);
 grunt g = group l by 1;
 grunt dump g;
 (1,{(asdfxc,M,23),(qwer,F,21),(uhsdf,M,34),(zxldf,M,21),(qwer,F,23),(oiue,M,54)})
 grunt f = foreach g generate SUM(l.c), 1 + SUM(l.c) + SUM(l.c);
 grunt dump f;
 (176L,)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (PIG-1118) expression with aggregate functions returning null, with accumulate interface

2009-12-02 Thread Ying He (JIRA)

[ 
https://issues.apache.org/jira/browse/PIG-1118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12785043#action_12785043
 ] 

Ying He commented on PIG-1118:
--

Olga, thank for review.  A unit test is in the patch, TestAccumulator. 

 expression with aggregate functions returning null, with accumulate interface
 -

 Key: PIG-1118
 URL: https://issues.apache.org/jira/browse/PIG-1118
 Project: Pig
  Issue Type: Bug
Reporter: Thejas M Nair
Assignee: Ying He
 Fix For: 0.7.0

 Attachments: PIG_1118.patch


 The problem is in trunk . It works fine in 0.6 branch.
 l = load '/tmp/students.txt' as (a : chararray,b : chararray,c : int);
 grunt g = group l by 1;
 grunt dump g;
 (1,{(asdfxc,M,23),(qwer,F,21),(uhsdf,M,34),(zxldf,M,21),(qwer,F,23),(oiue,M,54)})
 grunt f = foreach g generate SUM(l.c), 1 + SUM(l.c) + SUM(l.c);
 grunt dump f;
 (176L,)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (PIG-1118) expression with aggregate functions returning null, with accumulate interface

2009-12-02 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/PIG-1118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12785166#action_12785166
 ] 

Hadoop QA commented on PIG-1118:


-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12426698/PIG_1118.patch
  against trunk revision 886015.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/79/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/79/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/79/console

This message is automatically generated.

 expression with aggregate functions returning null, with accumulate interface
 -

 Key: PIG-1118
 URL: https://issues.apache.org/jira/browse/PIG-1118
 Project: Pig
  Issue Type: Bug
Reporter: Thejas M Nair
Assignee: Ying He
 Fix For: 0.7.0

 Attachments: PIG_1118.patch


 The problem is in trunk . It works fine in 0.6 branch.
 l = load '/tmp/students.txt' as (a : chararray,b : chararray,c : int);
 grunt g = group l by 1;
 grunt dump g;
 (1,{(asdfxc,M,23),(qwer,F,21),(uhsdf,M,34),(zxldf,M,21),(qwer,F,23),(oiue,M,54)})
 grunt f = foreach g generate SUM(l.c), 1 + SUM(l.c) + SUM(l.c);
 grunt dump f;
 (176L,)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.