[jira] Commented: (PIG-1172) PushDownForeachFlatten shall not push ForEach below Join if the flattened fields is used in Join

2010-01-04 Thread Alan Gates (JIRA)

[ 
https://issues.apache.org/jira/browse/PIG-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12796394#action_12796394
 ] 

Alan Gates commented on PIG-1172:
-

Changes look good, +1.

The patch lists a new hadoop20.jar.  Is this intentional?

 PushDownForeachFlatten shall not push ForEach below Join if the flattened 
 fields is used in Join
 

 Key: PIG-1172
 URL: https://issues.apache.org/jira/browse/PIG-1172
 Project: Pig
  Issue Type: Bug
  Components: impl
Affects Versions: 0.6.0
Reporter: Daniel Dai
Assignee: Daniel Dai
 Fix For: 0.6.0

 Attachments: PIG-1172-1.patch


 Currently the following script will push B below D. But we will use fattened 
 column in the join, we cannot push that.
 A = load '1.txt' as (bg:bag{t:tuple(a0,a1)});
 B = FOREACH A generate flatten($0);
 C = load '3.txt' AS (c0, c1);
 D = JOIN B by a1, C by c1;
 E = limit D 10;
 explain E;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (PIG-1172) PushDownForeachFlatten shall not push ForEach below Join if the flattened fields is used in Join

2009-12-25 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/PIG-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12794556#action_12794556
 ] 

Hadoop QA commented on PIG-1172:


+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12428938/PIG-1172-1.patch
  against trunk revision 893827.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/163/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/163/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/163/console

This message is automatically generated.

 PushDownForeachFlatten shall not push ForEach below Join if the flattened 
 fields is used in Join
 

 Key: PIG-1172
 URL: https://issues.apache.org/jira/browse/PIG-1172
 Project: Pig
  Issue Type: Bug
  Components: impl
Affects Versions: 0.6.0
Reporter: Daniel Dai
Assignee: Daniel Dai
 Fix For: 0.6.0

 Attachments: PIG-1172-1.patch


 Currently the following script will push B below D. But we will use fattened 
 column in the join, we cannot push that.
 A = load '1.txt' as (bg:bag{t:tuple(a0,a1)});
 B = FOREACH A generate flatten($0);
 C = load '3.txt' AS (c0, c1);
 D = JOIN B by a1, C by c1;
 E = limit D 10;
 explain E;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.