[jira] Updated: (PIG-1531) Pig gobbles up error messages
[
https://issues.apache.org/jira/browse/PIG-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
niraj rai updated PIG-1531:
---
Attachment: PIG-1531_5.patch
reviewed the patch and made the required changes after discussion with
Ashutosh. Ran test-patch and unit test and everything looks fine.
Ashutosh, please commit the patch, if you don't have any further comment.
Thanks
Niraj
Pig gobbles up error messages
-
Key: PIG-1531
URL: https://issues.apache.org/jira/browse/PIG-1531
Project: Pig
Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Ashutosh Chauhan
Assignee: niraj rai
Fix For: 0.8.0
Attachments: pig-1531_3.patch, pig-1531_4.patch, PIG-1531_5.patch,
PIG_1531.patch, PIG_1531_2.patch
Consider the following. I have my own Storer implementing StoreFunc and I am
throwing FrontEndException (and other Exceptions derived from PigException)
in its various methods. I expect those error messages to be shown in error
scenarios. Instead Pig gobbles up my error messages and shows its own generic
error message like:
{code}
010-07-31 14:14:25,414 [main] ERROR org.apache.pig.tools.grunt.Grunt - ERROR
2116: Unexpected error. Could not validate the output specification for:
default.partitoned
Details at logfile: /Users/ashutosh/workspace/pig/pig_1280610650690.log
{code}
Instead I expect it to display my error messages which it stores away in that
log file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1531) Pig gobbles up error messages
[
https://issues.apache.org/jira/browse/PIG-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashutosh Chauhan updated PIG-1531:
--
Status: Resolved (was: Patch Available)
Resolution: Fixed
Committed to both trunk and 0.8. Thanks, Niraj!
Pig gobbles up error messages
-
Key: PIG-1531
URL: https://issues.apache.org/jira/browse/PIG-1531
Project: Pig
Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Ashutosh Chauhan
Assignee: niraj rai
Fix For: 0.8.0
Attachments: pig-1531_3.patch, pig-1531_4.patch, PIG-1531_5.patch,
PIG_1531.patch, PIG_1531_2.patch
Consider the following. I have my own Storer implementing StoreFunc and I am
throwing FrontEndException (and other Exceptions derived from PigException)
in its various methods. I expect those error messages to be shown in error
scenarios. Instead Pig gobbles up my error messages and shows its own generic
error message like:
{code}
010-07-31 14:14:25,414 [main] ERROR org.apache.pig.tools.grunt.Grunt - ERROR
2116: Unexpected error. Could not validate the output specification for:
default.partitoned
Details at logfile: /Users/ashutosh/workspace/pig/pig_1280610650690.log
{code}
Instead I expect it to display my error messages which it stores away in that
log file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1531) Pig gobbles up error messages
[
https://issues.apache.org/jira/browse/PIG-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashutosh Chauhan updated PIG-1531:
--
Status: Patch Available (was: Reopened)
Pig gobbles up error messages
-
Key: PIG-1531
URL: https://issues.apache.org/jira/browse/PIG-1531
Project: Pig
Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Ashutosh Chauhan
Assignee: niraj rai
Fix For: 0.8.0
Attachments: pig-1531_3.patch, pig-1531_4.patch, PIG_1531.patch,
PIG_1531_2.patch
Consider the following. I have my own Storer implementing StoreFunc and I am
throwing FrontEndException (and other Exceptions derived from PigException)
in its various methods. I expect those error messages to be shown in error
scenarios. Instead Pig gobbles up my error messages and shows its own generic
error message like:
{code}
010-07-31 14:14:25,414 [main] ERROR org.apache.pig.tools.grunt.Grunt - ERROR
2116: Unexpected error. Could not validate the output specification for:
default.partitoned
Details at logfile: /Users/ashutosh/workspace/pig/pig_1280610650690.log
{code}
Instead I expect it to display my error messages which it stores away in that
log file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1531) Pig gobbles up error messages
[
https://issues.apache.org/jira/browse/PIG-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashutosh Chauhan updated PIG-1531:
--
Attachment: pig-1531_4.patch
Added a test-case which fails on trunk. Pig still gobbles up error messages.
Fix is to rethrow the message in the hierarchy. Attached patch containis the
test case and the fix.
Pig gobbles up error messages
-
Key: PIG-1531
URL: https://issues.apache.org/jira/browse/PIG-1531
Project: Pig
Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Ashutosh Chauhan
Assignee: niraj rai
Fix For: 0.8.0
Attachments: pig-1531_3.patch, pig-1531_4.patch, PIG_1531.patch,
PIG_1531_2.patch
Consider the following. I have my own Storer implementing StoreFunc and I am
throwing FrontEndException (and other Exceptions derived from PigException)
in its various methods. I expect those error messages to be shown in error
scenarios. Instead Pig gobbles up my error messages and shows its own generic
error message like:
{code}
010-07-31 14:14:25,414 [main] ERROR org.apache.pig.tools.grunt.Grunt - ERROR
2116: Unexpected error. Could not validate the output specification for:
default.partitoned
Details at logfile: /Users/ashutosh/workspace/pig/pig_1280610650690.log
{code}
Instead I expect it to display my error messages which it stores away in that
log file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1531) Pig gobbles up error messages
[
https://issues.apache.org/jira/browse/PIG-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashutosh Chauhan updated PIG-1531:
--
Attachment: pig-1531_3.patch
I took a look of the latest patch. There are two minor problems. Firstly,
pigExec was always null and never assigned a value, so it resulted in NPE in
certain code path. Second, the boolean logic in PigInputFormat needs instead
of ||. I thought of correcting it and committing. But then realized hudson
hasnt come back with results yet. So, I am uploading a new patch with those
corrections and submitting to Hudson again. In this patch, I also refactored a
code a bit, so its easier to read. Have a look and if its look fine to you. Can
you run test-patch and unit tests and paste results here, so I can commit it.
Pig gobbles up error messages
-
Key: PIG-1531
URL: https://issues.apache.org/jira/browse/PIG-1531
Project: Pig
Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Ashutosh Chauhan
Assignee: niraj rai
Fix For: 0.8.0
Attachments: pig-1531_3.patch, PIG_1531.patch, PIG_1531_2.patch
Consider the following. I have my own Storer implementing StoreFunc and I am
throwing FrontEndException (and other Exceptions derived from PigException)
in its various methods. I expect those error messages to be shown in error
scenarios. Instead Pig gobbles up my error messages and shows its own generic
error message like:
{code}
010-07-31 14:14:25,414 [main] ERROR org.apache.pig.tools.grunt.Grunt - ERROR
2116: Unexpected error. Could not validate the output specification for:
default.partitoned
Details at logfile: /Users/ashutosh/workspace/pig/pig_1280610650690.log
{code}
Instead I expect it to display my error messages which it stores away in that
log file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1531) Pig gobbles up error messages
[
https://issues.apache.org/jira/browse/PIG-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashutosh Chauhan updated PIG-1531:
--
Status: Patch Available (was: Open)
Pig gobbles up error messages
-
Key: PIG-1531
URL: https://issues.apache.org/jira/browse/PIG-1531
Project: Pig
Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Ashutosh Chauhan
Assignee: niraj rai
Fix For: 0.8.0
Attachments: pig-1531_3.patch, PIG_1531.patch, PIG_1531_2.patch
Consider the following. I have my own Storer implementing StoreFunc and I am
throwing FrontEndException (and other Exceptions derived from PigException)
in its various methods. I expect those error messages to be shown in error
scenarios. Instead Pig gobbles up my error messages and shows its own generic
error message like:
{code}
010-07-31 14:14:25,414 [main] ERROR org.apache.pig.tools.grunt.Grunt - ERROR
2116: Unexpected error. Could not validate the output specification for:
default.partitoned
Details at logfile: /Users/ashutosh/workspace/pig/pig_1280610650690.log
{code}
Instead I expect it to display my error messages which it stores away in that
log file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1531) Pig gobbles up error messages
[
https://issues.apache.org/jira/browse/PIG-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
niraj rai updated PIG-1531:
---
Attachment: PIG_1531_2.patch
I have tried to accommodate all the recommendations from Ashutosh. I have
changed the existing test case to validate the error message, in case the store
directory exist. Writing test case for the case, when input file deos not exist
was more effort than fixing the actual fix. So, I verified it manually and
they looked good.
Thanks
Niraj
Pig gobbles up error messages
-
Key: PIG-1531
URL: https://issues.apache.org/jira/browse/PIG-1531
Project: Pig
Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Ashutosh Chauhan
Assignee: niraj rai
Fix For: 0.8.0
Attachments: PIG_1531.patch, PIG_1531_2.patch
Consider the following. I have my own Storer implementing StoreFunc and I am
throwing FrontEndException (and other Exceptions derived from PigException)
in its various methods. I expect those error messages to be shown in error
scenarios. Instead Pig gobbles up my error messages and shows its own generic
error message like:
{code}
010-07-31 14:14:25,414 [main] ERROR org.apache.pig.tools.grunt.Grunt - ERROR
2116: Unexpected error. Could not validate the output specification for:
default.partitoned
Details at logfile: /Users/ashutosh/workspace/pig/pig_1280610650690.log
{code}
Instead I expect it to display my error messages which it stores away in that
log file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1531) Pig gobbles up error messages
[
https://issues.apache.org/jira/browse/PIG-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
niraj rai updated PIG-1531:
---
Status: Patch Available (was: Open)
Pig gobbles up error messages
-
Key: PIG-1531
URL: https://issues.apache.org/jira/browse/PIG-1531
Project: Pig
Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Ashutosh Chauhan
Assignee: niraj rai
Fix For: 0.8.0
Attachments: PIG_1531.patch, PIG_1531_2.patch
Consider the following. I have my own Storer implementing StoreFunc and I am
throwing FrontEndException (and other Exceptions derived from PigException)
in its various methods. I expect those error messages to be shown in error
scenarios. Instead Pig gobbles up my error messages and shows its own generic
error message like:
{code}
010-07-31 14:14:25,414 [main] ERROR org.apache.pig.tools.grunt.Grunt - ERROR
2116: Unexpected error. Could not validate the output specification for:
default.partitoned
Details at logfile: /Users/ashutosh/workspace/pig/pig_1280610650690.log
{code}
Instead I expect it to display my error messages which it stores away in that
log file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
