[jira] Updated: (PIG-553) EvalFunc.finish() not getting called

2009-02-06 Thread Santhosh Srinivasan (JIRA)

 [ 
https://issues.apache.org/jira/browse/PIG-553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Santhosh Srinivasan updated PIG-553:


  Resolution: Fixed
Hadoop Flags: [Reviewed]
  Status: Resolved  (was: Patch Available)

Patch has been committed. Thanks for the fix Shravan.

 EvalFunc.finish() not getting called
 

 Key: PIG-553
 URL: https://issues.apache.org/jira/browse/PIG-553
 Project: Pig
  Issue Type: Bug
Affects Versions: types_branch
 Environment: local mode
Reporter: Christopher Olston
Assignee: Shravan Matthur Narayanamurthy
 Attachments: 553.patch


 My EvalFunc's finish() method doesn't seem to get invoked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (PIG-553) EvalFunc.finish() not getting called

2009-01-28 Thread Shravan Matthur Narayanamurthy (JIRA)

 [ 
https://issues.apache.org/jira/browse/PIG-553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shravan Matthur Narayanamurthy updated PIG-553:
---

Attachment: 553.patch

Created TestCase that tests calling of finish in both MR  local mode and in 
each mode both scenarios: one where udf is in map phase  another where udf is 
in reduce phase.

Note that I have not used the minicluster because the MR job will run in 
another VM and its an overkill to use IPC to figure out whether finish() was 
called.

 EvalFunc.finish() not getting called
 

 Key: PIG-553
 URL: https://issues.apache.org/jira/browse/PIG-553
 Project: Pig
  Issue Type: Bug
Affects Versions: types_branch
 Environment: local mode
Reporter: Christopher Olston
Assignee: Shravan Matthur Narayanamurthy
 Attachments: 553.patch


 My EvalFunc's finish() method doesn't seem to get invoked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (PIG-553) EvalFunc.finish() not getting called

2009-01-28 Thread Shravan Matthur Narayanamurthy (JIRA)

 [ 
https://issues.apache.org/jira/browse/PIG-553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shravan Matthur Narayanamurthy updated PIG-553:
---

Attachment: (was: 553.patch)

 EvalFunc.finish() not getting called
 

 Key: PIG-553
 URL: https://issues.apache.org/jira/browse/PIG-553
 Project: Pig
  Issue Type: Bug
Affects Versions: types_branch
 Environment: local mode
Reporter: Christopher Olston
Assignee: Shravan Matthur Narayanamurthy

 My EvalFunc's finish() method doesn't seem to get invoked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (PIG-553) EvalFunc.finish() not getting called

2009-01-20 Thread Shravan Matthur Narayanamurthy (JIRA)

 [ 
https://issues.apache.org/jira/browse/PIG-553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shravan Matthur Narayanamurthy updated PIG-553:
---

Status: Patch Available  (was: Open)

Fixed the local mode by writing a visitor that calls the EvalFunc.finish() 
method. Waiting for comments from others on my earlier query

 EvalFunc.finish() not getting called
 

 Key: PIG-553
 URL: https://issues.apache.org/jira/browse/PIG-553
 Project: Pig
  Issue Type: Bug
Affects Versions: types_branch
 Environment: local mode
Reporter: Christopher Olston
Assignee: Shravan Matthur Narayanamurthy

 My EvalFunc's finish() method doesn't seem to get invoked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (PIG-553) EvalFunc.finish() not getting called

2009-01-20 Thread Shravan Matthur Narayanamurthy (JIRA)

 [ 
https://issues.apache.org/jira/browse/PIG-553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shravan Matthur Narayanamurthy updated PIG-553:
---

Attachment: 553.patch

 EvalFunc.finish() not getting called
 

 Key: PIG-553
 URL: https://issues.apache.org/jira/browse/PIG-553
 Project: Pig
  Issue Type: Bug
Affects Versions: types_branch
 Environment: local mode
Reporter: Christopher Olston
Assignee: Shravan Matthur Narayanamurthy
 Attachments: 553.patch


 My EvalFunc's finish() method doesn't seem to get invoked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.