Re: [Piglit] [PATCH] glsl-1.10: Add vec4 test for gl_FrontFacing ternary usage.
On 03/30/2015 08:41 PM, Matt Turner wrote: Reviewed-by: Matt Turner Are you planning to work on a i965 patch to fix this? Yep, this is the plan. did not investigate closer yet though. (Did you hit this in a real application?) This is causing noise in some of the objects in 'Papa & Yo' game (uses UE3 engine). // Tapani ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] Skip fp-indirections if the limits exposed are totally bogus.
Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH] Skip fp-indirections if the limits exposed are totally bogus.
Signed-off-by: Kenneth Graunke
---
tests/shaders/fp-indirections.c | 13 +
1 file changed, 13 insertions(+)
It looks like people expose real values, 128 (Intel/Windows), 16384 (NVIDIA,
i965,
Gallium), 65536 (one NVIDIA card), and INT_MAX (AMD). So 10,000 is pretty
arbitrary, but it's conservative and speeds up my Piglit run times.
diff --git a/tests/shaders/fp-indirections.c b/tests/shaders/fp-indirections.c
index 3c84aea..540c252 100644
--- a/tests/shaders/fp-indirections.c
+++ b/tests/shaders/fp-indirections.c
@@ -296,4 +296,17 @@ piglit_init(int argc, char **argv)
get_program_i(GL_MAX_PROGRAM_TEX_INDIRECTIONS_ARB));
printf("Maximum native tex indirections: %d\n",
get_program_i(GL_MAX_PROGRAM_NATIVE_TEX_INDIRECTIONS_ARB));
+
+ /* If the GL reports more than 1 texture indirections, then we're
probably
+* running on hardware with no limitations - the driver just picked some
+* arbitrary large number to report back. The test isn't meaningful,
and
+* the run time explodes with huge limits, so just skip it.
+*
+* For reference, Mesa and NVIDIA report 16384; AMD reports 2147483647.
+* Pineview hardware (where this test is relevant) has a limit of 4.
+*/
+ if (get_program_i(GL_MAX_PROGRAM_TEX_INDIRECTIONS_ARB) > 1) {
+ printf("Skipping; the hardware doesn't appear to have real
limits.\n");
+ piglit_report_result(PIGLIT_SKIP);
+ }
}
--
2.3.4
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] Problem submitting patch through git send-email
Hi Guy-Daniel, On 30 March 2015 at 20:36, Guy-Daniel Tiku wrote: > Hi, > > I've worked on an patch ans I've tried over and over to submit it through > the git send-email command. In the meantime, I've attached the patch to this > email. > Judging from the incomplete diff, it seems that you're just moving a test from one place to another. Is that correct ? Normally the commit message should explain why that is needed. > Can I get some help on how to fix this problem ? > As Matt mentioned already, without any information one cannot help :'-( Have you checked with the git send-email man page [1] it has a nice example how to format/email patches, plus how to setup your system with Gmail. Cheers, Emil [1] http://git-scm.com/docs/git-send-email ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] arb_arrays_of_arrays: compile test basic types
On Mon, 2015-03-30 at 10:51 +0300, Martin Peres wrote: > On 30/03/15 10:29, Timothy Arceri wrote: > > Test results: > > > > Nvidia GeForce 840M - NVIDIA 346.47: pass > > --- > > This is just > > /tests/spec/glsl-1.20/compiler/structure-and-array-operations/array-of-any-type.vert > > with an extra dimension added. > > Do you have any other test that would cover more than just the grammar? > Maybe you already sent them (possibly a while ago), sorry if this is the > case. Yeah there are a bunch of tests already in piglit that I've submitted over the past year. The main reason for this test is that I haven't got any tests for sampler arrays of arrays so this seemed like a nice test to start things off with. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] Problem submitting patch through git send-email
On Mon, Mar 30, 2015 at 12:36 PM, Guy-Daniel Tiku wrote: > Hi, > > I've worked on an patch ans I've tried over and over to submit it through > the git send-email command. In the meantime, I've attached the patch to this > email. Can I get some help on how to fix this problem ? Without describing the error... how can anyone help? As for the patch... I can't tell what its purpose is either since there's no commit message. It looks like it's just the output of git diff, rather than a patch you committed (git commit) and generated with git format-patch. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] Problem submitting patch through git send-email
Hi,
I've worked on an patch ans I've tried over and over to submit it through
the git send-email command. In the meantime, I've attached the patch to
this email. Can I get some help on how to fix this problem ?
Best.
Guy-Daniel.
diff --git a/tests/bugs/CMakeLists.gl.txt b/tests/bugs/CMakeLists.gl.txt
index e24ec6b..322232e 100644
--- a/tests/bugs/CMakeLists.gl.txt
+++ b/tests/bugs/CMakeLists.gl.txt
@@ -11,7 +11,6 @@ link_libraries (
${OPENGL_glu_LIBRARY}
)
-piglit_add_executable (crash-cubemap-order crash-cubemap-order.c)
piglit_add_executable (crash-texparameter-before-teximage crash-texparameter-before-teximage.c)
piglit_add_executable (drawbuffer-modes drawbuffer-modes.c)
piglit_add_executable (fdo10370 fdo10370.c)
diff --git a/tests/bugs/crash-cubemap-order.c b/tests/bugs/crash-cubemap-order.c
deleted file mode 100644
index c6b3882..000
--- a/tests/bugs/crash-cubemap-order.c
+++ /dev/null
@@ -1,51 +0,0 @@
-/**
- * @file crash-cubemap-order.c
- *
- * Test case for "crash if cubemap faces are loaded in an unusual order".
- *
- * This bug existed in the R300 driver and was triggered by Sauerbraten.
- */
-
-#include "piglit-util-gl.h"
-
-PIGLIT_GL_TEST_CONFIG_BEGIN
-
- config.supports_gl_compat_version = 10;
-
- config.window_visual = PIGLIT_GL_VISUAL_DOUBLE | PIGLIT_GL_VISUAL_RGB;
-
-PIGLIT_GL_TEST_CONFIG_END
-
-enum piglit_result
-piglit_display(void)
-{
- return PIGLIT_PASS;
-}
-
-void
-piglit_init(int argc, char **argv)
-{
- GLubyte data[4096]; /* 32*32*4 */
-
- piglit_require_extension("GL_ARB_texture_cube_map");
-
- memset(data, 0, sizeof(data));
-
- glViewport(0, 0, piglit_width, piglit_height);
-
- glBindTexture(GL_TEXTURE_CUBE_MAP, 1);
- glTexImage2D(GL_TEXTURE_CUBE_MAP_NEGATIVE_X, 0, GL_RGBA, 32, 32, 0, GL_RGBA, GL_UNSIGNED_BYTE, data);
- glTexImage2D(GL_TEXTURE_CUBE_MAP_NEGATIVE_Y, 0, GL_RGBA, 32, 32, 0, GL_RGBA, GL_UNSIGNED_BYTE, data);
- glTexImage2D(GL_TEXTURE_CUBE_MAP_NEGATIVE_Z, 0, GL_RGBA, 32, 32, 0, GL_RGBA, GL_UNSIGNED_BYTE, data);
- glTexImage2D(GL_TEXTURE_CUBE_MAP_POSITIVE_Z, 0, GL_RGBA, 32, 32, 0, GL_RGBA, GL_UNSIGNED_BYTE, data);
- glTexImage2D(GL_TEXTURE_CUBE_MAP_POSITIVE_Y, 0, GL_RGBA, 32, 32, 0, GL_RGBA, GL_UNSIGNED_BYTE, data);
- glTexImage2D(GL_TEXTURE_CUBE_MAP_POSITIVE_X, 0, GL_RGBA, 32, 32, 0, GL_RGBA, GL_UNSIGNED_BYTE, data);
-
- glBindTexture(GL_TEXTURE_CUBE_MAP, 2);
- glTexImage2D(GL_TEXTURE_CUBE_MAP_NEGATIVE_X, 0, GL_RGBA, 32, 32, 0, GL_RGBA, GL_UNSIGNED_BYTE, 0);
- glTexImage2D(GL_TEXTURE_CUBE_MAP_NEGATIVE_Y, 0, GL_RGBA, 32, 32, 0, GL_RGBA, GL_UNSIGNED_BYTE, 0);
- glTexImage2D(GL_TEXTURE_CUBE_MAP_NEGATIVE_Z, 0, GL_RGBA, 32, 32, 0, GL_RGBA, GL_UNSIGNED_BYTE, 0);
- glTexImage2D(GL_TEXTURE_CUBE_MAP_POSITIVE_Z, 0, GL_RGBA, 32, 32, 0, GL_RGBA, GL_UNSIGNED_BYTE, 0);
- glTexImage2D(GL_TEXTURE_CUBE_MAP_POSITIVE_Y, 0, GL_RGBA, 32, 32, 0, GL_RGBA, GL_UNSIGNED_BYTE, 0);
- glTexImage2D(GL_TEXTURE_CUBE_MAP_POSITIVE_X, 0, GL_RGBA, 32, 32, 0, GL_RGBA, GL_UNSIGNED_BYTE, 0);
-}
diff --git a/tests/spec/CMakeLists.txt b/tests/spec/CMakeLists.txt
index d921df4..cbc59f4 100644
--- a/tests/spec/CMakeLists.txt
+++ b/tests/spec/CMakeLists.txt
@@ -66,6 +66,7 @@ add_subdirectory (arb_transform_feedback2)
add_subdirectory (arb_transform_feedback3)
add_subdirectory (arb_viewport_array)
add_subdirectory (ati_envmap_bumpmap)
+add_subdirectory (crash_cubemap_order)
add_subdirectory (ext_fog_coord)
add_subdirectory (ext_framebuffer_multisample)
add_subdirectory (ext_framebuffer_multisample_blit_scaled)
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH v2 8/8] profile.py: Don't allow accidental reassignments of TestDict keys
Series is Reviewed-by: Ilia Mirkin
Still unsure about whether the texture size stuff needs to be fixed
up, but also can't bring myself to care about it.
On Mon, Mar 30, 2015 at 2:54 PM, Dylan Baker wrote:
> A common error in all.py is that two different tests are assigned to the
> same key value in profile.test_list. This change prevents a key from
> being reassigned to a new value on accident, but provides a mechanism to
> allow reassignment, using a context manager. This allows tests like the
> image_load_store tests in quick.py to be overwritten, but requires the
> author to mark that they know that they are overwriting tests, and that
> it's intentional.
>
> This also adds some tests for TestDict.
>
> v2: - remove some rebase artifacts, this makes the code a little simpler
> and a little cleaner
> v3: - rebase on master, includes grouptools separator changes
> v4: - Use a incremented value instead of True false for the context
> manager, this allows the allow_reassignment contextmanager to be
> nested. (Ilia)
>
> Signed-off-by: Dylan Baker
> ---
> framework/profile.py | 72 +-
> framework/tests/profile_tests.py | 96
>
> tests/quick.py | 15 ---
> 3 files changed, 165 insertions(+), 18 deletions(-)
>
> diff --git a/framework/profile.py b/framework/profile.py
> index 1384bbd..32d0c15 100644
> --- a/framework/profile.py
> +++ b/framework/profile.py
> @@ -32,7 +32,6 @@ import sys
> import multiprocessing
> import multiprocessing.dummy
> import importlib
> -import types
> import contextlib
> import itertools
>
> @@ -48,12 +47,23 @@ __all__ = [
> ]
>
>
> +class TestDictError(Exception):
> +pass
> +
> +
> class TestDict(dict): # pylint: disable=too-few-public-methods
> """A special kind of dict for tests.
>
> This dict lowers the names of keys by default
>
> """
> +def __init__(self, *args, **kwargs):
> +# This counter is incremented once when the allow_reassignment
> context
> +# manager is opened, and decremented each time it is closed. This
> +# allows stacking of the context manager
> +self.__allow_reassignment = 0
> +super(TestDict, self).__init__(*args, **kwargs)
> +
> def __setitem__(self, key, value):
> """Enforce types on set operations.
>
> @@ -67,14 +77,26 @@ class TestDict(dict): # pylint:
> disable=too-few-public-methods
> filesystems.
>
> """
> -assert isinstance(key, basestring), \
> -"Keys must be strings, but was {}".format(type(key))
> -# None is required to make empty assignment work:
> -# foo = Tree['a']
> -assert isinstance(value, (Test, types.NoneType)), \
> -"Values must be either a Test, but was {}".format(type(value))
> +# keys should be strings
> +if not isinstance(key, basestring):
> +raise TestDictError("Keys must be strings, but was {}".format(
> +type(key)))
> +
> +# Values should either be more Tests
> +if not isinstance(value, Test):
> +raise TestDictError(
> +"Values must be a Test, but was a {}".format(type(value)))
> +
> +# This must be lowered before the following test, or the test can
> pass
> +# in error if the key has capitals in it.
> +key = key.lower()
>
> -super(TestDict, self).__setitem__(key.lower(), value)
> +# If there is already a test of that value in the tree it is an error
> +if not self.__allow_reassignment and key in self:
> +raise TestDictError(
> +"A test has already been asigned the name: {}".format(key))
> +
> +super(TestDict, self).__setitem__(key, value)
>
> def __getitem__(self, key):
> """Lower the value before returning."""
> @@ -84,6 +106,25 @@ class TestDict(dict): # pylint:
> disable=too-few-public-methods
> """Lower the value before returning."""
> return super(TestDict, self).__delitem__(key.lower())
>
> +@property
> +@contextlib.contextmanager
> +def allow_reassignment(self):
> +"""Context manager that allows keys to be reassigned.
> +
> +Normally reassignment happens in error, but sometimes one actually
> +wants to do reassignment, say to add extra options in a reduced
> +profile. This method allows reassignment, but only within its
> context,
> +making it an explict choice to do so.
> +
> +It is safe to nest this contextmanager.
> +
> +It is not safe to use this context manager in a threaded application
> +
> +"""
> +self.__allow_reassignment += 1
> +yield
> +self.__allow_reassignment -= 1
> +
>
> class TestProfile(object):
> """ Class that holds a list of tests for execution
> @@ -354,6 +395,13 @@ class TestProfile(object):
>
> yield add
[Piglit] [PATCH v2 8/8] profile.py: Don't allow accidental reassignments of TestDict keys
A common error in all.py is that two different tests are assigned to the
same key value in profile.test_list. This change prevents a key from
being reassigned to a new value on accident, but provides a mechanism to
allow reassignment, using a context manager. This allows tests like the
image_load_store tests in quick.py to be overwritten, but requires the
author to mark that they know that they are overwriting tests, and that
it's intentional.
This also adds some tests for TestDict.
v2: - remove some rebase artifacts, this makes the code a little simpler
and a little cleaner
v3: - rebase on master, includes grouptools separator changes
v4: - Use a incremented value instead of True false for the context
manager, this allows the allow_reassignment contextmanager to be
nested. (Ilia)
Signed-off-by: Dylan Baker
---
framework/profile.py | 72 +-
framework/tests/profile_tests.py | 96
tests/quick.py | 15 ---
3 files changed, 165 insertions(+), 18 deletions(-)
diff --git a/framework/profile.py b/framework/profile.py
index 1384bbd..32d0c15 100644
--- a/framework/profile.py
+++ b/framework/profile.py
@@ -32,7 +32,6 @@ import sys
import multiprocessing
import multiprocessing.dummy
import importlib
-import types
import contextlib
import itertools
@@ -48,12 +47,23 @@ __all__ = [
]
+class TestDictError(Exception):
+pass
+
+
class TestDict(dict): # pylint: disable=too-few-public-methods
"""A special kind of dict for tests.
This dict lowers the names of keys by default
"""
+def __init__(self, *args, **kwargs):
+# This counter is incremented once when the allow_reassignment context
+# manager is opened, and decremented each time it is closed. This
+# allows stacking of the context manager
+self.__allow_reassignment = 0
+super(TestDict, self).__init__(*args, **kwargs)
+
def __setitem__(self, key, value):
"""Enforce types on set operations.
@@ -67,14 +77,26 @@ class TestDict(dict): # pylint:
disable=too-few-public-methods
filesystems.
"""
-assert isinstance(key, basestring), \
-"Keys must be strings, but was {}".format(type(key))
-# None is required to make empty assignment work:
-# foo = Tree['a']
-assert isinstance(value, (Test, types.NoneType)), \
-"Values must be either a Test, but was {}".format(type(value))
+# keys should be strings
+if not isinstance(key, basestring):
+raise TestDictError("Keys must be strings, but was {}".format(
+type(key)))
+
+# Values should either be more Tests
+if not isinstance(value, Test):
+raise TestDictError(
+"Values must be a Test, but was a {}".format(type(value)))
+
+# This must be lowered before the following test, or the test can pass
+# in error if the key has capitals in it.
+key = key.lower()
-super(TestDict, self).__setitem__(key.lower(), value)
+# If there is already a test of that value in the tree it is an error
+if not self.__allow_reassignment and key in self:
+raise TestDictError(
+"A test has already been asigned the name: {}".format(key))
+
+super(TestDict, self).__setitem__(key, value)
def __getitem__(self, key):
"""Lower the value before returning."""
@@ -84,6 +106,25 @@ class TestDict(dict): # pylint:
disable=too-few-public-methods
"""Lower the value before returning."""
return super(TestDict, self).__delitem__(key.lower())
+@property
+@contextlib.contextmanager
+def allow_reassignment(self):
+"""Context manager that allows keys to be reassigned.
+
+Normally reassignment happens in error, but sometimes one actually
+wants to do reassignment, say to add extra options in a reduced
+profile. This method allows reassignment, but only within its context,
+making it an explict choice to do so.
+
+It is safe to nest this contextmanager.
+
+It is not safe to use this context manager in a threaded application
+
+"""
+self.__allow_reassignment += 1
+yield
+self.__allow_reassignment -= 1
+
class TestProfile(object):
""" Class that holds a list of tests for execution
@@ -354,6 +395,13 @@ class TestProfile(object):
yield adder
+@property
+@contextlib.contextmanager
+def allow_reassignment(self):
+"""A convenience wrapper around self.test_list.allow_reassignment."""
+with self.test_list.allow_reassignment:
+yield
+
def load_test_profile(filename):
""" Load a python module and return it's profile attribute
@@ -370,16 +418,18 @@ def load_test_profile(filename):
filename -- the name of a python module to get
[Piglit] [PATCH v2 5/8] tests/all.py: remove duplicate oes_compressed_paletted test
Signed-off-by: Dylan Baker --- tests/all.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/all.py b/tests/all.py index db289ff..46bb9c1 100755 --- a/tests/all.py +++ b/tests/all.py @@ -4074,7 +4074,6 @@ with profile.group_manager( g(['oes_compressed_paletted_texture-api'], 'basic API') g(['arb_texture_compression-invalid-formats', 'paletted'], 'invalid formats') -g(['oes_compressed_paletted_texture-api'], 'basic API') with profile.group_manager( PiglitGLTest, -- 2.3.4 ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH v2 3/8] tests/all.py: move arb_framebuffer-rgb tests out of loop
This doesn't actually effect the nature or number of tests run.
Signed-off-by: Dylan Baker
---
tests/all.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/all.py b/tests/all.py
index 5b9dd2f..4e17745 100755
--- a/tests/all.py
+++ b/tests/all.py
@@ -1979,8 +1979,8 @@ with profile.group_manager(
'blit {} {} {} {}'.format(
backing_type, srgb_types, blit_type,
framebuffer_srgb_setting))
-g(['framebuffer-srgb'], run_concurrent=False)
-g(['arb_framebuffer_srgb-clear'])
+g(['framebuffer-srgb'], run_concurrent=False)
+g(['arb_framebuffer_srgb-clear'])
with profile.group_manager(
PiglitGLTest,
--
2.3.4
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH v2 6/8] tests/all.py: Don't add glsl-1.50 TextureSize tests twice
Because gs is a 1.50 features, but is added in the 1.30 and 1.40 loops
it currently adds the same tests twice. This corrects that.
Signed-off-by: Dylan Baker
---
tests/all.py | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/tests/all.py b/tests/all.py
index 46bb9c1..f63207a 100755
--- a/tests/all.py
+++ b/tests/all.py
@@ -1360,12 +1360,17 @@ for stage in ['vs', 'gs', 'fs']:
version = '1.50'
else:
version = '1.30'
+
# textureSize():
-for sampler in textureSize_samplers_130:
-profile.test_list[grouptools.join(
-'spec', 'glsl-{}'.format(version), 'execution', 'textureSize',
-'{}-textureSize-{}'.format(stage, sampler))] = PiglitGLTest(
-['textureSize', stage, sampler])
+# These will be added in the textureSize_samplers_140 loop for gs, because
+# it is a special case and is actually 1.50 feature.
+if stage is not 'gs':
+for sampler in textureSize_samplers_130:
+profile.test_list[grouptools.join(
+'spec', 'glsl-{}'.format(version), 'execution', 'textureSize',
+'{}-textureSize-{}'.format(stage, sampler))] = PiglitGLTest(
+['textureSize', stage, sampler])
+
# texelFetch():
for sampler in ['sampler1D', 'sampler2D', 'sampler3D', 'sampler1DArray',
'sampler2DArray', 'isampler1D', 'isampler2D', 'isampler3D',
@@ -1380,6 +1385,7 @@ for stage in ['vs', 'gs', 'fs']:
'spec', 'glsl-{}'.format(version), 'execution', 'texelFetchOffset',
'{}-texelFetch-{}'.format(stage, sampler))] = PiglitGLTest(
['texelFetch', 'offset', stage, sampler])
+
# texelFetch() with EXT_texture_swizzle mode "b0r1":
for type in ['i', 'u', '']:
profile.test_list[grouptools.join(
--
2.3.4
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH v2 2/8] tests/all.py: Remove duplicate arb_tessellation_shader_minmax entry
This test was added twice, remove the second copy. Signed-off-by: Dylan Baker --- tests/all.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/all.py b/tests/all.py index cc8d037..5b9dd2f 100755 --- a/tests/all.py +++ b/tests/all.py @@ -1665,7 +1665,6 @@ with profile.group_manager( os.path.join(TESTS_DIR, 'spec', 'arb_tessellation_shader', 'minimum-maximums.txt')], 'built-in-constants') -g(['arb_tessellation_shader-minmax']) # Group ARB_texture_multisample with profile.group_manager( -- 2.3.4 ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH v2 7/8] tests/cl.py: Remove accident duplicate test
This test is exactly the same as another test added a few lines later. v2: - add this patch Signed-off-by: Dylan Baker --- tests/cl.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/cl.py b/tests/cl.py index a6c18bb..dbc9232 100644 --- a/tests/cl.py +++ b/tests/cl.py @@ -67,7 +67,6 @@ with profile.group_manager(PiglitCLTest, 'api') as g: g(['cl-api-create-program-with-source'], 'clCreateProgramWithSource') g(['cl-api-build-program'], 'clBuildProgram') g(['cl-api-compile-program'], 'clCompileProgram') -g(['cl-api-create-kernels-in-program'], 'clCreateKernelsInProgram') g(['cl-api-get-program-info'], 'clGetProgramInfo') g(['cl-api-get-program-build-info'], 'clGetProgramBuildInfo') g(['cl-api-retain_release-program'], -- 2.3.4 ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH v2 4/8] tests/all.py: move arb_gpu_shader5 out of loop
Same as previous patch. Signed-off-by: Dylan Baker --- tests/all.py | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/tests/all.py b/tests/all.py index 4e17745..db289ff 100755 --- a/tests/all.py +++ b/tests/all.py @@ -2023,24 +2023,24 @@ with profile.group_manager( 'clamp' if sampler == '2DRect' else 'repeat'] g(cmd, testname) -g(['arb_gpu_shader5-minmax']) -g(['arb_gpu_shader5-invocation-id']) -g(['arb_gpu_shader5-invocations_count_too_large']) -g(['arb_gpu_shader5-xfb-streams']) -g(['arb_gpu_shader5-stream_value_too_large']) -g(['arb_gpu_shader5-emitstreamvertex_stream_too_large']) -g(['arb_gpu_shader5-tf-wrong-stream-value']) -g(['arb_gpu_shader5-xfb-streams-without-invocations']) -g(['arb_gpu_shader5-emitstreamvertex_nodraw']) -g(['arb_gpu_shader5-interpolateAtCentroid']) -g(['arb_gpu_shader5-interpolateAtCentroid-packing']) -g(['arb_gpu_shader5-interpolateAtCentroid-flat']) -g(['arb_gpu_shader5-interpolateAtCentroid-centroid']) -g(['arb_gpu_shader5-interpolateAtCentroid-noperspective']) -g(['arb_gpu_shader5-interpolateAtSample']) -g(['arb_gpu_shader5-interpolateAtSample-nonconst']) -g(['arb_gpu_shader5-interpolateAtOffset']) -g(['arb_gpu_shader5-interpolateAtOffset-nonconst']) +g(['arb_gpu_shader5-minmax']) +g(['arb_gpu_shader5-invocation-id']) +g(['arb_gpu_shader5-invocations_count_too_large']) +g(['arb_gpu_shader5-xfb-streams']) +g(['arb_gpu_shader5-stream_value_too_large']) +g(['arb_gpu_shader5-emitstreamvertex_stream_too_large']) +g(['arb_gpu_shader5-tf-wrong-stream-value']) +g(['arb_gpu_shader5-xfb-streams-without-invocations']) +g(['arb_gpu_shader5-emitstreamvertex_nodraw']) +g(['arb_gpu_shader5-interpolateAtCentroid']) +g(['arb_gpu_shader5-interpolateAtCentroid-packing']) +g(['arb_gpu_shader5-interpolateAtCentroid-flat']) +g(['arb_gpu_shader5-interpolateAtCentroid-centroid']) +g(['arb_gpu_shader5-interpolateAtCentroid-noperspective']) +g(['arb_gpu_shader5-interpolateAtSample']) +g(['arb_gpu_shader5-interpolateAtSample-nonconst']) +g(['arb_gpu_shader5-interpolateAtOffset']) +g(['arb_gpu_shader5-interpolateAtOffset-nonconst']) with profile.group_manager( -- 2.3.4 ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH v2 1/8] tests/all.py: fix two tests that had options dropped
I traced these two tests back and through a series of errors an option required to make them unique was dropped, this corrects that and brings them back to their original status. Signed-off-by: Dylan Baker --- tests/all.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/all.py b/tests/all.py index d0815da..cc8d037 100755 --- a/tests/all.py +++ b/tests/all.py @@ -676,9 +676,9 @@ with profile.group_manager( g(['glx-pixmap-multi']) g(['glx-tfp'], run_concurrent=False) g(['glx-visuals-depth'], run_concurrent=False) -g(['glx-visuals-depth']) +g(['glx-visuals-depth', '-pixmap']) g(['glx-visuals-stencil'], run_concurrent=False) -g(['glx-visuals-stencil']) +g(['glx-visuals-stencil', '-pixmap']) g(['glx-window-life']) g(['glx-pixmap-crosscheck']) g(['glx-query-drawable', '--attr=GLX_WIDTH', '--type=GLXWINDOW'], -- 2.3.4 ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] V2: don't allow test re-assignment
This addresses Ilia's concerns with the v1. I didn't have any other feedback, and I'd like to land this soon. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [Bug 89821] [all]Piglit report warn, but no warning in dmesg
https://bugs.freedesktop.org/show_bug.cgi?id=89821 Dylan changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTABUG --- Comment #1 from Dylan --- Do not conflate the 'dmesg-warn' and 'warn' statuses. 'warn' is set by the framework when the test passes, but there is unexpected output on stderr, or sometimes by the test itself. In this case the test itself is setting the warn status. From tests/spec/ext_transform_feedback/tessalation.c: Note: some OpenGL implementations do not pass the "flat_first" and "flat_last" tests when rendering quads or polygons. That is, they produce a tessellation which contains the correct vertices, but not in the order required to preserve flat shaded colors. This is unlikely to cause problems for client programs, since client programs that use new features like transform feedback are unlikely to also use deprecated features like quads and polygons. Also, it is a matter of interpretation whether these tests are expected to pass at all--after all, the spec does say that "the order of tessellation within a primitive is undefined". Accordingly, these failures, should they occur, are flagged as warnings rather than failures. -- You are receiving this mail because: You are the QA Contact for the bug. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] glsl-1.10: Add vec4 test for gl_FrontFacing ternary usage.
Reviewed-by: Matt Turner Are you planning to work on a i965 patch to fix this? (Did you hit this in a real application?) ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 1/1] cl: Enable required extension before using double type
On Fri, Mar 27, 2015 at 07:36:26PM -0400, Jan Vesely wrote:
> Fixes failures on OCL-1.1 implementations that provide cl_khr_fp64
>
> Signed-off-by: Jan Vesely
Reviewed-by: Tom Stellard
> ---
> generated_tests/cl/store/store-kernels-global.inc | 4 ++--
> generated_tests/cl/store/store-kernels-local.inc | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/generated_tests/cl/store/store-kernels-global.inc
> b/generated_tests/cl/store/store-kernels-global.inc
> index b6220d0..ae9b74e 100644
> --- a/generated_tests/cl/store/store-kernels-global.inc
> +++ b/generated_tests/cl/store/store-kernels-global.inc
> @@ -1,9 +1,9 @@
> -typedef TYPE type_t;
> -
> #if TYPE == double
> #pragma OPENCL EXTENSION cl_khr_fp64 : enable
> #endif
>
> +typedef TYPE type_t;
> +
> kernel void store_global(global type_t *out, global type_t *in) {
> out[0] = in[0];
> out[1] = in[1];
> diff --git a/generated_tests/cl/store/store-kernels-local.inc
> b/generated_tests/cl/store/store-kernels-local.inc
> index b3265f4..6692e37 100644
> --- a/generated_tests/cl/store/store-kernels-local.inc
> +++ b/generated_tests/cl/store/store-kernels-local.inc
> @@ -1,9 +1,9 @@
> -typedef TYPE type_t;
> -
> #if TYPE == double
> #pragma OPENCL EXTENSION cl_khr_fp64 : enable
> #endif
>
> +typedef TYPE type_t;
> +
> kernel void store_local(global type_t *out, global type_t *in) {
> local type_t local_data[8];
> size_t id = get_local_id(0);
> --
> 2.1.0
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH] glsl-1.10: Add vec4 test for gl_FrontFacing ternary usage.
Test try_opt_frontfacing_ternary optimization when type is vec4,
this test fails with current Mesa HEAD (ce83a6e).
Signed-off-by: Tapani Pälli
---
...rontfacing-ternary-vec4-neg-1.0-1.0.shader_test | 24 ++
1 file changed, 24 insertions(+)
create mode 100644
tests/spec/glsl-1.10/execution/fs-frontfacing-ternary-vec4-neg-1.0-1.0.shader_test
diff --git
a/tests/spec/glsl-1.10/execution/fs-frontfacing-ternary-vec4-neg-1.0-1.0.shader_test
b/tests/spec/glsl-1.10/execution/fs-frontfacing-ternary-vec4-neg-1.0-1.0.shader_test
new file mode 100644
index 000..74223e9
--- /dev/null
+++
b/tests/spec/glsl-1.10/execution/fs-frontfacing-ternary-vec4-neg-1.0-1.0.shader_test
@@ -0,0 +1,24 @@
+#
+# Shader for testing try_opt_frontfacing_ternary optimization
+# in the i965 driver with a vec4 type.
+#
+[require]
+GLSL >= 1.10
+
+[vertex shader passthrough]
+
+[fragment shader]
+void main()
+{
+ vec4 foo;
+ if (gl_FrontFacing)
+ foo = vec4(-1.0);
+ else
+ foo = vec4(1.0);
+
+ gl_FragColor = vec4(1.5 + foo);
+}
+
+[test]
+draw rect -1 -1 2 2
+probe all rgb 0.5 0.5 0.5
--
2.1.0
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] arb_arrays_of_arrays: compile test basic types
On 30/03/15 10:29, Timothy Arceri wrote:
Test results:
Nvidia GeForce 840M - NVIDIA 346.47: pass
---
This is just
/tests/spec/glsl-1.20/compiler/structure-and-array-operations/array-of-any-type.vert
with an extra dimension added.
Do you have any other test that would cover more than just the grammar?
Maybe you already sent them (possibly a while ago), sorry if this is the
case.
.../compiler/arrays-of-any-type.vert | 44 ++
1 file changed, 44 insertions(+)
create mode 100644
tests/spec/arb_arrays_of_arrays/compiler/arrays-of-any-type.vert
diff --git a/tests/spec/arb_arrays_of_arrays/compiler/arrays-of-any-type.vert
b/tests/spec/arb_arrays_of_arrays/compiler/arrays-of-any-type.vert
new file mode 100644
index 000..0ce45da
--- /dev/null
+++ b/tests/spec/arb_arrays_of_arrays/compiler/arrays-of-any-type.vert
@@ -0,0 +1,44 @@
+/* [config]
+ * expect_result: pass
+ * glsl_version: 1.20
+ * [end config]
+ *
+ * From page 19 (page 25 of the PDF) of the GLSL 1.20 spec:
+ *
+ * "All basic types and structures can be formed into arrays."
+ */
+#version 120
+#extension GL_ARB_arrays_of_arrays: enable
+
+uniform float array01[1][1];
+uniform int array02[1][1];
+uniform bool array03[1][1];
+uniform vec2 array04[1][1];
+uniform vec3 array05[1][1];
+uniform vec4 array06[1][1];
+uniform ivec2 array07[1][1];
+uniform ivec3 array08[1][1];
+uniform ivec4 array09[1][1];
+uniform bvec2 array10[1][1];
+uniform bvec3 array11[1][1];
+uniform bvec4 array12[1][1];
+uniform mat2 array13[1][1];
+uniform mat2x2 array14[1][1];
+uniform mat2x3 array15[1][1];
+uniform mat2x4 array16[1][1];
+uniform mat3 array17[1][1];
+uniform mat3x2 array18[1][1];
+uniform mat3x3 array19[1][1];
+uniform mat3x4 array20[1][1];
+uniform mat4 array21[1][1];
+uniform mat4x2 array22[1][1];
+uniform mat4x3 array23[1][1];
+uniform mat4x4 array24[1][1];
+uniform sampler1D array25[1][1];
+uniform sampler2D array26[1][1];
+uniform sampler3D array27[1][1];
+uniform samplerCube array28[1][1];
+uniform sampler1DShadow array29[1][1];
+uniform sampler2DShadow array30[1][1];
+
+void main() { gl_Position = vec4(0.0); }
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH] arb_arrays_of_arrays: compile test basic types
Test results:
Nvidia GeForce 840M - NVIDIA 346.47: pass
---
This is just
/tests/spec/glsl-1.20/compiler/structure-and-array-operations/array-of-any-type.vert
with an extra dimension added.
.../compiler/arrays-of-any-type.vert | 44 ++
1 file changed, 44 insertions(+)
create mode 100644
tests/spec/arb_arrays_of_arrays/compiler/arrays-of-any-type.vert
diff --git a/tests/spec/arb_arrays_of_arrays/compiler/arrays-of-any-type.vert
b/tests/spec/arb_arrays_of_arrays/compiler/arrays-of-any-type.vert
new file mode 100644
index 000..0ce45da
--- /dev/null
+++ b/tests/spec/arb_arrays_of_arrays/compiler/arrays-of-any-type.vert
@@ -0,0 +1,44 @@
+/* [config]
+ * expect_result: pass
+ * glsl_version: 1.20
+ * [end config]
+ *
+ * From page 19 (page 25 of the PDF) of the GLSL 1.20 spec:
+ *
+ * "All basic types and structures can be formed into arrays."
+ */
+#version 120
+#extension GL_ARB_arrays_of_arrays: enable
+
+uniform float array01[1][1];
+uniform int array02[1][1];
+uniform bool array03[1][1];
+uniform vec2 array04[1][1];
+uniform vec3 array05[1][1];
+uniform vec4 array06[1][1];
+uniform ivec2 array07[1][1];
+uniform ivec3 array08[1][1];
+uniform ivec4 array09[1][1];
+uniform bvec2 array10[1][1];
+uniform bvec3 array11[1][1];
+uniform bvec4 array12[1][1];
+uniform mat2 array13[1][1];
+uniform mat2x2 array14[1][1];
+uniform mat2x3 array15[1][1];
+uniform mat2x4 array16[1][1];
+uniform mat3 array17[1][1];
+uniform mat3x2 array18[1][1];
+uniform mat3x3 array19[1][1];
+uniform mat3x4 array20[1][1];
+uniform mat4 array21[1][1];
+uniform mat4x2 array22[1][1];
+uniform mat4x3 array23[1][1];
+uniform mat4x4 array24[1][1];
+uniform sampler1D array25[1][1];
+uniform sampler2D array26[1][1];
+uniform sampler3D array27[1][1];
+uniform samplerCube array28[1][1];
+uniform sampler1DShadow array29[1][1];
+uniform sampler2DShadow array30[1][1];
+
+void main() { gl_Position = vec4(0.0); }
--
2.1.0
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
