Re: [Piglit] [PATCH 2/2] framework: fix proces/process_isolation typo

[Charmaine Lee]

For both patches, Reviewed-by: Charmaine Lee 

From: Brian Paul 
Sent: Monday, September 25, 2017 3:47:24 PM
To: piglit@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende; Brian Paul
Subject: [PATCH 2/2] framework: fix proces/process_isolation typo

---
 framework/programs/run.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/programs/run.py b/framework/programs/run.py
index 4524f17..5fe8419 100644
--- a/framework/programs/run.py
+++ b/framework/programs/run.py
@@ -397,7 +397,7 @@ def resume(input_):
 options.OPTIONS.valgrind = results.options['valgrind']
 options.OPTIONS.sync = results.options['sync']
 options.OPTIONS.deqp_mustpass = results.options['deqp_mustpass']
-options.OPTIONS.proces_isolation = results.options['process_isolation']
+options.OPTIONS.process_isolation = results.options['process_isolation']

 core.get_config(args.config_file)

--
1.9.1

___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] cl: Add basic remainder(float, float) builtin tests

[Jan Vesely]

Hi Aaron,

looks like you never pushed this one. Did you have a reason to drop it?

Jan


On Fri, 2017-01-20 at 12:37 -0500, Jan Vesely wrote:
> On Tue, 2017-01-17 at 21:18 -0600, Aaron Watry wrote:
> > Tested with libclc on a Radeon HD 7850.
> > 
> > Hex output values were generated via remainderf(float, float).
> > 
> > No implications as to the quality of the inputs is intended.
> > 
> > Signed-off-by: Aaron Watry 
> 
> Reviewed-by: Jan Vesely 
> 
> Jan
> 
> > ---
> >  generated_tests/gen_cl_math_builtins.py | 13 +
> >  1 file changed, 13 insertions(+)
> > 
> > diff --git a/generated_tests/gen_cl_math_builtins.py 
> > b/generated_tests/gen_cl_math_builtins.py
> > index f609d73..178ff95 100644
> > --- a/generated_tests/gen_cl_math_builtins.py
> > +++ b/generated_tests/gen_cl_math_builtins.py
> > @@ -65,6 +65,7 @@ CLC_VERSION_MIN = {
> >  'log10' : 10,
> >  'log1p' : 10,
> >  'nextafter' : 10,
> > +'remainder' : 10,
> >  'round' : 10,
> >  'sin' : 10,
> >  'sinh' : 10,
> > @@ -398,6 +399,18 @@ tests = {
> >  [1.0,  -1.0 , 2.0, 0.0, 3.4, float("nan"), 
> > 5.0], # Arg1
> >  ]
> >  },
> > +'remainder' : {
> > +'arg_types': [F, F, F],
> > +'function_type': 'ttt',
> > +'values': [
> > +[float.fromhex("-0x1.dp-1"), float.fromhex("0x1.dp-1"),
> > + float.fromhex("-0x1.dp-1"), float.fromhex("0x1.dp-1"),
> > + 0.0, -0.0, 5.1, float("-nan")
> > +], # Result
> > +[ 5.1, -5.1,  5.1, -5.1, 0.0, -0.0, 5.1,  5.1], # Arg0
> > +[ 3.0,  3.0, -3.0, -3.0, 1.0,  1.0, float("inf"), 0.0], # Arg1
> > +]
> > +},
> >  'round' : {
> >  'arg_types': [F, F],
> >  'function_type': 'ttt',

-- 
Jan Vesely 

signature.asc
Description: This is a digitally signed message part
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH 2/2] framework: fix proces/process_isolation typo

[Brian Paul]

---
 framework/programs/run.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/programs/run.py b/framework/programs/run.py
index 4524f17..5fe8419 100644
--- a/framework/programs/run.py
+++ b/framework/programs/run.py
@@ -397,7 +397,7 @@ def resume(input_):
 options.OPTIONS.valgrind = results.options['valgrind']
 options.OPTIONS.sync = results.options['sync']
 options.OPTIONS.deqp_mustpass = results.options['deqp_mustpass']
-options.OPTIONS.proces_isolation = results.options['process_isolation']
+options.OPTIONS.process_isolation = results.options['process_isolation']
 
 core.get_config(args.config_file)
 
-- 
1.9.1

___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH 1/2] framework: fix comment typos on FastSkip class

[Brian Paul]

---
 framework/test/opengl.py | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/framework/test/opengl.py b/framework/test/opengl.py
index e19e437..41dfd4a 100644
--- a/framework/test/opengl.py
+++ b/framework/test/opengl.py
@@ -302,8 +302,8 @@ class FastSkip(object):
 all the tests that could have, but also a few that should have run.
 
 Keyword Arguments:
-gl_reqruied -- This is a set of extensions that are required for
-   running the extension.
+gl_required -- This is a set of extensions that are required for
+   running the test.
 gl_version  -- A float that is the required version number for an
OpenGL test.
 gles_version-- A float that is the required version number for an
@@ -390,8 +390,8 @@ class FastSkipMixin(object):
 has all of the same requirements as that class.
 
 It also provides new attributes:
-gl_reqruied -- This is a set of extensions that are required for
-   running the extension.
+gl_required -- This is a set of extensions that are required for
+   running the test.
 gl_version  -- A float that is the required version number for an
OpenGL test.
 gles_version-- A float that is the required version number for an
-- 
1.9.1

___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH 1/1] cl: Don't use unsigned long long

[Jan Vesely]

clc allows max long type
Fixes program@execute@calls on CUDA OpenCL
Fixes: e408ce1f2bff23121670a8206258c80bb3d9befd (cl: Add tests for function 
calls)

Signed-off-by: Jan Vesely 
---
 tests/cl/program/execute/calls.cl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/cl/program/execute/calls.cl 
b/tests/cl/program/execute/calls.cl
index f4f55be31..b1c73f7ba 100644
--- a/tests/cl/program/execute/calls.cl
+++ b/tests/cl/program/execute/calls.cl
@@ -291,7 +291,7 @@ long i64_func_void(void)
 #if USE_ASM
 __asm("v_lshlrev_b64 %0, 44, 1" : "=v"(ret));
 #else
-ret = 1ull << 44;
+ret = 1ul << 44;
 #endif
 return ret;
 }
-- 
2.13.5

___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit