Re: [Piglit] [PATCH v3] travis: add docker based cmake build job

2018-01-29 Thread Eric Anholt 
Andres Gomez  writes:

> Until now we were only running the python unit tests.
>
> It seems desirable to also check that the CMake based build compiles
> successfully. We do that now using docker.
>
> The docker build can be tweaked with some environment variables and,
> also, be stored in the docker hub if desired. Check the changes for
> extra details regarding these variables.
>
> v2: Removed other build possibilities other than just from inside
> Travis-CI, as suggested by Juan.
> v3: Replaced the "RELEASE" parameter to create the docker image with
> "PARENT" and removed some unneeded documentation after v2, as
> suggested by Juan.
>
> Cc: Dylan Baker 
> Cc: Juan A. Suarez 
> Signed-off-by: Andres Gomez 
> Reviewed-by: Juan A. Suarez 

I'm definitely interested in extending our tests using Travis, but could
you add some comments explaining what this system does?  Do we do a
bunch of image build work (numpy/six/mako install) on each Travis build,
or does it get cached?  Do I need to do any setup in Travis in order for
this to take effect?


signature.asc
Description: PGP signature
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] cl: Add test for MUBUF access with a negative vaddr

2018-01-29 Thread Jan Vesely 
On Fri, 2018-01-19 at 14:43 -0500, Matt Arsenault wrote:
> > On Jan 18, 2018, at 15:02, Jan Vesely  wrote:
> > 
> > Why is this necessary? can't you just pass the offset argument as a
> > kernel input?
> > 
> > Jan
> 
> It needs to specifically be in a VGPR

OK LGTM. I'll push it in the next few days.

wouldn't the same be achieved by adding get_local_id(0)?
I'm trying to make these tests more interesting for non-amd targets to
avoid adding bloat to the testing runs.
maybe the right approach would be to have a separate amd specific list
of tests that don't run by default (but still pass) on other devices.

Jan


-- 
Jan Vesely 

signature.asc
Description: This is a digitally signed message part
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 3/3] arb_internalformat_query2: some formats are not compatible with TBOs

2018-01-29 Thread Marek Olšák 
Reviewed-by: Marek Olšák 

Marek

On Sat, Jan 27, 2018 at 10:44 AM, Alejandro Piñeiro
 wrote:
> On those cases, the resource is not supported, so we should expect the
> unsupported outcome.
> ---
>  .../spec/arb_internalformat_query2/image-texture.c | 55 
> +-
>  1 file changed, 54 insertions(+), 1 deletion(-)
>
> diff --git a/tests/spec/arb_internalformat_query2/image-texture.c 
> b/tests/spec/arb_internalformat_query2/image-texture.c
> index 735f7e1a48..8bf6429b35 100644
> --- a/tests/spec/arb_internalformat_query2/image-texture.c
> +++ b/tests/spec/arb_internalformat_query2/image-texture.c
> @@ -107,6 +107,58 @@ static const struct imagetexture imagetexture_table[] = {
>  {GL_R8_SNORM, 8, GL_RED, GL_BYTE, GL_IMAGE_CLASS_1_X_8},
>  };
>
> +/*
> + * From OpenGL 4.5 spec, table 8.16, Internal formats for buffer
> + * textures
> + */
> +static const GLenum table_8_16[] = {
> +GL_R8,
> +GL_R16,
> +GL_R16F,
> +GL_R32F,
> +GL_R8I,
> +GL_R16I,
> +GL_R32I,
> +GL_R8UI,
> +GL_R16UI,
> +GL_R32UI,
> +GL_RG8,
> +GL_RG16,
> +GL_RG16F,
> +GL_RG32F,
> +GL_RG8I,
> +GL_RG16I,
> +GL_RG32I,
> +GL_RG8UI,
> +GL_RG16UI,
> +GL_RG32UI,
> +GL_RGB32F,
> +GL_RGB32I,
> +GL_RGB32UI,
> +GL_RGBA8,
> +GL_RGBA16,
> +GL_RGBA16F,
> +GL_RGBA32F,
> +GL_RGBA8I,
> +GL_RGBA16I,
> +GL_RGBA32I,
> +GL_RGBA8UI,
> +GL_RGBA16UI,
> +GL_RGBA32UI
> +};
> +
> +static bool
> +check_tbo_compatible(const GLenum target,
> + const GLenum format)
> +{
> +if (target != GL_TEXTURE_BUFFER)
> +return true;
> +
> +return value_on_set((const GLint*)table_8_16,
> +ARRAY_SIZE(table_8_16),
> +format);
> +}
> +
>  static bool
>  try(const GLenum *targets, unsigned num_targets,
>  const GLenum pname, test_data *data)
> @@ -124,7 +176,8 @@ try(const GLenum *targets, unsigned num_targets,
>  supported = check_query2_dependencies(pname, 
> targets[i])
>  && test_data_check_supported(data, 
> targets[i],
>   
> imagetexture_table[j].format)
> -&& (targets[i] != GL_RENDERBUFFER);
> +&& (targets[i] != GL_RENDERBUFFER)
> +&& (check_tbo_compatible(targets[i], 
> imagetexture_table[j].format));
>
>  test_data_execute(data, targets[i],
>imagetexture_table[j].format,
> --
> 2.11.0
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [v2 PATCH 1/3] arb_internalformat_query2: minmax GL_ALPHA8 deprecated on 3.1+

2018-01-29 Thread Marek Olšák 
Reviewed-by: Marek Olšák 

Marek

On Sat, Jan 27, 2018 at 10:44 AM, Alejandro Piñeiro
 wrote:
> When ARB_compatibility is missing or the context is Core.
>
> v2: check for ARB_compatibility or core (Marek)
> ---
>  tests/spec/arb_internalformat_query2/minmax.c | 18 --
>  1 file changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/tests/spec/arb_internalformat_query2/minmax.c 
> b/tests/spec/arb_internalformat_query2/minmax.c
> index a2cf059928..2571e3b219 100644
> --- a/tests/spec/arb_internalformat_query2/minmax.c
> +++ b/tests/spec/arb_internalformat_query2/minmax.c
> @@ -46,6 +46,10 @@ PIGLIT_GL_TEST_CONFIG_END
>
>  /* These are all the formats that are required to be color-renderable
>   * by the OpenGL 3.0 spec.
> + *
> + * But note that GL_ALPHA8 was removed on 3.1 and beyond on core, or
> + * if ARB_compatibility is missing, so we need to take that into
> + * account.
>   */
>  static const GLenum valid_formats[] = {
>  GL_RGBA32F,
> @@ -283,6 +287,7 @@ piglit_init(int argc, char **argv)
>  const bool tms_supported =
>  piglit_is_extension_supported("GL_ARB_texture_multisample");
>  GLint max_samples;
> +GLint valid_formats_size = ARRAY_SIZE(valid_formats);
>
>  piglit_require_extension("GL_ARB_framebuffer_object");
>  piglit_require_extension("GL_ARB_internalformat_query2");
> @@ -293,8 +298,17 @@ piglit_init(int argc, char **argv)
>  piglit_require_extension("GL_ARB_texture_float");
>  }
>
> +/* GL_ALPHA8 was removed on OpenGL 3.1 core, or if
> + * ARB_compatibility is missing, so on that case we skip that
> + * format
> + */
> +if (piglit_get_gl_version() >= 31 &&
> +(piglit_is_core_profile ||
> + !piglit_is_extension_supported("GL_ARB_compatibility")))
> +valid_formats_size = valid_formats_size - 1;
> +
>  glGetIntegerv(GL_MAX_SAMPLES, _samples);
> -for (i = 0; i < ARRAY_SIZE(valid_formats); i++) {
> +for (i = 0; i < valid_formats_size; i++) {
>  pass = try(GL_RENDERBUFFER,
> valid_formats[i],
> max_samples,
> @@ -345,7 +359,7 @@ piglit_init(int argc, char **argv)
>  max_samples_name = 
> "GL_MAX_COLOR_TEXTURE_SAMPLES";
>  }
>
> -for (j = 0; j < ARRAY_SIZE(valid_formats); j++) {
> +for (j = 0; j < valid_formats_size; j++) {
>  pass = try(valid_targets_with_tms[i],
> valid_formats[j],
> max_samples,
> --
> 2.11.0
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [v2 PATCH 2/3] arb_internalformat_query2: more than one way to support GEOMETRY_TEXTURE

2018-01-29 Thread Marek Olšák 
Reviewed-by: Marek Olšák 

Marek

On Sat, Jan 27, 2018 at 10:44 AM, Alejandro Piñeiro
 wrote:
> v2: GL_EXT_geometry_shader should not be checked, as is only for GLES
> (Ilia Mirkin)
> ---
>  tests/spec/arb_internalformat_query2/common.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/spec/arb_internalformat_query2/common.c 
> b/tests/spec/arb_internalformat_query2/common.c
> index 9fa5fa9d11..60109eaf68 100644
> --- a/tests/spec/arb_internalformat_query2/common.c
> +++ b/tests/spec/arb_internalformat_query2/common.c
> @@ -617,7 +617,8 @@ check_query2_pname_dependencies(const GLenum pname)
>  break;
>
>  case GL_GEOMETRY_TEXTURE:
> -if 
> (!piglit_is_extension_supported("GL_ARB_geometry_shader4"))
> +if 
> (!piglit_is_extension_supported("GL_ARB_geometry_shader4") &&
> +!(piglit_get_gl_version() >= 32))
>  return false;
>  break;
>
> --
> 2.11.0
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit