Re: [Piglit] [PATCH crucible] Add test for bug 108911
On 04/12/2018 19:13, Lionel Landwerlin wrote:
+if (resolvedData[1][i] != 0xff00ff00) {
+printf("unexpected clear color in layer1: got 0x%x expected
0x00ff00ff\n",
+ resolvedData[1][i]);
+t_fail();
+return;
Duh! fixed that error message locally
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH crucible] Add test for bug 108911
Signed-off-by: Lionel Landwerlin
---
Makefile.am| 1 +
src/tests/bug/108911.c | 306 +
2 files changed, 307 insertions(+)
create mode 100644 src/tests/bug/108911.c
diff --git a/Makefile.am b/Makefile.am
index 528650a..6e99516 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -75,6 +75,7 @@ bin_crucible_SOURCES = \
src/qonos/qonos_pipeline.c \
src/tests/bug/104809.c \
src/tests/bug/108909.c \
+ src/tests/bug/108911.c \
src/tests/bench/copy-buffer.c \
src/tests/example/basic.c \
src/tests/example/images.c \
diff --git a/src/tests/bug/108911.c b/src/tests/bug/108911.c
new file mode 100644
index 000..cc94bf4
--- /dev/null
+++ b/src/tests/bug/108911.c
@@ -0,0 +1,306 @@
+// Copyright 2018 Intel Corporation
+//
+// Permission is hereby granted, free of charge, to any person obtaining a
+// copy of this software and associated documentation files (the "Software"),
+// to deal in the Software without restriction, including without limitation
+// the rights to use, copy, modify, merge, publish, distribute, sublicense,
+// and/or sell copies of the Software, and to permit persons to whom the
+// Software is furnished to do so, subject to the following conditions:
+//
+// The above copyright notice and this permission notice (including the next
+// paragraph) shall be included in all copies or substantial portions of the
+// Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+// THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+// IN THE SOFTWARE.
+
+#include
+#include
+#include "tapi/t.h"
+#include "util/misc.h"
+
+/* This is a test for https://bugs.freedesktop.org/show_bug.cgi?id=108911
+ *
+ * The wrong clear color was landing into the layer1+ of a multi-layered
+ * multi-sampled image.
+ */
+
+static VkImage
+create_image_and_bind_memory(const VkImageCreateInfo *info)
+{
+VkImage img;
+VkDeviceMemory mem;
+
+vkCreateImage(t_device, info, NULL, );
+mem = qoAllocImageMemory(t_device, img,
+ .properties =
VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT);
+qoBindImageMemory(t_device, img, mem, 0);
+
+return img;
+}
+
+#define SIZE (8)
+
+static void
+test(void)
+{
+VkRenderPass renderPass;
+VkImage fbImage, imageLayers[2];
+VkImageView viewLayers[2];
+VkFramebuffer fbLayers[2];
+VkBuffer bufferLayers[2];
+VkDeviceMemory bufferMem[2];
+
+renderPass = qoCreateRenderPass(t_device,
+.attachmentCount = 1,
+.pAttachments = &(VkAttachmentDescription)
{
+.format = VK_FORMAT_R8G8B8A8_UNORM,
+.samples = VK_SAMPLE_COUNT_4_BIT,
+.loadOp = VK_ATTACHMENT_LOAD_OP_CLEAR,
+.storeOp =
VK_ATTACHMENT_STORE_OP_STORE,
+.stencilLoadOp =
VK_ATTACHMENT_LOAD_OP_DONT_CARE,
+.stencilStoreOp =
VK_ATTACHMENT_STORE_OP_DONT_CARE,
+.initialLayout =
VK_IMAGE_LAYOUT_UNDEFINED,
+.finalLayout =
VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL,
+},
+.subpassCount = 1,
+.pSubpasses = &(VkSubpassDescription) {
+.pipelineBindPoint =
VK_PIPELINE_BIND_POINT_GRAPHICS,
+.colorAttachmentCount = 1,
+.pColorAttachments =
&(VkAttachmentReference) {
+.attachment = 0,
+.layout =
VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL,
+},
+});
+
+fbImage = create_image_and_bind_memory(&(VkImageCreateInfo) {
+.sType = VK_STRUCTURE_TYPE_IMAGE_CREATE_INFO,
+.imageType = VK_IMAGE_TYPE_2D,
+.format = VK_FORMAT_R8G8B8A8_UNORM,
+.extent = (VkExtent3D) {
+.width = SIZE,
+.height = SIZE,
+.depth = 1,
+},
+.mipLevels = 1,
+.arrayLayers = 2,
+.samples = VK_SAMPLE_COUNT_4_BIT,
+.tiling = VK_IMAGE_TILING_OPTIMAL,
+.usage = (VK_IMAGE_USAGE_TRANSFER_SRC_BIT |
+
Re: [Piglit] [PATCH crucible] Add a test for bug 108909
On 04/12/2018 14:52, Józef Kucia wrote:
On Tue, Dec 4, 2018 at 3:46 PM Lionel Landwerlin
wrote:
Signed-off-by: Lionel Landwerlin
---
Makefile.am| 1 +
src/tests/bug/108909.c | 106 +
2 files changed, 107 insertions(+)
create mode 100644 src/tests/bug/108909.c
diff --git a/Makefile.am b/Makefile.am
index b35e329..528650a 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -74,6 +74,7 @@ bin_crucible_SOURCES = \
src/qonos/qonos.c \
src/qonos/qonos_pipeline.c \
src/tests/bug/104809.c \
+ src/tests/bug/108909.c \
src/tests/bench/copy-buffer.c \
src/tests/example/basic.c \
src/tests/example/images.c \
diff --git a/src/tests/bug/108909.c b/src/tests/bug/108909.c
new file mode 100644
index 000..1faadbf
--- /dev/null
+++ b/src/tests/bug/108909.c
@@ -0,0 +1,106 @@
+// Copyright 2018 Intel Corporation
+//
+// Permission is hereby granted, free of charge, to any person obtaining a
+// copy of this software and associated documentation files (the "Software"),
+// to deal in the Software without restriction, including without limitation
+// the rights to use, copy, modify, merge, publish, distribute, sublicense,
+// and/or sell copies of the Software, and to permit persons to whom the
+// Software is furnished to do so, subject to the following conditions:
+//
+// The above copyright notice and this permission notice (including the next
+// paragraph) shall be included in all copies or substantial portions of the
+// Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+// THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+// IN THE SOFTWARE.
+
+#include
+#include
+#include "tapi/t.h"
+#include "util/misc.h"
+
+/* This is a test for https://bugs.freedesktop.org/show_bug.cgi?id=108909
+ *
+ * Ensure ordering of operations for between 3d pipeline and command
+ * streamer on Intel HW.
+ */
+
+static void
+test(void)
+{
+const uint64_t initialData[] = {
+0xdeaddeadbeef,
+0xdeaddeadbeef,
+0xdeaddeadbeef,
+0xdeaddeadbeef,
+};
+VkBuffer dataBuffer = qoCreateBuffer(t_device,
+ .size = sizeof(initialData),
+ .usage =
VK_BUFFER_USAGE_TRANSFER_SRC_BIT);
+VkDeviceMemory dataMem = qoAllocBufferMemory(t_device, dataBuffer,
+ .properties =
VK_MEMORY_PROPERTY_HOST_COHERENT_BIT |
+
VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT);
+memcpy(qoMapMemory(t_device, dataMem, /*offset*/ 0,
+ sizeof(initialData), /*flags*/ 0),
+ initialData,
+ sizeof(initialData));
+qoBindBufferMemory(t_device, dataBuffer, dataMem, /*offset*/ 0);
+
+VkBuffer resultBuffer = qoCreateBuffer(t_device,
+.size = sizeof(initialData),
+.usage =
VK_BUFFER_USAGE_TRANSFER_DST_BIT);
+VkDeviceMemory resultMem = qoAllocBufferMemory(t_device, resultBuffer,
+ .properties =
VK_MEMORY_PROPERTY_HOST_COHERENT_BIT |
+
VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT);
+qoBindBufferMemory(t_device, resultBuffer, resultMem, /*offset*/ 0);
+
+VkQueryPool pool = qoCreateQueryPool(t_device,
+ .queryType =
VK_QUERY_TYPE_TIMESTAMP,
+ .queryCount =
ARRAY_LENGTH(initialData));
+
+
+/* vkCmdCopyQueryPoolResults should be ordered with regard to
vkCmdCopyBuffer. */
+VkCommandBuffer cmdBuffer = qoAllocateCommandBuffer(t_device, t_cmd_pool);
+qoBeginCommandBuffer(cmdBuffer);
+vkCmdWriteTimestamp(cmdBuffer, VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT, pool, 0);
+vkCmdWriteTimestamp(cmdBuffer, VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT, pool, 1);
+vkCmdCopyBuffer(cmdBuffer, dataBuffer, resultBuffer,
+1, &(VkBufferCopy){ .srcOffset = 0, .dstOffset = 0, .size
= sizeof(initialData) });
+vkCmdWriteTimestamp(cmdBuffer, VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT, pool, 2);
+vkCmdWriteTimestamp(cmdBuffer, VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT, pool, 3);
+vkCmdCopyQueryPoolResults(cmdBuffer, pool, /*firstQuery*/ 0,
/*queryCount*/ 4,
+ resultBuffer, /*dstBufferOffset*/ 0,
sizeof(uint64_t),
+ VK_QUERY_RESULT_WAIT_BIT);
A pipeline barrier between vkCmdCopyBuffer() and
Re: [Piglit] [PATCH crucible] Add a test for bug 108909
On Tue, Dec 4, 2018 at 3:46 PM Lionel Landwerlin
wrote:
>
> Signed-off-by: Lionel Landwerlin
> ---
> Makefile.am| 1 +
> src/tests/bug/108909.c | 106 +
> 2 files changed, 107 insertions(+)
> create mode 100644 src/tests/bug/108909.c
>
> diff --git a/Makefile.am b/Makefile.am
> index b35e329..528650a 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -74,6 +74,7 @@ bin_crucible_SOURCES = \
> src/qonos/qonos.c \
> src/qonos/qonos_pipeline.c \
> src/tests/bug/104809.c \
> + src/tests/bug/108909.c \
> src/tests/bench/copy-buffer.c \
> src/tests/example/basic.c \
> src/tests/example/images.c \
> diff --git a/src/tests/bug/108909.c b/src/tests/bug/108909.c
> new file mode 100644
> index 000..1faadbf
> --- /dev/null
> +++ b/src/tests/bug/108909.c
> @@ -0,0 +1,106 @@
> +// Copyright 2018 Intel Corporation
> +//
> +// Permission is hereby granted, free of charge, to any person obtaining a
> +// copy of this software and associated documentation files (the "Software"),
> +// to deal in the Software without restriction, including without limitation
> +// the rights to use, copy, modify, merge, publish, distribute, sublicense,
> +// and/or sell copies of the Software, and to permit persons to whom the
> +// Software is furnished to do so, subject to the following conditions:
> +//
> +// The above copyright notice and this permission notice (including the next
> +// paragraph) shall be included in all copies or substantial portions of the
> +// Software.
> +//
> +// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> +// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> +// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> +// THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> +// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> +// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> DEALINGS
> +// IN THE SOFTWARE.
> +
> +#include
> +#include
> +#include "tapi/t.h"
> +#include "util/misc.h"
> +
> +/* This is a test for https://bugs.freedesktop.org/show_bug.cgi?id=108909
> + *
> + * Ensure ordering of operations for between 3d pipeline and command
> + * streamer on Intel HW.
> + */
> +
> +static void
> +test(void)
> +{
> +const uint64_t initialData[] = {
> +0xdeaddeadbeef,
> +0xdeaddeadbeef,
> +0xdeaddeadbeef,
> +0xdeaddeadbeef,
> +};
> +VkBuffer dataBuffer = qoCreateBuffer(t_device,
> + .size = sizeof(initialData),
> + .usage =
> VK_BUFFER_USAGE_TRANSFER_SRC_BIT);
> +VkDeviceMemory dataMem = qoAllocBufferMemory(t_device, dataBuffer,
> + .properties =
> VK_MEMORY_PROPERTY_HOST_COHERENT_BIT |
> +
> VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT);
> +memcpy(qoMapMemory(t_device, dataMem, /*offset*/ 0,
> + sizeof(initialData), /*flags*/ 0),
> + initialData,
> + sizeof(initialData));
> +qoBindBufferMemory(t_device, dataBuffer, dataMem, /*offset*/ 0);
> +
> +VkBuffer resultBuffer = qoCreateBuffer(t_device,
> +.size = sizeof(initialData),
> +.usage =
> VK_BUFFER_USAGE_TRANSFER_DST_BIT);
> +VkDeviceMemory resultMem = qoAllocBufferMemory(t_device, resultBuffer,
> + .properties =
> VK_MEMORY_PROPERTY_HOST_COHERENT_BIT |
> +
> VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT);
> +qoBindBufferMemory(t_device, resultBuffer, resultMem, /*offset*/ 0);
> +
> +VkQueryPool pool = qoCreateQueryPool(t_device,
> + .queryType =
> VK_QUERY_TYPE_TIMESTAMP,
> + .queryCount =
> ARRAY_LENGTH(initialData));
> +
> +
> +/* vkCmdCopyQueryPoolResults should be ordered with regard to
> vkCmdCopyBuffer. */
> +VkCommandBuffer cmdBuffer = qoAllocateCommandBuffer(t_device,
> t_cmd_pool);
> +qoBeginCommandBuffer(cmdBuffer);
> +vkCmdWriteTimestamp(cmdBuffer, VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT, pool,
> 0);
> +vkCmdWriteTimestamp(cmdBuffer, VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT, pool,
> 1);
> +vkCmdCopyBuffer(cmdBuffer, dataBuffer, resultBuffer,
> +1, &(VkBufferCopy){ .srcOffset = 0, .dstOffset = 0,
> .size = sizeof(initialData) });
> +vkCmdWriteTimestamp(cmdBuffer, VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT, pool,
> 2);
> +vkCmdWriteTimestamp(cmdBuffer, VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT, pool,
> 3);
> +vkCmdCopyQueryPoolResults(cmdBuffer, pool, /*firstQuery*/ 0,
> /*queryCount*/ 4,
> +
[Piglit] [PATCH crucible] Add a test for bug 108909
Signed-off-by: Lionel Landwerlin
---
Makefile.am| 1 +
src/tests/bug/108909.c | 106 +
2 files changed, 107 insertions(+)
create mode 100644 src/tests/bug/108909.c
diff --git a/Makefile.am b/Makefile.am
index b35e329..528650a 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -74,6 +74,7 @@ bin_crucible_SOURCES = \
src/qonos/qonos.c \
src/qonos/qonos_pipeline.c \
src/tests/bug/104809.c \
+ src/tests/bug/108909.c \
src/tests/bench/copy-buffer.c \
src/tests/example/basic.c \
src/tests/example/images.c \
diff --git a/src/tests/bug/108909.c b/src/tests/bug/108909.c
new file mode 100644
index 000..1faadbf
--- /dev/null
+++ b/src/tests/bug/108909.c
@@ -0,0 +1,106 @@
+// Copyright 2018 Intel Corporation
+//
+// Permission is hereby granted, free of charge, to any person obtaining a
+// copy of this software and associated documentation files (the "Software"),
+// to deal in the Software without restriction, including without limitation
+// the rights to use, copy, modify, merge, publish, distribute, sublicense,
+// and/or sell copies of the Software, and to permit persons to whom the
+// Software is furnished to do so, subject to the following conditions:
+//
+// The above copyright notice and this permission notice (including the next
+// paragraph) shall be included in all copies or substantial portions of the
+// Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+// THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+// IN THE SOFTWARE.
+
+#include
+#include
+#include "tapi/t.h"
+#include "util/misc.h"
+
+/* This is a test for https://bugs.freedesktop.org/show_bug.cgi?id=108909
+ *
+ * Ensure ordering of operations for between 3d pipeline and command
+ * streamer on Intel HW.
+ */
+
+static void
+test(void)
+{
+const uint64_t initialData[] = {
+0xdeaddeadbeef,
+0xdeaddeadbeef,
+0xdeaddeadbeef,
+0xdeaddeadbeef,
+};
+VkBuffer dataBuffer = qoCreateBuffer(t_device,
+ .size = sizeof(initialData),
+ .usage =
VK_BUFFER_USAGE_TRANSFER_SRC_BIT);
+VkDeviceMemory dataMem = qoAllocBufferMemory(t_device, dataBuffer,
+ .properties =
VK_MEMORY_PROPERTY_HOST_COHERENT_BIT |
+
VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT);
+memcpy(qoMapMemory(t_device, dataMem, /*offset*/ 0,
+ sizeof(initialData), /*flags*/ 0),
+ initialData,
+ sizeof(initialData));
+qoBindBufferMemory(t_device, dataBuffer, dataMem, /*offset*/ 0);
+
+VkBuffer resultBuffer = qoCreateBuffer(t_device,
+.size = sizeof(initialData),
+.usage =
VK_BUFFER_USAGE_TRANSFER_DST_BIT);
+VkDeviceMemory resultMem = qoAllocBufferMemory(t_device, resultBuffer,
+ .properties =
VK_MEMORY_PROPERTY_HOST_COHERENT_BIT |
+
VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT);
+qoBindBufferMemory(t_device, resultBuffer, resultMem, /*offset*/ 0);
+
+VkQueryPool pool = qoCreateQueryPool(t_device,
+ .queryType =
VK_QUERY_TYPE_TIMESTAMP,
+ .queryCount =
ARRAY_LENGTH(initialData));
+
+
+/* vkCmdCopyQueryPoolResults should be ordered with regard to
vkCmdCopyBuffer. */
+VkCommandBuffer cmdBuffer = qoAllocateCommandBuffer(t_device, t_cmd_pool);
+qoBeginCommandBuffer(cmdBuffer);
+vkCmdWriteTimestamp(cmdBuffer, VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT, pool, 0);
+vkCmdWriteTimestamp(cmdBuffer, VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT, pool, 1);
+vkCmdCopyBuffer(cmdBuffer, dataBuffer, resultBuffer,
+1, &(VkBufferCopy){ .srcOffset = 0, .dstOffset = 0, .size
= sizeof(initialData) });
+vkCmdWriteTimestamp(cmdBuffer, VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT, pool, 2);
+vkCmdWriteTimestamp(cmdBuffer, VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT, pool, 3);
+vkCmdCopyQueryPoolResults(cmdBuffer, pool, /*firstQuery*/ 0,
/*queryCount*/ 4,
+ resultBuffer, /*dstBufferOffset*/ 0,
sizeof(uint64_t),
+ VK_QUERY_RESULT_WAIT_BIT);
+qoEndCommandBuffer(cmdBuffer);
+
+qoQueueSubmit(t_queue, 1, , VK_NULL_HANDLE);
+qoQueueWaitIdle(t_queue);
+
+uint64_t *copiedResults = qoMapMemory(t_device,
Re: [Piglit] [PATCH 1/2] EGL_EXT_image_dma_buf_import: drop alpha-one to sample yuv tests
Reviewed-by: Tapani Pälli On 11/13/18 4:40 PM, Lionel Landwerlin wrote: This option only applies to the sample_rgb tests. Signed-off-by: Lionel Landwerlin --- tests/opengl.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/opengl.py b/tests/opengl.py index c672fdad4..8957de6e2 100644 --- a/tests/opengl.py +++ b/tests/opengl.py @@ -3021,11 +3021,11 @@ with profile.test_list.group_manager( 'ext_image_dma_buf_import-sample_argb', run_concurrent=False) g(['ext_image_dma_buf_import-sample_rgb', '-fmt=XR24', '-alpha-one'], 'ext_image_dma_buf_import-sample_xrgb', run_concurrent=False) -g(['ext_image_dma_buf_import-sample_yuv', '-fmt=NV12', '-alpha-one'], +g(['ext_image_dma_buf_import-sample_yuv', '-fmt=NV12'], 'ext_image_dma_buf_import-sample_nv12', run_concurrent=False) -g(['ext_image_dma_buf_import-sample_yuv', '-fmt=YU12', '-alpha-one'], +g(['ext_image_dma_buf_import-sample_yuv', '-fmt=YU12'], 'ext_image_dma_buf_import-sample_yuv420', run_concurrent=False) -g(['ext_image_dma_buf_import-sample_yuv', '-fmt=YV12', '-alpha-one'], +g(['ext_image_dma_buf_import-sample_yuv', '-fmt=YV12'], 'ext_image_dma_buf_import-sample_yvu420', run_concurrent=False) g(['ext_image_dma_buf_import-sample_yuv', '-fmt=AYUV'], 'ext_image_dma_buf_import-sample_ayuv', run_concurrent=False) ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH v2] miptree: test ability to use upside down miptree
Hello, Didn't know it, thanks for clarification :) Regards, Andrii. On Mon, Dec 3, 2018 at 8:01 PM Mark Janes wrote: > It's preferable to push piglit tests first, and produce the CI test > failure. CI staff will track the failure, and attribute it to the > piglit patch. When the subsequent mesa patch is pushed, we track the > resolution. The process gives us artifacts in git that help to analyze > driver differences between stable releases. > > -Mark > > andrey simiklit writes: > > > Hello, > > > > If this patch is acceptable by everybody then > > I guess that we need to push the following mesa patch before this one > > to avoid errors from Intel CI because the fix for an issue which is > tested > > by this test is still there. > > > > https://patchwork.freedesktop.org/patch/254397/ > > One of the last comment from Kenneth Graunke : > > > >>". > >> So, back to Reviewed-by. I think once we get a Piglit test, I'm > happy > >> to land this patch. > >> > >>--Ken" > >> > > > > Thanks, > > Andrii. > > > > On Mon, Dec 3, 2018 at 5:07 PM wrote: > > > >> From: Andrii Simiklit > >> > >> Test that usage of upside down miptree doesn't cause assertion > >> > >> The miptree: > >> > >> level 0 = 1x1 > >> level 1 = 2x2 > >> level 2 = 4x4 > >> ... > >> level n = NxN > >> > >> should be acceptable for case when we don't use a min filter. > >> > >> v2: - Unnecessary function calls were removed > >> - The 'glClearColor' call was moved to 'piglit_display' function > >> - The program creation was moved to 'piglit_init' function > >> - The requirements check was moved to 'piglit_init' function > >>( Erik Faye-Lund ) > >> > >> - Fixed a leak of texture which is created in 'setup_texture' > >> > >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107987 > >> Signed-off-by: Andrii Simiklit > >> Reviewed-by: Erik Faye-Lund > >> --- > >> tests/opengl.py | 1 + > >> tests/texturing/CMakeLists.gl.txt | 1 + > >> tests/texturing/tex-upside-down-miptree.c | 171 ++ > >> 3 files changed, 173 insertions(+) > >> create mode 100644 tests/texturing/tex-upside-down-miptree.c > >> > >> diff --git a/tests/opengl.py b/tests/opengl.py > >> index f7e408cd5..f6a38e40e 100644 > >> --- a/tests/opengl.py > >> +++ b/tests/opengl.py > >> @@ -704,6 +704,7 @@ with profile.test_list.group_manager( > >> g(['getteximage-targets', '1D']) > >> g(['getteximage-targets', '2D']) > >> g(['teximage-scale-bias']) > >> +g(['tex-upside-down-miptree']) > >> add_msaa_visual_plain_tests(g, ['draw-pixels']) > >> add_msaa_visual_plain_tests(g, ['read-front'], > run_concurrent=False) > >> add_msaa_visual_plain_tests(g, ['read-front', 'clear-front-first'], > >> diff --git a/tests/texturing/CMakeLists.gl.txt > >> b/tests/texturing/CMakeLists.gl.txt > >> index e5d41e432..02b572c79 100644 > >> --- a/tests/texturing/CMakeLists.gl.txt > >> +++ b/tests/texturing/CMakeLists.gl.txt > >> @@ -98,5 +98,6 @@ piglit_add_executable (texture-al texture-al.c) > >> piglit_add_executable (texture-rg texture-rg.c) > >> piglit_add_executable (teximage-colors teximage-colors.c) > >> piglit_add_executable (zero-tex-coord zero-tex-coord.c) > >> +piglit_add_executable (tex-upside-down-miptree > tex-upside-down-miptree.c) > >> > >> # vim: ft=cmake: > >> diff --git a/tests/texturing/tex-upside-down-miptree.c > >> b/tests/texturing/tex-upside-down-miptree.c > >> new file mode 100644 > >> index 0..8e8f7154b > >> --- /dev/null > >> +++ b/tests/texturing/tex-upside-down-miptree.c > >> @@ -0,0 +1,171 @@ > >> +/* > >> + * Copyright (c) 2018 Andrii Simiklit > >> + * > >> + * Permission is hereby granted, free of charge, to any person > obtaining a > >> + * copy of this software and associated documentation files (the > >> "Software"), > >> + * to deal in the Software without restriction, including without > >> limitation > >> + * the rights to use, copy, modify, merge, publish, distribute, > >> sublicense, > >> + * and/or sell copies of the Software, and to permit persons to whom > the > >> + * Software is furnished to do so, subject to the following conditions: > >> + * > >> + * The above copyright notice and this permission notice (including the > >> next > >> + * paragraph) shall be included in all copies or substantial portions > of > >> the > >> + * Software. > >> + * > >> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > >> EXPRESS OR > >> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > >> MERCHANTABILITY, > >> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT > >> SHALL > >> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR > >> OTHER > >> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, > ARISING > >> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER > >> DEALINGS > >> + * IN THE SOFTWARE. > >>
