Re: [Piglit] [PATCH] shader_runner: some extra skip reasong logging

[Dylan Baker]

Reviewed-by: Dylan Baker 

Quoting Alejandro Piñeiro (2019-06-12 03:42:35)
> ---
>  tests/shaders/shader_runner.c | 13 ++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c
> index 44aa5da37..a2a1d43fb 100644
> --- a/tests/shaders/shader_runner.c
> +++ b/tests/shaders/shader_runner.c
> @@ -1143,13 +1143,17 @@ process_requirement(const char *line)
>  
> if (parse_str(line, "GL_", NULL) &&
> parse_word_copy(line, buffer, sizeof(buffer), )) {
> -   if (!piglit_is_extension_supported(buffer))
> +   if (!piglit_is_extension_supported(buffer)) {
> +   printf("Test requires unsupported extension %s\n", 
> buffer);
> return PIGLIT_SKIP;
> +   }
> } else if (parse_str(line, "!", ) &&
>parse_str(line, "GL_", NULL) &&
>parse_word_copy(line, buffer, sizeof(buffer), )) {
> -   if (piglit_is_extension_supported(buffer))
> +   if (piglit_is_extension_supported(buffer)) {
> +   printf("Test requires unsupported extension %s\n", 
> buffer);
> return PIGLIT_SKIP;
> +   }
> } else if (parse_str(line, "GLSL", )) {
> enum comparison cmp;
>  
> @@ -4727,8 +4731,11 @@ piglit_init(int argc, char **argv)
>  #endif
>  
> if (use_get_program_binary) {
> -   if (gl_num_program_binary_formats == 0)
> +   if (gl_num_program_binary_formats == 0) {
> +   printf("Trying to use get_program_binary, but "
> +  "GL_NUM_PROGRAM_BINARY == 0\n");
> piglit_report_result(PIGLIT_SKIP);
> +   }
> }
>  
> /* Automatic mode can run multiple tests per session. */
> -- 
> 2.19.1
> 
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit


signature.asc
Description: signature
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] framework/test: Add default 1min timeout to all OpenCL tests

[Dylan Baker]

Reviewed-by: Dylan Baker 

Quoting Jan Vesely (2019-06-22 16:48:56)
> On Wed, Jun 5, 2019 at 11:47 PM Jan Vesely  wrote:
> >
> > From: Jan Vesely 
> >
> > Signed-off-by: Jan Vesely 
> > ---
> >  framework/test/piglit_test.py | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/framework/test/piglit_test.py b/framework/test/piglit_test.py
> > index 166c2f792ca..b4e6eb444e0 100644
> > --- a/framework/test/piglit_test.py
> > +++ b/framework/test/piglit_test.py
> > @@ -215,6 +215,7 @@ class PiglitCLTest(PiglitBaseTest):  # pylint: 
> > disable=too-few-public-methods
> >
> >  """
> >  def __init__(self, command, run_concurrent=CL_CONCURRENT, **kwargs):
> > +self.timeout = 60
> >  super(PiglitCLTest, self).__init__(command, run_concurrent, 
> > **kwargs)
> >
> 
> ping (+fix Dylan's email)
> 
> Jan
> 
> >
> > --
> > 2.21.0
> >


signature.asc
Description: signature
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit