Re: [Piglit] [PATCH] arb_arrays_of_arrays: Fix format-secruity warning.

[Timothy Arceri]

Thanks.

Reviewed-by: Timothy Arceri 


On Sun, 2015-11-29 at 23:34 -0800, Vinson Lee wrote:
> max-binding.c:126:44: warning: format string is not a string literal
> (potentially insecure) [-Wformat-security]
> piglit_report_subtest_result(PIGLIT_FAIL, name);
>   ^~~~
> 
> Signed-off-by: Vinson Lee 
> ---
>  tests/spec/arb_arrays_of_arrays/max-binding.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/spec/arb_arrays_of_arrays/max-binding.c
> b/tests/spec/arb_arrays_of_arrays/max-binding.c
> index 07c567d..cc398e7 100644
> --- a/tests/spec/arb_arrays_of_arrays/max-binding.c
> +++ b/tests/spec/arb_arrays_of_arrays/max-binding.c
> @@ -123,7 +123,7 @@ run_test_ac_vertex_max_bindings(unsigned binding)
>  static void
>  subtest_fail(enum piglit_result *status, char *name)
>  {
> - piglit_report_subtest_result(PIGLIT_FAIL, name);
> + piglit_report_subtest_result(PIGLIT_FAIL, "%s", name);
>   *status = PIGLIT_FAIL;
>  }
>  
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] arb_arrays_of_arrays: Fix format-secruity warning.

[Vinson Lee]

max-binding.c:126:44: warning: format string is not a string literal 
(potentially insecure) [-Wformat-security]
piglit_report_subtest_result(PIGLIT_FAIL, name);
  ^~~~

Signed-off-by: Vinson Lee 
---
 tests/spec/arb_arrays_of_arrays/max-binding.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/spec/arb_arrays_of_arrays/max-binding.c 
b/tests/spec/arb_arrays_of_arrays/max-binding.c
index 07c567d..cc398e7 100644
--- a/tests/spec/arb_arrays_of_arrays/max-binding.c
+++ b/tests/spec/arb_arrays_of_arrays/max-binding.c
@@ -123,7 +123,7 @@ run_test_ac_vertex_max_bindings(unsigned binding)
 static void
 subtest_fail(enum piglit_result *status, char *name)
 {
-   piglit_report_subtest_result(PIGLIT_FAIL, name);
+   piglit_report_subtest_result(PIGLIT_FAIL, "%s", name);
*status = PIGLIT_FAIL;
 }
 
-- 
2.6.3

___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit