Re: [Piglit] [PATCH] arb_transform_feedback_overflow_query: skip QBO subtests if unsupported

2017-02-21 Thread Ilia Mirkin 
On Tue, Feb 21, 2017 at 7:56 PM, Kenneth Graunke  wrote:
> We need GL_ARB_query_buffer_object to run the GL_QUERY_BUFFER subtests.
>
> Signed-off-by: Kenneth Graunke 
> Cc: Rafael Antognolli 
> ---
>  tests/spec/arb_transform_feedback_overflow_query/basic.c | 6 ++
>  1 file changed, 6 insertions(+)
>
> diff --git a/tests/spec/arb_transform_feedback_overflow_query/basic.c 
> b/tests/spec/arb_transform_feedback_overflow_query/basic.c
> index 25c335578..0ca0afe6a 100644
> --- a/tests/spec/arb_transform_feedback_overflow_query/basic.c
> +++ b/tests/spec/arb_transform_feedback_overflow_query/basic.c
> @@ -244,6 +244,12 @@ run_subtest(int n_streams, int array_sizes[], int 
> stream, GLuint query_type,
> const char *gs_text;
> const char **gs_varyings;
>
> +   if (!strcmp(test_type, "buffer_object") &&
> +   !piglit_is_extension_supported("GL_ARB_query_buffer_object")) {
> +   piglit_loge("context does not support "
> +   "GL_ARB_query_buffer_object; skipping test");
> +   return PIGLIT_SKIP;

indent.

Reviewed-by: Ilia Mirkin 

> +   }
>
> if (n_streams > 1) {
> if (!check_multistream_extensions())
> --
> 2.11.1
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] arb_transform_feedback_overflow_query: skip QBO subtests if unsupported

2017-02-21 Thread Kenneth Graunke 
We need GL_ARB_query_buffer_object to run the GL_QUERY_BUFFER subtests.

Signed-off-by: Kenneth Graunke 
Cc: Rafael Antognolli 
---
 tests/spec/arb_transform_feedback_overflow_query/basic.c | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/tests/spec/arb_transform_feedback_overflow_query/basic.c 
b/tests/spec/arb_transform_feedback_overflow_query/basic.c
index 25c335578..0ca0afe6a 100644
--- a/tests/spec/arb_transform_feedback_overflow_query/basic.c
+++ b/tests/spec/arb_transform_feedback_overflow_query/basic.c
@@ -244,6 +244,12 @@ run_subtest(int n_streams, int array_sizes[], int stream, 
GLuint query_type,
const char *gs_text;
const char **gs_varyings;
 
+   if (!strcmp(test_type, "buffer_object") &&
+   !piglit_is_extension_supported("GL_ARB_query_buffer_object")) {
+   piglit_loge("context does not support "
+   "GL_ARB_query_buffer_object; skipping test");
+   return PIGLIT_SKIP;
+   }
 
if (n_streams > 1) {
if (!check_multistream_extensions())
-- 
2.11.1

___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit