Re: [Piglit] [PATCH] cl: Fix types to be unsigned
On Mon, 2018-08-13 at 23:42 +0300, Matt Arsenault wrote:
> ping
Reviewed-by: Jan Vesely
>
> > On Oct 27, 2017, at 13:03, Matt Arsenault wrote:
> >
> > Doesn't really matter.
so why change it?
still passes on clover carrizo/iceland
Jan
> > ---
> > tests/cl/program/execute/store-hi16.cl | 8
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/tests/cl/program/execute/store-hi16.cl
> > b/tests/cl/program/execute/store-hi16.cl
> > index b734b3766..4273d3369 100644
> > --- a/tests/cl/program/execute/store-hi16.cl
> > +++ b/tests/cl/program/execute/store-hi16.cl
> > @@ -92,7 +92,7 @@ kernel void store_hi16_global(volatile global ushort*
> > out, volatile global uint*
> >
> > kernel void store_hi16_local(volatile global ushort* out, volatile global
> > uint* in)
> > {
> > -volatile local short lds[64];
> > +volatile local ushort lds[64];
> > int lid = get_local_id(0);
> > int gid = get_global_id(0);
> >
> > @@ -104,7 +104,7 @@ kernel void store_hi16_local(volatile global ushort*
> > out, volatile global uint*
> > kernel void store_hi16_private(volatile global ushort* out, volatile global
> > uint* in)
> > {
> > int gid = get_global_id(0);
> > -volatile private short stack = in[gid] >> 16;
> > +volatile private ushort stack = in[gid] >> 16;
> > out[gid] = stack;
> > }
> >
> > @@ -117,7 +117,7 @@ kernel void truncstorei8_hi16_global(volatile global
> > uchar* out, volatile global
> >
> > kernel void truncstorei8_hi16_local(volatile global uchar* out, volatile
> > global uint* in)
> > {
> > -volatile local short lds[64];
> > +volatile local ushort lds[64];
> > int lid = get_local_id(0);
> > int gid = get_global_id(0);
> >
> > @@ -129,6 +129,6 @@ kernel void truncstorei8_hi16_local(volatile global
> > uchar* out, volatile global
> > kernel void truncstorei8_hi16_private(volatile global uchar* out, volatile
> > global uint* in)
> > {
> > int gid = get_global_id(0);
> > -volatile private short stack = in[gid] >> 16;
> > +volatile private ushort stack = in[gid] >> 16;
> > out[gid] = (uchar)stack;
> > }
> > --
> > 2.11.0
> >
>
>
--
Jan Vesely
signature.asc
Description: This is a digitally signed message part
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] cl: Fix types to be unsigned
ping
> On Oct 27, 2017, at 13:03, Matt Arsenault wrote:
>
> Doesn't really matter.
> ---
> tests/cl/program/execute/store-hi16.cl | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/cl/program/execute/store-hi16.cl
> b/tests/cl/program/execute/store-hi16.cl
> index b734b3766..4273d3369 100644
> --- a/tests/cl/program/execute/store-hi16.cl
> +++ b/tests/cl/program/execute/store-hi16.cl
> @@ -92,7 +92,7 @@ kernel void store_hi16_global(volatile global ushort* out,
> volatile global uint*
>
> kernel void store_hi16_local(volatile global ushort* out, volatile global
> uint* in)
> {
> -volatile local short lds[64];
> +volatile local ushort lds[64];
> int lid = get_local_id(0);
> int gid = get_global_id(0);
>
> @@ -104,7 +104,7 @@ kernel void store_hi16_local(volatile global ushort* out,
> volatile global uint*
> kernel void store_hi16_private(volatile global ushort* out, volatile global
> uint* in)
> {
> int gid = get_global_id(0);
> -volatile private short stack = in[gid] >> 16;
> +volatile private ushort stack = in[gid] >> 16;
> out[gid] = stack;
> }
>
> @@ -117,7 +117,7 @@ kernel void truncstorei8_hi16_global(volatile global
> uchar* out, volatile global
>
> kernel void truncstorei8_hi16_local(volatile global uchar* out, volatile
> global uint* in)
> {
> -volatile local short lds[64];
> +volatile local ushort lds[64];
> int lid = get_local_id(0);
> int gid = get_global_id(0);
>
> @@ -129,6 +129,6 @@ kernel void truncstorei8_hi16_local(volatile global
> uchar* out, volatile global
> kernel void truncstorei8_hi16_private(volatile global uchar* out, volatile
> global uint* in)
> {
> int gid = get_global_id(0);
> -volatile private short stack = in[gid] >> 16;
> +volatile private ushort stack = in[gid] >> 16;
> out[gid] = (uchar)stack;
> }
> --
> 2.11.0
>
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH] cl: Fix types to be unsigned
Doesn't really matter.
---
tests/cl/program/execute/store-hi16.cl | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/cl/program/execute/store-hi16.cl
b/tests/cl/program/execute/store-hi16.cl
index b734b3766..4273d3369 100644
--- a/tests/cl/program/execute/store-hi16.cl
+++ b/tests/cl/program/execute/store-hi16.cl
@@ -92,7 +92,7 @@ kernel void store_hi16_global(volatile global ushort* out,
volatile global uint*
kernel void store_hi16_local(volatile global ushort* out, volatile global
uint* in)
{
-volatile local short lds[64];
+volatile local ushort lds[64];
int lid = get_local_id(0);
int gid = get_global_id(0);
@@ -104,7 +104,7 @@ kernel void store_hi16_local(volatile global ushort* out,
volatile global uint*
kernel void store_hi16_private(volatile global ushort* out, volatile global
uint* in)
{
int gid = get_global_id(0);
-volatile private short stack = in[gid] >> 16;
+volatile private ushort stack = in[gid] >> 16;
out[gid] = stack;
}
@@ -117,7 +117,7 @@ kernel void truncstorei8_hi16_global(volatile global uchar*
out, volatile global
kernel void truncstorei8_hi16_local(volatile global uchar* out, volatile
global uint* in)
{
-volatile local short lds[64];
+volatile local ushort lds[64];
int lid = get_local_id(0);
int gid = get_global_id(0);
@@ -129,6 +129,6 @@ kernel void truncstorei8_hi16_local(volatile global uchar*
out, volatile global
kernel void truncstorei8_hi16_private(volatile global uchar* out, volatile
global uint* in)
{
int gid = get_global_id(0);
-volatile private short stack = in[gid] >> 16;
+volatile private ushort stack = in[gid] >> 16;
out[gid] = (uchar)stack;
}
--
2.11.0
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
