Re: [Piglit] [PATCH] glsl-es-3.00: Verify various UTF-8 clarifications from Khronos
On 05.12.2015 12:53, Ian Romanick wrote: > On 12/02/2015 07:03 PM, Michel Dänzer wrote: >> On 03.12.2015 01:42, Ian Romanick wrote: >>> >>> +#define eat_sushi_using_chopsticks 寿司使用して箸を食べます。 >> >> The nouns are reversed in the Japanese text, so it actually means "eat >> chopsticks using sushi". :) There should also be an を particle for the >> chopsticks, so it should be 箸を使用して寿司を食べます。 > > My memory of kanji is really, really bad, so I assumed that Google > translated it correctly. I remembered enough kana to believe the > translation... I guess it needed closer review. I also have some vague > recollection that で would be used with chopsticks... but maybe that's > "with" instead of "using." Would 箸で寿司を食べます be correct? Yes, that would be "eat sushi with chopsticks". Might be simpler to go with that for both languages. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] glsl-es-3.00: Verify various UTF-8 clarifications from Khronos
On 12/04/2015 05:50 PM, Dylan Baker wrote:
> On Wed, Dec 02, 2015 at 08:42:37AM -0800, Ian Romanick wrote:
>> From: Ian Romanick
>>
>> Further discussion in Khronos has determined that UTF-8 in unused
>> preprocessor defines as well.
>>
>> See Khronos internal bug #14939.
>>
>> Signed-off-by: Ian Romanick
>> ---
>> .../glsl-es-3.00/compiler/utf8-unused-define.vert | 26
>> +
>> .../glsl-es-3.00/compiler/utf8-used-define.vert| 27
>> ++
>> 2 files changed, 53 insertions(+)
>> create mode 100644 tests/spec/glsl-es-3.00/compiler/utf8-unused-define.vert
>> create mode 100644 tests/spec/glsl-es-3.00/compiler/utf8-used-define.vert
>>
>> diff --git a/tests/spec/glsl-es-3.00/compiler/utf8-unused-define.vert
>> b/tests/spec/glsl-es-3.00/compiler/utf8-unused-define.vert
>> new file mode 100644
>> index 000..69cde74
>> --- /dev/null
>> +++ b/tests/spec/glsl-es-3.00/compiler/utf8-unused-define.vert
>> @@ -0,0 +1,26 @@
>> +#version 300 es
>> +
>> +/* [config]
>> + * expect_result: pass
>> + * glsl_version: 3.00
>> + * [end config]
>> + *
>> + * Page 8 (page 14 of the PDF) of the OpenGL ES Shading Language 3.00 spec
>> + * says:
>> + *
>> + * "Inside comments, the character set is extended to allow any byte
>> + * values to be used but with the exception that a byte with the value
>> + * zero is always interpreted as the end of the string. The character
>> + * encoding is assumed to be UTF-8 but no checking is performed for
>> + * invalid characters."
>> + *
>> + * Further discussion in Khronos has determined that UTF-8 in unused
>> + * preprocessor defines as well.
>> + */
>> +
>> +#define eat_sushi_using_chopsticks 寿司使用して箸を食べます。
>> +
>> +void main()
>> +{
>> +gl_Position = vec4(0);
>> +}
>> diff --git a/tests/spec/glsl-es-3.00/compiler/utf8-used-define.vert
>> b/tests/spec/glsl-es-3.00/compiler/utf8-used-define.vert
>> new file mode 100644
>> index 000..7bc04e6
>> --- /dev/null
>> +++ b/tests/spec/glsl-es-3.00/compiler/utf8-used-define.vert
>> @@ -0,0 +1,27 @@
>> +#version 300 es
>> +
>> +/* [config]
>> + * expect_result: fail
>> + * glsl_version: 3.00
>> + * [end config]
>> + *
>> + * Page 8 (page 14 of the PDF) of the OpenGL ES Shading Language 3.00 spec
>> + * says:
>> + *
>> + * "Inside comments, the character set is extended to allow any byte
>> + * values to be used but with the exception that a byte with the value
>> + * zero is always interpreted as the end of the string. The character
>> + * encoding is assumed to be UTF-8 but no checking is performed for
>> + * invalid characters."
>> + *
>> + * Further discussion in Khronos has determined that UTF-8 in unused
>> + * preprocessor defines as well.
>> + */
>
> My brain isn't parsing this sentence.
>
> Should this read:
> Further discussion in Khronos has determined that UTF-8 "is allowed in"
> preprocessor defines as well.
> ? (or something to that effect?)
>
> Or is my brain just struggling hardcore today?
I think I meant:
Further discussion in Khronos has determined that UTF-8 in unused
preprocessor defines should be allowed as well.
I guess I botched the sentences in both languages! Language is hard.
>> +
>> +#define eat_sushi_using_chopsticks 寿司使用して箸を食べます
>> +
>> +void main()
>> +{
>> +float eat_sushi_using_chopsticks = 0;
>> +gl_Position = vec4(eat_sushi_using_chopsticks);
>> +}
>> --
>> 2.5.0
>>
>> ___
>> Piglit mailing list
>> Piglit@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/piglit
signature.asc
Description: OpenPGP digital signature
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] glsl-es-3.00: Verify various UTF-8 clarifications from Khronos
On 12/02/2015 07:03 PM, Michel Dänzer wrote: > On 03.12.2015 01:42, Ian Romanick wrote: >> >> +#define eat_sushi_using_chopsticks 寿司使用して箸を食べます。 > > The nouns are reversed in the Japanese text, so it actually means "eat > chopsticks using sushi". :) There should also be an を particle for the > chopsticks, so it should be 箸を使用して寿司を食べます。 My memory of kanji is really, really bad, so I assumed that Google translated it correctly. I remembered enough kana to believe the translation... I guess it needed closer review. I also have some vague recollection that で would be used with chopsticks... but maybe that's "with" instead of "using." Would 箸で寿司を食べます be correct? ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] glsl-es-3.00: Verify various UTF-8 clarifications from Khronos
On Wed, Dec 02, 2015 at 08:42:37AM -0800, Ian Romanick wrote:
> From: Ian Romanick
>
> Further discussion in Khronos has determined that UTF-8 in unused
> preprocessor defines as well.
>
> See Khronos internal bug #14939.
>
> Signed-off-by: Ian Romanick
> ---
> .../glsl-es-3.00/compiler/utf8-unused-define.vert | 26 +
> .../glsl-es-3.00/compiler/utf8-used-define.vert| 27
> ++
> 2 files changed, 53 insertions(+)
> create mode 100644 tests/spec/glsl-es-3.00/compiler/utf8-unused-define.vert
> create mode 100644 tests/spec/glsl-es-3.00/compiler/utf8-used-define.vert
>
> diff --git a/tests/spec/glsl-es-3.00/compiler/utf8-unused-define.vert
> b/tests/spec/glsl-es-3.00/compiler/utf8-unused-define.vert
> new file mode 100644
> index 000..69cde74
> --- /dev/null
> +++ b/tests/spec/glsl-es-3.00/compiler/utf8-unused-define.vert
> @@ -0,0 +1,26 @@
> +#version 300 es
> +
> +/* [config]
> + * expect_result: pass
> + * glsl_version: 3.00
> + * [end config]
> + *
> + * Page 8 (page 14 of the PDF) of the OpenGL ES Shading Language 3.00 spec
> + * says:
> + *
> + * "Inside comments, the character set is extended to allow any byte
> + * values to be used but with the exception that a byte with the value
> + * zero is always interpreted as the end of the string. The character
> + * encoding is assumed to be UTF-8 but no checking is performed for
> + * invalid characters."
> + *
> + * Further discussion in Khronos has determined that UTF-8 in unused
> + * preprocessor defines as well.
> + */
> +
> +#define eat_sushi_using_chopsticks 寿司使用して箸を食べます。
> +
> +void main()
> +{
> +gl_Position = vec4(0);
> +}
> diff --git a/tests/spec/glsl-es-3.00/compiler/utf8-used-define.vert
> b/tests/spec/glsl-es-3.00/compiler/utf8-used-define.vert
> new file mode 100644
> index 000..7bc04e6
> --- /dev/null
> +++ b/tests/spec/glsl-es-3.00/compiler/utf8-used-define.vert
> @@ -0,0 +1,27 @@
> +#version 300 es
> +
> +/* [config]
> + * expect_result: fail
> + * glsl_version: 3.00
> + * [end config]
> + *
> + * Page 8 (page 14 of the PDF) of the OpenGL ES Shading Language 3.00 spec
> + * says:
> + *
> + * "Inside comments, the character set is extended to allow any byte
> + * values to be used but with the exception that a byte with the value
> + * zero is always interpreted as the end of the string. The character
> + * encoding is assumed to be UTF-8 but no checking is performed for
> + * invalid characters."
> + *
> + * Further discussion in Khronos has determined that UTF-8 in unused
> + * preprocessor defines as well.
> + */
My brain isn't parsing this sentence.
Should this read:
Further discussion in Khronos has determined that UTF-8 "is allowed in"
preprocessor defines as well.
? (or something to that effect?)
Or is my brain just struggling hardcore today?
> +
> +#define eat_sushi_using_chopsticks 寿司使用して箸を食べます
> +
> +void main()
> +{
> +float eat_sushi_using_chopsticks = 0;
> +gl_Position = vec4(eat_sushi_using_chopsticks);
> +}
> --
> 2.5.0
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
signature.asc
Description: PGP signature
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] glsl-es-3.00: Verify various UTF-8 clarifications from Khronos
On 03.12.2015 01:42, Ian Romanick wrote: > > +#define eat_sushi_using_chopsticks 寿司使用して箸を食べます。 The nouns are reversed in the Japanese text, so it actually means "eat chopsticks using sushi". :) There should also be an を particle for the chopsticks, so it should be 箸を使用して寿司を食べます。 -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] glsl-es-3.00: Verify various UTF-8 clarifications from Khronos
On Wed, Dec 2, 2015 at 8:42 AM, Ian Romanick wrote: > From: Ian Romanick > > Further discussion in Khronos has determined that UTF-8 in unused > preprocessor defines as well. > > See Khronos internal bug #14939. > > Signed-off-by: Ian Romanick > --- > .../glsl-es-3.00/compiler/utf8-unused-define.vert | 26 + > .../glsl-es-3.00/compiler/utf8-used-define.vert| 27 > ++ > 2 files changed, 53 insertions(+) > create mode 100644 tests/spec/glsl-es-3.00/compiler/utf8-unused-define.vert > create mode 100644 tests/spec/glsl-es-3.00/compiler/utf8-used-define.vert > > diff --git a/tests/spec/glsl-es-3.00/compiler/utf8-unused-define.vert > b/tests/spec/glsl-es-3.00/compiler/utf8-unused-define.vert > new file mode 100644 > index 000..69cde74 > --- /dev/null > +++ b/tests/spec/glsl-es-3.00/compiler/utf8-unused-define.vert > @@ -0,0 +1,26 @@ > +#version 300 es > + > +/* [config] I was surprised to see #version before the [config] block, but we do seem to do that some other places (but basically only in ES tests...) Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH] glsl-es-3.00: Verify various UTF-8 clarifications from Khronos
From: Ian Romanick
Further discussion in Khronos has determined that UTF-8 in unused
preprocessor defines as well.
See Khronos internal bug #14939.
Signed-off-by: Ian Romanick
---
.../glsl-es-3.00/compiler/utf8-unused-define.vert | 26 +
.../glsl-es-3.00/compiler/utf8-used-define.vert| 27 ++
2 files changed, 53 insertions(+)
create mode 100644 tests/spec/glsl-es-3.00/compiler/utf8-unused-define.vert
create mode 100644 tests/spec/glsl-es-3.00/compiler/utf8-used-define.vert
diff --git a/tests/spec/glsl-es-3.00/compiler/utf8-unused-define.vert
b/tests/spec/glsl-es-3.00/compiler/utf8-unused-define.vert
new file mode 100644
index 000..69cde74
--- /dev/null
+++ b/tests/spec/glsl-es-3.00/compiler/utf8-unused-define.vert
@@ -0,0 +1,26 @@
+#version 300 es
+
+/* [config]
+ * expect_result: pass
+ * glsl_version: 3.00
+ * [end config]
+ *
+ * Page 8 (page 14 of the PDF) of the OpenGL ES Shading Language 3.00 spec
+ * says:
+ *
+ * "Inside comments, the character set is extended to allow any byte
+ * values to be used but with the exception that a byte with the value
+ * zero is always interpreted as the end of the string. The character
+ * encoding is assumed to be UTF-8 but no checking is performed for
+ * invalid characters."
+ *
+ * Further discussion in Khronos has determined that UTF-8 in unused
+ * preprocessor defines as well.
+ */
+
+#define eat_sushi_using_chopsticks 寿司使用して箸を食べます。
+
+void main()
+{
+gl_Position = vec4(0);
+}
diff --git a/tests/spec/glsl-es-3.00/compiler/utf8-used-define.vert
b/tests/spec/glsl-es-3.00/compiler/utf8-used-define.vert
new file mode 100644
index 000..7bc04e6
--- /dev/null
+++ b/tests/spec/glsl-es-3.00/compiler/utf8-used-define.vert
@@ -0,0 +1,27 @@
+#version 300 es
+
+/* [config]
+ * expect_result: fail
+ * glsl_version: 3.00
+ * [end config]
+ *
+ * Page 8 (page 14 of the PDF) of the OpenGL ES Shading Language 3.00 spec
+ * says:
+ *
+ * "Inside comments, the character set is extended to allow any byte
+ * values to be used but with the exception that a byte with the value
+ * zero is always interpreted as the end of the string. The character
+ * encoding is assumed to be UTF-8 but no checking is performed for
+ * invalid characters."
+ *
+ * Further discussion in Khronos has determined that UTF-8 in unused
+ * preprocessor defines as well.
+ */
+
+#define eat_sushi_using_chopsticks 寿司使用して箸を食べます
+
+void main()
+{
+float eat_sushi_using_chopsticks = 0;
+gl_Position = vec4(eat_sushi_using_chopsticks);
+}
--
2.5.0
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
