Re: [Piglit] [PATCH] sso: Check piglit_link_check_status return value.

2015-12-22 Thread Timothy Arceri 
On Tue, 2015-11-17 at 00:23 -0800, Vinson Lee wrote:
> Fixes Coverity "unchecked return value" defect.
> 
> Signed-off-by: Vinson Lee 
> ---
>  tests/spec/arb_separate_shader_objects/active-sampler-conflict.c | 2
> +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/spec/arb_separate_shader_objects/active-sampler
> -conflict.c b/tests/spec/arb_separate_shader_objects/active-sampler
> -conflict.c
> index 0a91f49..1c94b43 100644
> --- a/tests/spec/arb_separate_shader_objects/active-sampler
> -conflict.c
> +++ b/tests/spec/arb_separate_shader_objects/active-sampler
> -conflict.c
> @@ -124,7 +124,7 @@ setup_program(GLuint *prog, GLuint *pipe, GLuint
> *vao,
>  
>   *prog = glCreateShaderProgramv(GL_FRAGMENT_SHADER, 1,
> (const GLchar *const *)
> fs_code);
> - piglit_link_check_status(*prog);
> + pass = piglit_link_check_status(*prog) && pass;

Reviewed-by: Timothy Arceri 

>  
>   glGenProgramPipelines(1, pipe);
>   glUseProgramStages(*pipe,
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] sso: Check piglit_link_check_status return value.

2015-12-22 Thread Vinson Lee 
Fixes Coverity "unchecked return value" defect.

Signed-off-by: Vinson Lee 
---
 tests/spec/arb_separate_shader_objects/active-sampler-conflict.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/spec/arb_separate_shader_objects/active-sampler-conflict.c 
b/tests/spec/arb_separate_shader_objects/active-sampler-conflict.c
index 0a91f49..1c94b43 100644
--- a/tests/spec/arb_separate_shader_objects/active-sampler-conflict.c
+++ b/tests/spec/arb_separate_shader_objects/active-sampler-conflict.c
@@ -124,7 +124,7 @@ setup_program(GLuint *prog, GLuint *pipe, GLuint *vao,
 
*prog = glCreateShaderProgramv(GL_FRAGMENT_SHADER, 1,
  (const GLchar *const *) fs_code);
-   piglit_link_check_status(*prog);
+   pass = piglit_link_check_status(*prog) && pass;
 
glGenProgramPipelines(1, pipe);
glUseProgramStages(*pipe,
-- 
2.6.3

___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] sso: Check piglit_link_check_status return value.

2015-11-17 Thread Vinson Lee 
Fixes Coverity "unchecked return value" defect.

Signed-off-by: Vinson Lee 
---
 tests/spec/arb_separate_shader_objects/active-sampler-conflict.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/spec/arb_separate_shader_objects/active-sampler-conflict.c 
b/tests/spec/arb_separate_shader_objects/active-sampler-conflict.c
index 0a91f49..1c94b43 100644
--- a/tests/spec/arb_separate_shader_objects/active-sampler-conflict.c
+++ b/tests/spec/arb_separate_shader_objects/active-sampler-conflict.c
@@ -124,7 +124,7 @@ setup_program(GLuint *prog, GLuint *pipe, GLuint *vao,
 
*prog = glCreateShaderProgramv(GL_FRAGMENT_SHADER, 1,
  (const GLchar *const *) fs_code);
-   piglit_link_check_status(*prog);
+   pass = piglit_link_check_status(*prog) && pass;
 
glGenProgramPipelines(1, pipe);
glUseProgramStages(*pipe,
-- 
2.6.3

___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit