Re: [Piglit] [PATCH 1/2] shader_runner: fix error checking on MapBuffer gles workaround

2019-04-11 Thread Eric Engestrom 
On Thursday, 2019-04-11 11:14:41 +0200, Alejandro Piñeiro wrote:
> ---
>  tests/shaders/shader_runner_gles_workarounds.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/shaders/shader_runner_gles_workarounds.h 
> b/tests/shaders/shader_runner_gles_workarounds.h
> index d3ab77506..77956f6b9 100644
> --- a/tests/shaders/shader_runner_gles_workarounds.h
> +++ b/tests/shaders/shader_runner_gles_workarounds.h
> @@ -79,7 +79,7 @@ glMapBuffer(GLenum target, GLbitfield access)
>   GLsizeiptr length = 0;
>  
>   glGetBufferParameteri64v(target, GL_BUFFER_SIZE, (GLint64*) );
> - if (piglit_check_gl_error(GL_NO_ERROR))
> + if (!piglit_check_gl_error(GL_NO_ERROR))

This patch is:
Reviewed-by: Eric Engestrom 

>   piglit_report_result(PIGLIT_FAIL);
>  
>   return glMapBufferRange(target, 0, length, access);
> -- 
> 2.19.1
> 
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH 1/2] shader_runner: fix error checking on MapBuffer gles workaround

2019-04-11 Thread Alejandro Piñeiro 
---
 tests/shaders/shader_runner_gles_workarounds.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/shaders/shader_runner_gles_workarounds.h 
b/tests/shaders/shader_runner_gles_workarounds.h
index d3ab77506..77956f6b9 100644
--- a/tests/shaders/shader_runner_gles_workarounds.h
+++ b/tests/shaders/shader_runner_gles_workarounds.h
@@ -79,7 +79,7 @@ glMapBuffer(GLenum target, GLbitfield access)
GLsizeiptr length = 0;
 
glGetBufferParameteri64v(target, GL_BUFFER_SIZE, (GLint64*) );
-   if (piglit_check_gl_error(GL_NO_ERROR))
+   if (!piglit_check_gl_error(GL_NO_ERROR))
piglit_report_result(PIGLIT_FAIL);
 
return glMapBufferRange(target, 0, length, access);
-- 
2.19.1

___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit