Re: [Piglit] [PATCH] polygon-mode-facing: verify facing information is preserved with unfilled prims

2015-12-28 Thread Roland Scheidegger 
Ah yes, I'll add that before commiting.

Roland

Am 23.12.2015 um 02:04 schrieb Dylan Baker:
> You'll need to add this to all.py
> 
> On Tue, Dec 22, 2015 at 10:05 AM,  > wrote:
> 
> From: Roland Scheidegger  >
> 
> This test is quite mean to mesa's draw pipe. llvmpipe/softpipe fail
> even if
> front and back fill mode is the same (for points and aa lines as the
> latter
> get rendered as tris finally again). Most everything else fails too,
> before
> the driver dies in a fire...
> ---
>  tests/general/CMakeLists.gl.txt |   1 +
>  tests/general/polygon-mode-facing.c | 381
> 
>  2 files changed, 382 insertions(+)
>  create mode 100644 tests/general/polygon-mode-facing.c
> 
> diff --git a/tests/general/CMakeLists.gl.txt
> b/tests/general/CMakeLists.gl.txt
> index 298f59c..8f291db 100644
> --- a/tests/general/CMakeLists.gl.txt
> +++ b/tests/general/CMakeLists.gl.txt
> @@ -86,6 +86,7 @@ piglit_add_executable (pbo-teximage-tiling-2
> pbo-teximage-tiling-2.c)
>  piglit_add_executable (point-line-no-cull point-line-no-cull.c)
>  piglit_add_executable (point-vertex-id point-vertex-id.c)
>  piglit_add_executable (polygon-mode-offset polygon-mode-offset.c)
> +piglit_add_executable (polygon-mode-facing polygon-mode-facing.c)
>  piglit_add_executable (polygon-mode polygon-mode.c)
>  piglit_add_executable (polygon-offset polygon-offset.c)
>  piglit_add_executable (primitive-restart primitive-restart.c)
> diff --git a/tests/general/polygon-mode-facing.c
> b/tests/general/polygon-mode-facing.c
> new file mode 100644
> index 000..f107616
> --- /dev/null
> +++ b/tests/general/polygon-mode-facing.c
> @@ -0,0 +1,381 @@
> +/*
> + * Copyright (c) 2011 VMware, Inc.
> + *
> + * Permission is hereby granted, free of charge, to any person
> obtaining a
> + * copy of this software and associated documentation files (the
> "Software"),
> + * to deal in the Software without restriction, including without
> limitation
> + * on the rights to use, copy, modify, merge, publish, distribute, sub
> + * license, and/or sell copies of the Software, and to permit
> persons to whom
> + * the Software is furnished to do so, subject to the following
> conditions:
> + *
> + * The above copyright notice and this permission notice (including
> the next
> + * paragraph) shall be included in all copies or substantial
> portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + * NON-INFRINGEMENT.  IN NO EVENT SHALL VMWARE AND/OR THEIR SUPPLIERS
> + * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
> + * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
> + * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
> + * SOFTWARE.
> + */
> +
> +/**
> + * Tests glPolygonMode wrt facing.
> + * Roland Scheidegger
> + * December 2015
> + */
> +
> +#include "piglit-util-gl.h"
> +
> +PIGLIT_GL_TEST_CONFIG_BEGIN
> +
> +   config.supports_gl_compat_version = 20;
> +
> +   config.window_width = 400;
> +   config.window_height = 100;
> +   config.window_visual = PIGLIT_GL_VISUAL_RGB |
> PIGLIT_GL_VISUAL_DOUBLE;
> +
> +PIGLIT_GL_TEST_CONFIG_END
> +
> +static const char *TestName = "polygon-mode-facing";
> +
> +static const char *vstext =
> +"#version 130\n"
> +"\n"
> +"void main()\n"
> +"{\n"
> +"  gl_Position = gl_ModelViewProjectionMatrix * gl_Vertex;\n"
> +"}\n";
> +
> +static const char *fstext =
> +"#version 130\n"
> +"\n"
> +"void main()\n"
> +"{\n"
> +"  vec4 color = gl_FrontFacing ? vec4(1.0, 0.0, 0.0, 1.0)\n"
> +"  : vec4(0.0, 1.0, 0.0, 1.0);\n"
> +"  gl_FragColor = color;\n"
> +"}\n";
> +
> +
> +static const GLfloat Colors[2][4] = {
> +   /* back color */
> +   {0, 1, 0, 1},
> +   /* front color */
> +   {1, 0, 0, 1},
> +};
> +
> +static const GLfloat Positions[16][2] = {
> +   {10, 10},
> +   {90, 10},
> +   {90, 90},
> +   {10, 90},
> +
> +   {190, 10},
> +   {110, 10},
> +   {110, 90},
> +   {190, 90},
> +
> +   {290, 10},
> +   {210, 10},
> +   {210, 90},
> +   {290, 90},
> +
> +   {310, 10},
> +   {390, 10},
>

Re: [Piglit] [PATCH 4/7] all.py: add arb_framebuffer_srgb-srgb_conformance

2015-12-28 Thread Roland Scheidegger 
Am 24.12.2015 um 01:34 schrieb baker.dyla...@gmail.com:
> From: Dylan Baker 
> 
> This wasn't added to all.py.
> 
> cc: Roland Scheidegger 
> Signed-off-by: Dylan Baker 
> ---
>  tests/all.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/all.py b/tests/all.py
> index dce7456..f2cd6ae 100644
> --- a/tests/all.py
> +++ b/tests/all.py
> @@ -2053,6 +2053,7 @@ with profile.group_manager(
> 'single-sample'],
>'fbo-fast-clear')
>  g(['arb_framebuffer_srgb-fast-clear-blend'])
> +g(['arb_framebuffer_srgb-srgb_conformance'])
>  
>  with profile.group_manager(
>  PiglitGLTest,
> 

Reviewed-by: Roland Scheidegger 
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit