Re: [Pixman] pixman-0.32.6 fails to build on mips32r2
Hi Vincent, Thanks. I'll push it in the following days. Kind Regards, Nemanja Lukic -Original Message- From: Vicente Olivert Riera [mailto:vincent.ri...@imgtec.com] Sent: Friday, September 12, 2014 4:19 PM To: Nemanja Lukic Cc: pixman@lists.freedesktop.org Subject: Re: pixman-0.32.6 fails to build on mips32r2 Hello Nemanja, I have attached the new patch to the bug report: https://bugs.freedesktop.org/show_bug.cgi?id=83358#c1 Could you please commit it upstream? Thank you. On 09/11/2014 11:02 AM, Vicente Olivert Riera wrote: On 09/11/2014 10:57 AM, Nemanja Lukic wrote: Hi Vincent, Patch I sent to you was not intended for pushing upstream :) It was just for check. Ah, ok, I see :P Sorry about that then. Your patch LGTM, and it should be pushed on Pixman trunk. Thanks! Could you please let me know when you push it? And also, could you please update the bug report and close it as resolved/fixed? Thanks, Thanks to you Nemanja :) Nemanja Lukic -Original Message- From: Vicente Olivert Riera [mailto:vincent.ri...@imgtec.com] Sent: Thursday, September 11, 2014 11:34 AM To: Nemanja Lukic Cc: pixman@lists.freedesktop.org Subject: Re: pixman-0.32.6 fails to build on mips32r2 Hello Nemanja, yes, it works. But your patch wrong because it can't be applied without reverting your last commit which was already pushed upstream. So, the right solution would be to apply a new patch which removes the wrong lines and add the right lines. I have attached a valid patch to this email. Please, check it. Thanks. On 09/11/2014 10:02 AM, Nemanja Lukic wrote: Hi Vincent, Please take a look at attached fix. This one should solve the problem, without duplicating LEAF_MIPS32R2 macro. Trick is to use pre-processor on the right level. Please check on your side, Nemanja Lukic -Original Message- From: Vicente Olivert Riera [mailto:vincent.ri...@imgtec.com] Sent: Thursday, September 4, 2014 1:51 PM To: pixman@lists.freedesktop.org Cc: nemanja.lu...@rt-rk.com Subject: pixman-0.32.6 fails to build on mips32r2 Could you please have a look to this bug report? https://bugs.freedesktop.org/show_bug.cgi?id=83358 Thank you. -- Vincent -- Vincent ___ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pixman
Re: [Pixman] pixman-0.32.6 fails to build on mips32r2
Hello Nemanja, I have attached the new patch to the bug report: https://bugs.freedesktop.org/show_bug.cgi?id=83358#c1 Could you please commit it upstream? Thank you. On 09/11/2014 11:02 AM, Vicente Olivert Riera wrote: On 09/11/2014 10:57 AM, Nemanja Lukic wrote: Hi Vincent, Patch I sent to you was not intended for pushing upstream :) It was just for check. Ah, ok, I see :P Sorry about that then. Your patch LGTM, and it should be pushed on Pixman trunk. Thanks! Could you please let me know when you push it? And also, could you please update the bug report and close it as resolved/fixed? Thanks, Thanks to you Nemanja :) Nemanja Lukic -Original Message- From: Vicente Olivert Riera [mailto:vincent.ri...@imgtec.com] Sent: Thursday, September 11, 2014 11:34 AM To: Nemanja Lukic Cc: pixman@lists.freedesktop.org Subject: Re: pixman-0.32.6 fails to build on mips32r2 Hello Nemanja, yes, it works. But your patch wrong because it can't be applied without reverting your last commit which was already pushed upstream. So, the right solution would be to apply a new patch which removes the wrong lines and add the right lines. I have attached a valid patch to this email. Please, check it. Thanks. On 09/11/2014 10:02 AM, Nemanja Lukic wrote: Hi Vincent, Please take a look at attached fix. This one should solve the problem, without duplicating LEAF_MIPS32R2 macro. Trick is to use pre-processor on the right level. Please check on your side, Nemanja Lukic -Original Message- From: Vicente Olivert Riera [mailto:vincent.ri...@imgtec.com] Sent: Thursday, September 4, 2014 1:51 PM To: pixman@lists.freedesktop.org Cc: nemanja.lu...@rt-rk.com Subject: pixman-0.32.6 fails to build on mips32r2 Could you please have a look to this bug report? https://bugs.freedesktop.org/show_bug.cgi?id=83358 Thank you. -- Vincent -- Vincent ___ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pixman
Re: [Pixman] pixman-0.32.6 fails to build on mips32r2
Hello Nemanja, yes, it works. But your patch wrong because it can't be applied without reverting your last commit which was already pushed upstream. So, the right solution would be to apply a new patch which removes the wrong lines and add the right lines. I have attached a valid patch to this email. Please, check it. Thanks. On 09/11/2014 10:02 AM, Nemanja Lukic wrote: Hi Vincent, Please take a look at attached fix. This one should solve the problem, without duplicating LEAF_MIPS32R2 macro. Trick is to use pre-processor on the right level. Please check on your side, Nemanja Lukic -Original Message- From: Vicente Olivert Riera [mailto:vincent.ri...@imgtec.com] Sent: Thursday, September 4, 2014 1:51 PM To: pixman@lists.freedesktop.org Cc: nemanja.lu...@rt-rk.com Subject: pixman-0.32.6 fails to build on mips32r2 Could you please have a look to this bug report? https://bugs.freedesktop.org/show_bug.cgi?id=83358 Thank you. -- Vincent From 3a60aa8d574f4dfc4fa3ddb13aaa13c7d955105b Mon Sep 17 00:00:00 2001 From: Vicente Olivert Riera vincent.ri...@imgtec.com Date: Thu, 11 Sep 2014 10:24:10 +0100 Subject: [PATCH] Fix C pre-processor issues in LEAF_MIPS32R2 Signed-off-by: Vicente Olivert Riera vincent.ri...@imgtec.com --- pixman/pixman-mips-dspr2-asm.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pixman/pixman-mips-dspr2-asm.h b/pixman/pixman-mips-dspr2-asm.h index 11849bd..b2696d0 100644 --- a/pixman/pixman-mips-dspr2-asm.h +++ b/pixman/pixman-mips-dspr2-asm.h @@ -72,10 +72,10 @@ #define LEAF_MIPS32R2(symbol) \ .globl symbol; \ .align 2; \ -#ifdef __ELF__ +.if __ELF__;\ .hidden symbol; \ .type symbol, @function; \ -#endif +.endif; \ .entsymbol, 0; \ symbol: .frame sp, 0, ra; \ .setpush; \ -- 1.7.1 ___ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pixman
