[pkg-go] Bug#898651: fakemachine: missing dependencies

2018-05-14 Thread Simon McVittie
Control: tags 898651 + patch

On Mon, 14 May 2018 at 18:34:23 +0100, Simon McVittie wrote:
> Please consider the attached patch.

Note that this doesn't do anything for dependent packages like
debos, which will probably need similar dependencies.

What I proposed adding to fakemachine, which debos should probably also
get, are:

Architecture: amd64
Depends: busybox | busybox-static, qemu-system-x86, systemd
Recommends: e2fsprogs, linux-image-amd64

Thanks,
smcv

___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-go-maintainers

[pkg-go] Bug#898651: fakemachine: missing dependencies

2018-05-14 Thread Simon McVittie
Package: fakemachine
Version: 0.0~git20180126.e307c2f-1
Severity: grave
Justification: renders package unusable

In a relatively minimal (buildd) chroot:

smcv@archetype(sid-amd64):~$ sudo apt install fakemachine hello
...
smcv@archetype(sid-amd64):~$ fakemachine hello
2018/05/14 16:31:15 open failed: /bin/busybox - open /bin/busybox: no such file 
or directory
panic: open failed: /bin/busybox - open /bin/busybox: no such file or directory
smcv@archetype(sid-amd64):~$ sudo apt install busybox
...
smcv@archetype(sid-amd64):~$ fakemachine hello; echo $?
255
smcv@archetype(sid-amd64):~$ sudo apt install --no-install-recommends 
linux-image-amd64 qemu-system-x86
...
smcv@archetype(sid-amd64):~$ fakemachine hello; echo $?
...
Running hello
Hello, world!
Powering off.
[4.471990] reboot: Power down
0

fakemachine should have dependencies (or at least Recommends) on:

* busybox | busybox-static
* systemd
* linux-image-amd64 [1]
* qemu-system-x86   [2]

[1] Perhaps with linux-image-generic (Ubuntu), etc., as alternatives.
Upstream only supports x86_64 hosts, for which I've opened separate
bugs.
[2] Use of qemu-system-x86_64 is currently hard-coded.

By inspection of its source code, it should also have at least a Suggests
(probably a Recommends) on e2fsprogs, for mkfs.ext4.

Please consider the attached patch.

Thanks,
smcv
>From 67763c9fa94d9088537a314dbf050f69ac9af760 Mon Sep 17 00:00:00 2001
From: Simon McVittie 
Date: Mon, 14 May 2018 18:24:26 +0100
Subject: [PATCH 3/3] Add missing dependencies

Signed-off-by: Simon McVittie 
---
 debian/control | 7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/debian/control b/debian/control
index 53c7ded..93ee761 100644
--- a/debian/control
+++ b/debian/control
@@ -23,8 +23,13 @@ Testsuite: autopkgtest-pkg-go
 Package: fakemachine
 Architecture: amd64
 Built-Using: ${misc:Built-Using}
-Depends: ${shlibs:Depends},
+Depends: busybox | busybox-static,
+ qemu-system-x86,
+ systemd,
+ ${shlibs:Depends},
  ${misc:Depends}
+Recommends: e2fsprogs,
+linux-image-amd64
 Description: create and spawn virtual machines for building images with debos.
  Create and spawn virtual machines for building images with debos tool.
 
-- 
2.17.0

___
Pkg-go-maintainers mailing list
Pkg-go-maintainers@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-go-maintainers