Bug#866375: cabal-debian does not generate shlibs:Depends for -utils pacakges

2017-06-29 Thread Kei Hibino 
Package: cabal-debian
Version: 4.35.6-1+b1
Severity: important
Tags: patch

Dear Maintainer,

I made example sequence of cabal-debian like following.
`Depends:' block generated by cabal-debian which does not
contain `${shlibs:Depends}' variable.
So dependencies to shared object
which are linked by executables in haskell-*-utils packages
will be not generated.

---
 % cabal unpack text-ldap-0.1.1.8
Unpacking to text-ldap-0.1.1.8/
 % cd text-ldap-0.1.1.8
 % cabal-debian
 % egrep -A 5 haskell-text-ldap-utils debian/control
Package: haskell-text-ldap-utils
Architecture: any
Section: misc
Depends: ${haskell:Depends},
 ${misc:Depends},
Recommends: ${haskell:Recommends},
---

I made a small patch to fix this problem like following.

---
--- cabal-debian-4.35.6.orig/src/Debian/Debianize/Finalize.hs
+++ cabal-debian-4.35.6/src/Debian/Debianize/Finalize.hs
@@ -411,6 +411,8 @@ binaryPackageRelations b typ = zoom A.de
 when (typ == B.Development) $ do
   B.depends %= (edds ++)
   B.depends %= (anyrel "${shlibs:Depends}" : )
+when (typ == B.Utilities) $
+  B.depends %= (anyrel "${shlibs:Depends}" : )
 B.depends%= ([anyrel "${haskell:Depends}", anyrel "${misc:Depends}"] 
++)
 B.recommends %= (anyrel "${haskell:Recommends}" : )
 B.suggests   %= (anyrel "${haskell:Suggests}" :)
---

This problem affects cabal-debian package in Debian stretch too.


-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-3-amd64 (SMP w/40 CPU cores)
Locale: LANG=ja_JP.UTF-8, LC_CTYPE=ja_JP.UTF-8 (charmap=UTF-8), 
LANGUAGE=ja_JP:ja:en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages cabal-debian depends on:
ii  debhelper   10.5.1
ii  libbz2-1.0  1.0.6-8.1
ii  libc6   2.24-12
ii  libffi6 3.2.1-6
ii  libgmp102:6.1.2+dfsg-1
ii  zlib1g  1:1.2.8.dfsg-5

Versions of packages cabal-debian recommends:
ii  apt-file  3.1.4

cabal-debian suggests no packages.

-- no debconf information
--- cabal-debian-4.35.6.orig/src/Debian/Debianize/Finalize.hs
+++ cabal-debian-4.35.6/src/Debian/Debianize/Finalize.hs
@@ -411,6 +411,8 @@ binaryPackageRelations b typ = zoom A.de
 when (typ == B.Development) $ do
   B.depends %= (edds ++)
   B.depends %= (anyrel "${shlibs:Depends}" : )
+when (typ == B.Utilities) $
+  B.depends %= (anyrel "${shlibs:Depends}" : )
 B.depends%= ([anyrel "${haskell:Depends}", anyrel "${misc:Depends}"] 
++)
 B.recommends %= (anyrel "${haskell:Recommends}" : )
 B.suggests   %= (anyrel "${haskell:Suggests}" :)
___
Pkg-haskell-maintainers mailing list
Pkg-haskell-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-haskell-maintainers

Bug#850920: Cabal-debian bundled packages

2017-01-23 Thread Kei Hibino 
Hi Gianfranco,

I think this outout is good because this build-depends does not
contain built-in package with version constraint.

On Thu, Jan 19, 2017 at 11:02 PM, Gianfranco Costamagna
 wrote:
> Hello Kei,
> On Tue, 17 Jan 2017 19:42:57 + David Fox  wrote:
>> Fortunately or unfortunately, I made extensive changes to this code in
>> November:
>>
>
> I did apply your patch and the head result didn't change
>
>> https://github.com/ddssff/cabal-debian/commit/480f4f099657a20eb46a45c0ca5f492038773e5b
>>
>> Could you test the latest version of cabal-debian and see if it resolves
>> your issue?  Thanks!
> this version returns the following (in a clean sid chroot)
>
> head -12 debian/control
> Source: haskell-time-locale-compat
> Maintainer: Debian Haskell Group 
> 
> Priority: extra
> Section: haskell
> Build-Depends: debhelper (>= 10),
>  haskell-devscripts-minimal | haskell-devscripts (>= 0.8),
>  cdbs,
>  ghc,
>  ghc-prof,
>  libghc-old-locale-dev,
>  libghc-old-locale-prof,
> Build-Depends-Indep: ghc-doc,
>
> is that good?
>
> package is available here [1]
>
> [1] 
> http://debomatic-amd64.debian.net/distribution#unstable/cabal-debian/4.35.6-1/lintian
>
> G.
>
>
>
> ___
> Pkg-haskell-maintainers mailing list
> Pkg-haskell-maintainers@lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-haskell-maintainers

___
Pkg-haskell-maintainers mailing list
Pkg-haskell-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-haskell-maintainers

Bug#850920: cabal-debian fails to detect GHC built-in packages

2017-01-11 Thread Kei Hibino 
Package: cabal-debian
Version: 4.33-4
Severity: important
Tags: patch

Dear Maintainer,

I made example sequence of cabal-debian like following.
Build-depends lines are generated by cabal-debian
like 'libghc-base-dev (<< 5)' and 'libghc-base-prof (<< 5)',
but 'base' is GHC built-in package which provided by
'ghc' debian package. So these version constraints are wrong.
It is not expected that version constraints are produced
with built-in packages.

--
$ cabal unpack time-locale-compat-0.1.1.3
Unpacking to time-locale-compat-0.1.1.3/
$ cd time-locale-compat-0.1.1.3
$ tail -21 time-locale-compat.cabal | head -3

  build-depends: base <5

$ cabal-debian
$ head -12 debian/control
Source: haskell-time-locale-compat
Maintainer: Debian Haskell Group 

Priority: extra
Section: haskell
Build-Depends: debhelper (>= 10),
 haskell-devscripts (>= 0.8),
 cdbs,
 ghc,
 ghc-prof,
 libghc-base-dev (<< 5),
 libghc-base-prof (<< 5),
 libghc-old-locale-dev,
--

I made a small patch to fix this problem like following.

--
--- cabal-debian-4.33.orig/src/Debian/Debianize/Bundled.hs  2016-10-07 
04:13:42.0 +0900
+++ cabal-debian-4.33/src/Debian/Debianize/Bundled.hs   2017-01-09 
21:43:40.231080418 +0900
@@ -105,7 +105,7 @@
 lns = lines $ unsafePerformIO (chroot root (readProcess "dpkg" 
["-L", unBinPkgName hcname] ""))
 parseLib :: String -> Maybe PackageIdentifier
 parseLib s =
-case s =~ ("(.*)-([0-9.]*)-(.*).conf$") :: (String, 
String, String, [String]) of
+case s =~ ("(.*)-([0-9.]*)(-.*)?.conf$") :: (String, 
String, String, [String]) of
   (_, _, _, [cabalName, ver, _sum]) ->
   case parseVersion' ver of
 Just v -> Just (PackageIdentifier (PackageName 
cabalName) v)

--


-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.8.0-2-amd64 (SMP w/40 CPU cores)
Locale: LANG=ja_JP.UTF-8, LC_CTYPE=ja_JP.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages cabal-debian depends on:
ii  debhelper   10.2.3
ii  libbz2-1.0  1.0.6-8
ii  libc6   2.24-8
ii  libffi6 3.2.1-6
ii  libgmp102:6.1.2+dfsg-1
ii  zlib1g  1:1.2.8.dfsg-4

Versions of packages cabal-debian recommends:
ii  apt-file  3.1.3

cabal-debian suggests no packages.

-- no debconf information

___
Pkg-haskell-maintainers mailing list
Pkg-haskell-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-haskell-maintainers