Bug#837021: openjfx: FTBFS: PosixPlatform.cpp:235:10: error: 'wait' was not declared in this scope

[Emmanuel Bourg]

Control: tags -1 + help

I took a look at this issue, most of the errors can be fixed by adding
the -std=gnu++98 flag when building the fxpackager module (by patching
the LINUX.launcherlibrary.ccFlags line in the buildSrc/linux.gradle file).

There is one error left though:

  modules/fxpackager/src/main/native/library/common/PosixPlatform.cpp: In 
member function ‘virtual bool PosixProcess::Wait()’:
  modules/fxpackager/src/main/native/library/common/PosixPlatform.cpp:235:10: 
error: ‘wait’ was not declared in this scope
   wait();
^

I'm not sure to understand why this no longer works with GCC 6. I think
I've figured out a fix but I need a C expert to review it:

  --- a/modules/fxpackager/src/main/native/library/common/PosixPlatform.cpp
  +++ b/modules/fxpackager/src/main/native/library/common/PosixPlatform.cpp
  @@ -46,6 +46,7 @@
   #include 
   #include 
   #include 
  +#include 
  
  
   PosixPlatform::PosixPlatform(void) {
  @@ -227,17 +228,17 @@ bool PosixProcess::Execute(const TString Application, 
const std::vector
   bool PosixProcess::Wait() {
   bool result = false;
  
   int status;
   pid_t wpid;
  
   //TODO Use waitpid instead of wait
   #ifdef LINUX
  -wait();
  +wait(&status);
   #endif
   #ifdef MAC
   wpid = wait(&status);
   #endif
  
   if (!WIFEXITED(status) || WEXITSTATUS(status) != 0) {
   if (errno != EINTR){
   status = -1;

__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Processed: Re: Bug#837021: openjfx: FTBFS: PosixPlatform.cpp:235:10: error: 'wait' was not declared in this scope

[Debian Bug Tracking System]

Processing control commands:

> tags -1 + help
Bug #837021 [src:openjfx] openjfx: FTBFS: PosixPlatform.cpp:235:10: error: 
'wait' was not declared in this scope
Added tag(s) help.

-- 
837021: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=837021
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#837021: openjfx: FTBFS: PosixPlatform.cpp:235:10: error: 'wait' was not declared in this scope

[Lucas Nussbaum]

Source: openjfx
Version: 8u102-b14-1
Severity: serious
Tags: stretch sid
User: debian...@lists.debian.org
Usertags: qa-ftbfs-20160906 qa-ftbfs
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part (hopefully):
> g++ -Xlinker -s -static-libstdc++ -Wl,-O1 -shared -o libDumpRenderTreeJava.so 
> Release/obj/GCController.o Release/obj/TestRunner.o Release/obj/WorkQueue.o 
> Release/obj/DumpRenderTree.o Release/obj/GCControllerJava.o 
> Release/obj/JavaEnv.o Release/obj/TestRunnerJava.o 
> Release/obj/WorkQueueItemJava.o Release/obj/EventSender.o  
> -L../../Release/lib -lpthread -ljfxwebkit  
> mv -f libDumpRenderTreeJava.so ../../Release/lib/ 
> make[3]: Leaving directory 
> '/<>/modules/web/build/linux/Tools/DumpRenderTree'
> make[2]: Leaving directory '/<>/modules/web/build/linux/Release'
> 
> 
>  WebKit is now built (1h:03m:38s). 
>  To run FXLauncher with this newly-built code, use the
>  "Tools/Scripts/run-launcher" script.
> 
> :web:compileNativeLinux (Thread[main,5,main]) completed. Took 1 hrs 3 mins 
> 38.269 secs.
> :web:compileGeneratedLinux (Thread[main,5,main]) started.
> :web:compileGeneratedLinux
> Executing task ':web:compileGeneratedLinux' (up-to-date check took 0.075 
> secs) due to:
>   No history is available.
> All input files are considered out-of-date for incremental task 
> ':web:compileGeneratedLinux'.
> Compiling with Java command line compiler 
> '/usr/lib/jvm/java-8-openjdk-amd64/bin/javac'.
> Starting process 'command '/usr/lib/jvm/java-8-openjdk-amd64/bin/javac''. 
> Working directory: /<>/modules/web Command: 
> /usr/lib/jvm/java-8-openjdk-amd64/bin/javac 
> @/<>/modules/web/build/tmp/compileGeneratedLinux/java-compiler-args.txt
> Successfully started process 'command 
> '/usr/lib/jvm/java-8-openjdk-amd64/bin/javac''
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> :web:compileGeneratedLinux (Thread[main,5,main]) completed. Took 3.056 secs.
> :web:compileGenerated (Thread[main,5,main]) started.
> :web:compileGenerated
> Skipping task ':web:compileGenerated' as it has no actions.
> :web:compileGenerated (Thread[main,5,main]) completed. Took 0.0 secs.
> :web:drtJar (Thread[main,5,main]) started.
> :web:drtJar
> Executing task ':web:drtJar' (up-to-date check took 0.007 secs) due to:
>   No history is available.
> :web:drtJar (Thread[main,5,main]) completed. Took 0.028 secs.
> :web:jar (Thread[main,5,main]) started.
> :web:jar
> Executing task ':web:jar' (up-to-date check took 0.02 secs) due to:
>   No history is available.
> :web:jar (Thread[main,5,main]) completed. Took 0.166 secs.
> :builders:compileJava (Thread[main,5,main]) started.
> :builders:compileJava
> Executing task ':builders:compileJava' (up-to-date check took 0.046 secs) due 
> to:
>   No history is available.
> All input files are considered out-of-date for incremental task 
> ':builders:compileJava'.
> Compiling with Java command line compiler 
> '/usr/lib/jvm/java-8-openjdk-amd64/bin/javac'.
> Starting process 'command '/usr/lib/jvm/java-8-openjdk-amd64/bin/javac''. 
> Working directory: /<>/modules/builders Command: 
> /usr/lib/jvm/java-8-openjdk-amd64/bin/javac 
> @/<>/modules/builders/build/tmp/compileJava/java-compiler-args.txt
> Successfully started process 'command 
> '/usr/lib/jvm/java-8-openjdk-amd64/bin/javac''
> Note: 
> /<>/modules/builders/src/main/java/javafx/scene/web/WebViewBuilder.java
>  uses or overrides a deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> :builders:compileJava (Thread[main,5,main]) completed. Took 3.794 secs.
> :builders:processResources (Thread[main,5,main]) started.
> :builders:processResources
> file or directory '/<>/modules/builders/src/main/resources', not 
> found
> Skipping task ':builders:processResources' as it has no source files.
> :builders:processResources UP-TO-DATE
> :builders:processResources (Thread[main,5,main]) completed. Took 0.001 secs.
> :builders:classes (Thread[main,5,main]) started.
> :builders:classes
> Skipping task ':builders:classes' as it has no actions.
> :builders:classes (Thread[main,5,main]) completed. Took 0.0 secs.
> :builders:jar (Thread[main,5,main]) started.
> :builders:jar
> Executing task ':builders:jar' (up-to-date check took 0.003 secs) due to:
>   No history is available.
> :builders:jar (Thread[main,5,main]) completed. Took 0.053 secs.
> :builders:assemble (Thread[main,5,main]) started.
> :builders:assemble
> Skipping task ':builders:assemble' as it has no actions.
> :builders:assemble (Thread[main,5,main]) completed. Took 0.0 secs.
> :controls:assemble (Thread[main,5,main]) started.
> :controls:assemble
> Skipping task ':contro