[Pkg-javascript-devel] Bug#1068750: moment-timezone.js: FTBFS everywhere
Hi Santiago, On 30/04/2024 14:01, Santiago Vila wrote: It fails to build if tzdata is updated, but it never stops working. It just needs to be updated as often as tzdata is. But if you have a suggestion to make this more automatic, I would love to hear it.. Sorry, I still don't get it. Why does the package build needs to fail if tzdata is updated? What happens if we allow the package to be built anyway? (as in the attached patch). Would the resulting package be broken in any way? It works, but then there is no way to embed the (effective) tzdata version into the moment-timezone.js version, so you could have identical source packages producing binaries with the same version and different contents, and no way to depend on it. Plus, it almost always fails to build anyway, because many of the tests need to be adjusted when tzdata changes. The (better) alternative would be to make it always use a fixed tzdata version, but then tzdata migrations will be blocked each time until I upload a new version. I have been doing this very repetitive maintenance for years! Well, I get that you have to make a new upload so that the package is current. What I don't get is that the package fails to build. At most, it would result in an improved package, not worse. Or maybe I'm missing anything. What I described above, but I am really open to suggestions on how to better handle this. -- Martina Ferrari -- Pkg-javascript-devel mailing list Pkg-javascript-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#1068750: moment-timezone.js: FTBFS everywhere
Hi Santiago, On Wed, 10 Apr 2024 12:39:54 +0200 Santiago Vila wrote: Dear maintainer: This package currently fails to build from source in all supported distributions. # Fail the build if the tzdata package does not match TZVER. grep -q '^# version 2023d$' /usr/share/zoneinfo/tzdata.zi Yes, this is expected after each update to tzdata. I'm curious: Does this package embed the information from tzdata into javascript code, in such a way that a change in tzdata requires a rebuild? Yes. It is the only way I found to keep the package aligned with tzdata while ensuring it is fully built from source: upstream ships the pre-compiled tzdata information, so I regenerate those files using the tzdata package. I think it would be highly desirable to find a way for this package to do what it's supposed to do without having to fix it in oldstable and stable every year. Without a new upload, I cannot imagine how.. :-/ (In fact, I asked Paul Gevers about this, he says that a package which we know for sure that it will fail to build during the support time of the release is RC). It fails to build if tzdata is updated, but it never stops working. It just needs to be updated as often as tzdata is. But if you have a suggestion to make this more automatic, I would love to hear it.. I have been doing this very repetitive maintenance for years! -- Martina Ferrari -- Pkg-javascript-devel mailing list Pkg-javascript-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#1042336: moment-timezone.js: FTBFS: cp: cannot stat '/usr/share/zoneinfo/posix/*': No such file or directory
Sorry this took longer than expected. It turns out that the Ubuntu patch did not work, and it took me a while to find that many of the zone info symlinks had moved to tzdata-legacy. I have not just uploaded the fixed package, finally. On 13/09/2023 18:03, Martina Ferrari wrote: Hi, Thanks Daniel for spotting this, somehow I had missed all notifications and did not even realise Prometheus was about to be removed from testing :( I have just ported the patch from Benjamin and after I finish building the package I will upload it. On 10/09/2023 06:50, Daniel Swarbrick wrote: On Wed, 26 Jul 2023 22:08:15 +0200 Lucas Nussbaum wrote: > Relevant part (hopefully): > > mkdir -p temp/zic/2023c temp/zdump/2023c > > cp -RL /usr/share/zoneinfo/posix/* temp/zic/2023c/ > > cp: cannot stat '/usr/share/zoneinfo/posix/*': No such file or directory > > make[1]: *** [debian/rules:51: data/unpacked/2023c.json] Error 1 This appears to have broken due to a change in the tzdata package which landed in both Debian and Ubuntu[1]. The Ubuntu moment-timezone.js package was adapted[2] to accommodate this change, but the Debian package was not. [1]: https://bugs.launchpad.net/ubuntu/+source/tzdata/+bug/2008076 [2]: https://git.launchpad.net/ubuntu/+source/moment-timezone.js/commit/debian?h=applied/ubuntu/lunar -- Martina Ferrari (Tina) -- Pkg-javascript-devel mailing list Pkg-javascript-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#1042336: moment-timezone.js: FTBFS: cp: cannot stat '/usr/share/zoneinfo/posix/*': No such file or directory
Hi, Thanks Daniel for spotting this, somehow I had missed all notifications and did not even realise Prometheus was about to be removed from testing :( I have just ported the patch from Benjamin and after I finish building the package I will upload it. On 10/09/2023 06:50, Daniel Swarbrick wrote: On Wed, 26 Jul 2023 22:08:15 +0200 Lucas Nussbaum wrote: > Relevant part (hopefully): > > mkdir -p temp/zic/2023c temp/zdump/2023c > > cp -RL /usr/share/zoneinfo/posix/* temp/zic/2023c/ > > cp: cannot stat '/usr/share/zoneinfo/posix/*': No such file or directory > > make[1]: *** [debian/rules:51: data/unpacked/2023c.json] Error 1 This appears to have broken due to a change in the tzdata package which landed in both Debian and Ubuntu[1]. The Ubuntu moment-timezone.js package was adapted[2] to accommodate this change, but the Debian package was not. [1]: https://bugs.launchpad.net/ubuntu/+source/tzdata/+bug/2008076 [2]: https://git.launchpad.net/ubuntu/+source/moment-timezone.js/commit/debian?h=applied/ubuntu/lunar -- Martina Ferrari (Tina) -- Pkg-javascript-devel mailing list Pkg-javascript-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#1036259: moment-timezone.js: FTBFS in testing: make[1]: *** [debian/rules:28: execute_before_dh_auto_configure] Error 1
Update: I have just uploaded the package, force-pushed my changes to master, and submitted the unblock request: #1037049 On 02/06/2023 19:13, Martina Ferrari wrote: On Sun, 28 May 2023 18:15:14 +0200 gregor herrmann wrote: On Sun, 28 May 2023 20:05:09 +0400, Yadd wrote: > > This looked reasonably easy to fix (cf. attached patch), but the > > tests fail as follows: > I fixed it in salsa (needs an update to import 2023 data). I'm waiting for > Martina review who maintains it. Ack, I've seen your commits in salsa but as the pipeline fails (probably the version in d/changelog?) and as a new upstream release 2 weeks before the release might not be accepted by the release team, I thougt I'd give it a try as well; but well, it was not that quick&easy :) Agreed. The upstream release is not much more than a repackaging of the Olson database and adjusting the tests to match, but the debdiff is enormous. Luckily, the debian/rules I wrote a few years ago takes care of updating the data files and tests based on the installed tzdata package (which should match the last part of the debian package version). The only thing that needs to be handled separately are the countries.js test file, which is manually maintained. So I just made a quilt patch based on the git diff from upstream. I have just prepared a new package like this, the debdiff is fairly minimal: $ debdiff moment-timezone.js_0.5.40+dfsg-1+2022g.dsc moment-timezone.js_0.5.40+dfsg-1+2023c.dsc | diffstat changelog | 10 ++ control | 4 ++-- patches/02-tzdata-2023c.patch | 42 ++ patches/series | 1 + 4 files changed, 55 insertions(+), 2 deletions(-) Sadly, Yadd changes were already pushed to master, so I will have to do some git history rewriting. Please update your local clones accordingly. -- Martina Ferrari (Tina) -- Pkg-javascript-devel mailing list Pkg-javascript-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#1037049: unblock: moment-timezone.js/0.5.40+dfsg-1+2023c
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: moment-timezone...@packages.debian.org, t...@debian.org
Control: affects -1 + src:moment-timezone.js
Please unblock package moment-timezone.js
(Please provide enough (but not too much) information to help
the release team to judge the request efficiently. E.g. by
filling in the sections below.)
[ Reason ]
This package currently FTBFS (#1036259) because it is out of sync with the
tzdata package.
[ Impact ]
Reverse dependencies risk being removed from testing, in particular prometheus.
[ Tests ]
Upstream provides copious amounts of tests; the only non-trivial change in the
package is a patch to backport changes made upstream to match changes in the
tzdata database.
[ Risks ]
None I can think of.
[ Checklist ]
[✓] all changes are documented in the d/changelog
[✓] I reviewed all changes and I approve them
[✓] attach debdiff against the package in testing
[ Other info ]
n/a
unblock moment-timezone.js/0.5.40+dfsg-1+2023c
diff -Nru moment-timezone.js-0.5.40+dfsg/debian/changelog
moment-timezone.js-0.5.40+dfsg/debian/changelog
--- moment-timezone.js-0.5.40+dfsg/debian/changelog 2023-01-23
21:37:52.0 +
+++ moment-timezone.js-0.5.40+dfsg/debian/changelog 2023-06-02
17:39:46.0 +
@@ -1,3 +1,13 @@
+moment-timezone.js (0.5.40+dfsg-1+2023c) unstable; urgency=medium
+
+ [ Yadd ]
+ * Declare compliance with policy 4.6.2
+
+ [ Martina Ferrari ]
+ * Rebuild to support tzdata 2023c. Closes: #1036259.
+
+ -- Martina Ferrari Fri, 02 Jun 2023 17:39:46 +
+
moment-timezone.js (0.5.40+dfsg-1+2022g) unstable; urgency=medium
* New upstream version 0.5.40. Closes: #1028879.
diff -Nru moment-timezone.js-0.5.40+dfsg/debian/control
moment-timezone.js-0.5.40+dfsg/debian/control
--- moment-timezone.js-0.5.40+dfsg/debian/control 2023-01-23
21:37:52.0 +
+++ moment-timezone.js-0.5.40+dfsg/debian/control 2023-06-02
17:39:46.0 +
@@ -10,8 +10,8 @@
, dh-sequence-nodejs
, uglifyjs
, ts-node
- , tzdata (>= 2022f)
-Standards-Version: 4.6.1
+ , tzdata (>= 2023c)
+Standards-Version: 4.6.2
Vcs-Browser: https://salsa.debian.org/js-team/moment-timezone.js
Vcs-Git: https://salsa.debian.org/js-team/moment-timezone.js.git
Homepage: https://momentjs.com/timezone/
diff -Nru moment-timezone.js-0.5.40+dfsg/debian/patches/02-tzdata-2023c.patch
moment-timezone.js-0.5.40+dfsg/debian/patches/02-tzdata-2023c.patch
--- moment-timezone.js-0.5.40+dfsg/debian/patches/02-tzdata-2023c.patch
1970-01-01 00:00:00.0 +
+++ moment-timezone.js-0.5.40+dfsg/debian/patches/02-tzdata-2023c.patch
2023-06-02 17:39:46.0 +
@@ -0,0 +1,42 @@
+Author: Martina Ferrari
+Date:Fri, 02 Jun 2023 17:34:39 +
+Description: Backport upstream changes to match version 2023c of the Olson
Database.
+
+--- a/tests/countries/countries.js
b/tests/countries/countries.js
+@@ -227,7 +227,7 @@
+ test.deepEqual(tz.zone('America/Whitehorse').countries(),
["CA"]);
+ test.deepEqual(tz.zone('America/Winnipeg').countries(), ["CA"]);
+ test.deepEqual(tz.zone('America/Yakutat').countries(), ["US"]);
+- test.deepEqual(tz.zone('America/Yellowknife').countries(),
["CA"]);
++ test.deepEqual(tz.zone('America/Yellowknife').countries(), []);
+ test.deepEqual(tz.zone('Antarctica/Casey').countries(), ["AQ"]);
+ test.deepEqual(tz.zone('Antarctica/Davis').countries(), ["AQ"]);
+
test.deepEqual(tz.zone('Antarctica/DumontDUrville').countries(), ["AQ"]);
+@@ -549,7 +549,7 @@
+ test.deepEqual(tz.zone('Pacific/Gambier').countries(), ["PF"]);
+ test.deepEqual(tz.zone('Pacific/Guadalcanal').countries(),
["FM","SB"]);
+ test.deepEqual(tz.zone('Pacific/Guam').countries(),
["GU","MP"]);
+- test.deepEqual(tz.zone('Pacific/Honolulu').countries(),
["UM","US"]);
++ test.deepEqual(tz.zone('Pacific/Honolulu').countries(), ["US"]);
+ test.deepEqual(tz.zone('Pacific/Johnston').countries(), []);
+ test.deepEqual(tz.zone('Pacific/Kiritimati').countries(),
["KI"]);
+ test.deepEqual(tz.zone('Pacific/Kosrae').countries(), ["FM"]);
+@@ -643,7 +643,7 @@
+ test.deepEqual(tz.zonesForCountry("BW"),
["Africa/Gaborone","Africa/Maputo"]);
+ test.deepEqual(tz.zonesForCountry("BY"), ["Europe/Minsk"]);
+ test.deepEqual(tz.zonesFor
[Pkg-javascript-devel] Bug#1036259: moment-timezone.js: FTBFS in testing: make[1]: *** [debian/rules:28: execute_before_dh_auto_configure] Error 1
On Sun, 28 May 2023 18:15:14 +0200 gregor herrmann wrote: On Sun, 28 May 2023 20:05:09 +0400, Yadd wrote: > > This looked reasonably easy to fix (cf. attached patch), but the > > tests fail as follows: > I fixed it in salsa (needs an update to import 2023 data). I'm waiting for > Martina review who maintains it. Ack, I've seen your commits in salsa but as the pipeline fails (probably the version in d/changelog?) and as a new upstream release 2 weeks before the release might not be accepted by the release team, I thougt I'd give it a try as well; but well, it was not that quick&easy :) Agreed. The upstream release is not much more than a repackaging of the Olson database and adjusting the tests to match, but the debdiff is enormous. Luckily, the debian/rules I wrote a few years ago takes care of updating the data files and tests based on the installed tzdata package (which should match the last part of the debian package version). The only thing that needs to be handled separately are the countries.js test file, which is manually maintained. So I just made a quilt patch based on the git diff from upstream. I have just prepared a new package like this, the debdiff is fairly minimal: $ debdiff moment-timezone.js_0.5.40+dfsg-1+2022g.dsc moment-timezone.js_0.5.40+dfsg-1+2023c.dsc | diffstat changelog | 10 ++ control |4 ++-- patches/02-tzdata-2023c.patch | 42 ++ patches/series|1 + 4 files changed, 55 insertions(+), 2 deletions(-) Sadly, Yadd changes were already pushed to master, so I will have to do some git history rewriting. Please update your local clones accordingly. -- Martina Ferrari (Tina) -- Pkg-javascript-devel mailing list Pkg-javascript-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#1008230: pkg-js-tools: dh-sequence-nodejs-no-lerna not functional
Package: pkg-js-tools Version: 0.14.9 Severity: normal Tags: patch Due to a couple of bugs, you currently cannot disable the usage of workspaces (from lerna.json or packages.json), and if you try to use the nodejs-no-lerna sequence, the build fails completely. I have provided a patch in https://salsa.debian.org/js-team/pkg-js-tools/-/merge_requests/16 -- System Information: Debian Release: bookworm/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 5.10.0-11-amd64 (SMP w/4 CPU threads) Kernel taint flags: TAINT_USER, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE Locale: LANG=en_IE.UTF-8, LC_CTYPE=en_IE.UTF-8 (charmap=UTF-8), LANGUAGE=en_IE:en Shell: /bin/sh linked to /bin/dash Init: unable to detect Versions of packages pkg-js-tools depends on: ii dh-nodejs 0.14.9 Versions of packages pkg-js-tools recommends: ii apt-file 3.2.2 ii devscripts2.22.1 pn libcache-cache-perl pn libprogress-any-output-termprogressbarcolor-perl ii node-semver 7.3.5+~7.3.8-1 ii npm 8.5.5~ds1-1 Versions of packages pkg-js-tools suggests: pn autodep8 ii git-buildpackage 0.9.25 ii lintian 2.114.0 -- no debconf information -- Pkg-javascript-devel mailing list Pkg-javascript-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#1008229: pkg-js-tools: Issues with bundle packages with no main package
Package: pkg-js-tools
Version: 0.14.9
Severity: normal
Despite what the documentation says, placing an empty debian/nodejs/main file
does not properly work. There are many parts of the code that still try to use
the main package, and the ${nodejs:Provides} substvar contains an invalid
"node-" line.
-- System Information:
Debian Release: bookworm/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1,
'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 5.10.0-11-amd64 (SMP w/4 CPU threads)
Kernel taint flags: TAINT_USER, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_IE.UTF-8, LC_CTYPE=en_IE.UTF-8 (charmap=UTF-8),
LANGUAGE=en_IE:en
Shell: /bin/sh linked to /bin/dash
Init: unable to detect
Versions of packages pkg-js-tools depends on:
ii dh-nodejs 0.14.9
Versions of packages pkg-js-tools recommends:
ii apt-file 3.2.2
ii devscripts2.22.1
pn libcache-cache-perl
pn libprogress-any-output-termprogressbarcolor-perl
ii node-semver 7.3.5+~7.3.8-1
ii npm 8.5.5~ds1-1
Versions of packages pkg-js-tools suggests:
pn autodep8
ii git-buildpackage 0.9.25
ii lintian 2.114.0
-- no debconf information
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#1007983: node-puppeteer: broken autopkgtest keeping chromium from migrating to testing
Hi Andres, Thanks for your report, puppeteer will need to be updated to match the new version of chromium right away. It seems there are also some flaky tests, which caused the sporadic failures... On 21/03/2022 01:55, Andres Salomon wrote: On Sat, 19 Mar 2022 17:44:02 -0400 Andres Salomon wrote: > Source: node-puppeteer > Control: found -1 node-puppeteer/13.1.0+dfsg-6 > Control: affects -1 chromium > Severity: serious > Tags: sid bookworm > > node-puppeteer is keeping chromium from migrating; as > https://tracker.debian.org/pkg/chromium describes, It looks like the tests also failed in testing with chromium v98 (https://ci.debian.net/data/autopkgtest/testing/amd64/n/node-puppeteer/20151806/log.gz), which did actually allow chromium v99 to migrate to testing, so you can ignore that part of this bug report. -- Martina Ferrari (Tina) -- Pkg-javascript-devel mailing list Pkg-javascript-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#1006469: node-puppeteer shouldn't embed devtools-protocol
On 25/02/2022 22:26, Yadd wrote: node-puppeteer embeds a copy of devtools-protocol while Debian has node-devtools-protocol. Please drop this and use node-devtools-protocol dependency This was done on purpose, as it is not really workable to keep them separate due to how tightly coupled the code is to the version of the protocol. Keeping them separate will mean endless trouble, forcing both packages to always be updated in step, and if anybody ever updates the devtools package separately it most surely will break puppeteer. -- Martina Ferrari (Tina) -- Pkg-javascript-devel mailing list Pkg-javascript-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] node-dateformat
Hi, I have just noticed that node-dateformat is still in version 3.0.0, with the git repo carrying 4.3.1 and upstream is at 5.0.2. Before updating it and/or uploading to unstable, I wanted to double check if there is any reason why this package has been kept in this old release? I know there has been a breaking change at some point (although I thought it happened already at 3.0.0), but even if that is the reason, I can only see 2 reverse dependencies, so it would be simple to patch them. Thanks, Tina. PS: CC me in replies, I am not subscribed. -- Martina Ferrari (Tina) -- Pkg-javascript-devel mailing list Pkg-javascript-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] RFH: puppeteer tests
Hi, On 14/01/2022 08:41, Yadd wrote: I started to modify your package. The problem for tests is that it launches chromium, then this requires X server. Not really, the problem we were having was that the tests were failing during their compilation. I see you moved to version 13 and introduced other changes, but the problem is still the same.. undefined ERROR: ../../usr/share/nodejs/type-detect/type-detect.js(3,10): error TS2304: Cannot find name 'define'. And if I remove the mime module that changes to: undefined ERROR: ../../usr/share/nodejs/mime/Mime.js:15:8 - error TS2300: Duplicate identifier 'define'. You mentioned something about launching chromium and requiring an X server, but it is not clear how you got there.. Can you share how are you running the tests? -- Martina Ferrari (Tina) -- Pkg-javascript-devel mailing list Pkg-javascript-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] Bug#997736: Chiming in..
Hi, Sorry for being late to the party here.. (Thanks to Myon for pinging me about this today) So, it seems that my solution to this issue was not understood. It is *expected* (and wanted!) that tests would start failing as soon as a new tzdata release is uploaded. The solution is just to create a new source package version with no changes, just including the version of the olson DB in the moment-timezone debian revision: Debian package revision (D): 1 Olson database version (TZVER): 2021a Moment-timezone upstream version (U): 0.5.32 Mangled version after repackaging (U+dfsg): 0.5.32+dfsg moment-timezone.js full version (U+dfsg1-D+TZVER): 0.5.32+dfsg-1+2021a I am now uploading a new revision that fixes this. -- Martina Ferrari (Tina) -- Pkg-javascript-devel mailing list Pkg-javascript-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
