Re: [Pkg-javascript-devel] select2.js_4.0.13+dfsg-1_amd64.changes REJECTED
Hello Andrius, On Tue 28 Apr 2020 at 07:59AM +03, mer...@debian.org wrote: > Sorry for not answering properly earlier. No problem. > No, some of the tests cannot be run without vendor/qunit-1.23.1.css. > However, when the test dependencies get packaged for Debian, a symlink > (or a patch) will be added to replace path vendor/qunit-1.23.1.css with > appropriate path in Debian, and the tests will then be run successfully. In that case I think the files need to be filtered out, as otherwise we would be including code in Debian main without also including all its dependencies. -- Sean Whitton signature.asc Description: PGP signature -- Pkg-javascript-devel mailing list Pkg-javascript-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] select2.js_4.0.13+dfsg-1_amd64.changes REJECTED
Hello, On Wed 13 May 2020 at 06:29AM +03, mer...@debian.org wrote: > OK, I think I understand the issue. Could you please reject the package > so as I could repack and reupload it? It seems you have already reuploaded it? -- Sean Whitton signature.asc Description: PGP signature -- Pkg-javascript-devel mailing list Pkg-javascript-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] select2.js_4.0.13+dfsg-1_amd64.changes REJECTED
Hello, On 2020-05-14 01:02, Sean Whitton wrote: > It seems you have already reuploaded it? Yes, I have reuploaded 4.0.13+dfsg1-1 right after receiving the REJECT notice. Best, Andrius signature.asc Description: OpenPGP digital signature -- Pkg-javascript-devel mailing list Pkg-javascript-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] select2.js_4.0.13+dfsg-1_amd64.changes REJECTED
Hello Sean, On 2020-05-13 06:17, Sean Whitton wrote: > In that case I think the files need to be filtered out, as otherwise we > would be including code in Debian main without also including all its > dependencies. OK, I think I understand the issue. Could you please reject the package so as I could repack and reupload it? Thanks, Andrius signature.asc Description: OpenPGP digital signature -- Pkg-javascript-devel mailing list Pkg-javascript-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] select2.js_4.0.13+dfsg-1_amd64.changes REJECTED
Hi Jonas, On 2020-04-28 10:43, Jonas Smedegaard wrote: > Please file bugreports, to make the issue actionable, and to help track > progress. Thanks for the advice. I will try to keep up with it. Best wishes, Andrius signature.asc Description: OpenPGP digital signature -- Pkg-javascript-devel mailing list Pkg-javascript-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] select2.js_4.0.13+dfsg-1_amd64.changes REJECTED
Hello, On 2020-04-26 20:15, Sean Whitton wrote: > It depends on the answer to my original question, which I do not believe > you have answered: can the tests be run successfully without this file? Sorry for not answering properly earlier. No, some of the tests cannot be run without vendor/qunit-1.23.1.css. However, when the test dependencies get packaged for Debian, a symlink (or a patch) will be added to replace path vendor/qunit-1.23.1.css with appropriate path in Debian, and the tests will then be run successfully. Best wishes, Andrius signature.asc Description: OpenPGP digital signature -- Pkg-javascript-devel mailing list Pkg-javascript-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] select2.js_4.0.13+dfsg-1_amd64.changes REJECTED
Hello, On Thu 16 Apr 2020 at 08:39AM +03, mer...@debian.org wrote: > Tests are not run for this package due to not yet packaged dependencies. > Thus files tests/unit-jq*.html are not used at all for now. However, as > these files are part of the upstream tarball and are covered by the same > top-level license, I would prefer to keep them until test dependencies > get packaged. When this happens, these files should be patched to use > Debian qunit.css instead of excluded vendor one. Would this be acceptable? It depends on the answer to my original question, which I do not believe you have answered: can the tests be run successfully without this file? -- Sean Whitton signature.asc Description: PGP signature -- Pkg-javascript-devel mailing list Pkg-javascript-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] select2.js_4.0.13+dfsg-1_amd64.changes REJECTED
Hi Sean, Many thanks for the review. On 2020-04-16 02:00, Sean Whitton wrote: > src/scss/mixins/_gradients.scss has code from another project with > different copyright holders. Thanks for noticing this – I will add an entry in debian/copyright regarding this file. > It looks like tests/unit-jq*.html depend on the file > vendor/qunit-1.23.1.css -- can the tests be run successfully without > this file? If not, we will have to remove more files, because Debian > main is meant to be self-contained. Tests are not run for this package due to not yet packaged dependencies. Thus files tests/unit-jq*.html are not used at all for now. However, as these files are part of the upstream tarball and are covered by the same top-level license, I would prefer to keep them until test dependencies get packaged. When this happens, these files should be patched to use Debian qunit.css instead of excluded vendor one. Would this be acceptable? > I notice this package keeps being removed and reuploaded to NEW. > Perhaps it would be better to keep it in the archive for longer before > removal, if it again loses its reverse deps, to save effort. I completely agree. Best wishes, Andrius -- Pkg-javascript-devel mailing list Pkg-javascript-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] select2.js_4.0.13+dfsg-1_amd64.changes REJECTED
+--+ | REJECT reasoning | +--+ src/scss/mixins/_gradients.scss has code from another project with different copyright holders. It looks like tests/unit-jq*.html depend on the file vendor/qunit-1.23.1.css -- can the tests be run successfully without this file? If not, we will have to remove more files, because Debian main is meant to be self-contained. +--+ |Other comments| +--+ I notice this package keeps being removed and reuploaded to NEW. Perhaps it would be better to keep it in the archive for longer before removal, if it again loses its reverse deps, to save effort. +--+ | N.B. | +--+ This review may not be exhaustive. Please check your source package against your d/copyright and the ftpmaster REJECT-FAQ, throughly, before uploading to NEW again. Thank you for your time and contribution! Sean === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- Pkg-javascript-devel mailing list Pkg-javascript-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
