Bug#713515: crtmpserver: FTBFS: add_subdirectory given source tinyxml which is not an existing directory.
Hi Reinhard, Should I reupload upstream sources with patches inside ? (I guess merge that patches to upstream will be quick - 1-2days) On Sun, Jun 23, 2013 at 06:53:52PM +0200, Reinhard Tartler wrote: On Sun, Jun 23, 2013 at 4:04 PM, Andriy Beregovenko j...@jet.kiev.ua wrote: Hi Reinhard, Yes, I have contact. Yes, I will contact him and will discuss about. In addition, it seems that the package requires further changes to build on kfreebsd. I've prepared a patch here, and am going to upload it to unstable soon: http://anonscm.debian.org/gitweb/?p=pkg-multimedia/crtmpserver.git;a=blob;f=debian/patches/21_fix_ftbfs_kfreebsd.diff While you're at it, please also mention that url to upstream. Thanks! -- regards, Reinhard -- Best regards, Andriy 0xBDDBDAE3 signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#713515: crtmpserver: FTBFS: add_subdirectory given source tinyxml which is not an existing directory.
Hi Reinhard, Yes, I have contact. Yes, I will contact him and will discuss about. On Sat, Jun 22, 2013 at 06:16:07PM +0200, Reinhard Tartler wrote: On Sat, Jun 22, 2013 at 3:49 PM, Lucas Nussbaum lu...@lucas-nussbaum.net wrote: Source: crtmpserver Version: 1.0~dfsg-3 Severity: serious Tags: jessie sid User: debian...@lists.debian.org Usertags: qa-ftbfs-20130620 qa-ftbfs Justification: FTBFS on amd64 Hi, During a rebuild of all packages in sid, your package failed to build on amd64. Relevant part: -- Looking for tinyxml -- Looking for tinyxml headers - found -- Looking for tinyxml library - not found Andriy, do you still have contact to upstream? I've now backed a patch for that that seems to work for this bug. Can you perhaps forward to get it included into upstream? http://anonscm.debian.org/gitweb/?p=pkg-multimedia/crtmpserver.git;a=blob;f=debian/patches/20_use_pkgconfig_for_tinyxml.diff Since I'm not comfortable with uploading a new upstream version without checking with you, I'm going to create a jessie branch with this fix only in order to minimize the risk of introducing additional issues. -- regards, Reinhard -- Best regards, Andriy 0xBDDBDAE3 signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#687227: crtmpserver fails to relay a live stream
Package: crtmpserver Followup-For: Bug #687227 Exactly now I'm working on update package to latest one from upstream. So in few day (or possible more then few) you'll see the new/updated version. I'll be very thankful if you describe exactly what you would like to see Current config is exactly same as an upstream one, but is splited to several files. -- Best regards, Andriy 0xBDDBDAE3 signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] crtmpserver/master: Add postrm script for crtmpserver-apps.
Hi Jonas, Alessio,
I complete fixes. Please review changes and upload package.
On Tue, Apr 24, 2012 at 09:23:56AM -0400, Jonas Smedegaard wrote:
On 12-04-24 at 10:17am, Andriy Beregovenko wrote:
Hi Jonas,
On Tue, Apr 24, 2012 at 02:40:22AM -0400, Jonas Smedegaard wrote:
On 12-04-24 at 08:53am, Andriy Beregovenko wrote:
Hi Alessio,
On Tue, Apr 24, 2012 at 02:06:43AM +0200, Alessio Treglia wrote:
This doesn't look sane to me:
On Sat, Apr 14, 2012 at 9:45 PM, jet-gu...@users.alioth.debian.org
wrote:
+do_remove() {
+ for app in $APPLICATIONS; do
+ if [ -f /etc/crtmpserver/applications/$app.lua ];
then
+ compare
/etc/crtmpserver/applications/$app.lua \
+
/usr/share/doc/crtmpserver-apps/examples/$app.lua \
+ rm
/etc/crtmpserver/applications/$app.lua
Why do you try to remove those files?
The crtmpserver-apps package seems to own no conffiles.
This files are not managed by conffile, so I check if it is same as
default,
and if yes - remove it(if no user changes in it)
+ fi
+ done
+ rmdir /etc/crtmpserver/applications
This is Severity: grave as it means removing user's files and may
potentially
cause data loss!
This may not lead to data loss, because rmdir(w/o -f) actually do not
remove dir
if there are files inside, so this command remove dir only if it is
empty
(i.e. user do not modificate any conf files and it was removed during
prev
steps)
If you really want to provide crtmpserver-apps with conffiles, you
should install them clean way (e.g. dh_install) and then manage
their removal with dpkg-maintscript-helper.
If you really really need to do it this odd way (I too recommend to
simply use conffiles) then beware that you must not rely on files below
/usr/share/doc but need to install the reference files somewhere else.
Ok, let me describe my point, maybe I have misunderstood somewhere.
Files that need for server to be usable is installed with package
crtmpserver. Lua scripts that is installed with package crtmpserver-apps
mostly is example scripts and it provides default solution that can done
basic needs(so user will not modify them and if it purge app - it will be
removed), but users who need to implement advanced configuration will
modify this scripts harder, and in this way I do not think that annoing user
with conffiles notifications is good idea. That is why i'm just copy
example scripts from /usr/share/doc and maintaine remove/purge action
manually.
Please correct me if I wrong.
Either the files are *only* provided as examples or they are handled by
the packaging scripts.
If only example files, then they are not owned by the package and should
not be handled by the package.
If handled by the package - no matter how rarely - they must not be
located below /usr/share/doc/.
Conffiles except for special cases where you need some complex
maintenance routines. If conffile notifications occur without a sane
reason, then something else is wrong with your packaging!
Please carefully reas Debian Policy ?10.7.3 and ?12.3.
- Jonas
--
* Jonas Smedegaard - idealist Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
[x] quote me freely [ ] ask before reusing [ ] keep private
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
--
Best regards,
Andriy
0xBDDBDAE3
signature.asc
Description: Digital signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] crtmpserver/master: Add postrm script for crtmpserver-apps.
Hi Alessio, On Wed, Apr 25, 2012 at 12:43:20AM +0200, Alessio Treglia wrote: On Tue, Apr 24, 2012 at 3:23 PM, Jonas Smedegaard d...@jones.dk wrote: Either the files are *only* provided as examples or they are handled by the packaging scripts. If only example files, then they are not owned by the package and should not be handled by the package. If handled by the package - no matter how rarely - they must not be located below /usr/share/doc/. Conffiles except for special cases where you need some complex maintenance routines. If conffile notifications occur without a sane reason, then something else is wrong with your packaging! I totally agree, please decide whether treat those files as conffiles or not, and then fix the packaging accordingly. I leave it as configuration files (not conffile) and move it to /usr/share/crtmpserver-apps. Also I made corresponding fixes to postinst and prerm(that was previously postrm) scripts. It seems that now the location of these files and its maintenance is consistent with the Debian Policy. Please review package and upload it(if there are no issues). -- Alessio Treglia | www.alessiotreglia.com Debian Developer | ales...@debian.org Ubuntu Core Developer | quadris...@ubuntu.com 0416 0004 A827 6E40 BB98 90FB E8A4 8AE5 311D 765A ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers -- Best regards, Andriy 0xBDDBDAE3 signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] crtmpserver/master: Add postrm script for crtmpserver-apps.
Hi, Also thank you for your job and pointing me to the right way. :) On Wed, Apr 25, 2012 at 12:43:20AM +0200, Alessio Treglia wrote: On Tue, Apr 24, 2012 at 3:23 PM, Jonas Smedegaard d...@jones.dk wrote: Either the files are *only* provided as examples or they are handled by the packaging scripts. If only example files, then they are not owned by the package and should not be handled by the package. If handled by the package - no matter how rarely - they must not be located below /usr/share/doc/. Conffiles except for special cases where you need some complex maintenance routines. If conffile notifications occur without a sane reason, then something else is wrong with your packaging! I totally agree, please decide whether treat those files as conffiles or not, and then fix the packaging accordingly. -- Alessio Treglia | www.alessiotreglia.com Debian Developer | ales...@debian.org Ubuntu Core Developer | quadris...@ubuntu.com 0416 0004 A827 6E40 BB98 90FB E8A4 8AE5 311D 765A ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers -- Best regards, Andriy 0xBDDBDAE3 signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] crtmpserver/master: Add postrm script for crtmpserver-apps.
Hi Jonas,
On Tue, Apr 24, 2012 at 02:40:22AM -0400, Jonas Smedegaard wrote:
On 12-04-24 at 08:53am, Andriy Beregovenko wrote:
Hi Alessio,
On Tue, Apr 24, 2012 at 02:06:43AM +0200, Alessio Treglia wrote:
This doesn't look sane to me:
On Sat, Apr 14, 2012 at 9:45 PM, jet-gu...@users.alioth.debian.org
wrote:
+do_remove() {
+ for app in $APPLICATIONS; do
+ if [ -f /etc/crtmpserver/applications/$app.lua ]; then
+ compare
/etc/crtmpserver/applications/$app.lua \
+
/usr/share/doc/crtmpserver-apps/examples/$app.lua \
+ rm
/etc/crtmpserver/applications/$app.lua
Why do you try to remove those files?
The crtmpserver-apps package seems to own no conffiles.
This files are not managed by conffile, so I check if it is same as default,
and if yes - remove it(if no user changes in it)
+ fi
+ done
+ rmdir /etc/crtmpserver/applications
This is Severity: grave as it means removing user's files and may
potentially
cause data loss!
This may not lead to data loss, because rmdir(w/o -f) actually do not
remove dir
if there are files inside, so this command remove dir only if it is empty
(i.e. user do not modificate any conf files and it was removed during prev
steps)
If you really want to provide crtmpserver-apps with conffiles, you
should install them clean way (e.g. dh_install) and then manage
their removal with dpkg-maintscript-helper.
If you really really need to do it this odd way (I too recommend to
simply use conffiles) then beware that you must not rely on files below
/usr/share/doc but need to install the reference files somewhere else.
Ok, let me describe my point, maybe I have misunderstood somewhere.
Files that need for server to be usable is installed with package
crtmpserver. Lua scripts that is installed with package crtmpserver-apps
mostly is example scripts and it provides default solution that can done
basic needs(so user will not modify them and if it purge app - it will be
removed), but users who need to implement advanced configuration will
modify this scripts harder, and in this way I do not think that annoing user
with conffiles notifications is good idea. That is why i'm just copy
example scripts from /usr/share/doc and maintaine remove/purge action
manually.
Please correct me if I wrong.
- Jonas
--
* Jonas Smedegaard - idealist Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
[x] quote me freely [ ] ask before reusing [ ] keep private
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
--
Best regards,
Andriy
0xBDDBDAE3
signature.asc
Description: Digital signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] crtmpserver/master: Add postrm script for crtmpserver-apps.
Hi Alessio,
On Tue, Apr 24, 2012 at 02:06:43AM +0200, Alessio Treglia wrote:
This doesn't look sane to me:
On Sat, Apr 14, 2012 at 9:45 PM, jet-gu...@users.alioth.debian.org wrote:
+do_remove() {
+ for app in $APPLICATIONS; do
+ if [ -f /etc/crtmpserver/applications/$app.lua ]; then
+ compare /etc/crtmpserver/applications/$app.lua \
+
/usr/share/doc/crtmpserver-apps/examples/$app.lua \
+ rm
/etc/crtmpserver/applications/$app.lua
Why do you try to remove those files?
The crtmpserver-apps package seems to own no conffiles.
This files are not managed by conffile, so I check if it is same as default,
and if yes - remove it(if no user changes in it)
+ fi
+ done
+ rmdir /etc/crtmpserver/applications
This is Severity: grave as it means removing user's files and may potentially
cause data loss!
This may not lead to data loss, because rmdir(w/o -f) actually do not remove dir
if there are files inside, so this command remove dir only if it is empty
(i.e. user do not modificate any conf files and it was removed during prev
steps)
If you really want to provide crtmpserver-apps with conffiles, you should
install them clean way (e.g. dh_install) and then manage their removal
with dpkg-maintscript-helper.
--
Alessio Treglia | www.alessiotreglia.com
Debian Developer | ales...@debian.org
Ubuntu Core Developer | quadris...@ubuntu.com
0416 0004 A827 6E40 BB98 90FB E8A4 8AE5 311D 765A
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
--
Best regards,
Andriy
0xBDDBDAE3
signature.asc
Description: Digital signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
package crtmpserver had been updated
Hi, Could you please review and upload new(minor) version of package to ftpmaster? There are the only 2 fixes in it: fix gcc 4.7 building; fix remove/purge action(implemented from scratch) with postrm script. -- Best regards, Andriy 0xBDDBDAE3 signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#667144: crtmpserver: ftbfs with GCC-4.7
fixed 667144 1.0~dfsg-3 thanks -- Best regards, Andriy 0xBDDBDAE3 signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: new version of package 'crtmpserver' was prepared
Hi Andres, Thank you. On Wed, Mar 21, 2012 at 09:31:48PM -0400, Andres Mejia wrote: 2012/3/21 Andriy Beregovenko j...@jet.kiev.ua: Hi, I finished update package 'crtmpserver'. This is major update from the point of view of upstream update, but debian package changes are insignificant. So, please, upload updated version of package. -- Best regards, Andriy 0xBDDBDAE3 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBAgAGBQJPalsqAAoJEDajjCG929rjtDwP/1P3zn2r6VyKMA4LIx9h4OK9 JUyaf67iumAURLoY6Ndl7mxHdUexk8GMI5cTPrGwiQNY4TqzU8BxSoOaBdoWrbPZ kfDx5R0yhL3bT8xRRqOSxckV5Qvy/lStn/SyFmUN1WQ5GpMqv8Uss528yiPbuIhg jNm45XrzCmPNf9m3jNRtAIkA8YyVxiIFnBEvczXP5e//N8kQ2lmHGF8i8SKJi/gU cKiDvbmGYEhJjnHfO7XOOJk5R6YPJMF/Hf3D3q5avkdojUx+zbgJCY6AD5BJzqGM AehVHD8QK/YnToP3WGeXwIIVCaO6eVLxSkRzqwvdxJbmyPnYSnlVOm0Vgt3WRxkR lY8xtXXwZi24XOVfdWEShYjioMFdwwXPmpRYESjU2g3PpKaKG+NXWhhjjyqqxYfe pr6Fb5Pl6lGnxbkVpIL+Mb3n5sOOPvMh+MgJXy6kWuDmgS8ssn2M+/xtRd0jFAaa zJYipwSVJYsWj1TsMNC8ptCcDM2l81cLUMwbWSQQpjcUDHMhfOPJ4TPr1Ncz6kPM DjqVi1sZoXSBmlxHh1xwWUXDdenZfwFHlD5SmgdkTE3sJhjk1v7y60/J4XOcFv4U waXS6kLL2ZcE3tlDEWeznUOqkKMvaY7WogCspMSRyrO2IGAsLRaLzkmyBs6utDNC PI/5g3UYIjevkrBa28vL =a6DZ -END PGP SIGNATURE- ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers Ok, uploaded. -- ~ Andres -- Best regards, Andriy 0xBDDBDAE3 signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
new version of package 'crtmpserver' was prepared
Hi, I finished update package 'crtmpserver'. This is major update from the point of view of upstream update, but debian package changes are insignificant. So, please, upload updated version of package. -- Best regards, Andriy 0xBDDBDAE3 signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: Package crtmpserver upload
Hi Reinhard, On Tue, Dec 06, 2011 at 05:53:19PM +0100, Reinhard Tartler wrote: On Mo, Dez 05, 2011 at 21:03:43 (CET), Andriy Beregovenko wrote: Hi Debian, Still looking for package upload. Review: - a lot of whitespace error (I've already fixed most of them) - lintian warnings that you might want to fix before the next upload: I: crtmpserver source: duplicate-long-description crtmpserver crtmpserver-libs crtmpserver-apps crtmpserver-dev W: crtmpserver source: maintainer-script-lacks-debhelper-token debian/crtmpserver-apps.postinst I: crtmpserver source: quilt-patch-missing-description 16_add_header_install.diff W: crtmpserver-apps: spelling-error-in-news-debian devided divided I: crtmpserver-apps: debian-news-entry-uses-asterisk W: crtmpserver: spelling-error-in-readme-debian extention extension Thanks for review. I fix this right now. Cheers, Reinhard -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers -- Best regards, Andriy 0xBDDBDAE3 signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Package crtmpserver upload
Hi, Few days ago I done fixing all issue that Reinhard showed me. So I'm looking for package review and upload. Looks like Reinhard is too busy to do this, that is why I ask. -- Best regards, Andriy 0xBDDBDAE3 signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] crtmpserver/master: Correcting release
Hi Reinhard, On Sat, Nov 19, 2011 at 11:07:34AM +0100, Reinhard Tartler wrote: Hi, Sorry for being late, but I am currently increadibly busy with my day-job and have a numer of other open source projects that compete with my available time. I've now spend over 30 minutes reviewing your package, which is much longer than I intended to invest. Unfortunately, I also have some comments. Well... This is your participation as an Debian maintainer. Am I right? BTW, I do not ask you to do something RIGHT NOW. Your reaction is not clear to me. First of all, I noticed that you've pushed the tag for this upload to the repository. Please don't, leave that to the uploader. In this particular case, I think we need to do some additional changes so that the tag will not represent what will eventually go into the archive. Ok. On Fr, Nov 11, 2011 at 17:31:00 (CET), jet-gu...@users.alioth.debian.org wrote: The following commit has been merged in the master branch: commit 1ba6610128bcf372e3295496d9f933470a3bed89 Author: Andriy Beregovenko j...@jet.kiev.ua Date: Fri Nov 11 18:23:54 2011 +0200 Correcting release This commit message does not really match the contents. I notice this applies to a number your commits, which makes doesn't make reviewing any easier. Ok, I will comment my next commits more descriptive and more accurately. diff --git a/debian/changelog b/debian/changelog index 12d651d..7162b0d 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,29 @@ +crtmpserver (0.0~dfsg+svn611.1-1) UNRELEASED; urgency=low please merge the UNRELEASED entry of '0.0~dfsg+svn611-1' with this one Done. + * Makes main configuration script more clean I notice a number of whitespace issues in the scripts, making them 'unclean' Definitely!!! Btw that commit is not about whitespaces :) + * Add rc script I think we discussed this earlier this year. In commit http://anonscm.debian.org/gitweb/?p=pkg-multimedia/crtmpserver.git;a=commitdiff;h=e4f2bce15ab888aabcb97c035a09373bbf44c5af, I have removed it, and in http://anonscm.debian.org/gitweb/?p=pkg-multimedia/crtmpserver.git;a=commitdiff;h=c06ba11fbb9741c8de6253a64e04e9d978b8346a you are adding it back with 'Add rc script'. I'm still not convinced that this is the way to go, but if you insist on this, you should better have used 'git revert', so that this fact becomes clear. It would have saved my a lot of time, BTW. I can't cause that commit removes MANY files, but I need only one(two) file(s). Moreover, I'm not happy with the script, because in order to use it, users *have* to edit it. The previous solution with /etc/default/$servername is much more common in debian packages. Still, defaulting it to 'no' is something I personally feel very uncomfortable with. That was error, already fixed. I'm uncomfortable with it because IMO, installing a service should instantly make it usable. For instance, installing the apache package starts a webserver that serves a basic 'welcome' webpage. Can't we do something similar for crtmpserver? Yes. It is ready to use out-of-box. But there is error in rc script, already fixed. + * Make some cosmetic fixes [ ... ] In general, the changes in debian/changelog should state the differences to the previous version that was uploaded to the archive. Already remade it. Having said this, I fear the package still requires work :-( -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 -- Best regards, Andriy 0xBDDBDAE3 signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] crtmpserver/master: Updated README.Debian to reflect the new release
Hi Reinhard, On Sun, Nov 20, 2011 at 04:58:33PM +0100, Reinhard Tartler wrote: In general, excellent idea to document these steps! A couple of suggestions, though: On So, Nov 20, 2011 at 16:34:39 (CET), jet-gu...@users.alioth.debian.org wrote: The following commit has been merged in the master branch: commit 2ddf9e0e566e02b027fbb6fec9f2d20ba6c63338 Author: Andriy Beregovenko j...@jet.kiev.ua Date: Sun Nov 20 17:34:26 2011 +0200 Updated README.Debian to reflect the new release diff --git a/debian/README.Debian b/debian/README.Debian index 3107e90..0373b55 100644 --- a/debian/README.Debian +++ b/debian/README.Debian @@ -1,78 +1,61 @@ -crtmpserver for Debian +???crtmpserver for Debian == Unnecessary ' ' This is UTF-8 marker :) Sometimes kate(editor) suprising me :) BTW vim,kate,libreoffice-writer not shows it. What is the 'last' package version? In five uploads from now, this will heavily confuse the reader. I'd therefore suggest to place this in NEWS.Debian. Last version(that is actual right now) is '0.0~dfsg+svn474-2' and next version will be 0.0~dfsg+svn611.1-2 (i hope). But ok, i move this to news. +2. New startup script system + +Now all application configuration are placed in /etc/crtmpserver/applications. +To enable any of them, simple add script base name(without .lua extention) to +file /etc/crtmpserver/enabled_applications.conf. + +Main configuration script now only generate config from parts. It load logger +configuration script /etc/crtmpserver/log_appenders.lua, after this, script +read file /etc/crtmpserver/enabled_applications.conf and load application +scripts (using next filename form /etc/crtmpserver/applications/$name.lua) + +Also, now provided file /etc/defaults/crtmpserver for more comfortable daemon +maintaining. + + +3. Change daemon user. +--- +By default daemon run with root privileges, but you can change this behavior. +Next steps allows you to change daemon user: + a) Create system wide daemon user + You must add system user for daemon. Something like this: + adduser --system --disabled-login --ingroup adm \ + --home /var/lib/crtmpserver \ + --gecos crtmpserver \ + --shell /bin/false \ + crtmpserver + + b) Change daemon user + Open rc configuration file /etc/defaults/crtmpserver, and + change DAEMON_USER to created user name(in our case this is 'crtmpserver') + + c) Restart daemon + After all steps described above just do next: +/etc/init.d/crtmpserver restart These texts are great. I'd drop the numbering, though. Cheers, Reinhard -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers -- Best regards, Andriy 0xBDDBDAE3 signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] crtmpserver/master: Change default user to root
Hi pkg-multimedia-maintainers,
Can you review and upload new version?
On Mon, Nov 14, 2011 at 06:39:48PM +0200, Andriy Beregovenko wrote:
Hi Reinhard,
On Mon, Nov 14, 2011 at 02:30:12PM +0100, Reinhard Tartler wrote:
On Mo, Nov 14, 2011 at 13:29:08 (CET), jet-gu...@users.alioth.debian.org
wrote:
The following commit has been merged in the master branch:
commit 81bbf62fd926aee49359d8cc6b98b879bb5f36bc
Author: Andriy Beregovenko j...@jet.kiev.ua
Date: Mon Nov 14 02:33:13 2011 +0200
Change default user to root
diff --git a/debian/crtmpserver.init b/debian/crtmpserver.init
index 935f067..23145ae 100644
--- a/debian/crtmpserver.init
+++ b/debian/crtmpserver.init
@@ -17,7 +17,7 @@ NAME=crtmpserver
DAEMON=/usr/sbin/crtmpserver
DAEMON_ARGS= --daemon
DAEMON_CONF=/etc/crtmpserver/crtmpserver.lua
-DAEMON_USER=crtmpserver
+DAEMON_USER=root
PIDFILE=/var/run/$NAME.pid
SCRIPTNAME=/etc/init.d/$NAME
ENABLED=no
@@ -30,7 +30,7 @@ ENABLED=no
. /lib/lsb/init-functions
DAEMON_UID=$(getent passwd ${DAEMON_USER} | cut -d: -f3)
-[ -z ${DAEMON_UID} ] (echo User ${DAEMON_USER} not exists; return
1)
+[ -z ${DAEMON_UID} ] (echo User ${DAEMON_USER} not exists; exit 1)
echo Error: User ${DAEMON_USER} does not exist.
Fixed. Also exit fixed :)
--
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
--
Best regards,
Andriy
0xBDDBDAE3
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
--
Best regards,
Andriy
0xBDDBDAE3
signature.asc
Description: Digital signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] crtmpserver/master: Change default user to root
Hi Reinhard,
On Mon, Nov 14, 2011 at 02:30:12PM +0100, Reinhard Tartler wrote:
On Mo, Nov 14, 2011 at 13:29:08 (CET), jet-gu...@users.alioth.debian.org
wrote:
The following commit has been merged in the master branch:
commit 81bbf62fd926aee49359d8cc6b98b879bb5f36bc
Author: Andriy Beregovenko j...@jet.kiev.ua
Date: Mon Nov 14 02:33:13 2011 +0200
Change default user to root
diff --git a/debian/crtmpserver.init b/debian/crtmpserver.init
index 935f067..23145ae 100644
--- a/debian/crtmpserver.init
+++ b/debian/crtmpserver.init
@@ -17,7 +17,7 @@ NAME=crtmpserver
DAEMON=/usr/sbin/crtmpserver
DAEMON_ARGS= --daemon
DAEMON_CONF=/etc/crtmpserver/crtmpserver.lua
-DAEMON_USER=crtmpserver
+DAEMON_USER=root
PIDFILE=/var/run/$NAME.pid
SCRIPTNAME=/etc/init.d/$NAME
ENABLED=no
@@ -30,7 +30,7 @@ ENABLED=no
. /lib/lsb/init-functions
DAEMON_UID=$(getent passwd ${DAEMON_USER} | cut -d: -f3)
-[ -z ${DAEMON_UID} ] (echo User ${DAEMON_USER} not exists; return 1)
+[ -z ${DAEMON_UID} ] (echo User ${DAEMON_USER} not exists; exit 1)
echo Error: User ${DAEMON_USER} does not exist.
Fixed. Also exit fixed :)
--
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
--
Best regards,
Andriy
0xBDDBDAE3
signature.asc
Description: Digital signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Sources with RCS files
Hi, While I'm run lintian on package, I found that I not remove all RCS files from my package before import/upload new sources, so question is: how I can remove all theese unneded files from current branches. Of course I can remove it from debian branch, from upstream. Is this right way ? -- Best regards, Andriy 0xBDDBDAE3 signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] crtmpserver/master: Rename application scripts to make future updates more easy
Hi Reinhard, On Sat, Nov 05, 2011 at 11:16:35AM +0100, Reinhard Tartler wrote: On Sa, Nov 05, 2011 at 10:34:49 (CET), jet-gu...@users.alioth.debian.org wrote: The following commit has been merged in the master branch: commit 29468465ab3153c288bbb029736cd1e02639a0f0 Author: Andriy Beregovenko j...@jet.kiev.ua Date: Sat Nov 5 11:15:59 2011 +0200 Rename application scripts to make future updates more easy diff --git a/debian/crtmpserver-apps-scripts/admin.lua b/debian/crtmpserver-apps-scripts/admin.lua.sample similarity index 100% rename from debian/crtmpserver-apps-scripts/admin.lua rename to debian/crtmpserver-apps-scripts/admin.lua.sample diff --git a/debian/crtmpserver-apps-scripts/applestreamingclient.lua b/debian/crtmpserver-apps-scripts/applestreamingclient.lua.sample similarity index 100% rename from debian/crtmpserver-apps-scripts/applestreamingclient.lua rename to debian/crtmpserver-apps-scripts/applestreamingclient.lua.sample diff --git a/debian/crtmpserver-apps-scripts/appselector.lua b/debian/crtmpserver-apps-scripts/appselector.lua.sample similarity index 100% rename from debian/crtmpserver-apps-scripts/appselector.lua rename to debian/crtmpserver-apps-scripts/appselector.lua.sample diff --git a/debian/crtmpserver-apps-scripts/conf.d/users.lua b/debian/crtmpserver-apps-scripts/conf.d/users.lua.sample similarity index 100% rename from debian/crtmpserver-apps-scripts/conf.d/users.lua rename to debian/crtmpserver-apps-scripts/conf.d/users.lua.sample diff --git a/debian/crtmpserver-apps-scripts/flvplayback.lua b/debian/crtmpserver-apps-scripts/flvplayback.lua.sample similarity index 100% rename from debian/crtmpserver-apps-scripts/flvplayback.lua rename to debian/crtmpserver-apps-scripts/flvplayback.lua.sample diff --git a/debian/crtmpserver-apps-scripts/proxypublish.lua b/debian/crtmpserver-apps-scripts/proxypublish.lua.sample similarity index 100% rename from debian/crtmpserver-apps-scripts/proxypublish.lua rename to debian/crtmpserver-apps-scripts/proxypublish.lua.sample diff --git a/debian/crtmpserver-apps-scripts/samplefactory.lua b/debian/crtmpserver-apps-scripts/samplefactory.lua.sample similarity index 100% rename from debian/crtmpserver-apps-scripts/samplefactory.lua rename to debian/crtmpserver-apps-scripts/samplefactory.lua.sample diff --git a/debian/crtmpserver-apps-scripts/stresstest.lua b/debian/crtmpserver-apps-scripts/stresstest.lua.sample similarity index 100% rename from debian/crtmpserver-apps-scripts/stresstest.lua rename to debian/crtmpserver-apps-scripts/stresstest.lua.sample diff --git a/debian/crtmpserver-apps-scripts/vptests.lua b/debian/crtmpserver-apps-scripts/vptests.lua.sample similarity index 100% rename from debian/crtmpserver-apps-scripts/vptests.lua rename to debian/crtmpserver-apps-scripts/vptests.lua.sample diff --git a/debian/crtmpserver-apps.install b/debian/crtmpserver-apps.install index 7cd5068..02d176f 100644 --- a/debian/crtmpserver-apps.install +++ b/debian/crtmpserver-apps.install @@ -7,12 +7,12 @@ usr/lib/crtmpserver/applications/proxypublish/libproxypublish.so usr/lib/crtmpserver/applications/samplefactory/libsamplefactory.so usr/lib/crtmpserver/applications/stresstest/libstresstest.so usr/lib/crtmpserver/applications/vptests/libvptests.so -debian/crtmpserver-apps-scripts/admin.lua etc/crtmpserver/applications -debian/crtmpserver-apps-scripts/applestreamingclient.lua etc/crtmpserver/applications -debian/crtmpserver-apps-scripts/appselector.lua etc/crtmpserver/applications -debian/crtmpserver-apps-scripts/flvplayback.lua etc/crtmpserver/applications -debian/crtmpserver-apps-scripts/proxypublish.lua etc/crtmpserver/applications -debian/crtmpserver-apps-scripts/samplefactory.lua etc/crtmpserver/applications -debian/crtmpserver-apps-scripts/stresstest.lua etc/crtmpserver/applications -debian/crtmpserver-apps-scripts/vptests.lua etc/crtmpserver/applications -debian/crtmpserver-apps-scripts/conf.d/users.lua etc/crtmpserver/conf.d +debian/crtmpserver-apps-scripts/admin.lua..sample etc/crtmpserver/applications Do you really mean to have here a '..' instead of '.'? Yeah, this was mistake, I already fix it, but still not push updates :) +debian/crtmpserver-apps-scripts/applestreamingclient.lua.sample etc/crtmpserver/applications +debian/crtmpserver-apps-scripts/appselector.lua.sample etc/crtmpserver/applications +debian/crtmpserver-apps-scripts/flvplayback.lua.sample etc/crtmpserver/applications +debian/crtmpserver-apps-scripts/proxypublish.lua.sample etc/crtmpserver/applications +debian/crtmpserver-apps-scripts/samplefactory.lua.sample etc/crtmpserver/applications +debian/crtmpserver-apps-scripts/stresstest.lua.sample etc/crtmpserver/applications +debian/crtmpserver-apps-scripts
Re: [SCM] crtmpserver/master: Add portinstall script for crtmpserver-apps package
Hi Reinhard,
On Sat, Nov 05, 2011 at 11:15:54AM +0100, Reinhard Tartler wrote:
On Sa, Nov 05, 2011 at 10:34:49 (CET), jet-gu...@users.alioth.debian.org
wrote:
The following commit has been merged in the master branch:
commit a91aeff97b9c3a8e543a3f738bd52e0f952861ed
Author: Andriy Beregovenko j...@jet.kiev.ua
Date: Sat Nov 5 11:34:37 2011 +0200
Add portinstall script for crtmpserver-apps package
diff --git a/debian/crtmpserver-apps.postinst
b/debian/crtmpserver-apps.postinst
new file mode 100644
index 000..1c6507d
--- /dev/null
+++ b/debian/crtmpserver-apps.postinst
@@ -0,0 +1,36 @@
+#!/bin/sh
+
+set -e
+
+APPLICATIONS=admin applestreamingclient appselector flvplayback
proxypublish samplefactory stresstest vptests
+APPCONFPATH=/etc/crtmpserver/applications
+
+
+case $1 in
+ configure)
+ # Copy application config if not exists
+ for app in $APPLICATIONS; do
+ if [ ! -f /etc/crtmpserver/applications/${app}.lua ]
+ then
+ cp
/etc/crtmpserver/applications/${app}.lua.sample \
+ /etc/crtmpserver/applications/${app}.lua
+ chmod 644
/etc/crtmpserver/applications/${app}.lua
+ fi
+ done
Why this copying around? This looks pretty confusing and surprising to
the user. I guess you want to have a reference copy around on the
system, which is a valid concern. However, since we are working on the
'official' debian packages, I think we should do this consinstently with
other packages in debian.
Thank you for answer to must questions. I was going to ask this. :)
So, this is what I propose:
- Install the references in /usr/share/doc/crtmpserver/examples. This
can be done elegenatly using dh_installexamples(1) in debian/rules.
I think crtmpserver-apps.examples is enough.
- Install a copy of that sample files in
/etc/crtmpserver/applications/{app}.whatever.
- remove this postinst script.
This is main question. How I can copy/install working scripts if not use
postinst ? Most of theese scripts must and will be modified in future by user.
- Rely on dpkg conffile mechanism to track user changes.
I do not think that it so smart to track changes in LUA script.
We can safely expect that every user *will* definitly want to edit and
adjust the contents. This also means that dpkg *will* prompt on every
package upgrade that changes anything in the file. - Your word about(april
2011 :))
+ # copy users sample file if not exists
+ if [ ! -f /etc/crtmpserver/conf.d/users.lua ]
+ then
+ cp /etc/crtmpserver/conf.d/users.lua.sample \
+ /etc/crtmpserver/conf.d/users.lua
+ chmod 640 /etc/crtmpserver/conf.d/users.lua
+ fi
dito.
So mostly I wanna to know what way is properly for such type of situation.
Cheers,
Reinhard.
--
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
--
Best regards,
Andriy
0xBDDBDAE3
signature.asc
Description: Digital signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] crtmpserver/master: Add portinstall script for crtmpserver-apps package
Hi Reinhard,
On Sat, Nov 05, 2011 at 09:10:18PM +0100, Reinhard Tartler wrote:
On Sa, Nov 05, 2011 at 19:04:08 (CET), Andriy Beregovenko wrote:
Hi Reinhard,
On Sat, Nov 05, 2011 at 11:15:54AM +0100, Reinhard Tartler wrote:
On Sa, Nov 05, 2011 at 10:34:49 (CET), jet-gu...@users.alioth.debian.org
wrote:
The following commit has been merged in the master branch:
commit a91aeff97b9c3a8e543a3f738bd52e0f952861ed
Author: Andriy Beregovenko j...@jet.kiev.ua
Date: Sat Nov 5 11:34:37 2011 +0200
Add portinstall script for crtmpserver-apps package
diff --git a/debian/crtmpserver-apps.postinst
b/debian/crtmpserver-apps.postinst
new file mode 100644
index 000..1c6507d
--- /dev/null
+++ b/debian/crtmpserver-apps.postinst
@@ -0,0 +1,36 @@
+#!/bin/sh
+
+set -e
+
+APPLICATIONS=admin applestreamingclient appselector flvplayback
proxypublish samplefactory stresstest vptests
+APPCONFPATH=/etc/crtmpserver/applications
+
+
+case $1 in
+configure)
+# Copy application config if not exists
+for app in $APPLICATIONS; do
+if [ ! -f
/etc/crtmpserver/applications/${app}.lua ]
+then
+cp
/etc/crtmpserver/applications/${app}.lua.sample \
+
/etc/crtmpserver/applications/${app}.lua
+chmod 644
/etc/crtmpserver/applications/${app}.lua
+fi
+done
Why this copying around? This looks pretty confusing and surprising to
the user. I guess you want to have a reference copy around on the
system, which is a valid concern. However, since we are working on the
'official' debian packages, I think we should do this consinstently with
other packages in debian.
Thank you for answer to must questions. I was going to ask this. :)
So, this is what I propose:
- Install the references in /usr/share/doc/crtmpserver/examples. This
can be done elegenatly using dh_installexamples(1) in debian/rules.
I think crtmpserver-apps.examples is enough.
Ok
- Install a copy of that sample files in
/etc/crtmpserver/applications/{app}.whatever.
- remove this postinst script.
This is main question. How I can copy/install working scripts if not use
postinst ? Most of theese scripts must and will be modified in future by
user.
Oh, I didn't remember that point. That's important to have in mind.
- Rely on dpkg conffile mechanism to track user changes.
I do not think that it so smart to track changes in LUA script.
We can safely expect that every user *will* definitly want to edit and
adjust the contents. This also means that dpkg *will* prompt on every
package upgrade that changes anything in the file. - Your word about(april
2011 :))
right, in that case, I'd probably not put anything in /etc, but document
in README.Debian what the user is supposed to do. It could for example
tell users to copy the sample files to etc, similar to what your
postinst script does. Or you could even place such an install script in
verbatim the the README.Debian file so that the instructions become
copypaste-able.
Do these files really have to go to /etc? Wouldn't any other location,
such as the users home, do as well?
First of all, I should clarify the situation around this software usage.
So, this sofware is powerfull platform that allows to perform tasks related
to the streaming. It should be mentioned that despite the high functionality
of the product, it ready to use out-of-box(using default configuration).
Most of the users needs only default features(with some additional lines in
configs), so they looking for easy-to-install and fast-start software.
I plan to provide such solution. We can make software usage easy - so we
must to do this. Debian is not Slackware.
That is why I insist on placing the configuration files in the /etc, adding
system user(this is option, mostly for security reasons) and starting daemon
immediately after it is installed. We must do only 'apt-get install' and we
got already worked solution.
+# copy users sample file if not exists
+if [ ! -f /etc/crtmpserver/conf.d/users.lua ]
+then
+cp /etc/crtmpserver/conf.d/users.lua.sample \
+/etc/crtmpserver/conf.d/users.lua
+chmod 640 /etc/crtmpserver/conf.d/users.lua
+fi
dito.
So mostly I wanna to know what way is properly for such type of situation.
Yeah, I think a proper README.Debian that explains the situation would
be much more clear than copy copies of configuration files around in the
package and the system.
--
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4
Re: [SCM] crtmpserver/master: Split package to 4 parts
Hi Reinhard, Yeah, I see. Thanks alot. So there are question: Right not script get-orig-source is not actual, and do not make effective result. To import my version of script(which I actually use for import sources) I need to know next: what must be result of script execution ? Fresh source tree? Fresh source repacked tree ? With debian directory ? As tar(.gz) archive ? If this is described in some place, please point me the there. Also package not complete yet so there was no need to remove the binary package crtmpserver(from control) :) I'll finish this package for a few days. Also there is old question: in which way I can release old version with incremented minor version, if my master git-branch goes forward from old version? Make git brach and point tag to it ? On Mon, Oct 03, 2011 at 10:21:22AM +0200, Reinhard Tartler wrote: I noticed crtmpserver on PET hanging around, waiting for a reviewer and I took a look at it. On Fr, Jul 29, 2011 at 15:04:17 (CEST), Andriy Beregovenko wrote: Hi, On Thursday 28 July 2011 14:04:39 Alessio Treglia you wrote: On Thu, Jul 28, 2011 at 8:25 AM, jet-gu...@users.alioth.debian.org wrote: The following commit has been merged in the master branch: commit 589879437b6083106bb2ffa4a09ec6fff7cd5b0c Author: Andriy Beregovenko j...@jet.kiev.ua Date: Thu Jul 28 01:31:05 2011 +0300 Split package to 4 parts libs will install only basic libs (common and thelib) apps will install only applications main will install main binary, doc, examples, init script and basic configuration file \o/ What's the rationale? In fact, this software is the platform that consists of several components: - the main component library; - applications that use these libraries; - actually the main executable file / daemon and supported files like docs, configs etc... We can install only crtmpserver-libs and crtmpserver-dev and makes own software. Do you do this? Do you have any indication that there are users doing this? I'm asking because I notice the libs are installed in a private path, so this isn't directly accessible. Of course you can override this with proper linker paths, but there is neither documentation nor helper scripts/pkg-config files that would assist with that. Moreover, the package descriptions don't really explain what's going on, so I have doubts that the split in the current form is helpful for the users. I also note that the .orig.tar gz is an svn checkout. Please use 'svn export' instead. For the next upload (the package is RC buggy atm, after all), what shall we do? Shall we revert the fix, or do we want to keep it? Cheers, Reinhard -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] crtmpserver/master: Split package to 4 parts
Hi, On Thursday 28 July 2011 14:04:39 Alessio Treglia you wrote: On Thu, Jul 28, 2011 at 8:25 AM, jet-gu...@users.alioth.debian.org wrote: The following commit has been merged in the master branch: commit 589879437b6083106bb2ffa4a09ec6fff7cd5b0c Author: Andriy Beregovenko j...@jet.kiev.ua Date: Thu Jul 28 01:31:05 2011 +0300 Split package to 4 parts libs will install only basic libs (common and thelib) apps will install only applications main will install main binary, doc, examples, init script and basic configuration file \o/ What's the rationale? In fact, this software is the platform that consists of several components: - the main component library; - applications that use these libraries; - actually the main executable file / daemon and supported files like docs, configs etc... We can install only crtmpserver-libs and crtmpserver-dev and makes own software. -- With best regards, Andriy ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: package pkg-multimedia/crtmpserver looking for mentor(s)
субота 16 квітень 2011 23:13:17 Reinhard Tartler ви написали: On Fri, Apr 15, 2011 at 21:38:42 (CEST), Reinhard Tartler wrote: I had another look at the package. In debian/crtmpserver.install, the package installs crtmpserver/crtmpserver.lua - etc/crtmpserver. However, this configuration file seems horribly specific to me; i.e., we can safely expect that every user *will* definitly want to edit and adjust the contents. This also means that dpkg *will* prompt on every package upgrade that changes anything in the file. Sorry, the more I think about it, I come to the conclusion that a) we should not install the config file to /etc/ b) not install the init script c) not create the system user This will reduce a lot of complexity in the package, which wouldn't help our users much anyway. I have now implemented this change in a way that can be easily reverted. Please have a look and either revert or OK this change. I'm novice in debian packing policy, so I prefer to listen to more experienced people. Also, your point of view is not meaningless. That is why I agree with most part of your modifications. But, I'm still not understand why crtmpserver.lua is horribly specific. All other issues follow by this one. ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: package pkg-multimedia/crtmpserver looking for mentor(s)
понеділок 18 квітень 2011 17:53:45 Reinhard Tartler ви написали: On Mon, Apr 18, 2011 at 15:13:17 (CEST), Andriy Beregovenko wrote: субота 16 квітень 2011 23:13:17 Reinhard Tartler ви написали: On Fri, Apr 15, 2011 at 21:38:42 (CEST), Reinhard Tartler wrote: I had another look at the package. In debian/crtmpserver.install, the package installs crtmpserver/crtmpserver.lua - etc/crtmpserver. However, this configuration file seems horribly specific to me; i.e., we can safely expect that every user *will* definitly want to edit and adjust the contents. This also means that dpkg *will* prompt on every package upgrade that changes anything in the file. Sorry, the more I think about it, I come to the conclusion that a) we should not install the config file to /etc/ b) not install the init script c) not create the system user This will reduce a lot of complexity in the package, which wouldn't help our users much anyway. I have now implemented this change in a way that can be easily reverted. Please have a look and either revert or OK this change. I'm novice in debian packing policy, so I prefer to listen to more experienced people. Also, your point of view is not meaningless. That is why I agree with most part of your modifications. But, I'm still not understand why crtmpserver.lua is horribly specific. All other issues follow by this one. Well, the file does not seem to be meant used unmodified; au contrary, AFAIUI you *must* edit it to specify what content you want to stream. Mostly not need. Current configuration file is big cause it there are many explanations what we can do. Also it is generic :). Yes, we can specify some static configuration like pulling/pushing streams, static pointing to some directory with media files and few other options. But main work of this software is dynamic streaming. Someone push stream into it, and another one play it :) Anyway, currently there are plans to move configuration to separated files (in conf.d style) Also you can simply specify your own configuration file via defaults. For novice it works by default. Anyway I review configuration file and I will make it less specific. And these are the modification that will trigger conffile changes on every upgrade, which I think we should avoid. I think about this, but there are many packages which has like situation(squid for example). I take your mail as OK to the simplification and will upload it tonight or tomorrow then. Yes, I would be very grateful. Cheers! ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: package pkg-multimedia/crtmpserver looking for mentor(s)
Hi.
Any news ? :)
понеділок 11 квітень 2011 23:58:42 Reinhard Tartler ви написали:
On Wed, Apr 06, 2011 at 18:40:12 (CEST), Reinhard Tartler wrote:
On Wed, Apr 06, 2011 at 16:02:26 (CEST), Andriy Beregovenko wrote:
Hi,
Still looking for uploader :)
As I understand package now is clean.
I'll try to have a look tonight or tomorrow evening.
It seems that Alessio is already on it. Alessio, do you want to take
over?
I took a brief look and found the system user creation a bit
strange. If you created the user in postinst, you wouldn't need the
pre-dependency on adduser. And moreover, since the default configuration
doesn't start the daemon anyways, I'd rather skip the system user
creation completely and install the crtmpserver.lua config file in
/usr/share/doc/crtmpserver/examples instead of /etc/crtmpserver along
with some instructions to the users how to start the daemon.
This will save you a lot of headaches and bugreports.
The file debian/source/local-options is missing, see the wiki for
details
In debian/rules, where do the variables ${SVER} and ${DEBPATH} come from?
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: package pkg-multimedia/crtmpserver looking for mentor(s)
понеділок 11 квітень 2011 23:58:42 Reinhard Tartler ви написали:
On Wed, Apr 06, 2011 at 18:40:12 (CEST), Reinhard Tartler wrote:
On Wed, Apr 06, 2011 at 16:02:26 (CEST), Andriy Beregovenko wrote:
Hi,
Still looking for uploader :)
As I understand package now is clean.
I'll try to have a look tonight or tomorrow evening.
It seems that Alessio is already on it. Alessio, do you want to take
over?
I took a brief look and found the system user creation a bit
strange. If you created the user in postinst, you wouldn't need the
pre-dependency on adduser.
Has no reason to finish package install if user can not be created(or not
already exist). That is why I put user creation in preinst. Also adduser dep
was added looking into other packages. Need I remove this dep ?
And moreover, since the default configuration
doesn't start the daemon anyways,
Hm... By default after install, daemon must start. This works for me and some
another test platforms. So if it not start this is bug. In that way please
describe me a little you situation about this.
I'd rather skip the system user
creation completely and install the crtmpserver.lua config file in
/usr/share/doc/crtmpserver/examples instead of /etc/crtmpserver along
with some instructions to the users how to start the daemon.
This will save you a lot of headaches and bugreports.
The file debian/source/local-options is missing, see the wiki for
details
Fixed.
In debian/rules, where do the variables ${SVER} and ${DEBPATH} come from?
This was used by me, at time of build in my env. Of course this is
unacceptable for package at all. So I move ${SVER} to static string in rules,
and ${DEBPATH} to $(shell pwd).
Also I understand that $(shell pwd) is exactly wrong form, but right now I
do not see any way to provide value for CRMPSERVER_SOURCE_ROOT variable. If
you know how, please tell me(CRMPSERVER_SOURCE_ROOT must be pointed to package
source root).
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: package pkg-multimedia/crtmpserver looking for mentor(s)
Hi, Still looking for uploader :) As I understand package now is clean. On Friday 25 March 2011 11:53:16 Andriy Beregovenko wrote: Hi. I'm still looking for mentor for my package crtmpserver. Also, if someone can, please review package and show me the flaws that prevent it from uploading. It is here: http://git.debian.org/?p=pkg-multimedia/crtmpserver.git ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: package pkg-multimedia/crtmpserver looking for mentor(s)
Hi. Finally I remove tinyxml from sources and crtmpserver success build with systemwide tinyxml. Also cleaned copyright. So looking for review package and (if all clean) for uploader. п'ятниця 25 березень 2011 14:06:27 Andriy Beregovenko ви написали: п'ятниця 25 березень 2011 13:25:39 Alessio Treglia ви написали: Please take a look at this too: E: crtmpserver: embedded-library usr/lib/crtmpserver/libcommon.so: tinyxml N: N:The given ELF object appears to have been statically linked to a N:library. Doing this is strongly discouraged due to the extra work needed N:by the security team to fix all the extra embedded copies or trigger the N:package rebuilds, as appropriate. N: N:If the package uses a modified version of the given library it is highly N:recommended to coordinate with the library's maintainer to include the N:changes on the system version of the library. N: N:Refer to Debian Policy Manual section 4.13 (Convenience copies of code) N:for details. N: N:Severity: serious, Certainty: possible Waiting for upstream update which allows to use systemwide tinyxml. This will happen today :) ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: package pkg-multimedia/crtmpserver looking for mentor(s)
п'ятниця 25 березень 2011 12:47:44 Alessio Treglia ви написали: Hi Andriy, On Fri, Mar 25, 2011 at 10:53 AM, Andriy Beregovenko j...@jet.kiev.ua wrote: Hi. I'm still looking for mentor for my package crtmpserver. Also, if someone can, please review package and show me the flaws that prevent it from uploading. It is here: http://git.debian.org/?p=pkg-multimedia/crtmpserver.git I'm on it, please would you extend the description of the patches, filling them with all fields needed as per DEP-3 spec? [1] Moreover, just saying what the patch does is not enough, it would be good to elaborate a bit the rationale. I'll fix this in few ten minute. Great job man! [1] http://dep.debian.net/deps/dep3/ ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: package pkg-multimedia/crtmpserver looking for mentor(s)
п'ятниця 25 березень 2011 13:25:39 Alessio Treglia ви написали: Please take a look at this too: E: crtmpserver: embedded-library usr/lib/crtmpserver/libcommon.so: tinyxml N: N:The given ELF object appears to have been statically linked to a N:library. Doing this is strongly discouraged due to the extra work needed N:by the security team to fix all the extra embedded copies or trigger the N:package rebuilds, as appropriate. N: N:If the package uses a modified version of the given library it is highly N:recommended to coordinate with the library's maintainer to include the N:changes on the system version of the library. N: N:Refer to Debian Policy Manual section 4.13 (Convenience copies of code) N:for details. N: N:Severity: serious, Certainty: possible Waiting for upstream update which allows to use systemwide tinyxml. This will happen today :) ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Looking for sponsor or mentor for package crtmpserver
On Tue, Mar 15, 2011 at 07:44:04PM +0100, Alessandro Ghedini wrote:
On Tue, Mar 15, 2011 at 02:20:46PM +0200, Andriy Beregovenko wrote:
I'm already create repo and now preparing source files to initial commit :)
If somebody can check it, please do this :) I'll be very grateful :)
I don't see any 'upstream' nor 'pristine-tar' branches. You should do
'git push --all' to properly create all the branches that git-buildpackage
made, on the remote repository.
Please tell me, where I can read complete manual about basic requirements to
repo.
Also, since you have repackaged the orig.tar archive, you have also to
document it properly in the d/copyright (you can use a 'Comment:' field), or
in the d/README.source file, telling what and why you have removed (like
[0]).
What do you mean under orig.tar archive? Archive from project owner ?
It does not exist. There is only svn repo. But ok, I'll document what and
why I remove or move.
As per Debian Policy you also have to provide a 'get-orig-source' target
in the d/rules file, which builds properly the new tarball (without the
files you decided to remove). This makes easier for future maintainance
(you won't have to repack the tarball manually every time you update the
package).
Actually, the get-orig-source rule would have been required anyway, since
you are using directly the sources from a SVN repository (I have not much
experience in packaging directly from svn, so I missed this at the
beginning). Have a look at [1] for an example of what you should do.
Right now I have sh-script which automate all this routine(i mean create
from original sources debian tree), but I do not know how I can include it.
And this script is present in original svn-repo:
http://trac.rtmpd.com/browser/trunk/builders/packing/debian
But I have some doubts about repacking. Currentrly I rebuild all tree for
debian project. But original project have entirely different structure.
(You can see it here: http://trac.rtmpd.com/browser/trunk)
The main reason for this step was too many unnecessary in builders dir and
several not needed dirs, so I create source tree for deb package in
traditional cmake style. So I need advice on this issue.
Another requirement for the repackaged upstream tarball is to add something
like '~dfsg' to both the source and binary packages version just to make
clear to everyone that you have modified it. The package versions would
look something like:
0.0~dfsg+revNNN for the source package
0.0~dfsg+revNNN-1 for the binary package
Finally, you don't need to Build-Depend on quilt, since it is implied by
the 3.0 (quilt) source format (was it there also in the previous versions
of the package? I think I missed it...).
Ok, I'll do this. Also I remove quilt from deps.
Oh, and you didn't need to remove the lualib sources completely, since
they are DFSG-compliant. You just needed to patch the sources to use the
system-provided one and the build system to not build the local copy.
Since you would have repackaged the orig tarball anyway, IMHO, is not a
grave issue (but I may be wrong).
Mostly lualib is needed to build embeded version of crtmpserver(not in
debian environment). I do not see any reason to keep lualib sourses in
project tree.
Cheers
[0]
http://git.debian.org/?p=pkg-multimedia/deadbeef.git;a=blob;f=debian/README.source;h=ea7bb6b1dd7368aa7c5cd8813cf8996dc4e8b6ae;hb=HEAD
[1] http://wiki.debian.org/SandroTosi/Svn_get-orig-source
--
perl -E'$_=q;$/= @{[@_]};and s;\S+;inidehG ordnasselA;eg;say~~reverse'
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Looking for sponsor or mentor for package crtmpserver
On Wed, Mar 16, 2011 at 10:24:23AM +0100, Reinhard Tartler wrote: On Tue, Mar 15, 2011 at 19:44:04 (CET), Alessandro Ghedini wrote: On Tue, Mar 15, 2011 at 02:20:46PM +0200, Andriy Beregovenko wrote: I'm already create repo and now preparing source files to initial commit :) If somebody can check it, please do this :) I'll be very grateful :) I don't see any 'upstream' nor 'pristine-tar' branches. You should do 'git push --all' to properly create all the branches that git-buildpackage made, on the remote repository. it seems that Andriy's branch has not been developed using the git-buildpackage workflow, but he has rather just imported the contents of his package branch. Andriy, can you confirm? You are absolutely right. I prepare sources, copy it to local git and add+commit+push it. if somewhere are any doc about right way to create repo and filling it, please tell me where I can read/find it :) Can you please fix this, and also clarify what changes you did to the originial sources. the version number needs to be adapted as well. -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Looking for sponsor or mentor for package crtmpserver
Hi, thanks for the explanation:) I'll do it:) Now must read some docs/wiki/faq :) On Tue, Mar 15, 2011 at 02:29:35AM +0100, Jonas Smedegaard wrote: On Mon, Mar 14, 2011 at 11:09:20PM +0200, Andriy Beregovenko wrote: So, if you can, please review my package via mentors.debian.net You have joined a team here, and now participating in teamwork - which os different from solo work needing mentoring. :-) So please instead of using that mentors site upload to collab-maint so that we can properly maintain this together. Regards, - Jonas -- * Jonas Smedegaard - idealist Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Looking for sponsor or mentor for package crtmpserver
On Tue, Mar 15, 2011 at 12:18:46PM +0100, Jonas Smedegaard wrote: On Tue, Mar 15, 2011 at 07:17:48AM +0100, Reinhard Tartler wrote: On Tue, Mar 15, 2011 at 02:29:35 (CET), Jonas Smedegaard wrote: On Mon, Mar 14, 2011 at 11:09:20PM +0200, Andriy Beregovenko wrote: So, if you can, please review my package via mentors.debian.net You have joined a team here, and now participating in teamwork - which os different from solo work needing mentoring. :-) So please instead of using that mentors site upload to collab-maint so that we can properly maintain this together. I guess Jonas means a pkg-multimedia git repository instead of collab-maint. But staging in collab-maint makes migration to pkg-multimedia trivial, so this is good advice in any case! Sorry - thanks for correcting me: I totally forgot that we use an own access group (and no, I had no political message hidden in that!). I actually disagree that collab-maint makes a good staging area: It requires different access rights and there is no benefit IMO to cause noise there first - mess can just as well be poured into pkg-multimedia directly (or ideally avoided, obviously). I'm already create repo and now preparing source files to initial commit :) If somebody can check it, please do this :) I'll be very grateful :) Or please elaborate on why you find it good to use both? - Jonas -- * Jonas Smedegaard - idealist Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Looking for sponsor or mentor for package crtmpserver
Hi,
On Mon, Mar 14, 2011 at 10:16:01AM +0100, Alessandro Ghedini wrote:
Hello Andriy,
On Mon, Mar 14, 2011 at 02:01:45AM +0200, Andriy Beregovenko wrote:
I'm looking for sponsor or mentor to my package crtmpserver.
Here is ITP:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=617641
and package on mentors.debian.net:
http://mentors.debian.net/cgi-bin/sponsor-pkglist?action=details;package=crtmpserver
In two words:
crmpserver is high performance streaming server. It support several
protocols family like: RTMP, RTSP/RTCP/RTP, MPEG-TS, plain flv publishing.
Also it is generic network platform, and creating custom protocols with it
is
really easy. In future plans are implement next protocols: gearman(already
exist but not too clean, so not included yet), memcached, possible redis.
Also there is some implementation of RTMFP protocol, but still not clean.
This allow use crtmpserver as universal network media streaming platform.
Licensed under GNU GPLv3.
Here is a quick review of your package :)
- debian/init.d should be named debian/[package].init (have a look at the
dh_installinit manpage)
Ok, I fix this now :)
- debian/copyright looks wrong. There are many files licensed BSD-3-clause
and zlib/libpng. You should include them in the copyright as well.
Also, you may want to convert d/copyright to use the DEP5 format [0]
(not strictly needed, but very appreciated)
I do not see any BSD-licensed files
- Missing debian/watch file (I'm not sure if this can be fixed)
Right now watch file is not added cause original project do not have any
release and have every day commits. So, imo, there is not any practical
reason to track version.
- If you don't use the Vcs-* fields in debian/control you should remove
them (they are currently commented-out)
Ok.
- There are many lintian I, P and even E tags. Please fix them (and use
lintian -IE --pedantic to check your package). For example:
P: crtmpserver source: source-contains-svn-control-dir ...
E: crtmpserver: copyright-should-refer-to-common-license-file-for-gpl ..
E: crtmpserver: possible-gpl-code-linked-with-openssl ...
I: crtmpserver: copyright-with-old-dh-make-debian-copyright ...
I: crtmpserver: spelling-error-in-binary ...
[...]
I'm novice in debian policies and need some help as for
possible-gpl-code-linked-with-openssl. Also what version of dh_make i must
to use ? Currently I use 0.58 (squeeze).
Please also consider joining the Debian Multimedia Maintainers team to
(co-)maintain this and (when you'll feel comfortable) other
multimedia-related packages.
In the team you'll find valuable mentors that'll guide and help you in
the process of maintaining this and other (multimedia-related) packages.
Have a look at the team's wiki [0], if you agree with our policies (e.g.
using git to co-maintain packages, using quilt for managing patches, etc...)
you are very welcome. :)
(if you accept let us know your account name on alioth.debian.org so that I
or someone else can add you to the pkg-multimedia project and setup a git
repository for your package)
Yes, I agree and want to join your team :)
My nick is jet-guest on alioth.
Cheers
[0] http://wiki.debian.org/DebianMultimedia/DevelopPackaging
--
perl -E'$_=q;$/= @{[@_]};and s;\S+;inidehG ordnasselA;eg;say~~reverse'
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Looking for sponsor or mentor for package crtmpserver
Hi,
I update package and looks like lintian clean(except no-upstream-changelog
and some info as for libs).
Already uploaded to mentors.debian.net
On Mon, Mar 14, 2011 at 10:16:01AM +0100, Alessandro Ghedini wrote:
Hello Andriy,
On Mon, Mar 14, 2011 at 02:01:45AM +0200, Andriy Beregovenko wrote:
I'm looking for sponsor or mentor to my package crtmpserver.
Here is ITP:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=617641
and package on mentors.debian.net:
http://mentors.debian.net/cgi-bin/sponsor-pkglist?action=details;package=crtmpserver
In two words:
crmpserver is high performance streaming server. It support several
protocols family like: RTMP, RTSP/RTCP/RTP, MPEG-TS, plain flv publishing.
Also it is generic network platform, and creating custom protocols with it
is
really easy. In future plans are implement next protocols: gearman(already
exist but not too clean, so not included yet), memcached, possible redis.
Also there is some implementation of RTMFP protocol, but still not clean.
This allow use crtmpserver as universal network media streaming platform.
Licensed under GNU GPLv3.
Here is a quick review of your package :)
- debian/init.d should be named debian/[package].init (have a look at the
dh_installinit manpage)
- debian/copyright looks wrong. There are many files licensed BSD-3-clause
and zlib/libpng. You should include them in the copyright as well.
Also, you may want to convert d/copyright to use the DEP5 format [0]
(not strictly needed, but very appreciated)
- Missing debian/watch file (I'm not sure if this can be fixed)
- If you don't use the Vcs-* fields in debian/control you should remove
them (they are currently commented-out)
- There are many lintian I, P and even E tags. Please fix them (and use
lintian -IE --pedantic to check your package). For example:
P: crtmpserver source: source-contains-svn-control-dir ...
E: crtmpserver: copyright-should-refer-to-common-license-file-for-gpl ..
E: crtmpserver: possible-gpl-code-linked-with-openssl ...
I: crtmpserver: copyright-with-old-dh-make-debian-copyright ...
I: crtmpserver: spelling-error-in-binary ...
[...]
Please also consider joining the Debian Multimedia Maintainers team to
(co-)maintain this and (when you'll feel comfortable) other
multimedia-related packages.
In the team you'll find valuable mentors that'll guide and help you in
the process of maintaining this and other (multimedia-related) packages.
Have a look at the team's wiki [0], if you agree with our policies (e.g.
using git to co-maintain packages, using quilt for managing patches, etc...)
you are very welcome. :)
(if you accept let us know your account name on alioth.debian.org so that I
or someone else can add you to the pkg-multimedia project and setup a git
repository for your package)
Cheers
[0] http://wiki.debian.org/DebianMultimedia/DevelopPackaging
--
perl -E'$_=q;$/= @{[@_]};and s;\S+;inidehG ordnasselA;eg;say~~reverse'
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Looking for sponsor or mentor for package crtmpserver
Hi, Let me to summarize: - fixed init script name - fixed licenses: * added body of GPL3, GPL3 with Openssl exclusion, BSD, zlib * specified licenses of files * removed MIT license(due to lua remove) - removed custom snapshot of lua, now use system lua(detect via cmake) - copyright moved to DEP5 format - removed not needed htmls and other garbage(now only clean sources left) As I can see 2 lintian message left: no-upstream-changelog debian-watch-file-is-missing As I understand this is not a problem thing but is not so important for binary package. So, if you can, please review my package via mentors.debian.net On Mon, Mar 14, 2011 at 06:30:17PM +0100, Alessandro Ghedini wrote: On Mon, Mar 14, 2011 at 11:32:18AM +0200, Andriy Beregovenko wrote: - debian/init.d should be named debian/[package].init (have a look at the dh_installinit manpage) Ok, I fix this now :) Good. - debian/copyright looks wrong. There are many files licensed BSD-3-clause and zlib/libpng. You should include them in the copyright as well. Also, you may want to convert d/copyright to use the DEP5 format [0] (not strictly needed, but very appreciated) I do not see any BSD-licensed files % licensecheck -R --copyright . | grep BSD ./common/src/platform/solaris/timegm.cpp: BSD (3 clause) ./common/src/platform/windows/strncasecmp.cpp: BSD (3 clause) ./common/src/platform/windows/timegm.cpp: BSD (3 clause) ./common/src/platform/windows/strptime.cpp: BSD (3 clause) ./common/src/platform/android/timegm.cpp: BSD (3 clause) Look at these files. - Missing debian/watch file (I'm not sure if this can be fixed) Right now watch file is not added cause original project do not have any release and have every day commits. So, imo, there is not any practical reason to track version. Agree. - If you don't use the Vcs-* fields in debian/control you should remove them (they are currently commented-out) Ok. - There are many lintian I, P and even E tags. Please fix them (and use lintian -IE --pedantic to check your package). For example: P: crtmpserver source: source-contains-svn-control-dir ... E: crtmpserver: copyright-should-refer-to-common-license-file-for-gpl .. E: crtmpserver: possible-gpl-code-linked-with-openssl ... I: crtmpserver: copyright-with-old-dh-make-debian-copyright ... I: crtmpserver: spelling-error-in-binary ... [...] I'm novice in debian policies and need some help as for possible-gpl-code-linked-with-openssl. This means that a GPLed software is linking against openssl (which has a gpl-incompatible license) and is, therefore, illegal. See [0]. From the d/copyright of the latest version of the package I see: GPL-3.0+ with OpenSSL exception What does it mean? Where is the OpenSSL exception documented? In the copyright you should point to the proper documentation. Also what version of dh_make i must to use ? Currently I use 0.58 (squeeze). It's not a matter of which dh-make version you use. It simply says that the debian/copyright template, which has been created by an older version of dh-make have to be updated. Now you use DEP5 so there is no problem (note that newer dh-make version from sid creates a DEP5 template). Please also consider joining the Debian Multimedia Maintainers team to (co-)maintain this and (when you'll feel comfortable) other multimedia-related packages. In the team you'll find valuable mentors that'll guide and help you in the process of maintaining this and other (multimedia-related) packages. Have a look at the team's wiki [0], if you agree with our policies (e.g. using git to co-maintain packages, using quilt for managing patches, etc...) you are very welcome. :) (if you accept let us know your account name on alioth.debian.org so that I or someone else can add you to the pkg-multimedia project and setup a git repository for your package) Yes, I agree and want to join your team :) My nick is jet-guest on alioth. I added you to the group on alioth.d.o :) Also note that I'm not a DD (maybe I should have said this before), therefore I can't upload your package, but I am sure you'll find someone in the team to do so (when the package will be in a proper shape, of course). On Mon, Mar 14, 2011 at 01:31:27PM +0200, Andriy Beregovenko wrote: I update package and looks like lintian clean(except no-upstream-changelog and some info as for libs). Not quite true, I still see many spelling-error-in-binary. You should patch the source files fixing those spelling errors. I've also spotted some more issues: - In debian/control the long description starts with a '.'. It is not necessary (you can remove it). - The package includes and compiles the whole liblua sources. It should rely on libraries provided by the system rather than build and link against local copies
Looking for sponsor or mentor for package crtmpserver
Hi, I'm looking for sponsor or mentor to my package crtmpserver. Here is ITP: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=617641 and package on mentors.debian.net: http://mentors.debian.net/cgi-bin/sponsor-pkglist?action=details;package=crtmpserver In two words: crmpserver is high performance streaming server. It support several protocols family like: RTMP, RTSP/RTCP/RTP, MPEG-TS, plain flv publishing. Also it is generic network platform, and creating custom protocols with it is really easy. In future plans are implement next protocols: gearman(already exist but not too clean, so not included yet), memcached, possible redis. Also there is some implementation of RTMFP protocol, but still not clean. This allow use crtmpserver as universal network media streaming platform. Licensed under GNU GPLv3. ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
