Bug#788325: easytag: Don't register as default handler for directories
Hi James On 2015-06-10 11:10, James Cowgill james...@cowgill.org.uk wrote: This bug has been reported a few times upstream. … The argument against changing it was that easytag can infact handle the inode/directory MIME type properly so it should be allowed to have it in it's MimeTypes list. On balance (due to the issues it causes) I would probably lean towards removing it, which I see has already been done in git. The MIME type is still present in the desktop file (and in the Nautilus extension for the master branch) in git. David? It is not really a problem of EasyTAG that installing a desktop file, with a valid list of accepted MIME types, causes a different part of the system to adjust its associations. There is no defined way to adjust MIME type associations across all desktop environments, and each environment handles this differently. Modern GNOME versions simply ignore the inode/directory MIME association on anything that is not Nautilus. In this specific case, if gnome-open (an old GNOME2 component) fails and xdg-open succeeds, it simply means that each has a different way of handling a newly-installed desktop file with a MimeType key. If you want to work around the bugs (or unexpected behaviours) in each desktop environment by removing the inode/directory MIME type, that is something that is best done downstream. The root cause of the issue either needs fixing with a freedesktop.org specification for MIME type associations and desktop-specific (as well as desktop-neutral) defaults, or for the current specifications to be updated to do something similar. As far as I know, this problem is not specific to the inode/directory MIME type, so I do not see why it should be singled out as a problematic case. -- http://amigadave.com/ signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
easytag 2.2.4-1 ready for review/upload
Hi I updated easytag to the latest upstream version, and it would be good if someone can review the changes and upload it. Thanks! -- http://amigadave.com/ signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
easytag-2.2.0-1 ready for review/upload
Hi pkg-multimedia-maintainers I just finished packaging the latest upstream release, and I think that it is ready for review and upload. I initially forgot to add myself to the list of uploaders, as James Cowgill suggested: http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/2014-March/037353.html I have done so now, so I hope that the extra commit for the changelog is OK. -- http://amigadave.com/ signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
[PATCH 1/4] Add initial changelog entry
--- debian/changelog | 6 ++ 1 file changed, 6 insertions(+) diff --git a/debian/changelog b/debian/changelog index 927b4d5..be9b89a 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +easytag (2.1.10-2) UNRELEASED; urgency=low + + * Non-maintainer upload. + + -- David King amigad...@amigadave.com Fri, 07 Mar 2014 12:27:26 + + easytag (2.1.10-1) unstable; urgency=medium * Team upload. -- 1.8.5.3 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Crash fix and small improvements for easytag
Hi James and pkg-multimedia Thanks for getting EasyTAG 2.1.10 into Debian. I just installed Debian in a virtual machine, so hopefully I can help out a bit with packaging. There has been one important fix added since 2.1.10 was released, about a possible crash while clicking the window close button, and I think that it is worth including. To get rid of a buildd warning about hidden compiler flags, I disabled silent build rules. appdata-tools is now in experimental, so I added the dependency. I am still quite new to Debian packaging, so reviews are very welcome. Thanks ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
[PATCH 2/4] Drop remove-appdata.patch, depend on appdata-tools
--- debian/control | 1 + debian/patches/remove-appdata.patch | 58 - debian/patches/series | 1 - 3 files changed, 1 insertion(+), 59 deletions(-) delete mode 100644 debian/patches/remove-appdata.patch diff --git a/debian/control b/debian/control index c907bf6..a51512d 100644 --- a/debian/control +++ b/debian/control @@ -7,6 +7,7 @@ Uploaders: Reinhard Tartler siret...@tauware.de, James Cowgill james...@cowgill.org.uk Build-Depends: + appdata-tools, debhelper (= 9), desktop-file-utils, dh-autoreconf, diff --git a/debian/patches/remove-appdata.patch b/debian/patches/remove-appdata.patch deleted file mode 100644 index e1d9b19..000 --- a/debian/patches/remove-appdata.patch +++ /dev/null @@ -1,58 +0,0 @@ -Description: Remove AppData from build system - This requires the appdata-tools package which is not in Debian yet. - Partially reverts upstream commit https://git.gnome.org/browse/easytag/commit/?id=02d199b2cac7c34b36cb534a48eda32172efb941 -Author: James Cowgill james...@cowgill.org.uk -Forwarded: not-needed -Last-Update: 2014-02-22 -This patch header follows DEP-3: http://dep.debian.net/deps/dep3/ a/configure.ac -+++ b/configure.ac -@@ -27,9 +27,6 @@ - AS_IF([test x$USE_NLS != xno], - [AC_DEFINE([ENABLE_NLS], [1], [Native Language support is enabled])]) - --dnl AppData --APPDATA_XML -- - dnl --- - dnl Checks for programs. - dnl --- a/Makefile.am -+++ b/Makefile.am -@@ -1,7 +1,6 @@ - ACLOCAL_AMFLAGS = -I m4 - - DISTCHECK_CONFIGURE_FLAGS = \ -- --enable-appdata-check \ - --enable-flac \ - --enable-id3v23 \ - --enable-ogg \ -@@ -149,11 +148,6 @@ - $(AM_V_at)$(MKDIR_P) $(@D) - $(AM_V_at)touch $@ - --@APPDATA_XML_RULES@ --@INTLTOOL_XML_RULE@ --appdata_in_files = data/easytag.appdata.xml.in --appdata_XML = $(appdata_in_files:.appdata.xml.in=.appdata.xml) -- - @INTLTOOL_DESKTOP_RULE@ - desktopdir = $(datadir)/applications - desktop_in_files = data/easytag.desktop.in -@@ -230,7 +224,6 @@ - test -n $(DESTDIR) || $(UPDATE_ICON_CACHE) $(iconthemedir) - - dist_noinst_DATA = \ -- $(appdata_in_files) \ - $(desktop_in_files) \ - $(easytag_headers) \ - src/id3lib/patch_id3lib_3.8.3_UTF16_writing_bug.diff \ -@@ -267,7 +260,6 @@ - endif - - CLEANFILES = \ -- $(appdata_XML) \ - $(check_SCRIPTS) \ - $(desktop_DATA) \ - $(easytag_rc) \ diff --git a/debian/patches/series b/debian/patches/series index 79b5abe..e69de29 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -1 +0,0 @@ -remove-appdata.patch -- 1.8.5.3 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
[PATCH 4/4] Fix crash when clicking the window close button
---
debian/patches/fix-close-button-crash.patch | 43 +
debian/patches/series | 1 +
2 files changed, 44 insertions(+)
create mode 100644 debian/patches/fix-close-button-crash.patch
diff --git a/debian/patches/fix-close-button-crash.patch
b/debian/patches/fix-close-button-crash.patch
new file mode 100644
index 000..37a577b
--- /dev/null
+++ b/debian/patches/fix-close-button-crash.patch
@@ -0,0 +1,43 @@
+Description: Fix crash when clicking the window close button
+Origin: upstream,
https://git.gnome.org/browse/easytag/patch/?id=5442958d1ea34a992007bbb2bc047a9a5515387d
+Bug: https://bugzilla.gnome.org/show_bug.cgi?id=725568
+Bug-Fedora: https://bugzilla.redhat.com/show_bug.cgi?id=1071563
+Applied-Upstream: 2.1.11,
https://git.gnome.org/browse/easytag/commit/?id=5442958d1ea34a992007bbb2bc047a9a5515387d
+From: David King amigad...@amigadave.com
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+diff --git a/src/easytag.c b/src/easytag.c
+index 29eeb82..7f6ecc7 100644
+--- a/src/easytag.c
b/src/easytag.c
+@@ -156,6 +156,17 @@ static gboolean et_tag_field_on_key_press_event (GtkEntry
*entry,
+ GdkEventKey *event,
+ gpointer user_data);
+
++static gboolean
++on_main_window_delete_event (GtkWidget *window,
++ GdkEvent *event,
++ gpointer user_data)
++{
++Quit_MainWindow ();
++
++/* Handled the event, so stop propagation. */
++return TRUE;
++}
++
+ /*
+ * common_init:
+ * @application: the application
+@@ -225,8 +236,8 @@ common_init (GApplication *application)
+ // This part is needed to set correctly the position of handle panes
+
gtk_window_set_default_size(GTK_WINDOW(MainWindow),MAIN_WINDOW_WIDTH,MAIN_WINDOW_HEIGHT);
+
+-
g_signal_connect(G_OBJECT(MainWindow),delete_event,G_CALLBACK(Quit_MainWindow),NULL);
+-
g_signal_connect(G_OBJECT(MainWindow),destroy,G_CALLBACK(Quit_MainWindow),NULL);
++g_signal_connect (MainWindow, delete-event,
++ G_CALLBACK (on_main_window_delete_event), NULL);
+
+ /* Minimised window icon */
+ gtk_widget_realize(MainWindow);
+--
+cgit v0.9.2
diff --git a/debian/patches/series b/debian/patches/series
index e69de29..4280d60 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -0,0 +1 @@
+fix-close-button-crash.patch
--
1.8.5.3
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: Crash fix and small improvements for easytag
Hi Alessio On 2014-03-07 14:44, Alessio Treglia ales...@debian.org wrote: On Fri, Mar 7, 2014 at 1:18 PM, David King amigad...@amigadave.com wrote: I am still quite new to Debian packaging, so reviews are very welcome. I'd recommend you to create your own account on Alioth and eventually send us the request to join the team, so that you can start learning how to play with git together with the rest of the team and push your changes to the repositories yourself. Keep up the great work, and cheers! Thanks! I have registered for an Alioth account, and requested to join the team. My username is amigadave-guest. -- http://amigadave.com/ signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: Crash fix and small improvements for easytag
Hi James
On 2014-03-07 15:21, James Cowgill james...@cowgill.org.uk wrote:
Thanks David, I've pushed all the changes to the repository so I think this
can be uploaded straight away.
Thanks for that. You might want to also include this patch, which fixes
a crash when declining deletion of a file. I only just discovered and
fixed it.
--
http://amigadave.com/
From fa32884b675d38a7e03aed5e5d5903cfdb968269 Mon Sep 17 00:00:00 2001
From: David King amigad...@amigadave.com
Date: Fri, 7 Mar 2014 15:41:39 +
Subject: [PATCH] Fix crash when declining deletion of a file
---
debian/patches/fix-decline-delete-file-crash.patch | 29 ++
debian/patches/series | 1 +
2 files changed, 30 insertions(+)
create mode 100644 debian/patches/fix-decline-delete-file-crash.patch
diff --git a/debian/patches/fix-decline-delete-file-crash.patch b/debian/patches/fix-decline-delete-file-crash.patch
new file mode 100644
index 000..0b47812
--- /dev/null
+++ b/debian/patches/fix-decline-delete-file-crash.patch
@@ -0,0 +1,29 @@
+Description: Avoid crash when declining deleting a file
+Origin: upstream, https://git.gnome.org/browse/easytag/patch/?id=17afda799f95c97263e52ab41fa8c9676aba3021
+Applied-Upstream: 2.1.11, https://git.gnome.org/browse/easytag/commit/?id=17afda799f95c97263e52ab41fa8c9676aba3021
+From: David King amigad...@amigadave.com
+---
+diff --git a/src/easytag.c b/src/easytag.c
+index 40dbeec..52a1619 100644
+--- a/src/easytag.c
b/src/easytag.c
+@@ -2637,9 +2637,14 @@ Delete_Selected_Files_With_Answer (void)
+ ET_Remove_File_From_File_List(ETFile);
+ break;
+ case 0:
+-Log_Print (LOG_ERROR, _(Cannot delete file (%s)),
+- error-message);
+-g_error_free (error);
++/* Distinguish between the file being skipped, and there being
++ * an error during deletion. */
++if (error)
++{
++Log_Print (LOG_ERROR, _(Cannot delete file (%s)),
++ error-message);
++g_clear_error (error);
++}
+ break;
+ case -1:
+ // Stop deleting files + reinit progress bar
+--
+cgit v0.9.2
diff --git a/debian/patches/series b/debian/patches/series
index 4280d60..1bee884 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
fix-close-button-crash.patch
+fix-decline-delete-file-crash.patch
--
1.9.0
signature.asc
Description: Digital signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Add some useful Recommends to easytag
gvfs is used when loading from a URI (for example, dropping a URL to an image in the image tag view) gnome-icon-theme is used for the insert-text icon yelp is used for the application help ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
[PATCH] Recommend gvfs, gnome-icon-theme and yelp
---
debian/control | 3 +++
1 file changed, 3 insertions(+)
diff --git a/debian/control b/debian/control
index 11e74b1..e2b0ab9 100644
--- a/debian/control
+++ b/debian/control
@@ -34,6 +34,9 @@ Architecture: any
Depends:
${misc:Depends},
${shlibs:Depends}
+Recommends: gnome-icon-theme,
+gvfs,
+yelp
Description: viewing, editing and writing ID3 tags
EasyTAG is an utility for viewing, editing and writing
the ID3 tags of different audio files, using a GTK+ interface.
--
1.8.5.3
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: easytag 2.1.10
Hi James On 2014-02-24 19:41, James Cowgill james410atcowgill.org.uk wrote: I'm not in the multimedia team, but I've packaged easytag 2.1.10 after I kept getting crashes with the current version in Debian. I put the packaging on github if you want to look at it. https://github.com/jcowgill/debian-easytag I am the upstream maintainer of easytag, and I was just looking into doing this update myself. Thanks very much for your work on this, I would appreciate it if a Debian multimedia maintainer could look into getting your changes merged, as 2.1.10 has many stability fixes over 2.1.9 and 2.1.8 before that. I have only dabbled in Debian packaging before, although I maintain the Fedora package, and your changes look fine to me. Thanks again for your work on this. -- http://amigadave.com/ signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#701114: easytag: Please update to 2.1.8
On 2013-02-21 18:35, Reuben Thomas r...@sc3d.org wrote: The 2.1.8 release itself removes the Debian packaging, so I can't install it as easily as I did the pre-release, so it would be even nicer therefore if the Debian package were updated! I updated the packaging, which can be found at: https://github.com/amigadave/easytag-debian I am not that familiar with Debian packaging, so I probably made some mistakes, but I managed to build a binary package from the updates that I made, on Ubuntu 12.10. Is this packaging acceptable to be merged into the official Debian packaging? -- http://amigadave.com/ pgpzDPfiREx3i.pgp Description: PGP signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
