Re: [SCM] ffmpeg/master: Don't enable x11grab, which has been replaced with xcb.

[Andreas Cadhalpun]

Hi Felipe,

On 06.11.2016 22:15, Felipe Sateler wrote:
> On 6 November 2016 at 16:40,   wrote:
>> --- a/debian/rules
>> +++ b/debian/rules
>> @@ -88,8 +88,7 @@ CONFIG := --prefix=/usr \
>> --enable-libzmq \
>> --enable-libzvbi \
>> --enable-opengl \
>> -   --enable-sdl2 \
>> -   --enable-x11grab
>> +   --enable-sdl2
> 
> I think explicitly disabling is useful.

This setting is disabled by default, not autodetected,
so explicitly disabling is not useful here.

Best regards,
Andreas


___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: [SCM] ffmpeg/master: Don't enable x11grab, which has been replaced with xcb.

[Felipe Sateler]

On 6 November 2016 at 16:40,   wrote:
> The following commit has been merged in the master branch:
> commit 390d78a3b516af0544264fa0b11ea5cefeec5943
> Author: Andreas Cadhalpun 
> Date:   Sun Nov 6 19:54:10 2016 +0100
>
> Don't enable x11grab, which has been replaced with xcb.
>
> diff --git a/debian/control b/debian/control
> index 6c7d733..e7bc0f9 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -137,8 +137,6 @@ Build-Depends:
>   libx264-dev [!powerpcspe] ,
>  # --enable-libx265
>   libx265-dev (>= 1.8),
> -# --enable-x11grab
> - libxext-dev,
>  # --enable-libxvid
>   libxvidcore-dev,
>  # autodetected: decoder 'mpeg_xvmc'; outdev 'xv'
> diff --git a/debian/rules b/debian/rules
> index e9f90ed..f59b8eb 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -88,8 +88,7 @@ CONFIG := --prefix=/usr \
> --enable-libzmq \
> --enable-libzvbi \
> --enable-opengl \
> -   --enable-sdl2 \
> -   --enable-x11grab
> +   --enable-sdl2

I think explicitly disabling is useful. Having a build that differs
due to to extraneous packages installed is annoying.

Sometimes, allowing autodetection is useful: for example, it can lower
the diff between Debian and some other build that has some extra
libraries. However, explicit settings should be preferred whenever
possible:

1. They don't enable hidden features when an extra package is installed
2. Should a bug occur in the autodetection code, or on the depended
package, the feature will be silently disabled instead of failing the
build.

-- 

Saludos,
Felipe Sateler

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers