Re: [SCM] rtaudio/master: Add libpulse-dev to deps of -dev package. (Closes: #833271)

[Debian/GNU]

On 08/02/2016 04:42 PM, Jaromír Mikeš wrote:
> Hi Felipe,
> 
> I hope this is correct fix.
> It should be according bug description.
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=833271
> IOhannes can you comment on this please?

in theory i agree with felipe.
in practice there might be more to it than just patching
configure.ac/rtaudio.pc.in to exclude libpulse-simple.

i guess we should consult upstream about this.

until then, i believe that adding libpulse-dev to the deps is the
correct approach (it is a little like overlinking to unused libraries:
it doesn't do any good, but once you've done it, you also must¹ depend
on those (non-)dependencies...)

fgmards
IOhannes

¹ though this is probably not a real issue these days, with all these
"-as-needed" and what-not flags.



signature.asc
Description: OpenPGP digital signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: [SCM] rtaudio/master: Add libpulse-dev to deps of -dev package. (Closes: #833271)

[Jaromír Mikeš]

2016-08-02 15:39 GMT+02:00 Felipe Sateler :
> On 2 August 2016 at 07:43,   wrote:
>> The following commit has been merged in the master branch:
>> commit e34c103bad0f3ab33e7c6dd578cd061d6f4a57b1
>> Author: Jaromír Mikeš 
>> Date:   Tue Aug 2 13:37:36 2016 +0200
>>
>> Add libpulse-dev to deps of -dev package. (Closes: #833271)
>
>
> Is this the  correct fix? AFAICT there is no reason for an
> rtaudio-using package to require libpulse. The correct fix seems to me
> to be dropping libpulse-dev (and alsa) from Requires, as rtaudio is
> supposed to be an abstraction over those libraries, and the dev
> packages are not required:
>
> % grep '#include' RtAudio.h
> #include 
> #include 
> #include 
> #include 
>   #include 
>   #include 
>   #include 
>   #include 
> #include 
> #include 

Hi Felipe,

I hope this is correct fix.
It should be according bug description.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=833271
IOhannes can you comment on this please?

best regards

mira

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: [SCM] rtaudio/master: Add libpulse-dev to deps of -dev package. (Closes: #833271)

[Felipe Sateler]

On 2 August 2016 at 07:43,   wrote:
> The following commit has been merged in the master branch:
> commit e34c103bad0f3ab33e7c6dd578cd061d6f4a57b1
> Author: Jaromír Mikeš 
> Date:   Tue Aug 2 13:37:36 2016 +0200
>
> Add libpulse-dev to deps of -dev package. (Closes: #833271)


Is this the  correct fix? AFAICT there is no reason for an
rtaudio-using package to require libpulse. The correct fix seems to me
to be dropping libpulse-dev (and alsa) from Requires, as rtaudio is
supposed to be an abstraction over those libraries, and the dev
packages are not required:

% grep '#include' RtAudio.h
#include 
#include 
#include 
#include 
  #include 
  #include 
  #include 
  #include 
#include 
#include 

-- 

Saludos,
Felipe Sateler

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers