Re: Bug#643413: jack-tools: FTBFS: jack.dl.c:20:3: error: format not a string literal and no format arguments [-Werror=format-security] (patch)

2011-11-21 Thread Adrian Knoth 
On 11/19/11 00:48, Mònica Ramírez Arceda wrote:

Hi!

 tags 643413 +patch
 thanks

IOhannes: did you try to forward it to upstream? The patch header
doesn't mention anything related.


Cheers

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: Bug#643413: jack-tools: FTBFS: jack.dl.c:20:3: error: format not a string literal and no format arguments [-Werror=format-security] (patch)

2011-11-21 Thread IOhannes m zmoelnig 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 2011-11-21 16:23, Adrian Knoth wrote:
 On 11/19/11 00:48, Mònica Ramírez Arceda wrote:
 
 Hi!
 
 tags 643413 +patch
 thanks
 
 IOhannes: did you try to forward it to upstream? The patch header
 doesn't mention anything related.
 

good question.
given that i cannot find any hint in my outbox and that i am a bit lost
on the slavepianos website (me not being a darcs guy and finding no
instructions how to clone the repository on the website, thus not being
able to produce a proper patch for upstream), i fear that the answer is: no

dmf
IOhannes
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk7Ki+sACgkQkX2Xpv6ydvSbLgCgphAP4YyMmMHoJM2FRHZe2L5a
DasAn2lZ25dUm5CaBlQLJZPFz/bJav91
=YyL1
-END PGP SIGNATURE-



smime.p7s
Description: S/MIME Cryptographic Signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: Bug#643413: jack-tools: FTBFS: jack.dl.c:20:3: error: format not a string literal and no format arguments [-Werror=format-security] (patch)

2011-11-21 Thread Adrian Knoth 
On Mon, Nov 21, 2011 at 06:35:41PM +0100, IOhannes m zmoelnig wrote:

  tags 643413 +patch
  thanks
  
  IOhannes: did you try to forward it to upstream? The patch header
  doesn't mention anything related.
  
 good question.
 given that i cannot find any hint in my outbox and that i am a bit lost
 on the slavepianos website (me not being a darcs guy and finding no
 instructions how to clone the repository on the website, thus not being
 able to produce a proper patch for upstream), i fear that the answer is: no


Let's keep it simple and Cc the upstream author. ;)

Dear upstream author, the Debian project has a patch for jack-tools:

   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=643413

   
http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=10;filename=fix-format-security.patch;att=1;bug=643413


You might want to consider including it in your repository.


Cheers

-- 
mail: a...@thur.de  http://adi.thur.de  PGP/GPG: key via keyserver


___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: Bug#643413: jack-tools: FTBFS: jack.dl.c:20:3: error: format not a string literal and no format arguments [-Werror=format-security] (patch)

2011-11-21 Thread Rohan Drape 
hello adrian  iohannes

thanks -- applied -- also the gpl-gpl2+ edit as requested earlier.

rohan

ps.

 [1] http://slavepianos.org/rd/f/207983/

is obsolete, sorry -- you'd want:

  http://slavepianos.org/rd/?t=rju
  http://slavepianos.org/rd/?t=c-common

or to get archives type:

  darcs get http://slavepianos.org/rd/sw/rju
  darcs get http://slavepianos.org/rd/sw/c-common

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#643413: jack-tools: FTBFS: jack.dl.c:20:3: error: format not a string literal and no format arguments [-Werror=format-security] (patch)

2011-11-18 Thread Mònica Ramírez Arceda 
tags 643413 +patch
thanks

Trying to fix this bug :-)

Thanks for your work!
Description: Format an error string to avoid a format-security
 error while building.
Author: Mònica Ramírez Arceda mon...@probeta.net
Last-Update: 2011-11-19

--- a/jack.dl.c
+++ b/jack.dl.c
@@ -17,7 +17,7 @@

 void fail(char *s)
 {
-  fprintf(stderr, s);
+  fprintf(stderr, %s\n, s);
   exit(EXIT_FAILURE);
 }


___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers