Bug#802710: musescore: Embeds Qt5's private headers without putting them in a namespace

[Antonio Ospite]

Package: musescore
Version: 2.0.3+dfsg1-2
Followup-For: Bug #802710

Dear Maintainer,

on my system musescore is blocking the update to the latest Qt5 packages
in unstable as it depends on qtbase-abi-5-6-1.

Is this bug the cause of it?

Thanks,
   Antonio

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (900, 'unstable'), (500, 'unstable-debug')
Architecture: amd64 (x86_64)

Kernel: Linux 4.8.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=it_IT.utf8, LC_CTYPE=it_IT.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: systemd (via /run/systemd/system)

Versions of packages musescore depends on:
ii  desktop-file-utils   0.23-1
ii  libasound2   1.1.2-1
ii  libc62.24-5
ii  libfreetype6 2.6.3-3+b1
ii  libgcc1  1:6.2.0-10
ii  libportaudio219+svn20140130-1.1
ii  libpulse09.0-4
ii  libqt5core5a [qtbase-abi-5-6-1]  5.6.1+dfsg-3+b1
ii  libqt5gui5   5.6.1+dfsg-3+b1
ii  libqt5help5  5.6.1-4
ii  libqt5network5   5.6.1+dfsg-3+b1
ii  libqt5printsupport5  5.6.1+dfsg-3+b1
ii  libqt5qml5   5.6.1-11
ii  libqt5quick5 5.6.1-11
ii  libqt5sql5-sqlite5.6.1+dfsg-3+b1
ii  libqt5svg5   5.6.1-2
ii  libqt5webkit55.6.1+dfsg-5
ii  libqt5widgets5   5.6.1+dfsg-3+b1
ii  libqt5xml5   5.6.1+dfsg-3+b1
ii  libqt5xmlpatterns5   5.6.1-2
ii  libsndfile1  1.0.27-1
ii  libstdc++6   6.2.0-10
ii  libvorbisfile3   1.3.5-3
ii  musescore-common 2.0.3+dfsg1-2
ii  qml-module-qtquick-controls  5.6.1-3
ii  qml-module-qtquick-dialogs   5.6.1-3
ii  qml-module-qtquick-layouts   5.6.1-3
ii  qml-module-qtquick2  5.6.1-11
ii  shared-mime-info 1.7-1
ii  xdg-utils1.1.1-1
ii  zlib1g   1:1.2.8.dfsg-2+b3

Versions of packages musescore recommends:
ii  pulseaudio-utils  9.0-4

Versions of packages musescore suggests:
ii  fluid-soundfont-gm  3.1-5
pn  timgm6mb-soundfont  

-- no debconf information
-- 
Antonio Ospite
https://ao2.it
https://twitter.com/ao2it

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#802710: musescore: Embeds Qt5's private headers without putting them in a namespace

[Sebastian Ramacher]

Hi

On 2015-10-22 16:09:22, Lisandro Damián Nicanor Pérez Meyer wrote:
> Source: musescore
> Version: 2.0.2+dfsg-1
> Severity: important
> 
> Hi! While doing qt5's qtbase's private headers transition we noted that 
> musescore
> got into the list of packages that needed a transition [lop] but without
> build depending on qtbase5-dev.
> 
> [lop] 
> 
> My teammate Dmitry Schanev found out that musescore ships a Qt5 private 
> header:
> 
> 
> 
> By building this header without a namespace the symbols that it generates 
> matchs the symbols
> of qtbase's private stuff, so unnecesarily being part of transitions like 
> this.

The xmlstream stuff is not the problem. They are not unresolved symbols and do
not cause a dependency on qtbase-abi-5-5-1. They probably clash with the symbols
from Qt, but that's easy to fix with a namespace or renaming the copy of
QXmlUtils.

Looking at the output of dpkg-shlibdeps with -v -v shows the actual problem:
|  Looking up symbol 
_ZN12QPaintEngineC2ER19QPaintEnginePrivate6QFlagsINS_18PaintEngineFeatureEE@Base
|  Found in symbols file of libQt5Gui.so.5 (minver: 5.0.2, dep: libqt5gui5 
#MINVER#, qtbase-abi-5-5-1)

This might be caused by mscore/paintengine_p.h and mscore/svgenerator.* where
the QPaintEngine and QPaintEnginePrivate are used.

Cheers
-- 
Sebastian Ramacher

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#802710: musescore: Embeds Qt5's private headers without putting them in a namespace

[Lisandro Damián Nicanor Pérez Meyer]

On Friday 23 October 2015 15:53:37 Sebastian Ramacher wrote:
> Hi
[snip]
> > By building this header without a namespace the symbols that it generates
> > matchs the symbols of qtbase's private stuff, so unnecesarily being part
> > of transitions like this.
> The xmlstream stuff is not the problem. They are not unresolved symbols and
> do not cause a dependency on qtbase-abi-5-5-1. They probably clash with the
> symbols from Qt, but that's easy to fix with a namespace or renaming the
> copy of QXmlUtils.
> 
> Looking at the output of dpkg-shlibdeps with -v -v shows the actual problem:
> |  Looking up symbol
> |  _ZN12QPaintEngineC2ER19QPaintEnginePrivate6QFlagsINS_18PaintEngineFeatur
> |  eEE@Base Found in symbols file of libQt5Gui.so.5 (minver: 5.0.2, dep:
> |  libqt5gui5 #MINVER#, qtbase-abi-5-5-1)
> This might be caused by mscore/paintengine_p.h and mscore/svgenerator.*
> where the QPaintEngine and QPaintEnginePrivate are used.

Thanks a lot for the head up Sebastian :)

Indeed that seems to be the cause, and using a namespace or renaming the 
classes should fix it.

Or avoiding using Qt's internal at all, of course.

-- 
http://xkcd.com/150/
Personas como ésta no se encuentran todos los días. Y cuando uno las
encuentra, suelen no estar disponibles.
Si encontrás una, no la pierdas.

Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/


signature.asc
Description: This is a digitally signed message part.
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#802710: musescore: Embeds Qt5's private headers without putting them in a namespace

[Lisandro Damián Nicanor Pérez Meyer]

Source: musescore
Version: 2.0.2+dfsg-1
Severity: important

Hi! While doing qt5's qtbase's private headers transition we noted that 
musescore
got into the list of packages that needed a transition [lop] but without
build depending on qtbase5-dev.

[lop] 

My teammate Dmitry Schanev found out that musescore ships a Qt5 private header:



By building this header without a namespace the symbols that it generates 
matchs the symbols
of qtbase's private stuff, so unnecesarily being part of transitions like this.

This is easily solvable by putting the headers under a namespace (like 
musescore3rdparty,
for example) and using them trough it.

Another better solution is to avoid embedding private stuff at all, of course :)

Kinds regards, Lisandro.

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (500, 'buildd-unstable'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.2.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=es_AR.UTF-8, LC_CTYPE=es_AR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers