Bug#805549: Patch for strech, jessie, wheezy
On 12 Jan 2016 03:08, "Adam D. Barratt" wrote: > > On Tue, 2015-12-15 at 13:18 +, Adam D. Barratt wrote: > > On 2015-12-15 13:04, Felipe Sateler wrote: > > > Hi, > > > > > > Dear release team, I'm copying you to ask if the attached patch would > > > be OK to upload to stable/oldstable, fixes bug #805549. This error > > > makes some builds against stk impossible, since there are two headers > > > missing. > > > > > > The version in unstable is a different upstream version, so the patch > > > is not exactly the same (attached is a patch on a patch, currently we > > > patch the real file, as the previous patch was accepted upstream). > > > > In isolation, the patch looks okay. In order to get approval for actual > > uploads for stable and oldstable, however, please open a p-u bug for > > each, including a full source debdiff for a package built and tested on > > that distribution. > > I note that there are now #810760 and #810761. For future reference, > "[i]n order to get approval", implied opening the bugs _before_ the > uploads, not afterwards. Oops. Sorry, will do correctly next time. I suppose I somehow let "built and tested" also include "uploaded". Saludos ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#805549: Patch for strech, jessie, wheezy
On Tue, 2015-12-15 at 13:18 +, Adam D. Barratt wrote: > On 2015-12-15 13:04, Felipe Sateler wrote: > > Hi, > > > > Dear release team, I'm copying you to ask if the attached patch would > > be OK to upload to stable/oldstable, fixes bug #805549. This error > > makes some builds against stk impossible, since there are two headers > > missing. > > > > The version in unstable is a different upstream version, so the patch > > is not exactly the same (attached is a patch on a patch, currently we > > patch the real file, as the previous patch was accepted upstream). > > In isolation, the patch looks okay. In order to get approval for actual > uploads for stable and oldstable, however, please open a p-u bug for > each, including a full source debdiff for a package built and tested on > that distribution. I note that there are now #810760 and #810761. For future reference, "[i]n order to get approval", implied opening the bugs _before_ the uploads, not afterwards. Regards, Adam ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#805549: Patch for strech, jessie, wheezy
Hi,
> Hanno, could you please test on a wheezy and on a jessie system that
> what is living in the debian/{wheezy,jessie} branches works? I don't
> foresee any problems, but we should test first.
Tested on both systems, using amd64.
Worked on both.
This patch fixes the original problem described in this bug.
Thank you,
Hanno
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#805549: Patch for strech, jessie, wheezy
(Dropping release team while we prepare)
On 15 December 2015 at 10:18, Adam D. Barratt wrote:
> On 2015-12-15 13:04, Felipe Sateler wrote:
>>
>> Hi,
>>
>> Dear release team, I'm copying you to ask if the attached patch would
>> be OK to upload to stable/oldstable, fixes bug #805549. This error
>> makes some builds against stk impossible, since there are two headers
>> missing.
>>
>> The version in unstable is a different upstream version, so the patch
>> is not exactly the same (attached is a patch on a patch, currently we
>> patch the real file, as the previous patch was accepted upstream).
>
>
> In isolation, the patch looks okay. In order to get approval for actual
> uploads for stable and oldstable, however, please open a p-u bug for each,
> including a full source debdiff for a package built and tested on that
> distribution.
Hanno, could you please test on a wheezy and on a jessie system that
what is living in the debian/{wheezy,jessie} branches works? I don't
foresee any problems, but we should test first.
--
Saludos,
Felipe Sateler
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#805549: Patch for strech, jessie, wheezy
On 2015-12-15 13:04, Felipe Sateler wrote: Hi, Dear release team, I'm copying you to ask if the attached patch would be OK to upload to stable/oldstable, fixes bug #805549. This error makes some builds against stk impossible, since there are two headers missing. The version in unstable is a different upstream version, so the patch is not exactly the same (attached is a patch on a patch, currently we patch the real file, as the previous patch was accepted upstream). In isolation, the patch looks okay. In order to get approval for actual uploads for stable and oldstable, however, please open a p-u bug for each, including a full source debdiff for a package built and tested on that distribution. Regards, Adam ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#805549: Patch for strech, jessie, wheezy
Hi, Dear release team, I'm copying you to ask if the attached patch would be OK to upload to stable/oldstable, fixes bug #805549. This error makes some builds against stk impossible, since there are two headers missing. The version in unstable is a different upstream version, so the patch is not exactly the same (attached is a patch on a patch, currently we patch the real file, as the previous patch was accepted upstream). However, it is functionally the same[1]. [1] http://anonscm.debian.org/cgit/pkg-multimedia/stk.git/tree/debian/patches/0006-Install-missing-include-files-SKINI.msg-and-SKINI.tb.patch On 15 December 2015 at 06:38, Hanno Zulla wrote: > Hi, > > thanks for fixing this in sid's package. I can confirm that it works to > package supercollider-sc3-plugins. > > It would be beneficial if this could be fixed for > > strech This will make it automatically in a few days. > jessie > wheezy These won't, we need release team ACK for this. > too. Why even back to wheezy? Because supercollider-sc3-plugins is also > meant to be used by Raspbian, which is packaging their distribution > based on wheezy and jessie. > > Please find an attached patch which will fix this for all three versions > of the current Debian source package. -- Saludos, Felipe Sateler *** stk-4.4.4/debian/patches/01-makefile.patch 2015-09-21 19:17:01.0 +0200 --- stk-4.4.4.patched/debian/patches/01-makefile.patch 2015-12-15 10:19:37.320848851 +0100 *** *** 64,70 +install-headers: + install -d $(DESTDIR)/usr/include/stk ! + cp -r ../include/*.h $(DESTDIR)/usr/include/stk + +install: $(SHAREDLIB) install-headers + install -d $(DESTDIR)/usr/share/stk --- 64,70 +install-headers: + install -d $(DESTDIR)/usr/include/stk ! + cp -r ../include/* $(DESTDIR)/usr/include/stk + +install: $(SHAREDLIB) install-headers + install -d $(DESTDIR)/usr/share/stk ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#805549: Patch for strech, jessie, wheezy
Hi, thanks for fixing this in sid's package. I can confirm that it works to package supercollider-sc3-plugins. It would be beneficial if this could be fixed for strech jessie wheezy too. Why even back to wheezy? Because supercollider-sc3-plugins is also meant to be used by Raspbian, which is packaging their distribution based on wheezy and jessie. Please find an attached patch which will fix this for all three versions of the current Debian source package. Thank you, Hanno *** stk-4.4.4/debian/patches/01-makefile.patch 2015-09-21 19:17:01.0 +0200 --- stk-4.4.4.patched/debian/patches/01-makefile.patch 2015-12-15 10:19:37.320848851 +0100 *** *** 64,70 +install-headers: + install -d $(DESTDIR)/usr/include/stk ! + cp -r ../include/*.h $(DESTDIR)/usr/include/stk + +install: $(SHAREDLIB) install-headers + install -d $(DESTDIR)/usr/share/stk --- 64,70 +install-headers: + install -d $(DESTDIR)/usr/include/stk ! + cp -r ../include/* $(DESTDIR)/usr/include/stk + +install: $(SHAREDLIB) install-headers + install -d $(DESTDIR)/usr/share/stk ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
