Bug#852985: gsequencer: please do not build-depend on oss4-dev on Linux

[Simon McVittie]

On Tue, 31 Jan 2017 at 02:56:37 +0100, Joël Krähemann wrote:
> The patch looks fine. There should be no problem as passing this
> configure flag.  I even used gsequencer on linuxfromscratch.org based
> system without having OSS4 at all.

I'd be happy to sponsor a maintainer upload with this or a similar change
if you prepare one - I'd prefer to upload something that someone who knows
the software has tested! Or please let me know if you'd like me to prepare
a non-maintainer upload and send it to you for testing.

> Note you can disable it for GNU/Hurd, as well. So JACK is the only
> output sink.

Hurd isn't a release architecture (and never has been, unlike kFreeBSD)
so I don't mind whether it has an OSS4 dependency there - it isn't going
to disrupt the release either way. Do you have any preference for
whether it's [!linux-any] or [kfreebsd-any]?

In NMUs for other packages I've been using [!linux-any] so it's only
a change to previous behaviour on the kernel I know about.

S

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#852985: gsequencer: please do not build-depend on oss4-dev on Linux

[Joël Krähemann]

Hi

The patch looks fine. There should be no problem as passing this configure flag.
I even used gsequencer on linuxfromscratch.org based system without having OSS4
at all.

Note you can disable it for GNU/Hurd, as well. So JACK is the only output sink.

Bests,
Joël


On Sun, Jan 29, 2017 at 5:18 PM, Simon McVittie  wrote:
> Control: tags 852985 + patch
>
> On Sat, 28 Jan 2017 at 17:55:43 +, Simon McVittie wrote:
>> This package build-depends on oss4-dev, which is built by RC-buggy source
>> package oss4.
>
> I attach a possible patch.
>
> I don't know how to test gsequencer, so I am not intending to do a
> NMU for this bug.
>
> Regards,
> S

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#852985: gsequencer: please do not build-depend on oss4-dev on Linux

[Simon McVittie]

Control: tags 852985 + patch

On Sat, 28 Jan 2017 at 17:55:43 +, Simon McVittie wrote:
> This package build-depends on oss4-dev, which is built by RC-buggy source
> package oss4.

I attach a possible patch.

I don't know how to test gsequencer, so I am not intending to do a
NMU for this bug.

Regards,
S
>From a7fc446f2b269f054c371f32816d35747771f2b6 Mon Sep 17 00:00:00 2001
From: Simon McVittie 
Date: Sun, 29 Jan 2017 12:12:19 +
Subject: [PATCH] Build-depend on ALSA on Linux, and on OSS4 on non-Linux

Disable the other kernel's API in each case (Closes: #852985)
---
 debian/changelog | 8 
 debian/control   | 5 +++--
 debian/rules | 3 ++-
 3 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index a9b2ad4..550ff35 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+gsequencer (0.7.122-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Build-depend on ALSA on Linux, and on OSS4 on non-Linux, disabling
+the other kernel's API in each case (Closes: #852985)
+
+ -- Simon McVittie   Sun, 29 Jan 2017 12:11:56 +
+
 gsequencer (0.7.122-1) unstable; urgency=medium
 
   * New upstream version 0.7.122
diff --git a/debian/control b/debian/control
index b13e923..27f2c9e 100644
--- a/debian/control
+++ b/debian/control
@@ -20,8 +20,9 @@ Build-Depends: debhelper (>= 9),
  dssi-dev,
  lv2-dev,
  libgmp-dev,
- libasound2-dev|liboss4-salsa-dev,
- oss4-dev,
+ libasound2-dev [linux-any],
+ liboss4-salsa-dev [!linux-any],
+ oss4-dev [!linux-any],
  libjack-dev,
  uuid-dev,
  docbook-xsl,
diff --git a/debian/rules b/debian/rules
index fc2ae40..7575519 100755
--- a/debian/rules
+++ b/debian/rules
@@ -8,10 +8,11 @@ archconfflags :=
 
 ifeq ($(DEB_HOST_ARCH_OS),linux)
   archconfflags += --enable-alsa
+  archconfflags += --disable-oss
 else
   archconfflags += --disable-alsa
+  archconfflags += --enable-oss
 endif
-archconfflags += --enable-oss
 
 archconfflags += --enable-gtk-doc --enable-gtk-doc-html
 
-- 
2.11.0

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Processed: Re: Bug#852985: gsequencer: please do not build-depend on oss4-dev on Linux

[Debian Bug Tracking System]

Processing control commands:

> tags 852985 + patch
Bug #852985 [src:gsequencer] gsequencer: please do not build-depend on oss4-dev 
on Linux
Added tag(s) patch.

-- 
852985: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=852985
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#852985: gsequencer: please do not build-depend on oss4-dev on Linux

[Simon McVittie]

Source: gsequencer
Version: 0.7.122-1
Severity: serious
Justification: release team consensus

This package build-depends on oss4-dev, which is built by RC-buggy source
package oss4.

I discussed this with some release team members and their opinion is that
oss4 should only be used on non-Linux architectures: on Linux, we should be
using ALSA, either directly or via intermediaries like PulseAudio.
Please restrict the build-dependency to oss4-dev [kfreebsd-any] or possibly
oss4-dev [kfreebsd-any hurd-any], and set the configure options so OSS is
only requested on those architectures, similar to what is done in
vlc (>= 2.2.0~pre3-1).

Regards,
smcv
helping the Cambridge BSP

-- System Information:
Debian Release: 9.0
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (500, 'testing'), 
(500, 'stable'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers