Bug#875192: [simplescreenrecorder] Future Qt4 removal from Buster

2017-11-26 Thread Lisandro Damián Nicanor Pérez Meyer 
El 26 nov. 2017 10:33 a.m., "James Cowgill"  escribió:

Hi,

On 26/11/17 13:27, Lisandro Damián Nicanor Pérez Meyer wrote:
> El 26 nov. 2017 10:24 a.m., "Lisandro Damián Nicanor Pérez Meyer" <
> perezme...@gmail.com> escribió:
>
> El 26 nov. 2017 10:22 a.m., "James Cowgill" 
escribió:
>
> Hi,
> [...]
>
>> The only minor thing I noted is that QPainter is included twince in
> 0003*, but
>> definitely nothing to worry too much.
>
> I have applied the patches with some slight modifications:
> - Remove the duplicate QPainter include.
> - Use DEB_CXXFLAGS_MAINT_APPEND instead of overriding QT5_CFLAGS.
>
>
> It might be worth to note that that
>
> My son little G came and pressed the right key to send the mail ;-)

Not to worry :)

> I was about to write that that flag should be already present if the
> project is using cmake or qmake. I have not checked the build system.

The build system is autotools and it uses pkg-config to discover all the
Qt libs and cflags etc. I did do some Google searching and I did notice
that CMake would fix this up for you, but I couldn't find anything about
this with autotools. I think adding -fPIC is fine for the moment, even
if it's only a workaround.


Yes, it's perfectly fine! And I think it's a qt bug already reported
upstream.
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#875192: [simplescreenrecorder] Future Qt4 removal from Buster

2017-11-26 Thread gregor herrmann 
On Sun, 26 Nov 2017 13:33:41 +, James Cowgill wrote:

> > I have applied the patches with some slight modifications:
> > - Remove the duplicate QPainter include.
> > - Use DEB_CXXFLAGS_MAINT_APPEND instead of overriding QT5_CFLAGS.

Thanks!

> > I was about to write that that flag should be already present if the
> > project is using cmake or qmake. I have not checked the build system.
> The build system is autotools and it uses pkg-config to discover all the
> Qt libs and cflags etc. I did do some Google searching and I did notice
> that CMake would fix this up for you, but I couldn't find anything about
> this with autotools. I think adding -fPIC is fine for the moment, even
> if it's only a workaround.

Upstream's git repo shows a switch to CMake, so this temporary
workaround can probably be removed after the next release. (Or has to
be redone somehow differently if we're unlucky.)


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Bob Dylan: Just Like A Woman


signature.asc
Description: Digital Signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#875192: [simplescreenrecorder] Future Qt4 removal from Buster

2017-11-26 Thread James Cowgill 
Hi,

On 26/11/17 13:27, Lisandro Damián Nicanor Pérez Meyer wrote:
> El 26 nov. 2017 10:24 a.m., "Lisandro Damián Nicanor Pérez Meyer" <
> perezme...@gmail.com> escribió:
> 
> El 26 nov. 2017 10:22 a.m., "James Cowgill"  escribió:
> 
> Hi,
> [...]
> 
>> The only minor thing I noted is that QPainter is included twince in
> 0003*, but
>> definitely nothing to worry too much.
> 
> I have applied the patches with some slight modifications:
> - Remove the duplicate QPainter include.
> - Use DEB_CXXFLAGS_MAINT_APPEND instead of overriding QT5_CFLAGS.
> 
> 
> It might be worth to note that that
> 
> My son little G came and pressed the right key to send the mail ;-)

Not to worry :)

> I was about to write that that flag should be already present if the
> project is using cmake or qmake. I have not checked the build system.

The build system is autotools and it uses pkg-config to discover all the
Qt libs and cflags etc. I did do some Google searching and I did notice
that CMake would fix this up for you, but I couldn't find anything about
this with autotools. I think adding -fPIC is fine for the moment, even
if it's only a workaround.

Thanks,
James



signature.asc
Description: OpenPGP digital signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#875192: [simplescreenrecorder] Future Qt4 removal from Buster

2017-11-26 Thread James Cowgill 
Hi,

On 25/11/17 17:22, Lisandro Damián Nicanor Pérez Meyer wrote:
> On sábado, 25 de noviembre de 2017 05:37:36 -03 gregor herrmann wrote:
>> Control: tag -1 + patch
> [snip]
>> simplescreenrecorder bascially has Qt5 support upstream.
>> With a bit of trial I managed to build the package, and the
>> binary also seems to work afterwards :)
>>
>> Find attached my changes
>> - as one diff
>> - as 3 git patches against HEAD of the packaging repo
> 
> Thanks gregor!!!
> 
> The only minor thing I noted is that QPainter is included twince in 0003*, 
> but 
> definitely nothing to worry too much.

I have applied the patches with some slight modifications:
- Remove the duplicate QPainter include.
- Use DEB_CXXFLAGS_MAINT_APPEND instead of overriding QT5_CFLAGS.

Thanks,
James



signature.asc
Description: OpenPGP digital signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#875192: [simplescreenrecorder] Future Qt4 removal from Buster

2017-11-26 Thread Lisandro Damián Nicanor Pérez Meyer 
El 26 nov. 2017 10:22 a.m., "James Cowgill"  escribió:

Hi,
[...]
> The only minor thing I noted is that QPainter is included twince in
0003*, but
> definitely nothing to worry too much.

I have applied the patches with some slight modifications:
- Remove the duplicate QPainter include.
- Use DEB_CXXFLAGS_MAINT_APPEND instead of overriding QT5_CFLAGS.


It might be worth to note that that
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#875192: [simplescreenrecorder] Future Qt4 removal from Buster

2017-11-25 Thread Lisandro Damián Nicanor Pérez Meyer 
On sábado, 25 de noviembre de 2017 05:37:36 -03 gregor herrmann wrote:
> Control: tag -1 + patch
[snip]
> simplescreenrecorder bascially has Qt5 support upstream.
> With a bit of trial I managed to build the package, and the
> binary also seems to work afterwards :)
> 
> Find attached my changes
> - as one diff
> - as 3 git patches against HEAD of the packaging repo

Thanks gregor!!!

The only minor thing I noted is that QPainter is included twince in 0003*, but 
definitely nothing to worry too much.


-- 
Only wimps use tape backup: real men just upload their important stuff on
ftp, and let the rest of the world mirror it ;)
  Linus Benedict Torvalds.

Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/


signature.asc
Description: This is a digitally signed message part.
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Processed: Re: Bug#875192: [simplescreenrecorder] Future Qt4 removal from Buster

2017-11-24 Thread Debian Bug Tracking System 
Processing control commands:

> tag -1 + patch
Bug #875192 [src:simplescreenrecorder] [simplescreenrecorder] Future Qt4 
removal from Buster
Added tag(s) patch.

-- 
875192: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=875192
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Bug#875192: [simplescreenrecorder] Future Qt4 removal from Buster

2017-11-24 Thread gregor herrmann 
Control: tag -1 + patch

On Sat, 09 Sep 2017 23:09:52 +0200, Lisandro Damián Nicanor Pérez Meyer wrote:

> Source: simplescreenrecorder
> Version: 0.3.8-2
> Severity: wishlist
> User: debian-qt-...@lists.debian.org
> Usertags: qt4-removal
> 
> 
> Hi! As you might know we the Qt/KDE team are preparing to remove Qt4
> as [announced] in:
> [announced] 
> 

simplescreenrecorder bascially has Qt5 support upstream.
With a bit of trial I managed to build the package, and the
binary also seems to work afterwards :)

Find attached my changes
- as one diff
- as 3 git patches against HEAD of the packaging repo


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: R.E.M.: All The Way To Reno
From 334dd7c277ea446fb28b18bf45e73a592d0a3a10 Mon Sep 17 00:00:00 2001
From: gregor herrmann 
Date: Sat, 25 Nov 2017 05:01:19 +0100
Subject: [PATCH 1/3] debian/control: adjust build dependencies for Qt5.

---
 debian/control | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/debian/control b/debian/control
index fd2dad7..12598a7 100644
--- a/debian/control
+++ b/debian/control
@@ -17,7 +17,9 @@ Build-Depends:
  libjack-dev | libjack-jackd2-dev,
  liboss4-salsa-dev [!linux-any],
  libpulse-dev,
- libqt4-dev,
+ libqt5x11extras5-dev,
+ qtbase5-dev,
+ qttools5-dev-tools,
  libswscale-dev,
  libx11-dev,
  libxext-dev,
-- 
2.15.0

From b4b285c09df054f8614cb671a7add118a2654b18 Mon Sep 17 00:00:00 2001
From: gregor herrmann 
Date: Sat, 25 Nov 2017 05:01:49 +0100
Subject: [PATCH 2/3] debian/rules: update build flags for Qt5.

---
 debian/rules | 12 ++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/debian/rules b/debian/rules
index 2914469..60316fc 100755
--- a/debian/rules
+++ b/debian/rules
@@ -5,6 +5,12 @@ include /usr/share/dpkg/default.mk
 
 ARCH = $(shell dpkg --print-architecture)
 
+export QT_SELECT=5
+# cf. https://github.com/MaartenBaert/ssr/issues/498
+export QT5_CFLAGS += -fpic
+INC = $(shell pkg-config --cflags-only-I Qt5Core Qt5Gui Qt5Widgets Qt5X11Extras)
+export QT5_CFLAGS += $(INC)
+
 %:
 	dh $@ --parallel --with autotools-dev
 
@@ -17,12 +23,14 @@ ARCH = $(shell dpkg --print-architecture)
 override_dh_auto_configure:
 ifeq ($(ARCH),$(filter $(ARCH),amd64 i386 hurd-i386 kfreebsd-amd64 kfreebsd-i386 x32))
 		dh_auto_configure -- \
-		--disable-assert
+		--disable-assert \
+		--with-qt5
 else
 		dh_auto_configure -- \
 		--disable-x86-asm \
 		--disable-assert \
-		--disable-glinjectlib
+		--disable-glinjectlib \
+		--with-qt5
 endif
 
 override_dh_auto_install:
-- 
2.15.0

From cecdc793ba8202533a28c197b682544ea9386c4a Mon Sep 17 00:00:00 2001
From: gregor herrmann 
Date: Sat, 25 Nov 2017 05:02:17 +0100
Subject: [PATCH 3/3] Add patch qt5_includes.patch: adjust includes for Qt5
 build.

---
 debian/patches/qt5_includes.patch | 39 +++
 debian/patches/series |  1 +
 2 files changed, 40 insertions(+)
 create mode 100644 debian/patches/qt5_includes.patch
 create mode 100644 debian/patches/series

diff --git a/debian/patches/qt5_includes.patch b/debian/patches/qt5_includes.patch
new file mode 100644
index 000..c8c988a
--- /dev/null
+++ b/debian/patches/qt5_includes.patch
@@ -0,0 +1,39 @@
+Description: fix includes for qt5
+Origin: vendor
+Author: gregor herrmann 
+Last-Update: 2017-11-25
+
+--- a/src/Global.h
 b/src/Global.h
+@@ -22,8 +22,8 @@
+ 
+ #include "config.h"
+ 
+-#include 
+-
++// for QT_VERSION*
++#include "qglobal.h"
+ #if QT_VERSION >= QT_VERSION_CHECK(5, 0, 0)
+ 
+ #include 
+@@ -59,6 +59,20 @@
+ #include 
+ #include 
+ 
++#include 
++#include 
++#include 
++#include 
++#include 
++#include 
++#include 
++#include 
++#include 
++
++#else
++
++#include 
++
+ #endif
+ 
+ #include 
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 000..c807aae
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+qt5_includes.patch
-- 
2.15.0

diff --git a/debian/control b/debian/control
index fd2dad7..12598a7 100644
--- a/debian/control
+++ b/debian/control
@@ -17,7 +17,9 @@ Build-Depends:
  libjack-dev | libjack-jackd2-dev,
  liboss4-salsa-dev [!linux-any],
  libpulse-dev,
- libqt4-dev,
+ libqt5x11extras5-dev,
+ qtbase5-dev,
+ qttools5-dev-tools,
  libswscale-dev,
  libx11-dev,
  libxext-dev,
diff --git a/debian/patches/qt5_includes.patch b/debian/patches/qt5_includes.patch
new file mode 100644
index 000..c8c988a
--- /dev/null
+++ b/debian/patches/qt5_includes.patch
@@ -0,0 +1,39 @@
+Description: fix includes for qt5
+Origin: vendor
+Author: gregor herrmann 
+Last-Update: 2017-11-25
+
+--- a/src/Global.h

Bug#875192: [simplescreenrecorder] Future Qt4 removal from Buster

2017-09-09 Thread Lisandro Damián Nicanor Pérez Meyer 
Source: simplescreenrecorder
Version: 0.3.8-2
Severity: wishlist
User: debian-qt-...@lists.debian.org
Usertags: qt4-removal


Hi! As you might know we the Qt/KDE team are preparing to remove Qt4
as [announced] in:

[announced] 


Currently Qt4 has been dead upstream and we are starting to have problems
maintaining it, like for example in the [OpenSSL 1.1 support] case.

[OpenSSL 1.1 support] 

In order to make this move, all packages directly or indirectly depending on
the Qt4 libraries have to either get ported to Qt5 or eventually get
removed from the Debian repositories.

Therefore, please take the time and:
- contact your upstream (if existing) and ask about the state of a Qt5
port of your application
- if there are no activities regarding porting, investigate whether there are
suitable alternatives for your users
- if there is a Qt5 port that is not yet packaged, consider packaging it
- if both the Qt4 and the Qt5 versions already coexist in the Debian
archives, consider removing the Qt4 version

= Porting =

Some of us where involved in various Qt4 to Qt5 migrations [migration] and we
know for sure that porting stuff from Qt4 to Qt5 is much much easier and less
painful than it was from Qt3 to Qt4.

We also understand that there is still a lot of software still using Qt4.

Don't forget to take a look at the C++ API changes page [apichanges] whenever
you start porting your application.

[migration] http://pkg-kde.alioth.debian.org/packagingqtbasedstuff.html
[apichanges] http://doc.qt.io/qt-5/sourcebreaks.html

For any questions and issues, do not hesitate to contact the Debian Qt/KDE
team at debian-qt-...@lists.debian.org

The removal is being tracked in 

Lisandro,
on behalf of the Qt4 maintainers

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers