Re: debug-file-with-no-debug-symbols
2016-08-25 18:18 GMT+02:00 Felipe Sateler : > On 25 August 2016 at 11:50, Jaromír Mikeš wrote: >> 2016-08-25 15:03 GMT+02:00 Felipe Sateler : >>> On 25 August 2016 at 09:39, Jaromír Mikeš wrote: >>>> Hi all, >>>> >>>> I have a plenty of these warnings in eq10q package :( >>>> >>>> W: eq10q-dbgsym: debug-file-with-no-debug-symbols >>>> usr/lib/debug/.build-id/04/acdb8bc701b4237e2de4a94680dc5af26e3d14.debug >>>> >>>> I didn't have any problems with debugging symbols before ... any idea >>>> how to fix it? >>> >>> The upstream build system is ignoring the flags from the >>> environment[1]. It should not set that variable, but only add to it: >>> >>> set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ...") >>> >>> >>> [1] >>> https://anonscm.debian.org/cgit/pkg-multimedia/eq10q.git/tree/CMakeLists.txt#n6 >> >> I have just push patch which fixing this issue. >> Can you check if it is correct? > > I think add_definitions is not correct, as it adds CPPFLAGS. Thus the > same flags will be added both to gcc and g++. And in this case will > result in gcc being called with -std=c++11, which I don't think makes > much sense ;) > > I would use the approach I quoted before of using the previous value > of CMAKE_C_FLAGS, and then separately for CMAKE_CXX_FLAGS: > > ##ADD_DEFINITIONS(-Wall -O3 -fPIC -finline-functions > -finline-functions-called-once -msse -mfpmath=sse -std=c99) > -set(CMAKE_C_FLAGS "-Wall -O3 -fPIC -finline-functions > -finline-functions-called-once -std=c99") > +set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -O3 -fPIC > -finline-functions -finline-functions-called-once -std=c99") > #set(CMAKE_C_FLAGS "-Wall -O0 -g -fPIC -finline-functions > -finline-functions-called-once -msse -mfpmath=sse -std=c99") > > -set(CMAKE_CXX_FLAGS "-Wall -fPIC -std=c++11") > -set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -fPIC -std=c++11") Works fine this way. Going to upload. Thank you mira ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: debug-file-with-no-debug-symbols
On 25 August 2016 at 11:50, Jaromír Mikeš wrote: > 2016-08-25 15:03 GMT+02:00 Felipe Sateler : >> On 25 August 2016 at 09:39, Jaromír Mikeš wrote: >>> Hi all, >>> >>> I have a plenty of these warnings in eq10q package :( >>> >>> W: eq10q-dbgsym: debug-file-with-no-debug-symbols >>> usr/lib/debug/.build-id/04/acdb8bc701b4237e2de4a94680dc5af26e3d14.debug >>> >>> I didn't have any problems with debugging symbols before ... any idea >>> how to fix it? >> >> The upstream build system is ignoring the flags from the >> environment[1]. It should not set that variable, but only add to it: >> >> set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ...") >> >> >> [1] >> https://anonscm.debian.org/cgit/pkg-multimedia/eq10q.git/tree/CMakeLists.txt#n6 > > I have just push patch which fixing this issue. > Can you check if it is correct? I think add_definitions is not correct, as it adds CPPFLAGS. Thus the same flags will be added both to gcc and g++. And in this case will result in gcc being called with -std=c++11, which I don't think makes much sense ;) I would use the approach I quoted before of using the previous value of CMAKE_C_FLAGS, and then separately for CMAKE_CXX_FLAGS: ##ADD_DEFINITIONS(-Wall -O3 -fPIC -finline-functions -finline-functions-called-once -msse -mfpmath=sse -std=c99) -set(CMAKE_C_FLAGS "-Wall -O3 -fPIC -finline-functions -finline-functions-called-once -std=c99") +set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -O3 -fPIC -finline-functions -finline-functions-called-once -std=c99") #set(CMAKE_C_FLAGS "-Wall -O0 -g -fPIC -finline-functions -finline-functions-called-once -msse -mfpmath=sse -std=c99") -set(CMAKE_CXX_FLAGS "-Wall -fPIC -std=c++11") -set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -fPIC -std=c++11") -- Saludos, Felipe Sateler ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: debug-file-with-no-debug-symbols
2016-08-25 15:03 GMT+02:00 Felipe Sateler : > On 25 August 2016 at 09:39, Jaromír Mikeš wrote: >> Hi all, >> >> I have a plenty of these warnings in eq10q package :( >> >> W: eq10q-dbgsym: debug-file-with-no-debug-symbols >> usr/lib/debug/.build-id/04/acdb8bc701b4237e2de4a94680dc5af26e3d14.debug >> >> I didn't have any problems with debugging symbols before ... any idea >> how to fix it? > > The upstream build system is ignoring the flags from the > environment[1]. It should not set that variable, but only add to it: > > set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ...") > > > [1] > https://anonscm.debian.org/cgit/pkg-multimedia/eq10q.git/tree/CMakeLists.txt#n6 I have just push patch which fixing this issue. Can you check if it is correct? best regards mira ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: debug-file-with-no-debug-symbols
On 25/08/16 13:39, Jaromír Mikeš wrote: > Hi all, > > I have a plenty of these warnings in eq10q package :( > > W: eq10q-dbgsym: debug-file-with-no-debug-symbols > usr/lib/debug/.build-id/04/acdb8bc701b4237e2de4a94680dc5af26e3d14.debug > > I didn't have any problems with debugging symbols before ... any idea > how to fix it? The -g flag is not being passed to gcc or the executables are being stripped by something else before dh_strip has a chance to handle them. It probably started appearing when dbgsym packages were enabled. James signature.asc Description: OpenPGP digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers