Bug#689712: marked as done (faad crashes when given ADTS AAC file with large ID3v2 tag)
Your message dated Mon, 11 May 2015 12:19:44 +
with message-id e1yrmgs-00070g...@franck.debian.org
and subject line Bug#689712: fixed in faad2 2.8.0~cvs20150510-1
has caused the Debian Bug report #689712,
regarding faad crashes when given ADTS AAC file with large ID3v2 tag
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
689712: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=689712
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
---BeginMessage---
Package: faad
Version: 2.7-8
Severity: normal
Tags: upstream
I have an ADTS AAC file with an ID3v2 tag containing an image. Attempting to
skip this header by passing a value larger than the buffer size to
advance_buffer causes fill_buffer to misbehave. The problem is detected in
free() during a normal build but the problem is clearer when running under
valgrind:
==23880== Invalid write of size 8
==23880==at 0x50F81CB: __GI_memcpy (memcpy.S:267)
==23880==by 0x50E17D2: _IO_file_xsgetn (fileops.c:1414)
==23880==by 0x50D79B1: fread (iofread.c:44)
==23880==by 0x403930: ??? (in /usr/bin/faad)
==23880==by 0x401BAE: ??? (in /usr/bin/faad)
==23880==by 0x508EEAC: (below main) (libc-start.c:228)
==23880== Address 0x567a830 is 0 bytes after a block of size 4,608 alloc'd
==23880==at 0x4C28BED: malloc (in /usr/lib/valgrind/vgpreload_memcheck-
amd64-linux.so)
==23880==by 0x401AC2: ??? (in /usr/bin/faad)
==23880==by 0x508EEAC: (below main) (libc-start.c:228)
Here's a more useful log generated by a version of faad I compiled myself on
squeeze-i386:
==28965== Syscall param read(buf) points to unaddressable byte(s)
==28965==at 0x4A06073: __read_nocancel (syscall-template.S:82)
==28965==by 0x49B16F7: _IO_sgetn (genops.c:500)
==28965==by 0x49A52CD: fread (iofread.c:44)
==28965==by 0x8049150: fill_buffer (main.c:100)
==28965==by 0x8049544: decodeAACfile (main.c:478)
==28965==by 0x804A484: main (main.c:1249)
==28965== Address 0x6d20548 is 0 bytes after a block of size 4,608 alloc'd
==28965==at 0x48DEF50: malloc (vg_replace_malloc.c:236)
==28965==by 0x8049461: decodeAACfile (main.c:454)
==28965==by 0x804A484: main (main.c:1249)
==28965==
==28965== Invalid write of size 1
==28965==at 0x48E091F: memcpy (mc_replace_strmem.c:497)
==28965==by 0x49AF737: _IO_file_xsgetn (fileops.c:1414)
==28965==by 0x49B16F7: _IO_sgetn (genops.c:500)
==28965==by 0x49A52CD: fread (iofread.c:44)
==28965==by 0x8049150: fill_buffer (main.c:100)
==28965==by 0x8049544: decodeAACfile (main.c:478)
==28965==by 0x804A484: main (main.c:1249)
==28965== Address 0x6d24d95 is not stack'd, malloc'd or (recently) free'd
The attached patch fixes the problem for me. I've submitted it upstream at
https://sourceforge.net/tracker/?func=detailaid=3574761group_id=704atid=100704
-- System Information:
Debian Release: wheezy/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.2.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages faad depends on:
ii libc6 2.13-35
ii libfaad2 2.7-8
faad recommends no packages.
faad suggests no packages.
Only in faad2-2.7/common: Makefile
Only in faad2-2.7/common/mp4ff: .deps
Only in faad2-2.7/common/mp4ff: libmp4ff.a
Only in faad2-2.7/common/mp4ff: libmp4ff_a-mp4atom.o
Only in faad2-2.7/common/mp4ff: libmp4ff_a-mp4ff.o
Only in faad2-2.7/common/mp4ff: libmp4ff_a-mp4meta.o
Only in faad2-2.7/common/mp4ff: libmp4ff_a-mp4sample.o
Only in faad2-2.7/common/mp4ff: libmp4ff_a-mp4tagupdate.o
Only in faad2-2.7/common/mp4ff: libmp4ff_a-mp4util.o
Only in faad2-2.7/common/mp4ff: Makefile
Only in faad2-2.7: config.h
Only in faad2-2.7: config.log
Only in faad2-2.7: config.status
Only in faad2-2.7: faad2.spec
Only in faad2-2.7/frontend: audio.o
Only in faad2-2.7/frontend: .deps
Only in faad2-2.7/frontend: faad
Only in faad2-2.7/frontend: getopt.o
Only in faad2-2.7/frontend: .libs
diff -rup faad2-2.7.stock/frontend/main.c faad2-2.7/frontend/main.c
--- faad2-2.7.stock/frontend/main.c 2008-09-22 18:55:09.0 +0100
+++ faad2-2.7/frontend/main.c 2012-10-04 21:46:31.175490401 +0100
@@ -130,11 +130,22 @@ static int fill_buffer(aac_buffer *b)
static void advance_buffer(aac_buffer *b, int bytes)
{
-b-file_offset += bytes;
-b-bytes_consumed = bytes;
-b-bytes_into_buffer -= bytes;
- if (b-bytes_into_buffer 0)
- b-bytes_into_buffer = 0;
+while ((b-bytes_into_buffer 0) (bytes 0))
+{
+ assert(b
Re: faad
Am Samstag, den 15.11.2014, 15:17 + schrieb Julian Cable: Draft man page for libfaad and libfaad_drm - there has never been one and the .doc is out of date. I have taken the Description from the docs but the synopsis from the include header file and then added the missing calls to the description. There are two calls I don't have information for. Very cool, thank you! I have just added this to the Debian package, would you mind forwarding this to upstream as well? - Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
faad
Draft man page for libfaad and libfaad_drm - there has never been one and the .doc is out of date. I have taken the Description from the docs but the synopsis from the include header file and then added the missing calls to the description. There are two calls I don't have information for. I'll try and do the same for libfaac libfaad.3 Description: Binary data ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug report on faad: faad crashes with exit status 139
Hi, We found a crash in faad contained in the faad package. You are being contacted because your are listed as one of the maintainer of faad. We are planning to submit the bug to the Debian bug tracking system in two weeks. We wanted to give you a heads-up, so that you some time to assess the seriousness of the bug before it is publicly disclosed. The bug report that will be submitted to the bug tracker is available at the following url: http://www.forallsecure.com/bug-reports/844047f06cc34aae41e54607ace8f3402023cb61/ This email is part of a mass bug reporting campain comprising 1,182 bugs. You might have received multiple emails from us concerning different programs. More information about the mass bug reporting is available on the debian-devel mailing list: http://lists.debian.org/debian-devel/2013/06/msg00720.html Regards, The Mayhem Team Cylab, Carnegie Mellon University ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#703732: faad fails to gaplessly decode itunes, nero, fraunhofer aac
Am Sonntag, den 24.03.2013, 22:59 + schrieb Julian Hughes: The relevant patch seems to be: http://www.rockbox.org/tracker/task/12185 though I'm not knowledgeable enough to determine if this patches libfaad itself, rockbox's own code, or both. Anyway I hope it is useful. This commit refers to the frontend code and does not touch libfaad itself. It refers to rockbox/apps/codecs/aac.c but that's an old version (for their release 3.9.1)and in current Rockbox the relevant file is rockbox/lib/rbcodec/codecs/aac.c I see, the libfaad source copy has also been moved around in the source tree. However, digging through its history in the old location, I cannot find a single commit refering to gapless playback: http://git.rockbox.org/?p=rockbox.git;a=history;f=apps/codecs/libfaad;hb=a0009907de7a0107d49040d8a180f140e2eff299 In the new location the code has not been changed since its initial move there on 2012-04-25: http://git.rockbox.org/?p=rockbox.git;a=history;f=lib/rbcodec/codecs/libfaad;hb=HEAD I'm also sure it's an upstream issue because every faad/libfaad tool/app is defective in this respect unless it has been patched downstream. I emailed i...@audiocoding.com as I couldn't find any upstream bugtracker or similar. I don't expect to receive a reply but who knows? I am not that sure anymore. It seems that the library is fine to play gapless and that its the frontends that need to get patched in order to cope with this. But this is only a guess, we are still lacking a patch against libfaad to confirm this... - Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#703732: faad fails to gaplessly decode itunes, nero, fraunhofer aac
On Mon, 25 Mar 2013 09:47:36 +0100 Fabian Greffrath fab...@greffrath.com wrote: This commit refers to the frontend code and does not touch libfaad itself. I am not that sure anymore. It seems that the library is fine to play gapless and that its the frontends that need to get patched in order to cope with this. But this is only a guess, we are still lacking a patch against libfaad to confirm this... - Fabian Thanks for looking at the Rockbox implementation. Meanwhile the official faad binary itself surely would not be one of the frontends which doesn't use libfaad properly? I just built faad and libfaad from most recent source (now I see the bug tracker is at sourceforge, which is why I couldn't find it at audiocoding.com) and I get the same result: I make gapless m4a with neroAacEnc: to avoid any possible imperfect player's use of libfaad I decode to wav and play the wavs a) with 'mplayer2 -gapless-audio' and b) on my player running Rockbox: decode with neroaacdec: the wavs play gaplessly. decode with faad: there is a gap inserted. decode with win32 application foobar2000: the wavs play gaplessly. I repeat the exercise, this time making the encode with fdkaac instead of nero: The result is identical: wavs produced by faad have a gap inserted. wavs produced by another_decoder play as intended. I'm still concluding that faad/libfaad can only correctly decode gapless files if they are produced by faac, which doesn't seem to match the package description of FAAD2 correctly decodes all MPEG-4 and MPEG-2 MAIN, LOW, LTP, LD and ER object type AAC files. I hope I haven't completely misunderstood this, and I appreciate that any fix, if even possible, might not be very likely but thank you for taking the trouble to look into it regards Julian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#703732: faad fails to gaplessly decode itunes, nero, fraunhofer aac
Am Montag, den 25.03.2013, 12:31 + schrieb Julian Hughes: Meanwhile the official faad binary itself surely would not be one of the frontends which doesn't use libfaad properly? I wouldn't say that the libfaad library nor its official frontend are flawless. It is just that all patches addressing gapless playback that I found so far touched frontend code and not the library itself. I'm still concluding that faad/libfaad can only correctly decode gapless files if they are produced by faac, which doesn't seem to match the package description of The problem with your tests is that you can only exchange frontend *and* library for comparison. Could you try again with different fontends for the exact same libfaad2 again, e.g. mplayer, mplayer2, vlc, totem, xine? I hope I haven't completely misunderstood this, and I appreciate that any fix, if even possible, might not be very likely but thank you for taking the trouble to look into it I have yet to see any patch against libfaad that explicitely addresses gapless playback and I'd enjoy to apply it. - Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#703732: faad fails to gaplessly decode itunes, nero, fraunhofer aac
control: tags -1 moreinfo Am Freitag, den 22.03.2013, 21:43 + schrieb Julian Hughes: The same problem is in any application which decodes with unpatched libfaad2. I notice Rockbox has patched libfaad and their version properly decodes aac/m4a regardless of which encoder was used. The same files which don't decode gaplessly on my PC with faad or libfaad do decode gaplessly on my portable running Rockbox. I believe Dear Julian. thank you very much for your bug report. Is there any specific patch that Rockbox applied to their local copy of libfaad that you could identify to fix the issue? I have seen that Rockbox at least manage their source in GIT but unfortunately apply patches directly to the sources of their local library copies instead of keeping separate patches around. Squeezebox also patch libfaad to do the same but I can't confirm it works. In the past I have already forwarded some of the Squeezebox patches to FAAD upstream. There is still a lack of reaction towards a patch that adds ALAC support, but the others have been accepted and applied. AFAICT a patch addressing gapless playback was not among them, though. Anyway, I think this bug report is already correctly tagged upstream, since this is where the issue should get fixed in the first place. Cheers, - Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Processed: Re: Bug#703732: faad fails to gaplessly decode itunes, nero, fraunhofer aac
Processing control commands: tags -1 moreinfo Bug #703732 [faad] faad fails to gaplessly decode itunes, nero, fraunhofer aac Added tag(s) moreinfo. -- 703732: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=703732 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#703732: faad fails to gaplessly decode itunes, nero, fraunhofer aac
Hi Fabian thank you very much for responding. The relevant patch seems to be: http://www.rockbox.org/tracker/task/12185 though I'm not knowledgeable enough to determine if this patches libfaad itself, rockbox's own code, or both. Anyway I hope it is useful. It refers to rockbox/apps/codecs/aac.c but that's an old version (for their release 3.9.1)and in current Rockbox the relevant file is rockbox/lib/rbcodec/codecs/aac.c I'm also sure it's an upstream issue because every faad/libfaad tool/app is defective in this respect unless it has been patched downstream. I emailed i...@audiocoding.com as I couldn't find any upstream bugtracker or similar. I don't expect to receive a reply but who knows? cheers Julian Hughes ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#703732: faad fails to gaplessly decode itunes, nero, fraunhofer aac
Package: faad Version: 2.7-8 Severity: normal Tags: upstream faad incorrectly decodes any aac/m4a audio file that was encoded by neroaacenc or itunes or fraunhofer fdkaac/libfdk. This breaks gapless playback. example: Take an CD such as The Beatles' Abbey Road which plays without gaps. Rip and encode to individual flacs or wavs. The files play without any gap, for example in mpd or with 'mplayer2 -gapless-audio'. Encode the wavs to m4a with faac. Use faad to decode the m4a files to wav i.e. `faad -o out.wav in.m4a` The wavs play without any gap. Now encode the original wavs to m4a but use an encoder other than faac: Use faad to decode the m4a files to wav. Now the wavs play with a gap between each track. Using a different decoder such as neroAacDec on the same files produces wavs which play without gaps. The same problem is in any application which decodes with unpatched libfaad2. I notice Rockbox has patched libfaad and their version properly decodes aac/m4a regardless of which encoder was used. The same files which don't decode gaplessly on my PC with faad or libfaad do decode gaplessly on my portable running Rockbox. I believe Squeezebox also patch libfaad to do the same but I can't confirm it works. -- System Information: Debian Release: 7.0 APT prefers testing APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental') Architecture: i386 (i686) Kernel: Linux 3.8.3 (SMP w/2 CPU cores) Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages faad depends on: ii libc6 2.13-38 ii libfaad2 2.7-8 faad recommends no packages. faad suggests no packages. -- no debconf information ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Bug#689712: faad crashes when given ADTS AAC file with large ID3v2 tag
Package: faad
Version: 2.7-8
Severity: normal
Tags: upstream
I have an ADTS AAC file with an ID3v2 tag containing an image. Attempting to
skip this header by passing a value larger than the buffer size to
advance_buffer causes fill_buffer to misbehave. The problem is detected in
free() during a normal build but the problem is clearer when running under
valgrind:
==23880== Invalid write of size 8
==23880==at 0x50F81CB: __GI_memcpy (memcpy.S:267)
==23880==by 0x50E17D2: _IO_file_xsgetn (fileops.c:1414)
==23880==by 0x50D79B1: fread (iofread.c:44)
==23880==by 0x403930: ??? (in /usr/bin/faad)
==23880==by 0x401BAE: ??? (in /usr/bin/faad)
==23880==by 0x508EEAC: (below main) (libc-start.c:228)
==23880== Address 0x567a830 is 0 bytes after a block of size 4,608 alloc'd
==23880==at 0x4C28BED: malloc (in /usr/lib/valgrind/vgpreload_memcheck-
amd64-linux.so)
==23880==by 0x401AC2: ??? (in /usr/bin/faad)
==23880==by 0x508EEAC: (below main) (libc-start.c:228)
Here's a more useful log generated by a version of faad I compiled myself on
squeeze-i386:
==28965== Syscall param read(buf) points to unaddressable byte(s)
==28965==at 0x4A06073: __read_nocancel (syscall-template.S:82)
==28965==by 0x49B16F7: _IO_sgetn (genops.c:500)
==28965==by 0x49A52CD: fread (iofread.c:44)
==28965==by 0x8049150: fill_buffer (main.c:100)
==28965==by 0x8049544: decodeAACfile (main.c:478)
==28965==by 0x804A484: main (main.c:1249)
==28965== Address 0x6d20548 is 0 bytes after a block of size 4,608 alloc'd
==28965==at 0x48DEF50: malloc (vg_replace_malloc.c:236)
==28965==by 0x8049461: decodeAACfile (main.c:454)
==28965==by 0x804A484: main (main.c:1249)
==28965==
==28965== Invalid write of size 1
==28965==at 0x48E091F: memcpy (mc_replace_strmem.c:497)
==28965==by 0x49AF737: _IO_file_xsgetn (fileops.c:1414)
==28965==by 0x49B16F7: _IO_sgetn (genops.c:500)
==28965==by 0x49A52CD: fread (iofread.c:44)
==28965==by 0x8049150: fill_buffer (main.c:100)
==28965==by 0x8049544: decodeAACfile (main.c:478)
==28965==by 0x804A484: main (main.c:1249)
==28965== Address 0x6d24d95 is not stack'd, malloc'd or (recently) free'd
The attached patch fixes the problem for me. I've submitted it upstream at
https://sourceforge.net/tracker/?func=detailaid=3574761group_id=704atid=100704
-- System Information:
Debian Release: wheezy/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.2.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages faad depends on:
ii libc6 2.13-35
ii libfaad2 2.7-8
faad recommends no packages.
faad suggests no packages.
Only in faad2-2.7/common: Makefile
Only in faad2-2.7/common/mp4ff: .deps
Only in faad2-2.7/common/mp4ff: libmp4ff.a
Only in faad2-2.7/common/mp4ff: libmp4ff_a-mp4atom.o
Only in faad2-2.7/common/mp4ff: libmp4ff_a-mp4ff.o
Only in faad2-2.7/common/mp4ff: libmp4ff_a-mp4meta.o
Only in faad2-2.7/common/mp4ff: libmp4ff_a-mp4sample.o
Only in faad2-2.7/common/mp4ff: libmp4ff_a-mp4tagupdate.o
Only in faad2-2.7/common/mp4ff: libmp4ff_a-mp4util.o
Only in faad2-2.7/common/mp4ff: Makefile
Only in faad2-2.7: config.h
Only in faad2-2.7: config.log
Only in faad2-2.7: config.status
Only in faad2-2.7: faad2.spec
Only in faad2-2.7/frontend: audio.o
Only in faad2-2.7/frontend: .deps
Only in faad2-2.7/frontend: faad
Only in faad2-2.7/frontend: getopt.o
Only in faad2-2.7/frontend: .libs
diff -rup faad2-2.7.stock/frontend/main.c faad2-2.7/frontend/main.c
--- faad2-2.7.stock/frontend/main.c 2008-09-22 18:55:09.0 +0100
+++ faad2-2.7/frontend/main.c 2012-10-04 21:46:31.175490401 +0100
@@ -130,11 +130,22 @@ static int fill_buffer(aac_buffer *b)
static void advance_buffer(aac_buffer *b, int bytes)
{
-b-file_offset += bytes;
-b-bytes_consumed = bytes;
-b-bytes_into_buffer -= bytes;
- if (b-bytes_into_buffer 0)
- b-bytes_into_buffer = 0;
+while ((b-bytes_into_buffer 0) (bytes 0))
+{
+ assert(b-bytes_into_buffer 0);
+ int chunk = min(bytes, b-bytes_into_buffer);
+
+ bytes -= chunk;
+ b-file_offset += chunk;
+ b-bytes_consumed = chunk;
+ b-bytes_into_buffer -= chunk;
+ assert(b-bytes_into_buffer = 0);
+
+ if (b-bytes_into_buffer == 0)
+ fill_buffer(b);
+}
+
+assert(b-bytes_into_buffer = 0);
}
static int adts_sample_rates[] = {96000,88200,64000,48000,44100,32000,24000,22050,16000,12000,11025,8000,7350,0,0,0};
Only in faad2-2.7/frontend: main.c~
Only in faad2-2.7/frontend: main-debug.c
Only in faad2-2.7/frontend: main.o
Only in faad2-2.7/frontend: Makefile
Only in faad2-2.7/libfaad: bits.lo
Only in faad2-2.7/libfaad: bits.o
Only in faad2-2.7/libfaad: cfft.lo
Only in faad2-2.7/libfaad: cfft.o
Only in faad2-2.7/libfaad: common.lo
Only in faad2-2.7/libfaad: common.o
Only in faad2-2.7/libfaad: decoder.lo
Only in faad2-2.7/libfaad: decoder.o
Bug#603807: marked as done (faad segfaults on amd64 due to incorrect pointer size)
Your message dated Mon, 22 Nov 2010 10:31:51 +0100
with message-id aanlktinxmdypko1kr=b=wpk9vnwh-kjbuvn11z3sa...@mail.gmail.com
and subject line Fixed in sid
has caused the Debian Bug report #603807,
regarding faad segfaults on amd64 due to incorrect pointer size
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
603807: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=603807
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
---BeginMessage---
Package: faad
Version: 2.7-4
Severity: serious
Tags: patch sid squeeze upstream
This bug was reported on Ubuntu [1] and it affects Debian Squeeze too.
I've tried to reproduce it and here is the result:
ales...@alessio-laptop:~$ faad -b 2 -f 2 -w sample.aac
*** Ahead Software MPEG-4 AAC Decoder V2.7 **
Build: Oct 26 2009
Copyright 2002-2004: Ahead Software AG
http://www.audiocoding.com
Floating point version
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License.
**
sample.aac file info:
ADTS, 4.608 sec, 13 kbps, 16000 Hz
-
| Config: 2 Ch |
-
| Ch |Position|
-
| 00 | Left front |
| 01 | Right front|
-
Segmentation fault.aac.
A patch to fix this is available on Launchpad, I'm attaching it here:
--- frontend/audio.c.orig 2010-10-24 15:36:19.673485313 +0800
+++ frontend/audio.c2010-10-24 15:36:43.323775214 +0800
@@ -347,7 +347,7 @@
{
int ret;
unsigned int i;
-long *sample_buffer24 = (long*)sample_buffer;
+int *sample_buffer24 = (int*)sample_buffer;
char *data = malloc(samples*aufile-bits_per_sample*sizeof(char)/8);
aufile-total_samples += samples;
@@ -391,7 +391,7 @@
{
int ret;
unsigned int i;
-long *sample_buffer32 = (long*)sample_buffer;
+int *sample_buffer32 = (int*)sample_buffer;
char *data = malloc(samples*aufile-bits_per_sample*sizeof(char)/8);
aufile-total_samples += samples;
[1] https://launchpad.net/bugs/665802
-- System Information:
Debian Release: squeeze/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.32-5-amd64 (SMP w/4 CPU cores)
Locale: LANG=it_IT.utf8, LC_CTYPE=it_IT.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages faad depends on:
ii libc6 2.11.2-7 Embedded GNU C Library: Shared lib
ii libfaad2 2.7-4 freeware Advanced Audio Decoder -
faad recommends no packages.
faad suggests no packages.
-- no debconf information
---End Message---
---BeginMessage---
Version: 2.7-5
Hi,
although the change is not mentioned, the latest 2.7-5 in sid fixes this.
We're working on a new upload which would allow us to make the package
migrate to testing.
--
Alessio Treglia ales...@debian.org
Debian Ubuntu Developer | Homepage: http://www.alessiotreglia.com
0FEC 59A5 E18E E04F 6D40 593B 45D4 8C7C DCFC 3FD0
---End Message---
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#603807: marked as done (faad segfaults on amd64 due to incorrect pointer size)
Your message dated Tue, 23 Nov 2010 01:32:13 +
with message-id e1pkhjx-0005hg...@franck.debian.org
and subject line Bug#603807: fixed in faad2 2.7-6
has caused the Debian Bug report #603807,
regarding faad segfaults on amd64 due to incorrect pointer size
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
603807: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=603807
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
---BeginMessage---
Package: faad
Version: 2.7-4
Severity: serious
Tags: patch sid squeeze upstream
This bug was reported on Ubuntu [1] and it affects Debian Squeeze too.
I've tried to reproduce it and here is the result:
ales...@alessio-laptop:~$ faad -b 2 -f 2 -w sample.aac
*** Ahead Software MPEG-4 AAC Decoder V2.7 **
Build: Oct 26 2009
Copyright 2002-2004: Ahead Software AG
http://www.audiocoding.com
Floating point version
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License.
**
sample.aac file info:
ADTS, 4.608 sec, 13 kbps, 16000 Hz
-
| Config: 2 Ch |
-
| Ch |Position|
-
| 00 | Left front |
| 01 | Right front|
-
Segmentation fault.aac.
A patch to fix this is available on Launchpad, I'm attaching it here:
--- frontend/audio.c.orig 2010-10-24 15:36:19.673485313 +0800
+++ frontend/audio.c2010-10-24 15:36:43.323775214 +0800
@@ -347,7 +347,7 @@
{
int ret;
unsigned int i;
-long *sample_buffer24 = (long*)sample_buffer;
+int *sample_buffer24 = (int*)sample_buffer;
char *data = malloc(samples*aufile-bits_per_sample*sizeof(char)/8);
aufile-total_samples += samples;
@@ -391,7 +391,7 @@
{
int ret;
unsigned int i;
-long *sample_buffer32 = (long*)sample_buffer;
+int *sample_buffer32 = (int*)sample_buffer;
char *data = malloc(samples*aufile-bits_per_sample*sizeof(char)/8);
aufile-total_samples += samples;
[1] https://launchpad.net/bugs/665802
-- System Information:
Debian Release: squeeze/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.32-5-amd64 (SMP w/4 CPU cores)
Locale: LANG=it_IT.utf8, LC_CTYPE=it_IT.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages faad depends on:
ii libc6 2.11.2-7 Embedded GNU C Library: Shared lib
ii libfaad2 2.7-4 freeware Advanced Audio Decoder -
faad recommends no packages.
faad suggests no packages.
-- no debconf information
---End Message---
---BeginMessage---
Source: faad2
Source-Version: 2.7-6
We believe that the bug you reported is fixed in the latest version of
faad2, which is due to be installed in the Debian FTP archive:
faad2-dbg_2.7-6_amd64.deb
to main/f/faad2/faad2-dbg_2.7-6_amd64.deb
faad2_2.7-6.diff.gz
to main/f/faad2/faad2_2.7-6.diff.gz
faad2_2.7-6.dsc
to main/f/faad2/faad2_2.7-6.dsc
faad_2.7-6_amd64.deb
to main/f/faad2/faad_2.7-6_amd64.deb
libfaad-dev_2.7-6_amd64.deb
to main/f/faad2/libfaad-dev_2.7-6_amd64.deb
libfaad2_2.7-6_amd64.deb
to main/f/faad2/libfaad2_2.7-6_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 603...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Andres Mejia mcita...@gmail.com (supplier of updated faad2 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Format: 1.8
Date: Mon, 22 Nov 2010 19:17:36 -0500
Source: faad2
Binary: libfaad-dev libfaad2 faad2-dbg faad
Architecture: source amd64
Version: 2.7-6
Distribution: unstable
Urgency: high
Maintainer: Debian multimedia packages maintainers
pkg-multimedia-maintainers@lists.alioth.debian.org
Changed-By: Andres Mejia mcita...@gmail.com
Description:
faad - freeware Advanced Audio Decoder player
faad2-dbg - freeware Advanced Audio Decoder - debugging symbols
libfaad-dev - freeware Advanced Audio Decoder - development files
libfaad2 - freeware Advanced Audio Decoder - runtime files
Closes: 603807
Changes
Bug#603807: faad segfaults on amd64 due to incorrect pointer size
Package: faad
Version: 2.7-4
Severity: serious
Tags: patch sid squeeze upstream
This bug was reported on Ubuntu [1] and it affects Debian Squeeze too.
I've tried to reproduce it and here is the result:
ales...@alessio-laptop:~$ faad -b 2 -f 2 -w sample.aac
*** Ahead Software MPEG-4 AAC Decoder V2.7 **
Build: Oct 26 2009
Copyright 2002-2004: Ahead Software AG
http://www.audiocoding.com
Floating point version
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License.
**
sample.aac file info:
ADTS, 4.608 sec, 13 kbps, 16000 Hz
-
| Config: 2 Ch |
-
| Ch |Position|
-
| 00 | Left front |
| 01 | Right front|
-
Segmentation fault.aac.
A patch to fix this is available on Launchpad, I'm attaching it here:
--- frontend/audio.c.orig 2010-10-24 15:36:19.673485313 +0800
+++ frontend/audio.c2010-10-24 15:36:43.323775214 +0800
@@ -347,7 +347,7 @@
{
int ret;
unsigned int i;
-long *sample_buffer24 = (long*)sample_buffer;
+int *sample_buffer24 = (int*)sample_buffer;
char *data = malloc(samples*aufile-bits_per_sample*sizeof(char)/8);
aufile-total_samples += samples;
@@ -391,7 +391,7 @@
{
int ret;
unsigned int i;
-long *sample_buffer32 = (long*)sample_buffer;
+int *sample_buffer32 = (int*)sample_buffer;
char *data = malloc(samples*aufile-bits_per_sample*sizeof(char)/8);
aufile-total_samples += samples;
[1] https://launchpad.net/bugs/665802
-- System Information:
Debian Release: squeeze/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.32-5-amd64 (SMP w/4 CPU cores)
Locale: LANG=it_IT.utf8, LC_CTYPE=it_IT.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages faad depends on:
ii libc6 2.11.2-7 Embedded GNU C Library: Shared lib
ii libfaad2 2.7-4 freeware Advanced Audio Decoder -
faad recommends no packages.
faad suggests no packages.
-- no debconf information
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Bug#603807: faad segfaults on amd64 due to incorrect pointer size
Am 17.11.2010 15:16, schrieb Alessio Treglia: A patch to fix this is available on Launchpad, I'm attaching it here: Cool. Would you mind to apply it to the package? - Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Bug#603807: faad segfaults on amd64 due to incorrect pointer size
On Wed, Nov 17, 2010 at 3:46 PM, Fabian Greffrath fab...@greffrath.com wrote: Am 17.11.2010 15:16, schrieb Alessio Treglia: A patch to fix this is available on Launchpad, I'm attaching it here: Cool. Would you mind to apply it to the package? Of course I do. -- Alessio Treglia ales...@debian.org Debian Ubuntu Developer | Homepage: http://www.alessiotreglia.com 0FEC 59A5 E18E E04F 6D40 593B 45D4 8C7C DCFC 3FD0 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Bug#603807: faad segfaults on amd64 due to incorrect pointer size
On Wed, Nov 17, 2010 at 3:46 PM, Fabian Greffrath fab...@greffrath.com wrote: Am 17.11.2010 15:16, schrieb Alessio Treglia: A patch to fix this is available on Launchpad, I'm attaching it here: Cool. Would you mind to apply it to the package? Done! -- Alessio Treglia ales...@debian.org Debian Ubuntu Developer | Homepage: http://www.alessiotreglia.com 0FEC 59A5 E18E E04F 6D40 593B 45D4 8C7C DCFC 3FD0 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Bug#603807: faad segfaults on amd64 due to incorrect pointer size
On Wed, Nov 17, 2010 at 05:13:20PM +0100, Alessio Treglia wrote: On Wed, Nov 17, 2010 at 3:46 PM, Fabian Greffrath fab...@greffrath.com wrote: Am 17.11.2010 15:16, schrieb Alessio Treglia: A patch to fix this is available on Launchpad, I'm attaching it here: Cool. Would you mind to apply it to the package? Of course I do. nitpicking he he: you probably meant the opposite - that you do _not_ mind ;-) /nitpicking - Jonas -- * Jonas Smedegaard - idealist Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Bug#603807: faad segfaults on amd64 due to incorrect pointer size
On Wed, Nov 17, 2010 at 6:38 PM, Jonas Smedegaard d...@jones.dk wrote: nitpicking he he: you probably meant the opposite - that you do _not_ mind ;-) /nitpicking Yep, sorry :( -- Alessio Treglia ales...@debian.org Debian Ubuntu Developer | Homepage: http://www.alessiotreglia.com 0FEC 59A5 E18E E04F 6D40 593B 45D4 8C7C DCFC 3FD0 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Debian patches for FAAD
Dear Menno, maybe you could find some spare time within the next few weeks to review the patches Debian proposes for inclusion in FAAD? I'd like to get these changes into the upcoming Debian release (which is already in freeze for quite some time) and an upstream approval of the patches is likely to help convince the release team to make a freeze exception for faad. The patches in question can be found here: http://git.debian.org/?p=pkg-multimedia/faad2.git;a=tree;f=debian/patches;hb=HEAD Best regards, Fabian PS: Sorry for posting to both of your email addresses, but I have forgotten which one is more likely to get an answer. ;) ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
