Re: qxgedit review

[Jaromír Mikeš]

2015-09-29 14:59 GMT+02:00 Felipe Sateler :
> On 29 September 2015 at 03:12, Jaromír Mikeš  wrote:
>> 2015-06-15 16:30 GMT+02:00 Jaromír Mikeš :
>>> 2015-05-14 1:50 GMT+02:00 Jaromír Mikeš :
 Hello,

 qxgedit is almost ready.
 I'm having this two warnings which I am not able currently fix ;(

 I would be happy if somebody would find a time to review a package and
 possibly upload.
>>>
>>> Nobody? :(
>>
>> Hi,
>>
>> qxgedit is updated to latest upstream version now.
>> Can some DD upload it to NEW please?
>
> I can probably take a look during the weekend (hopefully earlier).
> Please ping me again on friday or so if I haven't uploaded, so that I
> don't forget.

Ping ;)

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: qxgedit review

[Felipe Sateler]

On 2 October 2015 at 03:49, Jaromír Mikeš  wrote:
>
> 2015-09-29 14:59 GMT+02:00 Felipe Sateler :
> > On 29 September 2015 at 03:12, Jaromír Mikeš  wrote:
> >> 2015-06-15 16:30 GMT+02:00 Jaromír Mikeš :
> >>> 2015-05-14 1:50 GMT+02:00 Jaromír Mikeš :
>  Hello,
> 
>  qxgedit is almost ready.
>  I'm having this two warnings which I am not able currently fix ;(
> 
>  I would be happy if somebody would find a time to review a package and
>  possibly upload.
> >>>
> >>> Nobody? :(
> >>
> >> Hi,
> >>
> >> qxgedit is updated to latest upstream version now.
> >> Can some DD upload it to NEW please?
> >
> > I can probably take a look during the weekend (hopefully earlier).
> > Please ping me again on friday or so if I haven't uploaded, so that I
> > don't forget.
>
> Ping ;)

Uploaded!

OT, I recently found out about the --follow-tags git push option,
which helps not forgetting to push the tags :)

-- 

Saludos,
Felipe Sateler

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: qxgedit review

[Jonas Smedegaard]

Quoting Jaromír Mikeš (2015-10-02 18:04:15)
> 2015-10-02 15:03 GMT+02:00 Felipe Sateler :
>> OT, I recently found out about the --follow-tags git push option, 
>> which helps not forgetting to push the tags :)

Ohh, cool!  I wasn't aware of that one.

> Hmm ... not sure if I am understanding advantage against --tags option :(
> Can you explain pls?

Problem with --tags is it pushes _all_ tags, also ones irrelevant for 
the the work being pushed (e.g. ones tied to upstream branches).

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private


signature.asc
Description: signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: qxgedit review

[Felipe Sateler]

On 2 October 2015 at 15:17, Jaromír Mikeš  wrote:
> 2015-10-02 18:26 GMT+02:00 Jonas Smedegaard :
>> Quoting Jaromír Mikeš (2015-10-02 18:04:15)
>>> 2015-10-02 15:03 GMT+02:00 Felipe Sateler :
 OT, I recently found out about the --follow-tags git push option,
 which helps not forgetting to push the tags :)
>>
>> Ohh, cool!  I wasn't aware of that one.
>>
>>> Hmm ... not sure if I am understanding advantage against --tags option :(
>>> Can you explain pls?
>>
>> Problem with --tags is it pushes _all_ tags, also ones irrelevant for
>> the the work being pushed (e.g. ones tied to upstream branches).
>
> Got it ;)
> Than we should maybe use it rather than --tags option and edit our
> wiki pages [1]
> Should we change it in all cases?

I think so. I don't see any reason why we should prefer using --tags
rather than --follow-tags.

-- 

Saludos,
Felipe Sateler

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: qxgedit review

[Jaromír Mikeš]

2015-10-02 20:23 GMT+02:00 Felipe Sateler :
> On 2 October 2015 at 15:17, Jaromír Mikeš  wrote:
>> 2015-10-02 18:26 GMT+02:00 Jonas Smedegaard :
>>> Quoting Jaromír Mikeš (2015-10-02 18:04:15)
 2015-10-02 15:03 GMT+02:00 Felipe Sateler :
> OT, I recently found out about the --follow-tags git push option,
> which helps not forgetting to push the tags :)
>>>
>>> Ohh, cool!  I wasn't aware of that one.
>>>
 Hmm ... not sure if I am understanding advantage against --tags option :(
 Can you explain pls?
>>>
>>> Problem with --tags is it pushes _all_ tags, also ones irrelevant for
>>> the the work being pushed (e.g. ones tied to upstream branches).
>>
>> Got it ;)
>> Than we should maybe use it rather than --tags option and edit our
>> wiki pages [1]
>> Should we change it in all cases?
>
> I think so. I don't see any reason why we should prefer using --tags
> rather than --follow-tags.

Felipe can you please suggest this change in separate mail in our ML?
So the topic wouldn't be missed by others and we can see if there will
be some objections.

regards

mira

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: qxgedit review

[Jaromír Mikeš]

2015-10-02 18:26 GMT+02:00 Jonas Smedegaard :
> Quoting Jaromír Mikeš (2015-10-02 18:04:15)
>> 2015-10-02 15:03 GMT+02:00 Felipe Sateler :
>>> OT, I recently found out about the --follow-tags git push option,
>>> which helps not forgetting to push the tags :)
>
> Ohh, cool!  I wasn't aware of that one.
>
>> Hmm ... not sure if I am understanding advantage against --tags option :(
>> Can you explain pls?
>
> Problem with --tags is it pushes _all_ tags, also ones irrelevant for
> the the work being pushed (e.g. ones tied to upstream branches).

Got it ;)
Than we should maybe use it rather than --tags option and edit our
wiki pages [1]
Should we change it in all cases?

mira

[1]https://wiki.debian.org/DebianMultimedia/DevelopPackaging

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: qxgedit review

[Jaromír Mikeš]

2015-06-15 16:30 GMT+02:00 Jaromír Mikeš :
> 2015-05-14 1:50 GMT+02:00 Jaromír Mikeš :
>> Hello,
>>
>> qxgedit is almost ready.
>> I'm having this two warnings which I am not able currently fix ;(
>>
>> I would be happy if somebody would find a time to review a package and
>> possibly upload.
>
> Nobody? :(

Hi,

qxgedit is updated to latest upstream version now.
Can some DD upload it to NEW please?

best regards

mira

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: qxgedit review

[Jaromír Mikeš]

2015-09-29 14:59 GMT+02:00 Felipe Sateler :
> On 29 September 2015 at 03:12, Jaromír Mikeš  wrote:
>> 2015-06-15 16:30 GMT+02:00 Jaromír Mikeš :
>>> 2015-05-14 1:50 GMT+02:00 Jaromír Mikeš :
 Hello,

 qxgedit is almost ready.
 I'm having this two warnings which I am not able currently fix ;(

 I would be happy if somebody would find a time to review a package and
 possibly upload.
>>>
>>> Nobody? :(
>>
>> Hi,
>>
>> qxgedit is updated to latest upstream version now.
>> Can some DD upload it to NEW please?
>
> I can probably take a look during the weekend (hopefully earlier).
> Please ping me again on friday or so if I haven't uploaded, so that I
> don't forget.

I will remind you in that case ;) Thank you Felipe.

mira

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: qxgedit review

[Felipe Sateler]

On 29 September 2015 at 03:12, Jaromír Mikeš  wrote:
> 2015-06-15 16:30 GMT+02:00 Jaromír Mikeš :
>> 2015-05-14 1:50 GMT+02:00 Jaromír Mikeš :
>>> Hello,
>>>
>>> qxgedit is almost ready.
>>> I'm having this two warnings which I am not able currently fix ;(
>>>
>>> I would be happy if somebody would find a time to review a package and
>>> possibly upload.
>>
>> Nobody? :(
>
> Hi,
>
> qxgedit is updated to latest upstream version now.
> Can some DD upload it to NEW please?

I can probably take a look during the weekend (hopefully earlier).
Please ping me again on friday or so if I haven't uploaded, so that I
don't forget.


-- 

Saludos,
Felipe Sateler

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: qxgedit review

[Jaromír Mikeš]

2015-05-14 1:50 GMT+02:00 Jaromír Mikeš mira.mi...@gmail.com:
 Hello,

 qxgedit is almost ready.
 I'm having this two warnings which I am not able currently fix ;(

 I would be happy if somebody would find a time to review a package and
 possibly upload.

Nobody? :(

mira

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: qxgedit review

[Jaromír Mikeš]

2015-05-31 19:55 GMT+02:00 Ross Gammon r...@the-gammons.net:
 On 05/14/2015 01:50 AM, Jaromír Mikeš wrote:
 Hello,

 qxgedit is almost ready.
 I'm having this two warnings which I am not able currently fix ;(

 I: qxgedit: hardening-no-fortify-functions usr/bin/qxgedit
 W: qxgedit: hardening-no-relro
 usr/lib/x86_64-linux-gnu/qt4/plugins/styles/libskulpturestyle.so

 I would be happy if somebody would find a time to review a package and
 possibly upload.

 Sorry - I have been a little busy over the last week.

No problem ;)

 I had done a
 review a while back, and made a couple of tweaks which I just pushed.

Awesome.

 I tried a few tricks, but couldn't solve the hardening issue either. I
 need a little bit more time to study the upstream build system.

Yes hardening can be sometimes tricky ;)
Thank you for trying!

regards

mira

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: qxgedit review

[Ross Gammon]

On 05/14/2015 01:50 AM, Jaromír Mikeš wrote:
 Hello,
 
 qxgedit is almost ready.
 I'm having this two warnings which I am not able currently fix ;(
 
 I: qxgedit: hardening-no-fortify-functions usr/bin/qxgedit
 W: qxgedit: hardening-no-relro
 usr/lib/x86_64-linux-gnu/qt4/plugins/styles/libskulpturestyle.so
 
 I would be happy if somebody would find a time to review a package and
 possibly upload.

Hi mira,

Sorry - I have been a little busy over the last week. I had done a
review a while back, and made a couple of tweaks which I just pushed.

I tried a few tricks, but couldn't solve the hardening issue either. I
need a little bit more time to study the upstream build system.

Cheers,

Ross



signature.asc
Description: OpenPGP digital signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: qxgedit review

[Jaromír Mikeš]

2015-05-31 21:39 GMT+02:00 James Cowgill james...@cowgill.org.uk:
 On Sun, 2015-05-31 at 19:55 +0200, Ross Gammon wrote:
 On 05/14/2015 01:50 AM, Jaromír Mikeš wrote:
  Hello,
 
  qxgedit is almost ready.
  I'm having this two warnings which I am not able currently fix ;(
 
  I: qxgedit: hardening-no-fortify-functions usr/bin/qxgedit

Hi James,

 configure.ac messes the flags up a bit (uses CFLAGS for C++ files,
 modifies CPPFLAGS but never uses it).

 Adding this to debian/rules will fix it, but upstream should sort their
 configure script out:

 export DEB_CFLAGS_MAINT_APPEND := $(shell dpkg-buildflags --get CPPFLAGS)

  W: qxgedit: hardening-no-relro
  usr/lib/x86_64-linux-gnu/qt4/plugins/styles/libskulpturestyle.so

 Add this to skulpture/skulpture.pri.in (copied from src/src.pri.in).

 # Extra optimization flags
 QMAKE_CXXFLAGS += @ac_cflags@
 QMAKE_LFLAGS += @ac_ldflags@

thank you for help!

best regards

mira

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: qxgedit review

[James Cowgill]

Hi,

On Sun, 2015-05-31 at 19:55 +0200, Ross Gammon wrote:
 On 05/14/2015 01:50 AM, Jaromír Mikeš wrote:
  Hello,
  
  qxgedit is almost ready.
  I'm having this two warnings which I am not able currently fix ;(
  
  I: qxgedit: hardening-no-fortify-functions usr/bin/qxgedit

configure.ac messes the flags up a bit (uses CFLAGS for C++ files,
modifies CPPFLAGS but never uses it).

Adding this to debian/rules will fix it, but upstream should sort their
configure script out:

export DEB_CFLAGS_MAINT_APPEND := $(shell dpkg-buildflags --get CPPFLAGS)

  W: qxgedit: hardening-no-relro
  usr/lib/x86_64-linux-gnu/qt4/plugins/styles/libskulpturestyle.so

Add this to skulpture/skulpture.pri.in (copied from src/src.pri.in).

# Extra optimization flags
QMAKE_CXXFLAGS += @ac_cflags@
QMAKE_LFLAGS += @ac_ldflags@

James


signature.asc
Description: This is a digitally signed message part
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: qxgedit review

[Jaromír Mikeš]

So if anybody is interested ... I think package is ready for review and upload.

best regards

mira

2015-05-31 23:21 GMT+02:00 Jaromír Mikeš mira.mi...@gmail.com:
 2015-05-31 21:39 GMT+02:00 James Cowgill james...@cowgill.org.uk:
 On Sun, 2015-05-31 at 19:55 +0200, Ross Gammon wrote:
 On 05/14/2015 01:50 AM, Jaromír Mikeš wrote:
  Hello,
 
  qxgedit is almost ready.
  I'm having this two warnings which I am not able currently fix ;(
 
  I: qxgedit: hardening-no-fortify-functions usr/bin/qxgedit

 Hi James,

 configure.ac messes the flags up a bit (uses CFLAGS for C++ files,
 modifies CPPFLAGS but never uses it).

 Adding this to debian/rules will fix it, but upstream should sort their
 configure script out:

 export DEB_CFLAGS_MAINT_APPEND := $(shell dpkg-buildflags --get CPPFLAGS)

  W: qxgedit: hardening-no-relro
  usr/lib/x86_64-linux-gnu/qt4/plugins/styles/libskulpturestyle.so

 Add this to skulpture/skulpture.pri.in (copied from src/src.pri.in).

 # Extra optimization flags
 QMAKE_CXXFLAGS += @ac_cflags@
 QMAKE_LFLAGS += @ac_ldflags@

 thank you for help!

 best regards

 mira

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers