Re: rtkit diff in Ubuntu

[Felipe Sateler]

On 22 October 2015 at 09:56, Felipe Sateler  wrote:
> On 21 October 2015 at 11:28, Martin Pitt  wrote:
>> Hey Felipe,
>>
>> Felipe Sateler [2015-10-18 12:52 -0300]:
>>> It took me a while to do this, but I've finally uploaded a rtkit that
>>> can be (I think) synced back to ubuntu. I also had to apply the rt
>>> linkage fix. If anything remains, please let me know!
>>
>> Thanks for this! The only remaining delta is now that
>> debian/patches/ubuntu.series still has old patch names
>> (01-no_ptrace_cap.patch and configure.patch) which don't actually
>> exist, and is missing some patches.
>>
>> But in fact, the Debian and Ubuntu patches are now exactly the same,
>> so if you could just completely kill debian/patches/ubuntu.series, we
>> would be in perfect sync again.
>
> Huh, I thought I did. I guess since my build just ignored it, I didn't notice.
>
> I don't think I can do this in the next few days, but I've added this
> to my TODO. NMUs or team uploads welcome!

OK, I uploaded a new version nuking the ubuntu.series file. We should
be able to sync now.


-- 

Saludos,
Felipe Sateler

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: rtkit diff in Ubuntu

[Martin Pitt]

Hello Felipe,

Felipe Sateler [2015-10-25 18:27 -0300]:
> OK, I uploaded a new version nuking the ubuntu.series file. We should
> be able to sync now.

Great, many thanks!

Martin

-- 
Martin Pitt| http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: rtkit diff in Ubuntu

[Felipe Sateler]

On 21 October 2015 at 11:28, Martin Pitt  wrote:
> Hey Felipe,
>
> Felipe Sateler [2015-10-18 12:52 -0300]:
>> It took me a while to do this, but I've finally uploaded a rtkit that
>> can be (I think) synced back to ubuntu. I also had to apply the rt
>> linkage fix. If anything remains, please let me know!
>
> Thanks for this! The only remaining delta is now that
> debian/patches/ubuntu.series still has old patch names
> (01-no_ptrace_cap.patch and configure.patch) which don't actually
> exist, and is missing some patches.
>
> But in fact, the Debian and Ubuntu patches are now exactly the same,
> so if you could just completely kill debian/patches/ubuntu.series, we
> would be in perfect sync again.

Huh, I thought I did. I guess since my build just ignored it, I didn't notice.

I don't think I can do this in the next few days, but I've added this
to my TODO. NMUs or team uploads welcome!

-- 

Saludos,
Felipe Sateler

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: rtkit diff in Ubuntu

[Martin Pitt]

Hey Felipe,

Felipe Sateler [2015-10-18 12:52 -0300]:
> It took me a while to do this, but I've finally uploaded a rtkit that
> can be (I think) synced back to ubuntu. I also had to apply the rt
> linkage fix. If anything remains, please let me know!

Thanks for this! The only remaining delta is now that
debian/patches/ubuntu.series still has old patch names
(01-no_ptrace_cap.patch and configure.patch) which don't actually
exist, and is missing some patches.

But in fact, the Debian and Ubuntu patches are now exactly the same,
so if you could just completely kill debian/patches/ubuntu.series, we
would be in perfect sync again.

Thank you!

Martin

-- 
Martin Pitt| http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)


signature.asc
Description: Digital signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: rtkit diff in Ubuntu

[Felipe Sateler]

Hi again,

On 3 May 2015 at 20:10, Luke Yelavich  wrote:
> On Wed, Apr 29, 2015 at 11:01:47PM AEST, Felipe Sateler wrote:
>> On 28 April 2015 at 11:07, Felipe Sateler  wrote:
>> > On 28 April 2015 at 10:32, Martin Pitt  wrote:
>> >> Hey Felipe,
>> >>
>> >> Felipe Sateler [2015-04-24 18:25 -0300]:
>> >>> I see that rtkit has diverged in Ubuntu. Should debian incorporate the
>> >>> patch added to check for mq_getattr? Why is it necessary?
>> >>
>> >> TBH I don't know; I figure back then it failed to build with
>> >> -Wl,--as-needed (as we have in Ubuntu by default) because it forgot to
>> >> link against -lrt, but this doesn't happen on current 15.04. So I
>> >> figure we can drop this patch.
>> >>
>> >> So if you could also apply the unfuzzing of 01-no_ptrace_cap.patch in
>> >> Debian, I think we would be back in sync.
>> >
>> > Ok, I will do that for the next upload. I will request a sync when I
>> > do so pointing to this discussion.
>>
>> Hmm, so 01-no_ptrace_cap.patch is not applied by debian. Maybe we
>> should apply it as well? If so we should also probably drop the
>> CAP_SYS_PTRACE from the systemd unit.
>>
>> Luke, why did you add this patch? The ubuntu changelog does not give
>> hints as to why it is there...
>
> As per the Ubuntu main inclusion request bug, 
> https://bugs.launchpad.net/bugs/396396 the Ubuntu security team requested it 
> be removed.
>
> I also believe it was originally in the changelog when the Ubuntu package was 
> created, but that changelog entry was lost when Debian took the diff, and the 
> package was synced.

It took me a while to do this, but I've finally uploaded a rtkit that
can be (I think) synced back to ubuntu. I also had to apply the rt
linkage fix. If anything remains, please let me know!


-- 

Saludos,
Felipe Sateler

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: rtkit diff in Ubuntu

[Luke Yelavich]

On Wed, Apr 29, 2015 at 11:01:47PM AEST, Felipe Sateler wrote:
 On 28 April 2015 at 11:07, Felipe Sateler fsate...@debian.org wrote:
  On 28 April 2015 at 10:32, Martin Pitt mp...@debian.org wrote:
  Hey Felipe,
 
  Felipe Sateler [2015-04-24 18:25 -0300]:
  I see that rtkit has diverged in Ubuntu. Should debian incorporate the
  patch added to check for mq_getattr? Why is it necessary?
 
  TBH I don't know; I figure back then it failed to build with
  -Wl,--as-needed (as we have in Ubuntu by default) because it forgot to
  link against -lrt, but this doesn't happen on current 15.04. So I
  figure we can drop this patch.
 
  So if you could also apply the unfuzzing of 01-no_ptrace_cap.patch in
  Debian, I think we would be back in sync.
 
  Ok, I will do that for the next upload. I will request a sync when I
  do so pointing to this discussion.
 
 Hmm, so 01-no_ptrace_cap.patch is not applied by debian. Maybe we
 should apply it as well? If so we should also probably drop the
 CAP_SYS_PTRACE from the systemd unit.
 
 Luke, why did you add this patch? The ubuntu changelog does not give
 hints as to why it is there...

As per the Ubuntu main inclusion request bug, 
https://bugs.launchpad.net/bugs/396396 the Ubuntu security team requested it be 
removed.

I also believe it was originally in the changelog when the Ubuntu package was 
created, but that changelog entry was lost when Debian took the diff, and the 
package was synced.

Luke

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: rtkit diff in Ubuntu

[Felipe Sateler]

On 28 April 2015 at 11:07, Felipe Sateler fsate...@debian.org wrote:
 On 28 April 2015 at 10:32, Martin Pitt mp...@debian.org wrote:
 Hey Felipe,

 Felipe Sateler [2015-04-24 18:25 -0300]:
 I see that rtkit has diverged in Ubuntu. Should debian incorporate the
 patch added to check for mq_getattr? Why is it necessary?

 TBH I don't know; I figure back then it failed to build with
 -Wl,--as-needed (as we have in Ubuntu by default) because it forgot to
 link against -lrt, but this doesn't happen on current 15.04. So I
 figure we can drop this patch.

 So if you could also apply the unfuzzing of 01-no_ptrace_cap.patch in
 Debian, I think we would be back in sync.

 Ok, I will do that for the next upload. I will request a sync when I
 do so pointing to this discussion.

Hmm, so 01-no_ptrace_cap.patch is not applied by debian. Maybe we
should apply it as well? If so we should also probably drop the
CAP_SYS_PTRACE from the systemd unit.

Luke, why did you add this patch? The ubuntu changelog does not give
hints as to why it is there...

-- 

Saludos,
Felipe Sateler

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: rtkit diff in Ubuntu

[Martin Pitt]

Hey Felipe,

Felipe Sateler [2015-04-24 18:25 -0300]:
 I see that rtkit has diverged in Ubuntu. Should debian incorporate the
 patch added to check for mq_getattr? Why is it necessary?

TBH I don't know; I figure back then it failed to build with
-Wl,--as-needed (as we have in Ubuntu by default) because it forgot to
link against -lrt, but this doesn't happen on current 15.04. So I
figure we can drop this patch.

So if you could also apply the unfuzzing of 01-no_ptrace_cap.patch in
Debian, I think we would be back in sync.

Thank you!

Martin

-- 
Martin Pitt| http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

rtkit diff in Ubuntu

[Felipe Sateler]

Hi Martin,

I see that rtkit has diverged in Ubuntu. Should debian incorporate the
patch added to check for mq_getattr? Why is it necessary?

-- 

Saludos,
Felipe Sateler

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers