Re: x264_0.120.2171+git01f7a33-2_amd64.changes ACCEPTED into unstable
Hi Andres, Am 17.03.2012 18:48, schrieb Debian FTP Masters: * Add hardened build flags excluding -O2 and -g. I don't quite get it. These packages already have dh compat 9 enabled and thus have the hardeneing build flags exported into their build environment. Why do you now explicitely set CFLAGS again, and while at it, ignore CPPFLAGS and LDFLAGS? - Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: x264_0.120.2171+git01f7a33-2_amd64.changes ACCEPTED into unstable
On Mon, Mar 19, 2012 at 4:48 AM, Fabian Greffrath fab...@greffrath.com wrote: Hi Andres, Am 17.03.2012 18:48, schrieb Debian FTP Masters: * Add hardened build flags excluding -O2 and -g. I don't quite get it. These packages already have dh compat 9 enabled and thus have the hardeneing build flags exported into their build environment. Why do you now explicitely set CFLAGS again, and while at it, ignore CPPFLAGS and LDFLAGS? - Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers x264 set -O3 by default. Us setting -O2 would have overridden that. And with -g, x264 doesn't set -g by default (I presume because full optimizations are enabled). Even so, x264 doesn't provide dbg packages so there's no use in enabling -g anyway. -- ~ Andres ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: x264_0.120.2171+git01f7a33-2_amd64.changes ACCEPTED into unstable
Am 19.03.2012 13:41, schrieb Andres Mejia: x264 set -O3 by default. Us setting -O2 would have overridden that. And with -g, x264 doesn't set -g by default (I presume because full optimizations are enabled). Even so, x264 doesn't provide dbg packages so there's no use in enabling -g anyway. I see, so you re-set CFLAGS to get rid of certain flags that are enabled in Debian by default but that the source's build system should better take care of in these cases. Is this right also for the other packages where you introduced this change? - Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: x264_0.120.2171+git01f7a33-2_amd64.changes ACCEPTED into unstable
On Mon, Mar 19, 2012 at 9:40 AM, Fabian Greffrath fab...@greffrath.com wrote: Am 19.03.2012 13:41, schrieb Andres Mejia: x264 set -O3 by default. Us setting -O2 would have overridden that. And with -g, x264 doesn't set -g by default (I presume because full optimizations are enabled). Even so, x264 doesn't provide dbg packages so there's no use in enabling -g anyway. I see, so you re-set CFLAGS to get rid of certain flags that are enabled in Debian by default but that the source's build system should better take care of in these cases. Is this right also for the other packages where you introduced this change? - Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers Yes. In particular, I checked if the package's build system sets -O3 instead of -O2. -- ~ Andres ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: x264_0.120.2171+git01f7a33-2_amd64.changes ACCEPTED into unstable
On 12-03-19 at 09:42am, Andres Mejia wrote: On Mon, Mar 19, 2012 at 9:40 AM, Fabian Greffrath fab...@greffrath.com wrote: Am 19.03.2012 13:41, schrieb Andres Mejia: x264 set -O3 by default. Us setting -O2 would have overridden that. And with -g, x264 doesn't set -g by default (I presume because full optimizations are enabled). Even so, x264 doesn't provide dbg packages so there's no use in enabling -g anyway. I see, so you re-set CFLAGS to get rid of certain flags that are enabled in Debian by default but that the source's build system should better take care of in these cases. Is this right also for the other packages where you introduced this change? Yes. In particular, I checked if the package's build system sets -O3 instead of -O2. Sounds like related to a previous misunderstanding I've had too: In the past I got the impression that -O2 was sort-of mandatory in Debian - but have since learned that unusual optimization is fine (as long as it is sensible!), what is mandated by Policy is the ability to turn off optimizations. - Jonas -- * Jonas Smedegaard - idealist Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
x264_0.120.2171+git01f7a33-2_amd64.changes ACCEPTED into unstable
Accepted: libx264-120_0.120.2171+git01f7a33-2_amd64.deb to main/x/x264/libx264-120_0.120.2171+git01f7a33-2_amd64.deb libx264-dev_0.120.2171+git01f7a33-2_amd64.deb to main/x/x264/libx264-dev_0.120.2171+git01f7a33-2_amd64.deb x264_0.120.2171+git01f7a33-2.debian.tar.gz to main/x/x264/x264_0.120.2171+git01f7a33-2.debian.tar.gz x264_0.120.2171+git01f7a33-2.dsc to main/x/x264/x264_0.120.2171+git01f7a33-2.dsc x264_0.120.2171+git01f7a33-2_amd64.deb to main/x/x264/x264_0.120.2171+git01f7a33-2_amd64.deb Changes: x264 (2:0.120.2171+git01f7a33-2) unstable; urgency=low . * Allow dev package to be multiarch installable. * Bump to Standards-Version 3.9.3. * Add hardened build flags excluding -O2 and -g. Override entries for your package: libx264-120_0.120.2171+git01f7a33-2_amd64.deb - optional libs libx264-dev_0.120.2171+git01f7a33-2_amd64.deb - optional libdevel x264_0.120.2171+git01f7a33-2.dsc - source graphics x264_0.120.2171+git01f7a33-2_amd64.deb - optional graphics Announcing to debian-devel-chan...@lists.debian.org Thank you for your contribution to Debian. ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
