[DRE-maint] Bug#895188: asciidoctor: E-mail addresses are rendered twice [manpage backend]

[Christoph Biedl]

Joseph Herlant wrote...

> To achieve your goal you would need to use the following:
> mailto:debian.a...@manchmal.in-ulm.de[Christoph Biedl]
(...)
> Is that acceptable?

Certainly.

Christoph, should actually be able to read documentation on his own


signature.asc
Description: PGP signature
___
Pkg-ruby-extras-maintainers mailing list
Pkg-ruby-extras-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-ruby-extras-maintainers

[DRE-maint] Bug#895188: asciidoctor: E-mail addresses are rendered twice [manpage backend]

[Christoph Biedl]

Package: asciidoctor
Version: 1.5.5-1
Severity: normal

Dear Maintainer,



ASCIIPATIENT(1)
===

NAME

asciipatient - E-mail addresses are rendered twice [manpage backend]


DESCRIPTION
---

Comparing the output of the *roff created by asciidoc and asciidoctor,
I found e-mail addresses are rendered twice for no appearent reason.


HOW TO REPEAT
-

Run this document through "asciidoctor --backend manpage", then execute
"MANWIDTH=80 man./asciipatient.1". Look at the way the address below is
rendered.


EXAMPLE
---

This bugreport was written for the Debian project by Christoph Biedl
 but may be used by others (although
there should be no need for this).


EXPECTED



This manpage was written for the Debian project by Christoph Biedl
 but may be used by others (although
there should be no need for this).



GOT
---


This manpage was written for the Debian project by Christoph Biedl
> but
may be used by others (although there should be no need for this).




-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.14.32 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: unable to detect

Versions of packages asciidoctor depends on:
ii  ruby  1:2.5.1

asciidoctor recommends no packages.

asciidoctor suggests no packages.

-- no debconf information



signature.asc
Description: PGP signature
___
Pkg-ruby-extras-maintainers mailing list
Pkg-ruby-extras-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-ruby-extras-maintainers

[DRE-maint] Bug#895187: asciidoctor: In the manpage backend, URLs are wrapped by default

[Christoph Biedl]

Package: asciidoctor
Version: 1.5.5-1
Severity: normal

Dear Maintainer,



ASCIIPATIENT(1)
===

NAME

asciipatient - In the manpage backend, URLs are wrapped by default


DESCRIPTION
---

Different from the output created by asciidoc, embedded URLs are
happily wrapped across line boundaries. Please change this as this
makes it quite hard to pick them from a terminal.


HOW TO REPEAT
-

Run this document through "asciidoctor --backend manpage", then execute
"MANWIDTH=80 man ./asciipatient.1".


EXAMPLE
---

For details about asciidoctor in Debian, see
https://tracker.debian.org/pkg/asciidoctor

EXPECTED



For details about asciidoctor in Debian, see




GOT
---


For details about asciidoctor in Debian, see 




-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.14.32 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: unable to detect

Versions of packages asciidoctor depends on:
ii  ruby  1:2.5.1

asciidoctor recommends no packages.

asciidoctor suggests no packages.

-- no debconf information



signature.asc
Description: PGP signature
___
Pkg-ruby-extras-maintainers mailing list
Pkg-ruby-extras-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-ruby-extras-maintainers

[DRE-maint] Bug#895186: asciidoctor: In the manpage backend, URLs change alignment

[Christoph Biedl]

Package: asciidoctor
Version: 1.5.5-1
Severity: normal

Dear Maintainer,



ASCIIPATIENT(1)
===

NAME

asciipatient - In the manpage backend, URLs change alignment


DESCRIPTION
---

The *roff output created by the "manpage" backend contains a ".ad l" at
the very beginning, resulting in the text alignment flushed left. It
seems however any inserted URL, expanded into a ".URL" statement, voids
this, formatting subsequent paragraphs as justified.


HOW TO REPEAT
-

Run this document through "asciidoctor --backend manpage", then execute
"MANWIDTH=80 man./asciipatient.1". Compare the two "Lorem ipsum"
paragraphs below. They should be formatted identically but are not.
Remove the URL as a demonstration this is the cause of the trouble.


EXAMPLE
---

Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod
tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim
veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea
commodo consequat.

https://www.debian.org/

Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod
tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim
veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea
commodo consequat.


-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.14.32 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: unable to detect

Versions of packages asciidoctor depends on:
ii  ruby  1:2.5.1

asciidoctor recommends no packages.

asciidoctor suggests no packages.

-- no debconf information



signature.asc
Description: PGP signature
___
Pkg-ruby-extras-maintainers mailing list
Pkg-ruby-extras-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-ruby-extras-maintainers

[DRE-maint] Bug#882308: http-parser 2.7 breaks ruby-em-http-request's tests

[Christoph Biedl]

forwarded 882308 https://github.com/igrigorik/em-http-request/issues/316
thanks

Jérémy Lal wrote...

> Control: reassign -1 ruby-em-http-request
> I took the liberty to reassign it to it. Feel free to reassign to
> whichever you see it would be better assigned.

Good question where to put it, you already figured this, see below.

> Please try this patch on ruby-em-http-request.
> 
> --- a/lib/em-http/http_connection.rb
> +++ b/lib/em-http/http_connection.rb
> @@ -131,7 +131,7 @@
>end
> 
>@p.on_message_complete = proc do
> -if !client.continue?
> +if client and !client.continue?
>c = @clients.shift
>c.state = :finished
>c.on_request_complete

This does the trick. I was pretty close back in December but not
close enough.

> Bug or feature ? nodejs is using http-parser and has a thorough test suite,
> so i suppose we're on the safe side fixing this package (but my experience
> tells me i'm 80% wrong when i suppose things like that).

It looks a lot like a behaviour change in http-parser. Then
ruby-em-http-request cannot deal with an another on_message callback,
and fails. But I'd like to see that in the sources. Good question who is
to blame for this, the documentation for on_message is rather terse.
Hardening ruby-em-http-request using your patch is certainly a good
thing to do.

To increase the noise, I've also opened an issue at
ruby-em-http-request's upstream.

Christoph


signature.asc
Description: PGP signature
___
Pkg-ruby-extras-maintainers mailing list
Pkg-ruby-extras-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-ruby-extras-maintainers

[DRE-maint] Bug#882308: http-parser 2.7 breaks ruby-em-http-request's tests

[Christoph Biedl]

Jérémy Lal wrote...

> Control: reassign -1 ruby-http-parser.rb

Thanks for taking care of that one. However ...

> it seems ruby-em-http-request uses a fork of http_parser.rb that has not
> been updated for a while. However, upstream seems to have fixed some
> issues with more recents http-parser developments:
> 
> https://github.com/tmm1/http_parser.rb/commit/7ef407e35247750e369746dec4ed4ed6c2265f73
> 
> So it'd rather be ruby-http-parser.rb debian package that needs a patch here.

The *ruby-http-parser.rb* package has been fixed in #881627 (yes, that
was me). The failing package however is *ruby-em-http-request*, and
while you state it's is fork of the first, I cannot quite see a lot of
common code.

Are you sure the assignment to ruby-http-parser.rb is correct?

Christoph, still trying to understand why the tests fail


signature.asc
Description: PGP signature
___
Pkg-ruby-extras-maintainers mailing list
Pkg-ruby-extras-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-ruby-extras-maintainers

[DRE-maint] Bug#881627: ruby-http-parser.rb: FTBFS with newer http-parser version

[Christoph Biedl]

tags 881627 patch
thanks

Christoph Biedl wrote...

> Would you mind disabling or relaxing the test on your side for
> the time being?

Patch attached, tested successfully.

As I noticed some packaging work has been done since the last release,
so I'm somewhat reluctant to do a NMU. But since this is the remaining
blocker for the http-parser transition, I'd like to do the finishing
step soon. I'll wait until the week-end but would of course appreciate a
faster resolution.

Regards,

Christoph
Subject: Disable folding header test
Author: Christoph Biedl 
Bug-Debian: https://bugs.debian.org/881627

--- a/spec/support/requests.json
+++ b/spec/support/requests.json
@@ -440,27 +440,6 @@
 "strict": true
   },
   {
-"name": "line folding in header value",
-"type": "HTTP_REQUEST",
-"raw": "GET / HTTP/1.1\r\nLine1:   abc\r\n\tdef\r\n ghi\r\n\t\tjkl\r\n  mno \r\n\t \tqrs\r\nLine2: \t line2\t\r\n\r\n",
-"should_keep_alive": true,
-"message_complete_on_eof": false,
-"http_major": 1,
-"http_minor": 1,
-"method": "GET",
-"query_string": "",
-"fragment": "",
-"request_path": "/",
-"request_url": "/",
-"num_headers": 2,
-"headers": {
-  "Line1": "abcdefghijklmno qrs",
-  "Line2": "line2\t"
-},
-"body": "",
-"strict": true
-  },
-  {
 "name": "host terminated by a query string",
 "type": "HTTP_REQUEST",
 "raw": "GET http://hypnotoad.org?hail=all HTTP/1.1\r\n\r\n",


signature.asc
Description: Digital signature
___
Pkg-ruby-extras-maintainers mailing list
Pkg-ruby-extras-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-ruby-extras-maintainers

[DRE-maint] Bug#881627: ruby-http-parser.rb: FTBFS with newer http-parser version

[Christoph Biedl]

Source: ruby-http-parser.rb
Version: 0.6.0-3+b3
Severity: serious
Tags: upstream

Dear Maintainer,

your package build-depends on http-parser, and a new version of that
one  has been around for a while. Even before eventually uploading last
night I already saw a problem in the test suite of your package.
However, due to a fault on my side, the new http-parser went to
unstable instead of experimental. So this increases the pressure for
your package, sorry about that.

With http-parser 2.7.1, one test fails:

  1) HTTP::Parser should parse request: line folding in header value
 Failure/Error: expect(@headers).to eq(test['headers'])

   expected: {"Line1"=>"abcdefghijklmno qrs", "Line2"=>"line2\t"}
got: {"Line1"=>"abc\tdef ghi\t\tjkl  mno \t \tqrs", 
"Line2"=>"line2\t"}

   (compared using ==)

   Diff:
   @@ -1,3 +1,3 @@
   -"Line1" => "abcdefghijklmno qrs",
   +"Line1" => "abc\tdef ghi\t\tjkl  mno \t \tqrs",
"Line2" => "line2\t",
 # ./spec/parser_spec.rb:347:in `block (4 levels) in '

If I understand correctly, this is taken from spec/support/requests.json
line 445 and 457f.

While doubtlessly http-parser changed the behaviour, I'm not sure yet
whether this wasn't rather about fixing bugs - bugs the test in
ruby-http-parser.rb relied upon.

However, HTTP header line folding is complicated and actually also
deprecated in RFC 7230. Reading that one and also the older description
in RFC 2616 I guess there a too many freedoms to expect a certain
result. Also it seems http-parser 2.7.1 does unfolding in a ...
surprising manner.

Now, quite frankly, my main interest is a sound solution. Otherwise,
I'm not keen on legal discussions, especially when it's about a
deprecated feature like this one. It's my job to sort these things out
with http-parser upstream but since I'm not sure how long this will
take: Would you mind disabling or relaxing the test on your side for
the time being? You might as well upgrade the test to the one in
http-parser/test.c¹ which is where obviously it was taken from in the
first place - but I'd expect this to change again soon.

Sorry for the mess, and kind regards,

Christoph

¹ https://github.com/nodejs/http-parser/blob/master/test.c (line 614)


signature.asc
Description: Digital signature
___
Pkg-ruby-extras-maintainers mailing list
Pkg-ruby-extras-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-ruby-extras-maintainers

[DRE-maint] Bug#861040: camping: diff for NMU version 2.1.580-1.1 (was: Bug#861040: camping: broken symlink: /usr/share/doc/camping/rdoc/fonts/Lato-RegularItalic.ttf -> ../../../../fonts/truetype/lato

[Christoph Biedl]

Control: tags 861040 + patch
Control: tags 861040 + pending

Chris Lamb wrote...

> Christoph Biedl wrote:
> 
> > So would just naming the link Lato-RegularItalic.ttf [..]
> > fix the issue?
> 
> Works for me :)  Updated patch attached.

Thanks for testing, here we go:

Dear maintainer,

I've prepared an NMU for camping (versioned as 2.1.580-1.1) and
uploaded it to DELAYED/05. Please feel free to tell me if I
should delay it longer.

Regards.
diff -Nru camping-2.1.580/debian/changelog camping-2.1.580/debian/changelog
--- camping-2.1.580/debian/changelog2014-10-17 21:07:08.0 +
+++ camping-2.1.580/debian/changelog2017-05-06 13:42:18.0 +
@@ -1,3 +1,10 @@
+camping (2.1.580-1.1) unstable; urgency=high
+
+  * Non-maintainer upload.
+  * Fix broken symlink, patch by Chris Lamb. Closes: #861040
+
+ -- Christoph Biedl   Sat, 06 May 2017 
13:42:18 +
+
 camping (2.1.580-1) unstable; urgency=medium
 
   [ Tim Potter ]
diff -Nru camping-2.1.580/debian/rules camping-2.1.580/debian/rules
--- camping-2.1.580/debian/rules2014-10-17 21:00:21.0 +
+++ camping-2.1.580/debian/rules2017-05-06 13:38:39.0 +
@@ -34,7 +34,7 @@
ln -s /usr/share/fonts/truetype/lato/Lato-Light.ttf 
debian/camping/usr/share/doc/camping/rdoc/fonts/
ln -s /usr/share/fonts/truetype/lato/Lato-LightItalic.ttf 
debian/camping/usr/share/doc/camping/rdoc/fonts/
ln -s /usr/share/fonts/truetype/lato/Lato-Regular.ttf 
debian/camping/usr/share/doc/camping/rdoc/fonts/
-   ln -s /usr/share/fonts/truetype/lato/Lato-RegularItalic.ttf 
debian/camping/usr/share/doc/camping/rdoc/fonts/
+   ln -s /usr/share/fonts/truetype/lato/Lato-Italic.ttf 
debian/camping/usr/share/doc/camping/rdoc/fonts/Lato-RegularItalic.ttf
 
 override_dh_auto_clean:
dh_auto_clean


signature.asc
Description: Digital signature
___
Pkg-ruby-extras-maintainers mailing list
Pkg-ruby-extras-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-ruby-extras-maintainers

[DRE-maint] Bug#861040: Bug#861040: camping: broken symlink: /usr/share/doc/camping/rdoc/fonts/Lato-RegularItalic.ttf -> ../../../../fonts/truetype/lato/Lato-RegularItalic.ttf

[Christoph Biedl]

Christian Hofstaedtler wrote...

> * Chris Lamb  [170424 11:45]:
> > > The fonts-lato ships /usr/share/fonts/truetype/lato/Lato-Italic.ttf
> > > instead.
> > 
> > Indeed. Patch attached.
> 
> > -   ln -s /usr/share/fonts/truetype/lato/Lato-RegularItalic.ttf 
> > debian/camping/usr/share/doc/camping/rdoc/fonts/
> > +   ln -s /usr/share/fonts/truetype/lato/Lato-Italic.ttf 
> > debian/camping/usr/share/doc/camping/rdoc/fonts/
> 
> Note that rdoc really expects a file named Lato-RegularItalic.ttf
> in that place.

So would just naming the link Lato-RegularItalic.ttf as in (untested)

| ln -s /usr/share/fonts/truetype/lato/Lato-Italic.ttf 
debian/camping/usr/share/doc/camping/rdoc/fonts/Lato-RegularItalic.ttf

fix the issue?

Christoph


signature.asc
Description: Digital signature
___
Pkg-ruby-extras-maintainers mailing list
Pkg-ruby-extras-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-ruby-extras-maintainers