Processed: Re: Bug#995006: init-system-helpers: deb-systemd-helper does not call daemon-reload despite unit files were changed

[Debian Bug Tracking System]

Processing control commands:

> retitle -1 dh_installsystemd should call daemon-reload in postinst if unit 
> files changed
Bug #995006 [init-system-helpers] init-system-helpers: deb-systemd-helper does 
not call daemon-reload despite unit files were changed
Changed Bug title to 'dh_installsystemd should call daemon-reload in postinst 
if unit files changed' from 'init-system-helpers: deb-systemd-helper does not 
call daemon-reload despite unit files were changed'.
> reassign -1 debhelper 13.5.1
Bug #995006 [init-system-helpers] dh_installsystemd should call daemon-reload 
in postinst if unit files changed
Bug reassigned from package 'init-system-helpers' to 'debhelper'.
No longer marked as found in versions init-system-helpers/1.60.
Ignoring request to alter fixed versions of bug #995006 to the same values 
previously set
Bug #995006 [debhelper] dh_installsystemd should call daemon-reload in postinst 
if unit files changed
Marked as found in versions debhelper/13.5.1.

-- 
995006: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=995006
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#995006: init-system-helpers: deb-systemd-helper does not call daemon-reload despite unit files were changed

[Vasyl Gello]

Control: retitle -1 dh_installsystemd should call daemon-reload in postinst if 
unit files changed
Control: reassign -1 debhelper 13.5.1

Oops, forgot to add Control word…  :(
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#995006: init-system-helpers: deb-systemd-helper does not call daemon-reload despite unit files were changed

[Vasyl Gello]

retitle -1 dh_installsystemd should call daemon-reload in postinst if unit 
files changed
reassign -1 debhelper 13.5.1

>No, my point is that i-s-h is not called as part of the upgrade process, since 
>you explicititly asked not to. So i-s-h can not call daemon-reload.
>Whether dh_installsystemd should generate a blank "daemon-reload" in this case 
>is another matter.

OK, so I am re-assigning the bug to debhelper and temporary add the 
daemon-reload step into xpra postinst.

Thanks for the tip on i-s-h!
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#995006: init-system-helpers: deb-systemd-helper does not call daemon-reload despite unit files were changed

[Michael Biebl]

Am 24.09.2021 um 21:21 schrieb Vasyl Gello:

Hi Michael,

 >I think the relevant bits are
 >
 > dh_installsystemd -v --no-enable --no-start
 >
 >which means,iirc, no explicit maintainer scripts code is generated to 
reload systemd as you asked it to neither start nor enable the service.
 >Since i-s-h is not really involved at this point, I assume this issue 
is misfiled.


So if we don't want to enable and/or start service in postinst, proper 
solution is to add wrapped block to postinst with proper comment 
referencing this bug?


No, my point is that i-s-h is not called as part of the upgrade process, 
since you explicititly asked not to. So i-s-h can not call daemon-reload.
Whether dh_installsystemd should generate a blank "daemon-reload" in 
this case is another matter.





OpenPGP_signature
Description: OpenPGP digital signature

Bug#995006: init-system-helpers: deb-systemd-helper does not call daemon-reload despite unit files were changed

[Vasyl Gello]

Hi Michael,

>I think the relevant bits are
>
>   dh_installsystemd -v --no-enable --no-start
>
>which means,iirc, no explicit maintainer scripts code is generated to reload 
>systemd as you asked it to neither start nor enable the service.
>Since i-s-h is not really involved at this point, I assume this issue is 
>misfiled.

So if we don't want to enable and/or start service in postinst, proper solution 
is to add wrapped block to postinst with proper comment referencing this bug?
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Processed: Re: Bug#995006: init-system-helpers: deb-systemd-helper does not call daemon-reload despite unit files were changed

[Debian Bug Tracking System]

Processing control commands:

> severity -1 normal
Bug #995006 [init-system-helpers] init-system-helpers: deb-systemd-helper does 
not call daemon-reload despite unit files were changed
Severity set to 'normal' from 'important'

-- 
995006: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=995006
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#995006: init-system-helpers: deb-systemd-helper does not call daemon-reload despite unit files were changed

[Michael Biebl]

Control: severity -1 normal

Am 24.09.2021 um 20:50 schrieb Vasyl Gello:

Hi Michael!

The package I encountered an issue is trunk version of Xpra: 
https://salsa.debian.org/basilgello/xpra/-/tree/debian/4.x 



I have uploaded the artifacts to FEX, they will be stored for 7 days 
there: https://fex.net/s/afe 


I think the relevant bits are

dh_installsystemd -v --no-enable --no-start

which means,iirc, no explicit maintainer scripts code is generated to 
reload systemd as you asked it to neither start nor enable the service.
Since i-s-h is not really involved at this point, I assume this issue is 
misfiled.







OpenPGP_signature
Description: OpenPGP digital signature

Bug#995006: init-system-helpers: deb-systemd-helper does not call daemon-reload despite unit files were changed

[Vasyl Gello]

Hi Michael!

The package I encountered an issue is trunk version of Xpra: 
https://salsa.debian.org/basilgello/xpra/-/tree/debian/4.x

I have uploaded the artifacts to FEX, they will be stored for 7 days there: 
https://fex.net/s/afe

Please let me know if you need more information.
-- 
Vasyl Gello
==
Certified SolidWorks Expert

Mob.:+380 (98) 465 66 77

E-Mail: vasek.ge...@gmail.com

Skype: vasek.gello
==
호랑이는 죽어서 가죽을 남기고 사람은 죽어서 이름을 남긴다

Bug#995006: init-system-helpers: deb-systemd-helper does not call daemon-reload despite unit files were changed

[Michael Biebl]

Am 24.09.2021 um 18:58 schrieb Michael Biebl:


Please provide a minimal package/.dsc which shows the problem.


I'm especially interested in debian/rules (how you call 
dh_installsystemd), the unit files and the generated maintainer scripts 
files.

Bug#995006: init-system-helpers: deb-systemd-helper does not call daemon-reload despite unit files were changed

[Michael Biebl]

Am 24.09.2021 um 18:22 schrieb Vasyl Gello:

Package: init-system-helpers
Version: 1.60
Severity: important
X-Debbugs-Cc: mat...@debian.org, mbi...@debian.org

Dear colleagues,

I noticed that systemd keeps older versions of unit files even after
I explicitly rebuilt the package with new contents of unitfiles.

I decided to track down the issue and found that '$changed_sth' is
set to 1 only when **links** to systemd units are somehow updated,
i.e:

 - make_systemd_links
 - remove_links
 - mask_service
 - unmask_service

Furthermore, 'dh_installsystemd' does place 'systemctl daemon-reload'
in postrm script, but relies on conditional invocation of the same
inside 'deb-systemd-helper' for postinst one.

To reproduce, you need a package installing systemd units.
First you install the package version with one contents of systemd unit,
then install another version with changed content of the same
systemd unit, and typing `systemctl status service` shows you old
configuration of service.


Please provide a minimal package/.dsc which shows the problem.

Thanks

Bug#995006: init-system-helpers: deb-systemd-helper does not call daemon-reload despite unit files were changed

[Vasyl Gello]

Package: init-system-helpers
Version: 1.60
Severity: important
X-Debbugs-Cc: mat...@debian.org, mbi...@debian.org

Dear colleagues,

I noticed that systemd keeps older versions of unit files even after
I explicitly rebuilt the package with new contents of unitfiles.

I decided to track down the issue and found that '$changed_sth' is
set to 1 only when **links** to systemd units are somehow updated,
i.e:

- make_systemd_links
- remove_links
- mask_service
- unmask_service

Furthermore, 'dh_installsystemd' does place 'systemctl daemon-reload'
in postrm script, but relies on conditional invocation of the same 
inside 'deb-systemd-helper' for postinst one.

To reproduce, you need a package installing systemd units.
First you install the package version with one contents of systemd unit,
then install another version with changed content of the same
systemd unit, and typing `systemctl status service` shows you old
configuration of service.

Cheers,
Vasyl   

-- System Information:
Debian Release: bookworm/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'buildd-unstable'), (500, 
'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 5.10.0-8-amd64 (SMP w/6 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=C, LC_CTYPE=C (charmap=UTF-8) (ignored: LC_ALL set to 
en_US.UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: unable to detect

Versions of packages init-system-helpers depends on:
ii  perl-base  5.32.1-5

init-system-helpers recommends no packages.

init-system-helpers suggests no packages.

Versions of packages init-system-helpers is related to:
pn  insserv  

-- no debconf information