Re: Review Request: new meter theming approach

[Petri Damstén]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/239/#review233
---


Looks good.


/trunk/KDE/kdebase/workspace/libs/plasma/widgets/meter.cpp


Can we do thermometer like meters (not tiled) with the new svg format (And 
is old svg format deprecated or just alternative way)?.



/trunk/KDE/kdebase/workspace/libs/plasma/widgets/meter.cpp


* Fixed tile width/height ratio?



- Petri


On 2008-10-23 14:24:23, Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/239/
> ---
> 
> (Updated 2008-10-23 14:24:23)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> the old theming for Plasma::Meter deformed the bar way too much when it was 
> resized too wide
> this uses panelsvg and tiling to do the image, and there is the new theme..
> it should be retrocompatible with old themes, still falls back at the old 
> elements
> 
> it does have a problem, when the number of tiles is not integer  it rounds to 
> the lower integer and mover the progressbar pattern at the centr, so there 
> are little margins at both sides.
> maybe not reeally pretty but still better than the deformed old one i think
> 
> 
> Diffs
> -
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/widgets/meter.cpp
>   
> /trunk/KDE/kdebase/workspace/plasma/desktoptheme/widgets/bar_meter_horizontal.svgz
>   
> /trunk/KDE/kdebase/workspace/plasma/desktoptheme/widgets/bar_meter_vertical.svgz
> 
> Diff: http://reviewboard.vidsolbach.de/r/239/diff
> 
> 
> Testing
> ---
> 
> 
> Screenshots
> ---
> 
> 
>   http://reviewboard.vidsolbach.de/r/239/s/84/
> 
> 
> Thanks,
> 
> Marco
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Correctly position panel toolbox when moving and resizing panel

[Beat Wolf]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/240/
---

Review request for Plasma.


Summary
---

How to reproduce the bug:
move the panel on the left size and resize it to a big size
move the panel pack to the bottom

you will see that the toolbox is not on the right place, it thinks that the 
panel is higher than it actually is.

Sollution:
place the toolbox after all the size contraint stuff is done.


Diffs
-

  trunk/KDE/kdebase/workspace/libs/plasma/containment.cpp

Diff: http://reviewboard.vidsolbach.de/r/240/diff


Testing
---

Every place where cashew is, the alignement has been checked.


Screenshots
---

wrongly positioned toolbox
  http://reviewboard.vidsolbach.de/r/240/s/85/


Thanks,

Beat

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: plasma apps and screen information

[Aaron J. Seigo]

On Thursday 23 October 2008, Guillaume Pothier wrote:
> 2008/10/23 Aaron J. Seigo <[EMAIL PROTECTED]>:
> > hm... so viewport is a bad name. i completely forgot that we'd need that
> > method in a scroll area subclass (View) ... well, let's leave it at
> > screen then, and just allow the Corona to say what a "screen" means.
>
> Argh! Ok, the patch will be much smaller then ;-)
> One of the things I'll do is replace uses of QDesktopWidget by Corona
> calls where possible, is that ok?

should work ..

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [PROBLEM] New systray notifications and kwin

[Chani]

> > Isn't one of the NET flag usable to avoid the dialog getting focus?
>
> probably.. i wonder if the ComboBox type would work better... would have 
to
> experiment..
>
> > Hmm, I'm starting to doubt if it wasn't Qt::Popup before, instead of
> > Qt::Tooltip.
>
> probably was Qt::Popup, yes...

what I find interesting is that they used to have 
Qt::X11BypassWindowManagerHint set (not directly, probably as a side-
effect of Qt::Popup) but now they don't. if they had that flag again they 
might magicallly go back to working on the screensaver.

however, it'd be nicer if I could find a less... fragile... way to tell the 
difference between popups and config dialogs. (getting a bit OT here) my 
problem is that I have to pass input directly to config dialogs for them to 
work, but I MUST NOT try to do that to popup dialogs or all input gets 
dropped on the floor somewhere. and since the function that creates the 
config dialogs is virtual, I don't really know how to tell the difference 
between these things other than my old hack in 
shells/screensaver/plasmaapp.cpp.

if anyone has a solution to this I'd love to hear it :) I don't really 
understand the x11 stuff as well as I'd like.

-- 
This message brought to you by eevil bananas and the number 3.
www.chani3.com
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: plasma apps and screen information

[Guillaume Pothier]

2008/10/23 Aaron J. Seigo <[EMAIL PROTECTED]>:
> hm... so viewport is a bad name. i completely forgot that we'd need that
> method in a scroll area subclass (View) ... well, let's leave it at screen
> then, and just allow the Corona to say what a "screen" means.

Argh! Ok, the patch will be much smaller then ;-)
One of the things I'll do is replace uses of QDesktopWidget by Corona
calls where possible, is that ok?
g

>
> --
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Qt Software
>
>
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: plasma apps and screen information

[Aaron J. Seigo]

On Thursday 23 October 2008, Guillaume Pothier wrote:
> 2008/10/23 Aaron J. Seigo <[EMAIL PROTECTED]>:
> > On Wednesday 22 October 2008, Guillaume Pothier wrote:
> >> Just tell me if you want me to go ahead.
> >
> > please do =)
>
> It ended up a much bigger task than I thought... adding the methods to
> corona and making use of them was rather simple, but I also changed
> the naming from "screen" to "viewport" in Containment, View, etc...
> lots of renaming. And when I think I'm done, I realize that View
> extends QAbstractScrollArea through QGraphicsView, and that class has
> a viewport() method that returns a QWidget*... It seems the overloaded
> method is still accessible by explicitly qualifying it
> ("QGraphicsView::viewport()"), but is it ok to overload that method?

hm... so viewport is a bad name. i completely forgot that we'd need that 
method in a scroll area subclass (View) ... well, let's leave it at screen 
then, and just allow the Corona to say what a "screen" means.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: plasma apps and screen information

[Guillaume Pothier]

2008/10/23 Aaron J. Seigo <[EMAIL PROTECTED]>:
> On Wednesday 22 October 2008, Guillaume Pothier wrote:
>> Just tell me if you want me to go ahead.
>
> please do =)

It ended up a much bigger task than I thought... adding the methods to
corona and making use of them was rather simple, but I also changed
the naming from "screen" to "viewport" in Containment, View, etc...
lots of renaming. And when I think I'm done, I realize that View
extends QAbstractScrollArea through QGraphicsView, and that class has
a viewport() method that returns a QWidget*... It seems the overloaded
method is still accessible by explicitly qualifying it
("QGraphicsView::viewport()"), but is it ok to overload that method?
g
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: new meter theming approach

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/239/
---

Review request for Plasma.


Summary
---

the old theming for Plasma::Meter deformed the bar way too much when it was 
resized too wide
this uses panelsvg and tiling to do the image, and there is the new theme..
it should be retrocompatible with old themes, still falls back at the old 
elements

it does have a problem, when the number of tiles is not integer  it rounds to 
the lower integer and mover the progressbar pattern at the centr, so there are 
little margins at both sides.
maybe not reeally pretty but still better than the deformed old one i think


Diffs
-

  /trunk/KDE/kdebase/workspace/libs/plasma/widgets/meter.cpp
  
/trunk/KDE/kdebase/workspace/plasma/desktoptheme/widgets/bar_meter_horizontal.svgz
  
/trunk/KDE/kdebase/workspace/plasma/desktoptheme/widgets/bar_meter_vertical.svgz

Diff: http://reviewboard.vidsolbach.de/r/239/diff


Testing
---


Screenshots
---


  http://reviewboard.vidsolbach.de/r/239/s/84/


Thanks,

Marco

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

RE: Problems with the new tasks applet

[Christian Mollekopf]

> From: [EMAIL PROTECTED]
> To: plasma-devel@kde.org
> Subject: Re: Problems with the new tasks applet
> Date: Thu, 23 Oct 2008 13:06:14 +0300
> 
> On Thursday 23 October 2008 12:21:37 christian mollekopf wrote:
> > Would be cool of course if you could fix it, but theres a working version
> > in trunk now. It recreates the layout everytime as you suggested.
> > Its ugly but at least it works.
> > I 've tried loads of stuff to get around this but it never worked.
> 
> I have max rows = 1 and I still get two rows occasionally like this:
> http://kotisivu.lumonetti.fi/damu0/images/two_rows.jpg
> That happened when I had kontact on screen 2 and I started konsole to that 
> screen. It usually (only?) happens when starting a program.

Yes it was a problem that applied only to startup tasks. 
Should be fixed now.

Regards
> 
> Petri
-- 
Pt! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: 
http://www.gmx.net/de/go/multimessenger
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Qt 4.5.0 tp1 and Plasma

[Tim Beaulen]

2008/10/23 Aaron J. Seigo <[EMAIL PROTECTED]>

> On Thursday 23 October 2008, Riccardo Iaconelli wrote:
> > * No applet handle on the desktop. (that doesn't need much description.
> ;-)
> > ). You put your mouse on it... and simply nothing happens.
>
> that's disconcerting. could you pop some debug output into
> Containment::sceneEventFilter and see what's going on there? e.g. does it
> get
> to the point where it creates the AppletHandle at all?
>
> (i'm assuming this is broken without compositing turned on as well?)
>
>

See https://bugs.kde.org/show_bug.cgi?id=164575

I forgot to report it to Trolltech though :-(
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Qt 4.5.0 tp1 and Plasma

[Riccardo Iaconelli]

Oh, yet another thing (this might be for everyone because of the new systray 
though)...
If I move stuff on the panel (e.g. by simply locking/unlocking the widgets the 
widgets) the systray icons become more fun (screenshot).
A full screen refresh (e.g. switching to tty1 and back) fixes it. This doesn't 
depend on whether compositing is on or off.

Bye,
-Riccardo
-- 
GPG key:
3D0F6376
When encrypting, please encrypt also for this subkey:
9EBD7FE1
-
Pace Peace Paix Paz Frieden Pax Pokój Friður Fred Béke 和平
Hasiti Lapé Hetep Malu Mир Wolakota Santiphap Irini Peoch שלום
Shanti Vrede Baris Rój Mír Taika Rongo Sulh Mir Py'guapy 평화

<>___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: problem with pastebin applet

[Artur Souza(MoRpHeUz)]

On Thursday 23 October 2008 15:10:48 Riccardo Iaconelli wrote:
> Any clue?

Does it happen with Qt 4.4 ?

Cheers!

-- 
--
Artur Duque de Souza
OpenBossa Research Labs
INdT - Instituto Nokia de Tecnologia
--
Blog: http://labs.morpheuz.eng.br/blog/
PGP: 0xDBEEAAC3 @ wwwkeys.pgp.net
--
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Option to use all rows in taskbar

[Beat Wolf]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/238/
---

Review request for Plasma.


Summary
---

Adds a configuration option which lets you use all aviable rows in the taskbar


Diffs
-

  trunk/KDE/kdebase/workspace/plasma/applets/tasks/layoutwidget.h
  trunk/KDE/kdebase/workspace/plasma/applets/tasks/layoutwidget.cpp
  trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.h
  trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.cpp
  trunk/KDE/kdebase/workspace/plasma/applets/tasks/tasks.cpp
  trunk/KDE/kdebase/workspace/plasma/applets/tasks/tasksConfig.ui

Diff: http://reviewboard.vidsolbach.de/r/238/diff


Testing
---

The usual, tried in different panel positions, different amount of rows/tasks


Thanks,

Beat

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Qt 4.5.0 tp1 and Plasma

[Aaron J. Seigo]

On Thursday 23 October 2008, Riccardo Iaconelli wrote:
> Hello,
> I installed Qt 4.5.0 yesterday, here there are some issues I already found
> out.
> So, here we have a list (without marble...)
>
> * Panel painting is...weird. (see screenshot) The borders are drawn, the
> space between applets is, under... it's not. The applet themselves can
> kinda paint themselves, although some similar issue appears in the painting
> of the tasks applet (of kdebase). Look at the MSN kopete window beginning
> for 'nuno' (fourth from left), which is requesting attention, they seem to
> paint but only if there's no other item on top of it, or something like
> that...
> That's with compositing, without, everything works.

sounds like a !plasma issue; if it works without compositing, then it's 
painting correctly. 

what may have changed are the painting paths within QGraphicsView which may be 
exposing fun new bugs in drivers. what graphics driver are you using?

> * No applet handle on the desktop. (that doesn't need much description. ;-)
> ). You put your mouse on it... and simply nothing happens.

that's disconcerting. could you pop some debug output into 
Containment::sceneEventFilter and see what's going on there? e.g. does it get 
to the point where it creates the AppletHandle at all? 

(i'm assuming this is broken without compositing turned on as well?)

> * Frames are a bit fucked up, with most (all?) themes... I think is the
> same problem as #1. Sshot #2 with oxygen.

including "it works if i'm not using compositing"?

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

problem with pastebin applet

[Riccardo Iaconelli]

hello,
it might be a combination of yesterday's plasma and Qt 4.5, but...
when trying to add the pastebin applet to the desktop, via a double click 
(dragging showed the "forbidden" cursor), plasma "freezes" (the gui thread 
seems to continue running, but maybe it's just compositing. kwin offers me to 
kill the window) with this bt:

(gdb) bt
#0  0xb399b08c in QRectF::intersects () from 
/usr/lib/kde4/plasma_containment_desktop.so
#1  0xb399dc92 in ItemSpace::itemInRegionEndingLastVert () from 
/usr/lib/kde4/plasma_containment_desktop.so
#2  0xb399e2d3 in ItemSpace::positionVertically () from 
/usr/lib/kde4/plasma_containment_desktop.so
#3  0xb39a2f7a in DesktopLayout::addItem () from 
/usr/lib/kde4/plasma_containment_desktop.so
#4  0xb399ca86 in DefaultDesktop::onAppletAdded () from 
/usr/lib/kde4/plasma_containment_desktop.so
#5  0xb399cbc6 in DefaultDesktop::qt_metacall () from 
/usr/lib/kde4/plasma_containment_desktop.so
#6  0xb66e67d2 in QMetaObject::activate () from /usr/lib/libQtCore.so.4
#7  0xb66e6d72 in QMetaObject::activate () from /usr/lib/libQtCore.so.4
#8  0xb7f46f69 in Plasma::Containment::appletAdded () from 
/usr/lib/libplasma.so.3
#9  0xb7f4e20b in Plasma::Containment::addApplet () from 
/usr/lib/libplasma.so.3
#10 0xb7f4e565 in Plasma::ContainmentPrivate::addApplet () from 
/usr/lib/libplasma.so.3
#11 0xb7f4e779 in Plasma::Containment::addApplet () from 
/usr/lib/libplasma.so.3
#12 0xb8090e4c in Plasma::AppletBrowserWidget::addApplet () from 
/usr/lib/libkdeinit4_plasma.so
#13 0xb8095903 in Plasma::AppletBrowserWidget::qt_metacall () from 
/usr/lib/libkdeinit4_plasma.so
#14 0xb66e67d2 in QMetaObject::activate () from /usr/lib/libQtCore.so.4
#15 0xb66e6d72 in QMetaObject::activate () from /usr/lib/libQtCore.so.4
#16 0xb8096ba3 in KCategorizedItemsView::doubleClicked () from 
/usr/lib/libkdeinit4_plasma.so
#17 0xb80981da in KCategorizedItemsView::qt_metacall () from 
/usr/lib/libkdeinit4_plasma.so
#18 0xb66e67d2 in QMetaObject::activate () from /usr/lib/libQtCore.so.4
#19 0xb66e6d72 in QMetaObject::activate () from /usr/lib/libQtCore.so.4
#20 0xb6316083 in QAbstractItemView::doubleClicked () from 
/usr/lib/libQtGui.so.4
#21 0xb635f80d in QTreeView::mouseDoubleClickEvent () from 
/usr/lib/libQtGui.so.4
#22 0xb5e8b8e9 in QWidget::event () from /usr/lib/libQtGui.so.4
#23 0xb61f4033 in QFrame::event () from /usr/lib/libQtGui.so.4
#24 0xb62849ff in QAbstractScrollArea::viewportEvent () from 
/usr/lib/libQtGui.so.4
#25 0xb6323d7f in QAbstractItemView::viewportEvent () from 
/usr/lib/libQtGui.so.4
#26 0xb6359cea in QTreeView::viewportEvent () from /usr/lib/libQtGui.so.4
#27 0xb6286e65 in ?? () from /usr/lib/libQtGui.so.4
#28 0x0964aaa0 in ?? ()
#29 0xbfad443c in ?? ()
#30 0xbfad3f78 in ?? ()
#31 0xb66d351a in QCoreApplicationPrivate::sendThroughObjectEventFilters () 
from /usr/lib/libQtCore.so.4
Backtrace stopped: frame did not save the PC

Any clue?
-Riccardo
-- 
GPG key:
3D0F6376
When encrypting, please encrypt also for this subkey:
9EBD7FE1
-
Pace Peace Paix Paz Frieden Pax Pokój Friður Fred Béke 和平
Hasiti Lapé Hetep Malu Mир Wolakota Santiphap Irini Peoch שלום
Shanti Vrede Baris Rój Mír Taika Rongo Sulh Mir Py'guapy 평화

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: bad panel rendering on NetBSD

[Mark Kirby]

On 22 Oct 2008, at 21:04, Aaron J. Seigo wrote:

> On Wednesday 22 October 2008, Mark Kirby wrote:
>> http://www.coris.org.uk/mrk/plasma_bad.png
>
> thanks for the report + screenshot.

Not a problem :)
>>
>
> tuesday was probably a different systray container =) the new one  
> went in early
> tuesday morning-ish UTC iirc? anyways .. what version of Qt are you  
> using?

Qt is 4.4.0 from pkgsrc.
>
>
>> and the shadow for the window names is
>> drawn through the text.
>
> known issue; the new tasks wiget is getting the layouting kinks  
> worked out of
> it (there's another thread on this list right now about these issues  
> actually)
>
>> Another niggle is if i open kickoff and type something in the text  
>> box
>> plasma will freeze and i have to kill X.
>
> does x freeze, or just plasma? (you can easily tell by pressing Alt 
> +F2 and
> trying to get krunner to show up) ... if it's an X freeze, that's an  
> X driver
> bug. if it's plasma, i'd love to see a backtrace so we can track it  
> down.

Pressing Alt+F2 just changes my cursor to a directional cursor (4  
little arrows) and all i can do is move stuff around, can't type  
anything. Can't seem to get out of this mode.

It's plasma, i can still interact with konsole when kickoff locks up.  
Also when it freezes kickoff loses focus, that is the cursor always  
goes behind. If left awhile eventually key presses are registered and  
it brings up search results.

hmm maybe still an X problem.

ok i just tried logging in from GDM to a session with only an Xterm.  
On starting plasma up everything works fine, in fact the whole KDE  
experience is a lot better this way.

Very odd.

Let me know what else i can do. My build hasn't got debug stuff  
compiled in so would take a while to set that up.

Thanks

Mark
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: bad panel rendering on NetBSD

[Mark Kirby]

On 23 Oct 2008, at 01:56, Jason Stubbs wrote:
>
> It could have something to do with it, but I hope not. ;)
> The screenshot reminds me of https://bugs.kde.org/show_bug.cgi?id=170283 
> .

I don't have MigrationHeuristic in my xorg.conf.

Mark
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [PROBLEM] New systray notifications and kwin

[Rob Scheepmaker]

On Wednesday 22 October 2008 15:27:18 Dmitry Suzdalev wrote:
> dimsuz is touch-typing with amazing speed in his kmail window. at the same
> time he often alt-tabs to kopete to chat with friends, and also types much
> in konversation in #plasma channel :)
> At the same time a lot of notifications arrive, and guess what  - each of
> them steals focus from dimsuz's current input widget! Because each of them
> has a default window role.
> What do you think dimsuz thinks on each notification appearance? Yeah, he
> thinks:
>
> "#%#!!!?#?!!!"
>
> And then  clicks back on the widget he is typing into :)

I've tried to investigate this problem, and encountered the following on my 
recent trunk/ build: focus is not stolen when a notification pops up, and I 
can continue typing, however, while the NET:SkipTaskbar | NET:SkipPager flags 
are set on the window, and indeed the window is hidden in the taskbar and 
pager applet, the window does appear in the alt-tab switcher, which is 
undesirable. But according to http://api.kde.org/4.x-api/kdelibs-
apidocs/kdeui/html/classNET.html, this shouldn't be the case:

"To set the state of a window, you'll typically do something like: 
KWindowSystem::setState( winId(), NET::SkipTaskbar | NET::SkipPager );

 for example to not show the window on the taskbar and pager (alt-tab dialog). 
winId() is a function of QWidget()"

Is this maybe a bug in kwin?
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Some possible improvements for Lancelot

[Davide Bettio]

Hi,

I have a list of improvements for lancelot that I like to see for KDE 4.2.

1) I think that lancelot part should be hidden: allowing users to add lancelot 
part to the desktop doesn't seems a good idea.

2) I think that lancelot should use (like kickoff and other applets) 
Plasma::PopupApplet.

3) Rounded squares are nice (I'm talking about selection squares on the left).

4) Config UI needs to follow plasma HIG.

5) It shouldn't use its own scrollbar style: it should use plasma scrollbar 
style.

6) Resize needs to be fixed, lancelot doesn't behave correctly when it is 
resized.

Bye,
Davide Bettio.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Drag from panel and drop to desktop PATCH

[Alessandro Diaferia]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/237/
---

(Updated 2008-10-23 08:05:30.689090)


Review request for Plasma and Aaron Seigo.


Summary
---

This patch allows moving an applet from panel to desktop. Its state is really 
basic but i felt this feature missing. I talked about this patch together with 
notmart and we'd like to know the best way to draw the applet even out of the 
panel while dragging. Please test this little patch and let me know =)

UPDATE: i feel this patch works muuuch nicer.. Btw there are still some little 
issues.. hope you'll point me in the right way :D

UPDATE Oct 22 2008: Works as expected apart from really little glitches.. hope 
to commit to have more feedback :)

Sorry for the previous wrong diff...


Diffs
-

  trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelappletoverlay.cpp

Diff: http://reviewboard.vidsolbach.de/r/237/diff


Testing
---


Thanks,

Alessandro

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Drag from panel and drop to desktop PATCH

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/237/#review232
---


tried it extensively today, still some rough edges but i think it could go in, 
it improved a lot

- Marco


On 2008-10-23 08:05:30, Alessandro Diaferia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/237/
> ---
> 
> (Updated 2008-10-23 08:05:30)
> 
> 
> Review request for Plasma and Aaron Seigo.
> 
> 
> Summary
> ---
> 
> This patch allows moving an applet from panel to desktop. Its state is really 
> basic but i felt this feature missing. I talked about this patch together 
> with notmart and we'd like to know the best way to draw the applet even out 
> of the panel while dragging. Please test this little patch and let me know =)
> 
> UPDATE: i feel this patch works muuuch nicer.. Btw there are still some 
> little issues.. hope you'll point me in the right way :D
> 
> UPDATE Oct 22 2008: Works as expected apart from really little glitches.. 
> hope to commit to have more feedback :)
> 
> Sorry for the previous wrong diff...
> 
> 
> Diffs
> -
> 
>   trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelappletoverlay.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/237/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alessandro
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Drag from panel and drop to desktop PATCH

[Alessandro Diaferia]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/237/
---

(Updated 2008-10-23 06:59:40.620972)


Review request for Plasma and Aaron Seigo.


Summary
---

This patch allows moving an applet from panel to desktop. Its state is really 
basic but i felt this feature missing. I talked about this patch together with 
notmart and we'd like to know the best way to draw the applet even out of the 
panel while dragging. Please test this little patch and let me know =)

UPDATE: i feel this patch works muuuch nicer.. Btw there are still some little 
issues.. hope you'll point me in the right way :D

UPDATE Oct 22 2008: Works as expected apart from really little glitches.. hope 
to commit to have more feedback :)


Diffs
-

  trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelappletoverlay.cpp

Diff: http://reviewboard.vidsolbach.de/r/237/diff


Testing
---


Thanks,

Alessandro

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

RE: Problems with the new tasks applet

[christian mollekopf]

> From: [EMAIL PROTECTED]> To: plasma-devel@kde.org> Subject: Re: Problems with 
> the new tasks applet> Date: Thu, 23 Oct 2008 13:06:14 +0300> > On Thursday 23 
> October 2008 12:21:37 christian mollekopf wrote:> > Would be cool of course 
> if you could fix it, but theres a working version> > in trunk now. It 
> recreates the layout everytime as you suggested.> > Its ugly but at least it 
> works.> > I 've tried loads of stuff to get around this but it never 
> worked.> > I have max rows = 1 and I still get two rows occasionally like 
> this:> http://kotisivu.lumonetti.fi/damu0/images/two_rows.jpg> That happened 
> when I had kontact on screen 2 and I started konsole to that > screen. It 
> usually (only?) happens when starting a program.
 
jep i can confirm the problem. i will look into it this evening.
The screen number and the row arent related at all,so this shouldn't matter.
> > Petri> 
_
Die neue Generation der Windows Live Services - jetzt downloaden!
http://get.live.com___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Problems with the new tasks applet

[Petri Damstén]

On Thursday 23 October 2008 12:21:37 christian mollekopf wrote:
> Would be cool of course if you could fix it, but theres a working version
> in trunk now. It recreates the layout everytime as you suggested.
> Its ugly but at least it works.
> I 've tried loads of stuff to get around this but it never worked.

I have max rows = 1 and I still get two rows occasionally like this:
http://kotisivu.lumonetti.fi/damu0/images/two_rows.jpg
That happened when I had kontact on screen 2 and I started konsole to that 
screen. It usually (only?) happens when starting a program.

Petri



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

RE: Problems with the new tasks applet

[christian mollekopf]

> From: [EMAIL PROTECTED]> To: plasma-devel@kde.org> Subject: Re: Problems with 
> the new tasks applet> Date: Thu, 23 Oct 2008 11:42:08 +0200> > On Thursday 23 
> October 2008, christian mollekopf wrote:> > > From: [EMAIL PROTECTED]> To: 
> plasma-devel@kde.org> Subject: Re: > Problems> > > with the new tasks applet> 
> Date: Thu, 23 Oct 2008 11:20:45 +0200> > On> > > Wednesday 22 October 2008, 
> Aaron J. Seigo wrote:> > On Wednesday 22> > > October 2008, Marco Martin 
> wrote:> > > rows to make room for that ghost> > > dead third row and seems 
> there is no way> > > to really reset it (and no,> > > there was absolutely no 
> updates to> > > graphicslayouts in qt4.5tp not a> > > single line changed :/ 
> ).> >> > ugh. this is really bad. and probably> > > means that whenever we 
> change row #,> > we'll have to delete and recreate> > > the layout. the baby 
> jesus weeps.> > update: replicating the scenario> > > with the very simple 
> test program attached > the problem doesn't appear.>> > > but if in the 
> taskbar i explicitly remove all the items from the layout> > > before > a 
> relayout the problem is still here, i.e the debug output says> > > it placed 
> only > items in the first row but items are resized as the rows> > > were 
> two> > so the situation is weirder and weirder, it doesn't seem a> > > bug of 
> the grid > layout but something at our end, this gives hope but> > > seems 
> tricky> i suspect has something to do with size hints and preferred> > > 
> sizes, will do > some more experiments later today.> hopefully the> > > 
> solution is way simpler than it seemed in the first place :D> >> > Would be 
> cool of course if you could fix it, but theres a working version> > in trunk 
> now. It recreates the layout everytime as you suggested.> > Its ugly but at 
> least it works.> > I 've tried loads of stuff to get around this but it never 
> worked.> > i see, good job, man :)
 
thanks =)
> in the way you did it should be quite easy to not destroy it anymore if a > 
> solution is found, so i'll keep searching :)> 
 
Yes, we will have to keep this workaround in mind until the solution is found,
so we keep it easy to switch back. 
Maybe we can fix it in qt-copy? (for 4.3 or someting at least)
 
> Cheers,> Marco Martin> > > Good luck =)> >> > > > Cheers,> Marco Martin>> >> 
> > > _> > 
> Werden Sie Mitglied der neuen Windows Live Messenger Familie!> > 
> http://get.live.com> > > ___> 
> Plasma-devel mailing list> Plasma-devel@kde.org> 
> https://mail.kde.org/mailman/listinfo/plasma-devel
_
Die neue Generation der Windows Live Services - jetzt downloaden!
http://get.live.com___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Problems with the new tasks applet

[Marco Martin]

On Thursday 23 October 2008, christian mollekopf wrote:
> > From: [EMAIL PROTECTED]> To: plasma-devel@kde.org> Subject: Re: 
Problems
> > with the new tasks applet> Date: Thu, 23 Oct 2008 11:20:45 +0200> > On
> > Wednesday 22 October 2008, Aaron J. Seigo wrote:> > On Wednesday 22
> > October 2008, Marco Martin wrote:> > > rows to make room for that ghost
> > dead third row and seems there is no way> > > to really reset it (and no,
> > there was absolutely no updates to> > > graphicslayouts in qt4.5tp not a
> > single line changed :/ ).> >> > ugh. this is really bad. and probably
> > means that whenever we change row #,> > we'll have to delete and recreate
> > the layout. the baby jesus weeps.> > update: replicating the scenario
> > with the very simple test program attached > the problem doesn't appear.>
> > but if in the taskbar i explicitly remove all the items from the layout
> > before > a relayout the problem is still here, i.e the debug output says
> > it placed only > items in the first row but items are resized as the rows
> > were two> > so the situation is weirder and weirder, it doesn't seem a
> > bug of the grid > layout but something at our end, this gives hope but
> > seems tricky> i suspect has something to do with size hints and preferred
> > sizes, will do > some more experiments later today.> hopefully the
> > solution is way simpler than it seemed in the first place :D
>
> Would be cool of course if you could fix it, but theres a working version
> in trunk now. It recreates the layout everytime as you suggested.
> Its ugly but at least it works.
> I 've tried loads of stuff to get around this but it never worked.

i see, good job, man :)
in the way  you did it should be quite easy to not destroy it anymore if a 
solution is found, so i'll keep searching :)

Cheers,
Marco Martin

> Good luck =)
>
> > > Cheers,> Marco Martin>
>
> 
_
> Werden Sie Mitglied der neuen Windows Live Messenger Familie!
> http://get.live.com


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

RE: Problems with the new tasks applet

[christian mollekopf]

> From: [EMAIL PROTECTED]> To: plasma-devel@kde.org> Subject: Re: Problems with 
> the new tasks applet> Date: Thu, 23 Oct 2008 11:20:45 +0200> > On Wednesday 
> 22 October 2008, Aaron J. Seigo wrote:> > On Wednesday 22 October 2008, Marco 
> Martin wrote:> > > rows to make room for that ghost dead third row and seems 
> there is no way> > > to really reset it (and no, there was absolutely no 
> updates to> > > graphicslayouts in qt4.5tp not a single line changed :/ ).> 
> >> > ugh. this is really bad. and probably means that whenever we change row 
> #,> > we'll have to delete and recreate the layout. the baby jesus weeps.> > 
> update: replicating the scenario with the very simple test program attached > 
> the problem doesn't appear.> but if in the taskbar i explicitly remove all 
> the items from the layout before > a relayout the problem is still here, i.e 
> the debug output says it placed only > items in the first row but items are 
> resized as the rows were two> > so the situation is weirder and weirder, it 
> doesn't seem a bug of the grid > layout but something at our end, this gives 
> hope but seems tricky> i suspect has something to do with size hints and 
> preferred sizes, will do > some more experiments later today.> hopefully the 
> solution is way simpler than it seemed in the first place :D
 
Would be cool of course if you could fix it, but theres a working version in 
trunk now.
It recreates the layout everytime as you suggested.
Its ugly but at least it works. 
I 've tried loads of stuff to get around this but it never worked.
 
Good luck =)
> > Cheers,> Marco Martin> 
_
Werden Sie Mitglied der neuen Windows Live Messenger Familie!
http://get.live.com___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Problems with the new tasks applet

[Marco Martin]

On Wednesday 22 October 2008, Aaron J. Seigo wrote:
> On Wednesday 22 October 2008, Marco Martin wrote:
> > rows to make room for that ghost dead third row and seems there is no way
> > to really reset it (and no, there was absolutely no updates to
> > graphicslayouts in qt4.5tp not a single line changed :/ ).
>
> ugh. this is really bad. and probably means that whenever we change row #,
> we'll have to delete and recreate the layout. the baby jesus weeps.

update: replicating the scenario with the very simple test program attached  
the problem doesn't appear.
but if in the taskbar i explicitly remove all the items from the layout before 
a relayout the problem is still here, i.e the debug output says it placed only 
items in the first row but items are resized as the rows were two

so the situation is weirder and weirder, it doesn't seem a bug of the grid 
layout but something at our end, this gives hope but seems tricky
i suspect has something to do with size hints and preferred sizes, will do 
some more experiments later today.
hopefully the solution is way simpler than it seemed in the first place :D

Cheers,
Marco Martin

#include 
#include 
#include 
#include 
#include 
#include 
#include 

class TestWidget : public QGraphicsWidget
{
public:
TestWidget(QGraphicsItem * parent = 0, Qt::WindowFlags wFlags = 0 );
~TestWidget();


void paint(QPainter *painter, const QStyleOptionGraphicsItem *option,
QWidget *widget);
QColor background;
};

TestWidget::TestWidget(QGraphicsItem * parent, Qt::WindowFlags wFlags)
 : QGraphicsWidget(parent, wFlags )
{
background = Qt::green;
}

TestWidget::~TestWidget()
{}


void TestWidget::paint(QPainter *painter, const QStyleOptionGraphicsItem *option,
  QWidget *widget)
{
painter->fillRect(option->rect, background);
}


int main(int argc, char **argv)
{
QApplication app(argc, argv);

QGraphicsScene scene;
TestWidget *outerWidget = new TestWidget(0,Qt::Window);
outerWidget->background = Qt::red;
outerWidget->resize(100,100);
QGraphicsGridLayout *lay = new QGraphicsGridLayout(outerWidget);
outerWidget->setWindowFrameMargins(10,10,10,10);

scene.addItem(outerWidget);


TestWidget *widget00 = new TestWidget(outerWidget);
TestWidget *widget01 = new TestWidget(outerWidget);
TestWidget *widget10 = new TestWidget(outerWidget);
TestWidget *widget11 = new TestWidget(outerWidget);

lay->addItem(widget00,0,0);
lay->addItem(widget01,0,1);
lay->addItem(widget10,1,0);
lay->addItem(widget11,1,1);

lay->removeAt(2);
lay->removeAt(2);


QGraphicsView view(&scene);
view.show();

return app.exec();
}
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel