Review Request: Folderview popups should inherit file preview settings
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2286/ --- Review request for Plasma and Fredrik Höglund. Summary --- Currently the folderview on-hover popups always previews (only) images no matter what the preview settings of the parent folderview applet is. I saw a 'TODO' comment in the code that says popups should inherit file preview settings from the parent, so I assumed this is the right / desired behavior and implemented it :) I think my approach is sensible, and it would also accommodate allowing the folderview and the popup to have different file preview settings if we ever need that in future. Still, this is my first time ever staring at folderview code, so if I'm doing something unspeakably wrong, or if there's a better way to do this, please let me know :) Diffs - /trunk/KDE/kdebase/apps/plasma/applets/folderview/folderview.cpp 1055216 /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 1055216 /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1055216 /trunk/KDE/kdebase/apps/plasma/applets/folderview/popupview.h 1055216 /trunk/KDE/kdebase/apps/plasma/applets/folderview/popupview.cpp 1055216 Diff: http://reviewboard.kde.org/r/2286/diff Testing --- Tested on trunk. Works AFAIK. Thanks, Yuen Hoe ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Folderview popups should inherit file preview settings
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2286/ --- (Updated 2009-11-28 09:55:39.107970) Review request for Plasma and Fredrik Höglund. Summary (updated) --- Currently the folderview on-hover popups always previews (only) images no matter what the preview settings of the parent folderview applet is. I saw a 'TODO' comment in the code that says popups should inherit file preview settings from the parent, so I assumed this is the right / desired behavior and implemented it :) I think my approach is sensible, and it would also accommodate allowing the folderview and the popup to have different file preview settings if we ever need that in future. Still, this is my first time ever staring at folderview code, so if I'm doing something unspeakably wrong, or if there's a better way to do this, please let me know :) (I know it's feature/string freeze now, but this is rectification of faulty behaviour - ie bugfix, so it can be accepted right? This itch happens to bother me somewhat :) Diffs - /trunk/KDE/kdebase/apps/plasma/applets/folderview/folderview.cpp 1055216 /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 1055216 /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1055216 /trunk/KDE/kdebase/apps/plasma/applets/folderview/popupview.h 1055216 /trunk/KDE/kdebase/apps/plasma/applets/folderview/popupview.cpp 1055216 Diff: http://reviewboard.kde.org/r/2286/diff Testing --- Tested on trunk. Works AFAIK. Thanks, Yuen Hoe ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fix Plasma CalendarTable widget for RTL
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2088/ --- (Updated 2009-11-29 00:56:27.688430) Review request for Plasma. Changes --- While trying to fix a bug in the behaviour of the original patch, I thought about this some more, and decided that rather than patch over the top I should really fix the problem at it's root, so here's a revised version that separates the date offset calculations from the screen drawing position. 1) There's far fewer places that need to check for RTL 2) The code is simpler and cleaner 3) This also solves the bug where the hover highlight usually doesn't disappear when moving the mouse off the calendar, and where borders got confused (well almost, moving off the right edge doesn't remove the hover at first, but if you resize the widget it does start working, very mysterious). 4) It gets rid of the localeDateNum() stuff by using the KCalendarSystem string methods (changes made in kdelibs for this). 5) More clean-ups and some krazy fixes. Summary --- The CalendarTable widget does not correctly display in RTL mode, the cells in the table go LTR instead. The numbers in the cells are controlled by code and not the widget layout, so we need to handle this the code. This patch fixes the day numbers, weekday names, and week numbers to go RTL, see screenshots for example. It doesn't move the Week Numbers column from the left to the right as this is part of the SVG, we would need to flip the SVG along it's vertical axis to do so and shuffle everything about. Is this possible or too much effort? Also rename a couple of variables for clarity seeing as I now understand what they do. Patch against trunk, I'll backport to 4.3 if all OK. Note we may want to rewrite some of the CalendarTable in 4.5 for a cleaner implementation. cc to Dotan to confirm this looks OK and to confirm it's not a problem if we can't move the Week Number column. This addresses bug 182976. https://bugs.kde.org/show_bug.cgi?id=182976 Diffs (updated) - trunk/KDE/kdebase/workspace/libs/plasmaclock/calendartable.cpp 1055882 Diff: http://reviewboard.kde.org/r/2088/diff Testing --- Tested using 'plasmoidviewer --reverse calendar' Screenshots --- Left to Right mode http://reviewboard.kde.org/r/2088/s/253/ Right to Left mode http://reviewboard.kde.org/r/2088/s/254/ Thanks, John ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Update on networkmanager plasmoid
On Tue, Nov 17, 2009 at 5:11 AM, Sebastian Kügler se...@kde.org wrote: Hey all, After hiding under the rock and hacking on networkmanager, I'd like to give a bit of a status update on the plasmoid, and move towards getting better artwork in. I wanted to try out the networkmanager plasmoid, but couldn't find it (I tried in extragear and playground, but couldn't guess). Where is it located? Thanks :) On Friday 06 November 2009 23:48:07 Nuno Pinheiro wrote: On Friday, 6 de November de 2009 19:20:54 Andreas Demmer wrote: Nuno Pinheiro: if i was doing it exclusively for air it would be something like this, with more contrast maybe Attached is a side-by-side comparison with an improved version with better contrast. If you like this, I will do the other states to. Thanks to your SVG template it was very easy to do! :-) Greets, Andreas excelent I really like them, too. Can I have them in SVN, in all sizes? :) http://vizzzion.org/tmp/nm-plasmoid-alpha-2.ogv In the video, you can see the networkmanager plasmoid (not knetworkmanager!) sitting in the panel's systray area. the popup shows networkinterfaces on the left, checkboxes for dis/enabling networking altogether and dis/enabling wireless. On the right, you have two tabs, the Connections tab shows the available connections: when the wireless network is plugged in (it's not in the video), it'll show an available connection and connect automatically. You can click on those connections, and it will pop up connection dialogs as needed. The plasmoid has become a rather thin UI for the whole networkmanager stack now. As you can see, I've changed a couple of things according to the results in this discussion. Indeed no overlay for connected, as you can see. I've not done the VPN overlay yet, but am planning to. (Which icon should be used for this?) = connecting ... = For the connecting state, I wanted to show the progress somehow. I experimented a bit with a progress bar, and now have a ring that completes itself while the interface is connecting. The different steps have distinct states, a bit like a clock, so you can tell when it's at 0900, it's waiting for a dhcp lease. After the connection succeeds, the ring becomes green and fades out after a couple of seconds. = painting = I've also changed the applet so that it will only use sizes predefined by KIconLoader (so we don't randomly scale, but can get pristine, pixel-perfect painting of the icon pixmaps -- as long as all sizes are there). I've ditched the SVG in favor of using KIcon, so we're not bound by Qt's lacking of SVG filters. = layout problem = the wireless networks list on the right hand side of the popupapplet actually sits inside a scrollwidget. I can't get the scrollbars to show, though, the layout just overflows. It would be nice if someone could have a look at this, I've been staring at it repeatedly and just can't see what I'm doing wrong there. You can see the problem in the screencast when a longer list of wireless networks overflows into the manage connections IconWidget. It's basically TabWidget holds two ActivatableListWidgets which are ScrollWidgets. I've updated the networkmanagement/applet/README.txt with a couple of TODO items, if you want to help out. In general, I feel that most things are falling into place now, it's developing nicely and that the UI concept works quite well as it's now. P.S.: if you wonder what the crappy LSD-style blending in the changing labels is, that's the radeon graphics driver :/ Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Shantanu Tushar(UTC +0530) http://www.shantanutushar.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
