Plasma Calendar showing Akonadi Events in SC 4.5

2010-07-07 Thread John Layt
I've been chatting to the kdepim guys about the bugs in the plasma calendar 
when showing pim events.  While I'm on track to fix those today, a more basic 
issue has appeared.

The plasma calendar uses Akonadi to obtain the calendar data.  Calendar data 
is being akonadi-fied for the first time in kdepim 4.5.  kdepim 4.5 has been 
delayed and will not ship with the rest of SC 4.5.  Hence most users will not 
even see the calendar events displayed as their data will not have been 
migrated and they do not have the compatibility layer enabled.

This becomes a comms issue.  If we announce the feature in the release plan 
then we will get bug reports for it not working and disappointed users.  We 
need to either not announce the feature at all, or make it very clear that 
this will only work when kdepim 4.5 is released which may be several months.

Cheers!

John.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


initial plasmoid size?

2010-07-07 Thread Thomas Fjellstrom
Now that I've got my plasmoid working somewhat decently, I've noticed that 
when its on the desktop, it doesn't want to size quite properly.

http://strangesoft.net/plasma-networkinfo/prototype2.png

What would cause that? It shows up fine in the panel as a popup (it is a 
popup applet)

-- 
Thomas Fjellstrom
tfjellst...@shaw.ca
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: initial plasmoid size?

2010-07-07 Thread Marco Martin
On Wed, Jul 7, 2010 at 1:44 PM, Thomas Fjellstrom tfjellst...@shaw.ca wrote:
 Now that I've got my plasmoid working somewhat decently, I've noticed that
 when its on the desktop, it doesn't want to size quite properly.

 http://strangesoft.net/plasma-networkinfo/prototype2.png

 What would cause that? It shows up fine in the panel as a popup (it is a
 popup applet)

do you set minimum/preferred/maxcimum sizes on -any- of the widgets?
and what are the size hints of that list widget?

Cheers,
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: initial plasmoid size?

2010-07-07 Thread Thomas Fjellstrom
On July 7, 2010, Marco Martin wrote:
 On Wed, Jul 7, 2010 at 1:44 PM, Thomas Fjellstrom tfjellst...@shaw.ca 
wrote:
  Now that I've got my plasmoid working somewhat decently, I've noticed
  that when its on the desktop, it doesn't want to size quite properly.
  
  http://strangesoft.net/plasma-networkinfo/prototype2.png
  
  What would cause that? It shows up fine in the panel as a popup (it is
  a popup applet)
 
 do you set minimum/preferred/maxcimum sizes on -any- of the widgets?
 and what are the size hints of that list widget?

I have a max height on the list widget (300px), and a sizeHint on each the 
items in the list.

 Cheers,
 Marco Martin
 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel


-- 
Thomas Fjellstrom
tfjellst...@shaw.ca
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: initial plasmoid size?

2010-07-07 Thread Marco Martin
On Wed, Jul 7, 2010 at 2:23 PM, Thomas Fjellstrom tfjellst...@shaw.ca wrote:
 On July 7, 2010, Marco Martin wrote:
 On Wed, Jul 7, 2010 at 1:44 PM, Thomas Fjellstrom tfjellst...@shaw.ca
 wrote:
  Now that I've got my plasmoid working somewhat decently, I've noticed
  that when its on the desktop, it doesn't want to size quite properly.
 
  http://strangesoft.net/plasma-networkinfo/prototype2.png
 
  What would cause that? It shows up fine in the panel as a popup (it is
  a popup applet)

 do you set minimum/preferred/maxcimum sizes on -any- of the widgets?
 and what are the size hints of that list widget?

 I have a max height on the list widget (300px), and a sizeHint on each the
 items in the list.

those 300px manual hint shouldn't be necessary, aanyways,

something is getting broken either a) minimumsize of the list -widget-
(not items)
b) broken minimum size of the whole applet (sure you don't ever set it?)

Cheers,
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: initial plasmoid size?

2010-07-07 Thread Thomas Fjellstrom
On July 7, 2010, Marco Martin wrote:
 On Wed, Jul 7, 2010 at 2:23 PM, Thomas Fjellstrom tfjellst...@shaw.ca 
wrote:
  On July 7, 2010, Marco Martin wrote:
  On Wed, Jul 7, 2010 at 1:44 PM, Thomas Fjellstrom
  tfjellst...@shaw.ca
  
  wrote:
   Now that I've got my plasmoid working somewhat decently, I've
   noticed that when its on the desktop, it doesn't want to size quite
   properly.
   
   http://strangesoft.net/plasma-networkinfo/prototype2.png
   
   What would cause that? It shows up fine in the panel as a popup (it
   is a popup applet)
  
  do you set minimum/preferred/maxcimum sizes on -any- of the widgets?
  and what are the size hints of that list widget?
  
  I have a max height on the list widget (300px), and a sizeHint on each
  the items in the list.
 
 those 300px manual hint shouldn't be necessary, aanyways,
 
 something is getting broken either a) minimumsize of the list -widget-
 (not items)
 b) broken minimum size of the whole applet (sure you don't ever set it?)

I haven't set a minimum size on anything. Just a maximum size on the list 
widget to keep it from hitting the top of the screen as a popup with my 
initial fake data.

I do have a lot of the sizePolicy's set to MinimumExpanding, could that have 
this effect?

 Cheers,
 Marco Martin
 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel


-- 
Thomas Fjellstrom
tfjellst...@shaw.ca
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: initial plasmoid size?

2010-07-07 Thread Marco Martin
On Wed, Jul 7, 2010 at 2:38 PM, Thomas Fjellstrom tfjellst...@shaw.ca wrote:
 On July 7, 2010, Marco Martin wrote:
 On Wed, Jul 7, 2010 at 2:23 PM, Thomas Fjellstrom tfjellst...@shaw.ca
 wrote:
  On July 7, 2010, Marco Martin wrote:
  On Wed, Jul 7, 2010 at 1:44 PM, Thomas Fjellstrom
  tfjellst...@shaw.ca
 
  wrote:
   Now that I've got my plasmoid working somewhat decently, I've
   noticed that when its on the desktop, it doesn't want to size quite
   properly.
  
   http://strangesoft.net/plasma-networkinfo/prototype2.png
  
   What would cause that? It shows up fine in the panel as a popup (it
   is a popup applet)
 
  do you set minimum/preferred/maxcimum sizes on -any- of the widgets?
  and what are the size hints of that list widget?
 
  I have a max height on the list widget (300px), and a sizeHint on each
  the items in the list.

 those 300px manual hint shouldn't be necessary, aanyways,

 something is getting broken either a) minimumsize of the list -widget-
 (not items)
 b) broken minimum size of the whole applet (sure you don't ever set it?)

 I haven't set a minimum size on anything. Just a maximum size on the list
 widget to keep it from hitting the top of the screen as a popup with my
 initial fake data.

 I do have a lot of the sizePolicy's set to MinimumExpanding, could that have
 this effect?


it could, please, try with other ones, like Expanding and Preferred,
so we can rule out this possibility
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: initial plasmoid size?

2010-07-07 Thread Thomas Fjellstrom
On July 7, 2010, Marco Martin wrote:
 On Wed, Jul 7, 2010 at 2:38 PM, Thomas Fjellstrom tfjellst...@shaw.ca 
wrote:
  On July 7, 2010, Marco Martin wrote:
  On Wed, Jul 7, 2010 at 2:23 PM, Thomas Fjellstrom
  tfjellst...@shaw.ca
  
  wrote:
   On July 7, 2010, Marco Martin wrote:
   On Wed, Jul 7, 2010 at 1:44 PM, Thomas Fjellstrom
   tfjellst...@shaw.ca
   
   wrote:
Now that I've got my plasmoid working somewhat decently, I've
noticed that when its on the desktop, it doesn't want to size
quite properly.

http://strangesoft.net/plasma-networkinfo/prototype2.png

What would cause that? It shows up fine in the panel as a popup
(it is a popup applet)
   
   do you set minimum/preferred/maxcimum sizes on -any- of the
   widgets? and what are the size hints of that list widget?
   
   I have a max height on the list widget (300px), and a sizeHint on
   each the items in the list.
  
  those 300px manual hint shouldn't be necessary, aanyways,
  
  something is getting broken either a) minimumsize of the list -widget-
  (not items)
  b) broken minimum size of the whole applet (sure you don't ever set
  it?)
  
  I haven't set a minimum size on anything. Just a maximum size on the
  list widget to keep it from hitting the top of the screen as a popup
  with my initial fake data.
  
  I do have a lot of the sizePolicy's set to MinimumExpanding, could that
  have this effect?
 
 it could, please, try with other ones, like Expanding and Preferred,
 so we can rule out this possibility

That did seem to fix it. Though now its making the applet too short in popup 
mode.

 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel


-- 
Thomas Fjellstrom
tfjellst...@shaw.ca
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request: Adds support for corner widgets in Plasma::TabBar

2010-07-07 Thread Giulio Camuffo

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4537/
---

Review request for Plasma and Marco Martin.


Summary
---

This patch adds two methods that allow to put two QGraphicsWidget in the top 
left and top right corner of the tab bar, like it is possible with QTabWidget.


Diffs
-

  trunk/KDE/kdelibs/plasma/widgets/tabbar.h 1147219 
  trunk/KDE/kdelibs/plasma/widgets/tabbar.cpp 1147219 

Diff: http://reviewboard.kde.org/r/4537/diff


Testing
---

Tested, it works, but there's one thing that annoys me and I don't how to solve 
in a clean way: when there are no tabs the NativeTabBar becomes a bit smaller 
in height and the widgets resize accordingly.


Thanks,

Giulio

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Adds support for corner widgets in Plasma::TabBar

2010-07-07 Thread Giulio Camuffo

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4537/
---

(Updated 2010-07-07 17:17:22.235283)


Review request for Plasma and Marco Martin.


Summary
---

This patch adds two methods that allow to put two QGraphicsWidget in the top 
left and top right corner of the tab bar, like it is possible with QTabWidget.


Diffs
-

  trunk/KDE/kdelibs/plasma/widgets/tabbar.h 1147219 
  trunk/KDE/kdelibs/plasma/widgets/tabbar.cpp 1147219 

Diff: http://reviewboard.kde.org/r/4537/diff


Testing
---

Tested, it works, but there's one thing that annoys me and I don't how to solve 
in a clean way: when there are no tabs the NativeTabBar becomes a bit smaller 
in height and the widgets resize accordingly.


Screenshots (updated)
---

added two Plasma::PushButton
  http://reviewboard.kde.org/r/4537/s/446/


Thanks,

Giulio

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Adds support for corner widgets in Plasma::TabBar

2010-07-07 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4537/#review6415
---


i don't  think i'm in favor or such a change.
the tabbar was designed to be something really simple, never to really work as 
complex stuff like a browser tabbar.
moreover, it's already possible to enable close buttons on the tabs, as well i 
think putting a qwidget at the top left corner of the tabbar.
redoing this from scratch gives also problems like not respecting the layout 
direction and support different paradigms like where put the new or the close 
buttons. 

- Marco


On 2010-07-07 17:17:22, Giulio Camuffo wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviewboard.kde.org/r/4537/
 ---
 
 (Updated 2010-07-07 17:17:22)
 
 
 Review request for Plasma and Marco Martin.
 
 
 Summary
 ---
 
 This patch adds two methods that allow to put two QGraphicsWidget in the top 
 left and top right corner of the tab bar, like it is possible with QTabWidget.
 
 
 Diffs
 -
 
   trunk/KDE/kdelibs/plasma/widgets/tabbar.h 1147219 
   trunk/KDE/kdelibs/plasma/widgets/tabbar.cpp 1147219 
 
 Diff: http://reviewboard.kde.org/r/4537/diff
 
 
 Testing
 ---
 
 Tested, it works, but there's one thing that annoys me and I don't how to 
 solve in a clean way: when there are no tabs the NativeTabBar becomes a bit 
 smaller in height and the widgets resize accordingly.
 
 
 Screenshots
 ---
 
 added two Plasma::PushButton
   http://reviewboard.kde.org/r/4537/s/446/
 
 
 Thanks,
 
 Giulio
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: [Kde-bindings] Ruby applet dataEngine service operation call

2010-07-07 Thread Richard Dale
On Mon, Dec 14, 2009 at 6:19 PM, Arno Rehn a...@arnorehn.de wrote:
 Hi,

 we already know this problem (KPluginFactoy::create() has it as well) and
 currently only have a workaround, which consists of special-casing the
 affected method. This is obviously not the ideal solution.

 So what we really want is the following:
 For objects that we create ourselves in the bindings language, i.e we
 explicitly call a constructor, we most probably always want to call the native
 implemention of a virtual method (i.e. through a super.foo() call). If we
 subclassed the class in the bindings language, the bindings language's own
 dynamic dispatch will kick in and do the work for us.

 If an object is returned by some method and we know that it was _not_ created
 in the bindings language, we want dynamic dispatch to do its work.

 Eventually the problem boils down to having to know whether a object is a
 smoke-subclass or just the 'original' class.
 I still don't have a solution for this, so suggestions are welcome :)

 On Monday 14 December 2009 14:43:18 Richard Dale wrote:
 On Sat, Dec 12, 2009 at 3:58 PM, Cédric k...@xfou.com wrote:
  Hi richard,
 
  Do you think this is corrected now and if it is in which release will it
  be available ?

 No, i'm afraid the code generated by the new smoke bindings generator
 is the same as the old one:

     void x_12(Smoke::Stack x) {
         // virtual Plasma::Service* serviceForSource(const QString)
         Plasma::Service* xret =
 this-Plasma::DataEngine::serviceForSource(*(const
 QString*)x[1].s_class);
         x[0].s_class = (void*)xret;
     }

 It is difficult to allow virtual methods to be overriden in a bindings
 language, at the same time as allowing dynamic despatch for virtual
 methods on unknown classes. I'll cc this mail to kde-bindi...@kde.org
 and maybe we can discuss it there.
 Yep, kde-bindings seems like a better place to discuss this. ;)

  On Tue, Aug 18, 2009 at 2:59 PM, Richard Dale richard.j.d...@gmail.com
 
  wrote:
  On Tue, Aug 18, 2009 at 1:45 PM, Cédrick...@xfou.com wrote:
   Thanks Richard,
  
   That seems to be the problem.
   What I was telling in my earlier mail is that the javascript binding
   seems
   to have a similar problem with plasmoid.dataEngine(engine
   name).serviceForSource(source name) and maybe they solved it by
   implementing the service function: plasmoid.service(engine name,
   source
   name) (and method Plasma::Applet#service is not implemented in ruby
   ) .
 
  I found the problem. It is a bug in how the smoke library works with
  overriden virtual methods in classes that are don't have bindings
  generated for them. In this case the 'TasksEngine' class isn't part of
  the bindings, and when the serviceForSource() method is called on the
  DataEngine, the code to invoke it looks like this:
 
     void x_10(Smoke::Stack x) {
         // serviceForSource(const QString)
         Plasma::Service* xret =
  this-Plasma::DataEngine::serviceForSource(*(const QString
  *)x[1].s_voidp);
         x[0].s_class = (void*)xret;
     }
 
  When it should probably look like this, and invoke the method in the
  TasksEngine class:
 
     void x_10(Smoke::Stack x) {
         // serviceForSource(const QString)
         Plasma::Service* xret = this-serviceForSource(*(const QString
  *)x[1].s_voidp);
         x[0].s_class = (void*)xret;
     }
 
  Arno Rehn has just written a new smoke library bindings generator, and
  I think we need to discuss this issue and see if we can fix it in that
  tool.
 
Arno has commited a fix for this now and I've just been testing it. It
works ok now - here is the debugging output:produced by the following
code:

pp @de.sources
engine = dataEngine(tasks)
sources = engine.sources
pp engine
p sources
service = engine.serviceForSource(engine.sources[1])
pp service
p service.name
p service.operationNames

56623193
[62914687,
 77594744,
 37748773,
 67109251,
 65011760,
 121635259,
 37748791,
 56623193,
 71303295,
 37748802,
 90177561,
 20971621,
 121635109]
#Plasma::DataEngine:0xaaf1a0f4
  children=Array (13 element(s)),
  metaObject=#Qt::MetaObject:0x0 className=TasksEngine,
superClass=#Qt::MetaObject:0x0 className=Plasma::DataEngine,
  objectName=Window Information,
  sources=nil,
  valid=true,
  icon=user-desktop
[62914687, 77594744, 37748773, 67109251, 65011760,
121635259, 37748791, 56623193, 71303295, 37748802,
90177561, 20971621, 121635109]
#Plasma::Service:0xaaf18f4c
  parent=#TasksEngine:0x0 objectName=Window Information,
  children=Array (1 element(s)),
  metaObject=#Qt::MetaObject:0x0 className=TaskService,
superClass=#Qt::MetaObject:0x0 className=Plasma::Service,
  objectName=nil
tasks
[setMaximized, setMinimized, setShaded, setFullScreen,
setAlwaysOnTop, setKeptBelowOthers, toggleMaximized,
toggleMinimized, toggleShaded, toggleFullScreen,
toggleAlwaysOnTop, toggleKeptBelowOthers, restore, raise,
lower, activate,