Re: Review Request: Manual panel hiding [WIP]
On 2010-05-04 03:49:54, Aaron Seigo wrote: any updates on this? Ditto - our users are still asking for it - as they do on every release. - Will --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3121/#review5390 --- On 2010-03-04 19:19:53, Andrzej JR Hunt wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3121/ --- (Updated 2010-03-04 19:19:53) Review request for Plasma. Summary --- Manual panel hiding patch (still in progress). Currently only horizontal panels are properly implemented, there is still a display bug whereby the plasma toolbox (cashew) ignores the contentsMargins set on the containment and thus gets covered by the hiding buttons. This addresses bug 158556. https://bugs.kde.org/show_bug.cgi?id=158556 Diffs - /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelcontroller.h 1097398 /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelcontroller.cpp 1097398 /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelview.h 1097398 /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelview.cpp 1097398 /trunk/KDE/kdebase/workspace/plasma/desktop/shell/scripting/panel.cpp 1097398 Diff: http://reviewboard.kde.org/r/3121/diff Testing --- Hiding the panels, changing states, changing positions and sizes. Thanks, Andrzej JR ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Grouping Desktop moved to kdereview
On July 24, 2010, Giulio Camuffo wrote: Actually it seems like 4.5 doesn't install anymore the kephal headers. Is this something wanted? kephal is currntly for use by kdebase-workspace only. i see you moved to using QDesktopWidget ... while that probably mostly works, it assumes that this is being used in a full screen workspace. that's an assumption that is likely to hold up, but not necessarily. for Containments, init() is called prior to restore(), which is where settings such as default sizes are set up. this is actually the opposite to Applets, where restore() is called first. since this is a pure Containment (won't be used as an Applet), you can rely on that bit of knowledge. (if that wasn't the case, you could check for isContainment() in init() to know :) anyways .. in init(), you have access to the Corona. and the Corona offers screenGeometry(int screen), which allows for app/platform specific implementations of what that means. for Plasma Desktop, that is implemented using Kephal. so you could instead just use corona()-screenGeometry() in init(). :) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Grouping Desktop moved to kdereview
On July 24, 2010, Aaron Peterson wrote: Sorry, Still haven't been able to get a development environment working, (anybody in Seattle area willing to help for beer?) take a day trip up to Vancouver and we could do it here ;) i occassional go down to Seattle, though, as my sis lives in the area... who knows, maybe something will work out there. Would this eventually be able to be integrated with panels? As it would be cool if all panels did this... And then we don't need another type of item. i think you're confusing panel, the view / window and panel, the containment. it's a core part of plasma's design that the contents of a window (e.g. a panel) is an item on the canvas (in this case a containment, which IsA Applet), so you always have the viw and the contents separated. (personally, I don't understand why panels arn't like other plasmoids they are plasmoids. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Manual panel hiding [WIP]
On 2010-05-04 03:49:54, Aaron Seigo wrote: any updates on this? Will Stephenson wrote: Ditto - our users are still asking for it - as they do on every release. *gasp* all of them? ;) more seriously, our users as a generic term is not a very interesting metric, since in reality it could be 10 loud users out of 1000 or it could be an actually significant %. :) that said ... looks like this patch is abandoned. would be nice if someone picked it up and finished it out. - Aaron --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3121/#review5390 --- On 2010-03-04 19:19:53, Andrzej JR Hunt wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3121/ --- (Updated 2010-03-04 19:19:53) Review request for Plasma. Summary --- Manual panel hiding patch (still in progress). Currently only horizontal panels are properly implemented, there is still a display bug whereby the plasma toolbox (cashew) ignores the contentsMargins set on the containment and thus gets covered by the hiding buttons. This addresses bug 158556. https://bugs.kde.org/show_bug.cgi?id=158556 Diffs - /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelcontroller.h 1097398 /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelcontroller.cpp 1097398 /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelview.h 1097398 /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelview.cpp 1097398 /trunk/KDE/kdebase/workspace/plasma/desktop/shell/scripting/panel.cpp 1097398 Diff: http://reviewboard.kde.org/r/3121/diff Testing --- Hiding the panels, changing states, changing positions and sizes. Thanks, Andrzej JR ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Folderview : label when empty folder
On 2010-07-23 18:31:44, Aaron Seigo wrote: looks good to me; as long as Frederik is cool with it as well (as he is the author/maintainer of folderview :), then this should go in Iamluc wrote: Thanks. I do not have a SVN account, so if you could commit it (Of course if Frederik is OK !) :-) ok, i'll work on integrating testing it today. btw, if you wish to continue submitting patches (and i hope you do! i see you posted another one for kio, e.g. :), then we should get you your own account so you can do the committing and what not yourself :) - Aaron --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4519/#review6693 --- On 2010-07-22 17:14:18, Iamluc wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4519/ --- (Updated 2010-07-22 17:14:18) Review request for Plasma. Summary --- Hello, This patch add a Plasma::Label with text This folder is empty. in Folderview's Popup when the folder is empty. The related bug number in kde bugzilla is 201542. Luc This addresses bug 201542. https://bugs.kde.org/show_bug.cgi?id=201542 Diffs - /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 1151820 /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1151820 Diff: http://reviewboard.kde.org/r/4519/diff Testing --- Delete/add files several times. The label disappears/appears correctly. Screenshots --- folderview empty folder http://reviewboard.kde.org/r/4519/s/444/ version 2 http://reviewboard.kde.org/r/4519/s/455/ Thanks, Iamluc ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Akonadi PIM in the Plasma Calendar
Hi pimsters and plasma-wranglers(?), Just a follow-up on where this is now. After Akademy I managed to finish off my changes to the calendar data engine to enable recurring and multi-day incidences to be treated correctly. Basically I deleted much of what was already there and started again. This still required copying files from kdepim/akonadi/kcal which now live in their own directory kdebase/workspace/plasma/generic/dataengines/calendar/akonadi along with a README explaining the what and why: calendar_p.h calendar.h calendar.cpp calendarmodel.h calendarmodel.cpp calfilterproxymodel.h calfilterproxymodel.cpp utils.h utils.cpp If anyone makes bug-fixes to those classes in kdepim could you also apply them to kdebase, or at least ccmail: me so I can keep them in sync? Thanks. The CalendarEngine now returns almost all the Event/ToDo/Journal attributes for all Incidences that occur within the requested date range, as well as a list of all the Recurrences for each Incidence within the requested date range. Only Attendees, Attachments, Relations, Alarms, Custom Properties, Lat/Lon and Collection/Source are not (yet) returned. The returned data structure can be found in kdebase/workspace/plasma/generic/dataengines/calendar/calendarengine.h. The problems with the original code resulted from it not being obvious to us non-experts that requesting from Akonadi a list of Incidences in a date range does not return all the Recurrences in that date range, only the base Incidence which gives Start/End Dates for the first Recurrence only which may not even fall in the requested date range. Explicit calls must be made on each base Incidence to obtain the Recurrences and their End Dates. I don't think the KCal::CalendarModel::entityData() call even exposes the recurrence details at all, hence having to switch to KCal::Calendar class instead. Any new Akonadi/KCal API intended for use outside kdepim should try to make this easier and more obvious to non-experts, i.e. that a one-to-many model is needed between Incidences and Recurrences. Where to next? Obviously we'll start using the new Akonadi/KCal code once it's in kdepimlibs, remove the duplicated code, and add the last few missing fields to the returned data. I think the code needs to move from the Calendar DataEngine into the Akonadi DataEngine so they can share a common infrastructure and consistent API design. We'll need to allow the user to configure what Collections/Sources get displayed in each plasmoid instance, and to filter within those Collections e.g. have work and personal calendars on separate widgets, hide private events, disable events if calendar displayed on screen-saver, etc. Or even to turn it off entirely, something missing in 4.5 ;-) There's probably a lot that can be done to make the display prettier, but I'll mostly leave that to the Plasma guys, they're better at that kind of stuff :-) Perhaps use html table formatting in the pop-up text to allow proper layout and indenting? The big one will be allowing creating/editing of Incidences. I managed to grab Marco for a couple of minutes just before he left Akademy. He pointed me at Plasma Services which are designed for Plasmoids needing to perform updates. He would prefer that we try implement as much functionality as possible using a Service so it is usable by scripted Plasmoids, but did agree that advanced/complicated functionality like the recurrence editor might be better off used directly rather than being duplicated. This needs more investigation as I don't understand any of it yet :-) Perhaps I can copy how sebas does it in LionMail if it works that way? Cheers! John. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Grouping Desktop moved to kdereview
On Monday 26 July 2010, Aaron J. Seigo wrote: anyways .. in init(), you have access to the Corona. and the Corona offers screenGeometry(int screen), which allows for app/platform specific implementations of what that means. for Plasma Desktop, that is implemented using Kephal. so you could instead just use corona()-screenGeometry() in init(). :) or even corona()-availableScreenRegion() if you want to know even what area panels cover (for now the screengeometry could be fine tough)... Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: JJ: align these icons
On July 19, 2010 14:35:21 Aaron J. Seigo wrote: On July 19, 2010, Chani wrote: someone adjusted the list thingy that the add-widgets and activity-manager UIs use so that it's prettier and shows the names on top. I like it :) but they missed something: the little icons that the activity manager draws on top (and, most likely, the corresponding click area for the stop button) haven't been shifted down to match the icon. http://chani.ca/sshots/icon-over-text.png yes, needs to be fixed. my fault. i'll take a gander when i have some time... *coughs* if anyone else has time, please don't hesitate to fix this. :) the release is coming soon and it'd really suck to have such an obvious glitch in it. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: JJ: align these icons
On July 26, 2010, Chani wrote: if anyone else has time, please don't hesitate to fix this. :) the release is coming soon and it'd really suck to have such an obvious glitch in it. erm ... these changes should be all trunk-only. this is 4.6 work, and shouldn't be touching anything in 4.5. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
moving Projects/Plasma to userbase
hi everyone ... as of today, we will not be using http://techbase.kde.org/Projects/Plasma for coordination and documentation of what we're up to. instead, we will be using http://userbase.kde.org/Plasma. and explanation of why can be found here: http://kate-editor.org/2010/07/26/the-mission-of-kdes-wikis/ i've started moving content over, and have marked the items that i've already dealt with (either moved or decided to drop) with a strikethrough on the old techbase page. this is also an opportunity for us to take a look at some old pages there and refresh them a bit. in particular, i need to rewrite the open tasks page and the Theme page is dreadfully out of date. help with bringing the latter up to the current status would be greatly appreciated, as i have not been very involved in the evolution of the SVG theme contents. there is also the FAQ which should probably get a reading over when being migrated. i'll be leaving it up to each person to move their own projects (e.g. raptor, dbus interfaces, etc) over to the new wiki. if they aren't moved, at some point they will be considered deceased, so please do help in the move. cheers ... -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
