Re: Review Request: Standard Actions KCM: Hide global column, and fix group name
> On Oct. 19, 2011, 9:50 p.m., Christoph Feck wrote: > > Ship It! Erm, forgot the comment... Please commit to KDE/4.7, then git cherry-pick -x to master. - Christoph --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102709/#review7502 --- On Sept. 26, 2011, 3:50 p.m., Ralf Jung wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102709/ > --- > > (Updated Sept. 26, 2011, 3:50 p.m.) > > > Review request for Plasma. > > > Description > --- > > This patch attempts to fix https://bugs.kde.org/show_bug.cgi?id=245603 . It > also fixes the problem that the action group had the title "Unknown" by > setting it manually. > The same string also appears at the beginning of > StandardActionsModule::StandardActionsModule - does that mean it can be > backported? > > I hope I added the right people as reviewers... I could not find a > kde-workspace group and was told in IRC that plasma mostly deals with that. > > > This addresses bug 245603. > http://bugs.kde.org/show_bug.cgi?id=245603 > > > Diffs > - > > kcontrol/standard_actions/standard_actions_module.cpp f1bd45d > > Diff: http://git.reviewboard.kde.org/r/102709/diff/diff > > > Testing > --- > > Compile-tested, logged in and verified that the column indeed disappeared and > the group name was fixed. > > > Thanks, > > Ralf Jung > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Standard Actions KCM: Hide global column, and fix group name
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102709/#review7502 --- Ship it! Ship It! - Christoph Feck On Sept. 26, 2011, 3:50 p.m., Ralf Jung wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102709/ > --- > > (Updated Sept. 26, 2011, 3:50 p.m.) > > > Review request for Plasma. > > > Description > --- > > This patch attempts to fix https://bugs.kde.org/show_bug.cgi?id=245603 . It > also fixes the problem that the action group had the title "Unknown" by > setting it manually. > The same string also appears at the beginning of > StandardActionsModule::StandardActionsModule - does that mean it can be > backported? > > I hope I added the right people as reviewers... I could not find a > kde-workspace group and was told in IRC that plasma mostly deals with that. > > > This addresses bug 245603. > http://bugs.kde.org/show_bug.cgi?id=245603 > > > Diffs > - > > kcontrol/standard_actions/standard_actions_module.cpp f1bd45d > > Diff: http://git.reviewboard.kde.org/r/102709/diff/diff > > > Testing > --- > > Compile-tested, logged in and verified that the column indeed disappeared and > the group name was fixed. > > > Thanks, > > Ralf Jung > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: Left set of buttons in the title bar
On Wednesday 19 October 2011 22:26:08 todd rme wrote: > On Tue, Oct 18, 2011 at 12:30 PM, Alex Fiestas wrote: > > By default we have 2 buttons in the left side of the titlebar, and I'm > > wondering if we really need them. > > > > "On all desktop": Our defaults set only one desktop so I guess that's what > > we want the average user to use. Do we need a button in all titlebars > > that does nothing in that context? > > Currently right-click on the maximize button maximizes horizontally, > middle-click maximizes vertically. Could we do something like that > with the button, assign one of these functions to each of the three > mouse buttons: not before KDE Frameworks 5 as it would break the ABI of the decoration library. signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Left set of buttons in the title bar
On Tue, Oct 18, 2011 at 12:30 PM, Alex Fiestas wrote: > By default we have 2 buttons in the left side of the titlebar, and I'm > wondering if we really need them. > > "On all desktop": Our defaults set only one desktop so I guess that's what we > want the average user to use. Do we need a button in all titlebars that does > nothing in that context? Currently right-click on the maximize button maximizes horizontally, middle-click maximizes vertically. Could we do something like that with the button, assign one of these functions to each of the three mouse buttons: 1. Show on all desktops 2. Show on all activites 3. Activities list. So maybe have left click pulls up a "show on activity" menu, which also has check boxes for "show on all activities" and "show on all desktops" (the latter being grayed out if there is only one desktop), right-click toggles show on all activities, and middle click toggles show on all desktops. I know this isn't very discoverable, but the most important thing, the menu, would be the thing people would encounter naturally anyway. Even ignoring the middel and right-click, this preserves existing functionality (although it takes one more click than it did), while making activity controls easier to access (they are currently stuck in a sub-menu). -Todd ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: Left set of buttons in the title bar
On Wednesday 19 October 2011 16:21:52 Sebastian Kügler wrote: > On Tuesday, October 18, 2011 20:14:34 Kevin Krammer wrote: > > On Tuesday, 2011-10-18, Alex Fiestas wrote: > > > By default we have 2 buttons in the left side of the titlebar, and I'm > > > wondering if we really need them. > > > > > > > > > > > > "On all desktop": Our defaults set only one desktop so I guess that's > > > what we want the average user to use. Do we need a button in all > > > titlebars that does nothing in that context? > > > > When has this been changed? > > I am still on a 4.6.x workspace but here the button successfully makes the > > window appear on all desktops. > > It's a 4.7 change, and only affects the default settings. The button of > course only has no effect when there is only one virtual desktop. I suppose > it should autohide itself in that case. yes, I think that would be the proper solution. If anyone is interested: kcommondecoration.cpp in kde-workspace/kwin/libkdecoration is your friend :-) Cheers Martin > -- > sebas > > http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Left set of buttons in the title bar
On Tuesday, October 18, 2011 20:14:34 Kevin Krammer wrote: > On Tuesday, 2011-10-18, Alex Fiestas wrote: > > By default we have 2 buttons in the left side of the titlebar, and I'm > > wondering if we really need them. > > > > > > > > "On all desktop": Our defaults set only one desktop so I guess that's > > what we want the average user to use. Do we need a button in all > > titlebars that does nothing in that context? > > When has this been changed? > I am still on a 4.6.x workspace but here the button successfully makes the > window appear on all desktops. It's a 4.7 change, and only affects the default settings. The button of course only has no effect when there is only one virtual desktop. I suppose it should autohide itself in that case. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Junior job] Re: translations of qml plasmoids
On Tuesday 18 October 2011, Marco Martin wrote: > Hi all, > as an experiment, i've put a Messages.sh (hopefully adapted to work on qml) > that should extract messages from the activityscreen containment and > produce a pot file called as the plugin name. > > the plasma-mobile project on projects.kde.org now has master as i18n trunk > branch.. > > ..anything else to be done ? so, the translation of the activity screen plasmoid worked, http://websvn.kde.org/trunk/l10n-kde4/templates/messages/playground- base/org.kde.active.activityscreen.pot?revision=1259592&view=markup that means, a proper adapted Messages.sh file has to be added in every plasmoid file. that's a quite easy and boring job, also a quite easy junior job... anybody interested? :p Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Left set of buttons in the title bar
On Tuesday, 2011-10-18, Alex Fiestas wrote: > By default we have 2 buttons in the left side of the titlebar, and I'm > wondering if we really need them. > > "On all desktop": Our defaults set only one desktop so I guess that's what > we want the average user to use. Do we need a button in all titlebars that > does nothing in that context? When has this been changed? I am still on a 4.6.x workspace but here the button successfully makes the window appear on all desktops. Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
