Review Request: Display media info on MediaPlayer applet

2011-12-03 Thread Vitor Boschi da Silva

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103315/
---

Review request for Plasma, Aaron J. Seigo and Marco Martin.


Description
---

Display the name of the playing media below the video using metadata or 
filename if it's not available


This addresses bug https://bugs.kde.org/show_bug.cgi?id=270974.

http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=270974


Diffs
-

  applets/mediaplayer/mediaplayer.h ab58cd2 
  applets/mediaplayer/mediaplayer.cpp d661abd 

Diff: http://git.reviewboard.kde.org/r/103315/diff/diff


Testing
---

tried some music files and videos, with and without title metadata


Thanks,

Vitor Boschi da Silva

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Display media info on MediaPlayer applet

2011-12-03 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103315/#review8686
---


This review has been submitted with commit 
0a8be5c1f0b3bbd557ea85d08c5608e62f888fea by Vitor Boschi da Silva to branch 
mediaplayer-4.9.

- Commit Hook


On Dec. 3, 2011, 2:12 p.m., Vitor Boschi da Silva wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/103315/
 ---
 
 (Updated Dec. 3, 2011, 2:12 p.m.)
 
 
 Review request for Plasma, Aaron J. Seigo and Marco Martin.
 
 
 Description
 ---
 
 Display the name of the playing media below the video using metadata or 
 filename if it's not available
 
 
 This addresses bug https://bugs.kde.org/show_bug.cgi?id=270974.
 
 http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=270974
 
 
 Diffs
 -
 
   applets/mediaplayer/mediaplayer.h ab58cd2 
   applets/mediaplayer/mediaplayer.cpp d661abd 
 
 Diff: http://git.reviewboard.kde.org/r/103315/diff/diff
 
 
 Testing
 ---
 
 tried some music files and videos, with and without title metadata
 
 
 Thanks,
 
 Vitor Boschi da Silva
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: bug killing

2011-12-03 Thread Aaron J. Seigo
On Sunday, November 20, 2011 21:37:16 Aaron J. Seigo wrote:
 so .. 1700+ bugs. fun, huh? :)

as an encouraging little update, thanks to everyone's combined efforts we are 
now down to ~1270 reports. that's ~500 fewer than when i sent the email 2 
weeks ago.

we are destined at this rate to have closed more reports than were opened over 
the last six months. as i write this we are 30 closures away from that.

i begin to wonder how much effort it will take to get it down to under 1000 :)

thanks for everyone who has helped out to achieve this. our bug database is in 
an increasingly healthy state and finding things to actually work on will be 
easier. in fact, tomorrow i will be posting a small (non-comprehensive) list 
of bugs we should ensure get addressed for 4.8.0, and that list is a direct 
result of the triaging that's been going on like made yesterday and today.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Re: bug killing

2011-12-03 Thread Martin Gräßlin
On Saturday 03 December 2011 17:20:20 Aaron J. Seigo wrote:
 On Sunday, November 20, 2011 21:37:16 Aaron J. Seigo wrote:
  so .. 1700+ bugs. fun, huh? :)
 
 as an encouraging little update, thanks to everyone's combined efforts we
 are now down to ~1270 reports. that's ~500 fewer than when i sent the email
 2 weeks ago.
I want that, too. And it's only 410 bugs and kwin is down to 0. So please 
apply your magic to reduce the bugs :-) (We are 20 bugs more than half a year 
ago.) Btw kwin shows what is possible when constantly triaged. We are working 
on it with two people. So far Plasma you would need about ten people working 
on it.

Seriously: awesome job all of you. Keep that going. I'm pretty sure we can get 
plasma down to around 300 to 500 real bugs and that makes it managable.

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: plasmoid folderview - context menu empty trash bin

2011-12-03 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103282/#review8689
---


This review has been submitted with commit 
fed2ad991153672deecfc2df7c51bb34a58761c5 by Gregor Tätzner to branch master.

- Commit Hook


On Nov. 28, 2011, 3:52 p.m., Greg T wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/103282/
 ---
 
 (Updated Nov. 28, 2011, 3:52 p.m.)
 
 
 Review request for Plasma.
 
 
 Description
 ---
 
 I incorporated the proposal in the last comment. What do you think?
 
 
 This addresses bug 259356.
 http://bugs.kde.org/show_bug.cgi?id=259356
 
 
 Diffs
 -
 
   plasma/applets/folderview/folderview.cpp 01b71d1 
 
 Diff: http://git.reviewboard.kde.org/r/103282/diff/diff
 
 
 Testing
 ---
 
 empty trash gets enabled
 
 
 Thanks,
 
 Greg T
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: plasmoid folderview - context menu empty trash bin

2011-12-03 Thread Greg T


 On Dec. 3, 2011, 5:49 p.m., Commit Hook wrote:
  This review has been submitted with commit 
  fed2ad991153672deecfc2df7c51bb34a58761c5 by Gregor Tätzner to branch master.

yes, I've got it!


- Greg


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103282/#review8689
---


On Nov. 28, 2011, 3:52 p.m., Greg T wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/103282/
 ---
 
 (Updated Nov. 28, 2011, 3:52 p.m.)
 
 
 Review request for Plasma.
 
 
 Description
 ---
 
 I incorporated the proposal in the last comment. What do you think?
 
 
 This addresses bug 259356.
 http://bugs.kde.org/show_bug.cgi?id=259356
 
 
 Diffs
 -
 
   plasma/applets/folderview/folderview.cpp 01b71d1 
 
 Diff: http://git.reviewboard.kde.org/r/103282/diff/diff
 
 
 Testing
 ---
 
 empty trash gets enabled
 
 
 Thanks,
 
 Greg T
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: bug killing

2011-12-03 Thread Aaron J. Seigo
On Saturday, December 3, 2011 17:37:01 Martin =?ISO-8859-1?Q?Gr=E4=DFlin?= 
wrote:
 On Saturday 03 December 2011 17:20:20 Aaron J. Seigo wrote:
  On Sunday, November 20, 2011 21:37:16 Aaron J. Seigo wrote:
   so .. 1700+ bugs. fun, huh? :)
  
  as an encouraging little update, thanks to everyone's combined efforts we
  are now down to ~1270 reports. that's ~500 fewer than when i sent the
  email
  2 weeks ago.
 
 I want that, too. And it's only 410 bugs and kwin is down to 0. So please

ehehe ;)

seriously: we should do a bug days for kwin too.. maybe in january? assuming 
you need or could use the help for a good cleaning.

 Seriously: awesome job all of you. Keep that going. I'm pretty sure we can
 get plasma down to around 300 to 500 real bugs and that makes it managable.

agreed...

right now i'm looking at the 1000 mark as the next acheivable short-term goal.

btw.. did a quick LOC count the other day and plasma is shipping nearly 300k 
LOC right now. that include Plasma Active, but not the applications, just the 
actual plasma bits.

that doesn't include kwin, either, which itself is 92k+ LOC in kde-workspace.

dr. konqi makes reporting bugs amazingly easy and pleasant now as well... 
given the feature-to-LOC ratio, it's quite evident why we have so many 
reports.

but i'm quite enthused with how much progress was made in just 2 days (of 
admiteedly abnormal levels of effort ;)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel